On 20.07.2018 12:46, Aaron wrote:
> Thanks Ede,
>
> On 2018-07-20 10:21, edso wrote:
>> question. does it really make sense to adorn singular strings meant as
>> a code comment only eg.
>>
>> class GlobbingError(Exception):
>> - """Something has gone wrong when parsing a glob string"""
>> +
The proposal to merge lp:~aaron-whitehouse/duplicity/08-adorn-strings into
lp:duplicity has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~aaron-whitehouse/duplicity/08-adorn-strings/+merge/350078
--
Your team duplicity-team is requested to
I really don't see it makes a lot of difference. Doc generators are used to
extracting these strings as unadorned, so we could leave them. If you do a lot
of regex replacement to adorn the strings it would be a pain to skip. On a
purely aesthetic note, I'd just as soon adorn them.
--
Thanks Ede,
On 2018-07-20 10:21, edso wrote:
question. does it really make sense to adorn singular strings meant as
a code comment only eg.
class GlobbingError(Exception):
-"""Something has gone wrong when parsing a glob string"""
+u"""Something has gone wrong when parsing a glob
question. does it really make sense to adorn singular strings meant as a code
comment only eg.
class GlobbingError(Exception):
-"""Something has gone wrong when parsing a glob string"""
+u"""Something has gone wrong when parsing a glob string"""
pass
..ede
--
Aaron Whitehouse has proposed merging
lp:~aaron-whitehouse/duplicity/08-adorn-strings into lp:duplicity.
Commit message:
Adorning string literals (normally to make these unicode), in support of a
transition to Python 3.
See https://blueprints.launchpad.net/duplicity/+spec/adorn-string-literals
6 matches
Mail list logo
