The proposal to merge lp:~dawgfoto/duplicity/fixup1252 into lp:duplicity has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~dawgfoto/duplicity/fixup1252/+merge/343816
--
Your team duplicity-team is requested to review the proposed merge of
The manifest check was in the original code I inherited. It's the only
file verified physically against the remote, the rest are hash based. That
verification has not caused many problems, and to my knowledge, has
detected very few comparison errors, so maybe it should just go away now.
As to
On 24.04.2018 18:20, Martin Nowak wrote:
> What's the corruption scenario that manifest comparison should protect
> against?
>
> The manifest contains volume checksums, but those aren't checked against the
> volumes.
they should, at least during verify/restore
> Eventually the remote manifest
What's the corruption scenario that manifest comparison should protect against?
The manifest contains volume checksums, but those aren't checked against the
volumes.
Eventually the remote manifest is just a copy of the local one. Multiple
duplicity instances writing to the same remote should be
hey Martin,
are you aware of the "no private key issue/double key approach" as eg.
described here
https://lists.gnu.org/archive/html/duplicity-talk/2017-10/msg00015.html
?
On 23.04.2018 15:50, Martin Nowak wrote:
> Seems like it tries to catch corruptions see
>
Changed the patch to still check the local manifest.
--
https://code.launchpad.net/~dawgfoto/duplicity/fixup1252/+merge/343816
Your team duplicity-team is requested to review the proposed merge of
lp:~dawgfoto/duplicity/fixup1252 into lp:duplicity.
Seems like it tries to catch corruptions see
https://bazaar.launchpad.net/~duplicity-team/duplicity/0.8-series/view/1301/bin/duplicity#L1333
and
https://bazaar.launchpad.net/~duplicity-team/duplicity/0.8-series/view/1301/duplicity/collections.py#L218.
Given that this is not possible with an
hey Martin,
while the patch looks sound, i'd really like to know why the manifest is
retrieved/decrypted from backend in the first place, before it get's applied.
@Ken?
..ede/duply.net
--
https://code.launchpad.net/~dawgfoto/duplicity/fixup1252/+merge/343816
Your team duplicity-team is
Martin Nowak has proposed merging lp:~dawgfoto/duplicity/fixup1252 into
lp:duplicity.
Commit message:
* only check decryptable remote manifests
- fixup of revision 1252 which introduces a non-fatal error message (see
#1729796)
- for backups the GPG private key and/or it's password are
9 matches
Mail list logo
