Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-27 Thread Anselm R. Garbe
On Sun, Apr 20, 2008 at 09:49:37PM +0200, yy wrote: I like this change, good work Premysl! But once you are using the array, you don't need seltags any more. The attached patch saves 2 or 3 loc. It also includes the functionality of my patch to see prevtags, but if you do the XOR inside memcpy

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-27 Thread Anselm R. Garbe
On Sun, Apr 20, 2008 at 10:24:32PM +0200, Premysl Hruby wrote: void view(const char *arg) { seltags ^= 1; memset(tagset[seltag], (NULL == arg), TAGSZ); tagset[seltag][idxoftag(arg)] = True; arrange(); } I simplified view() accordingly. -- Anselm R. Garbe

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-27 Thread Anselm R. Garbe
On Sun, Apr 27, 2008 at 07:41:08PM +0200, Anselm R. Garbe wrote: On Sun, Apr 20, 2008 at 10:24:32PM +0200, Premysl Hruby wrote: void view(const char *arg) { seltags ^= 1; memset(tagset[seltag], (NULL == arg), TAGSZ); tagset[seltag][idxoftag(arg)] = True; arrange(); }

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-27 Thread Premysl Hruby
On (27/04/08 19:58), Anselm R. Garbe wrote: With the current change in mind, do we still need viewprev()? Short answer: yes, we do :) Long answer: yes, we do because: - you are not able to see previous tagset if you have currently selected more than one tag - for switching to

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-27 Thread yy
2008/4/27 Anselm R. Garbe [EMAIL PROTECTED]: On Sun, Apr 27, 2008 at 07:41:08PM +0200, Anselm R. Garbe wrote: On Sun, Apr 20, 2008 at 10:24:32PM +0200, Premysl Hruby wrote: void view(const char *arg) { seltags ^= 1; memset(tagset[seltag], (NULL == arg), TAGSZ);

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-27 Thread Premysl Hruby
On (27/04/08 20:33), yy wrote: To: dynamic window manager dwm@suckless.org From: yy [EMAIL PROTECTED] Subject: Re: [dwm] Yet another simplification, this time sel/prevtags Reply-To: dynamic window manager dwm@suckless.org List-Id: dynamic window manager dwm.suckless.org After the last

[dwm] Yet another simplification, this time sel/prevtags

2008-04-20 Thread Premysl Hruby
Hi, attached patch makes one array for both sel and prevtags. So there is no need to swap them in memory in view() as we only change seltags pointer to point viewtags[0] or viewtags[1]. It also with little change can support arbitrary number of saved tags set (3 save position can be usable, with

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-20 Thread Anselm R. Garbe
On Sun, Apr 20, 2008 at 06:05:50PM +0200, Premysl Hruby wrote: attached patch makes one array for both sel and prevtags. So there is no need to swap them in memory in view() as we only change seltags pointer to point viewtags[0] or viewtags[1]. It also with little change can support

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-20 Thread yy
2008/4/20, Anselm R. Garbe [EMAIL PROTECTED]: On Sun, Apr 20, 2008 at 06:05:50PM +0200, Premysl Hruby wrote: attached patch makes one array for both sel and prevtags. So there is no need to swap them in memory in view() as we only change seltags pointer to point viewtags[0] or

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-20 Thread Premysl Hruby
On (20/04/08 21:49), yy wrote: To: dynamic window manager dwm@suckless.org From: yy [EMAIL PROTECTED] Subject: Re: [dwm] Yet another simplification, this time sel/prevtags Reply-To: dynamic window manager dwm@suckless.org List-Id: dynamic window manager dwm.suckless.org I like this change

Re: [dwm] Yet another simplification, this time sel/prevtags

2008-04-20 Thread yy
2008/4/20, Premysl Hruby [EMAIL PROTECTED]: On (20/04/08 21:49), yy wrote: To: dynamic window manager dwm@suckless.org From: yy [EMAIL PROTECTED] Subject: Re: [dwm] Yet another simplification, this time sel/prevtags Reply-To: dynamic window manager dwm@suckless.org List-Id: dynamic