Re: [DynInst_API:] deleting snippets and relocated code

2016-02-04 Thread Barton Miller
Thanks Marc. There are a lot of things that we do inside of Dyninst that sometimes seem pretty hard ... and that work pretty well. And sometimes they don't ... For this issue, we definitely have code that evolved with incremental changes and no clear overview. So, we're going to back up a

Re: [DynInst_API:] deleting snippets and relocated code

2016-02-04 Thread Marc Brünink
I am not sure whether we should jump from v1 to v2 at all. If you got any kind of state, moving from v1 to v2 is just asking for trouble. The more I think about it, the more I believe that it is at least very very hard to do right. (But I would be more than happy to be put right) Actually, si

Re: [DynInst_API:] deleting snippets and relocated code

2016-01-28 Thread Bill Williams
Nice find, Marc. I admire the bug. The problem here, I think, is that going relocated->original->relocated is a lossy transformation; what we want to be able to do is go from relocated v1 to relocated v2 directly so that we don't wind up getting rewound to the beginning of instrumentation. (Al

Re: [DynInst_API:] deleting snippets and relocated code

2016-01-28 Thread Marc Brünink
I found the problem, but I do not really know how to solve it: 1. A springboard overwrites 3 instructions. 2. The PC of the thread is at the second instruction. 3. The PC of the thread is not changed, because the TrackerElement was merged in CodeTracker::addTracker 4. The thread continues and c

[DynInst_API:] deleting snippets and relocated code

2016-01-22 Thread Marc Brünink
Hi all, if I deleteSnippet, does the relocation code get deleted as well? Or do the relocated code regions get reused? If yes, where? I was unable to find anything. I insert and delete snippets quite a lot. Sometimes I will end up with threads pointing into broken relocation regions. And I don’

Re: [DynInst_API:] Deleting snippets

2015-11-18 Thread Barton Miller
of Marc Brünink Sent: Tuesday, November 17, 2015 9:08 PM To: dyninst-api@cs.wisc.edu Subject: Re: [DynInst_API:] Deleting snippets Hi, I think I never got an answer to this one, did I? -> Is it safe to delete snippets while a thread is executing them? I suppose not. BPatchAddressSp

Re: [DynInst_API:] Deleting snippets

2015-11-18 Thread Bill Williams
with memory, you can wrap your snippets in conditionals that enable/disable them as needed. From: Dyninst-api on behalf of Marc Brünink Sent: Tuesday, November 17, 2015 9:08 PM To: dyninst-api@cs.wisc.edu Subject: Re: [DynInst_API:] Deleting snippets Hi

Re: [DynInst_API:] Deleting snippets

2015-11-17 Thread Marc Brünink
Hi, I think I never got an answer to this one, did I? -> Is it safe to delete snippets while a thread is executing them? I suppose not. BPatchAddressSpace::deleteSnippet also seems to support the “no, not safe” assumption. So what is the best practice to delete a snippet? Currently I just disab

[DynInst_API:] Deleting snippets

2015-03-30 Thread Marc Brünink
Dear all, is it safe to delete a snippet while a thread is actually executing the snippet? If not, what is the current best practice to delete a snippet? Kind regards, Marc ___ Dyninst-api mailing list Dyninst-api@cs.wisc.edu https://lists.cs.wisc.ed