Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

2009-04-08 Thread Brandeburg, Jesse
Tony Breeds wrote: GCC warns: drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task': drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses around operand of '!' or change '' to '' or '!' to '~' Which I think is right. Bracket to remove ambiguity.

Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

2009-04-08 Thread Jeff Kirsher
On Tue, Apr 7, 2009 at 9:44 PM, Tony Breeds t...@bakeyournoodle.com wrote: GCC warns: drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task': drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses around operand of '!' or change '' to '' or '!' to '~' Which I

Re: [E1000-devel] 2.6.30-rc1: e1000: list_add corruption

2009-04-08 Thread Alexander Beregalov
2009/4/9 Alexander Beregalov a.berega...@gmail.com:  WARNING: at lib/list_debug.c:30 __list_add+0x89/0x90()  Hardware name:  list_add corruption. prev-next should be next (c06ea834), but was f70244c8. (prev=c06ea834).  Modules linked in: w83627hf hwmon_vid i2c_nforce2  Pid: 1436, comm:

Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

2009-04-08 Thread Tony Breeds
On Wed, Apr 08, 2009 at 07:26:08PM -0700, Jeff Kirsher wrote: Thanks, I will add it to my queue of ixgbe patches. Thanks. Remember to CC netdev mailing list for networking patches. I did but due to a misconfiguration on my latop all the lisst on vger.kernel.org rejected the messsages and I

Re: [E1000-devel] 2.6.30-rc1: e1000: list_add corruption

2009-04-08 Thread Alexander Beregalov
2009/4/9 Alexander Beregalov a.berega...@gmail.com: 2009/4/9 Alexander Beregalov a.berega...@gmail.com:  WARNING: at lib/list_debug.c:30 __list_add+0x89/0x90()  Hardware name:  list_add corruption. prev-next should be next (c06ea834), but was f70244c8. (prev=c06ea834).  Modules linked in:

Re: [E1000-devel] 2.6.30-rc1: e1000: list_add corruption

2009-04-08 Thread David Miller
From: Alexander Beregalov a.berega...@gmail.com Date: Thu, 9 Apr 2009 08:16:00 +0400 The host has two interfaces eth0 - e1000, eth1 - forcedeth. Both are not working after that messages. It looks like the NAPI pending list is being modified in an illegal state by forcedeth, and mid-stream to