Re: [E1000-devel] [PATCH] Fix link test for e1000 and e1000e when iface is down

2009-02-13 Thread Jeff Kirsher
On Fri, Feb 13, 2009 at 4:08 AM, André Detsch adet...@br.ibm.com wrote: Jeff Kirsher wrote: I guess this comes down to what the definition of a Link test should be doing. My $0.02 is that it should be testing if the interface has a link, in which case if you ifdown the interface before

Re: [E1000-devel] [PATCH] Fix link test for e1000 and e1000e when iface is down

2009-02-12 Thread David Miller
From: Andre Detsch adet...@br.ibm.com Date: Tue, 10 Feb 2009 14:35:58 -0200 When running ethtool -t on an interface that was just brought down, the link test was failing. That's because we need to perform a reset on the interface to be able to check the link status correctly. There is no

Re: [E1000-devel] [PATCH] Fix link test for e1000 and e1000e when iface is down

2009-02-12 Thread Jeff Kirsher
On Tue, Feb 10, 2009 at 8:35 AM, Andre Detsch adet...@br.ibm.com wrote: When running ethtool -t on an interface that was just brought down, the link test was failing. That's because we need to perform a reset on the interface to be able to check the link status correctly. There is no problem

Re: [E1000-devel] [PATCH] Fix link test for e1000 and e1000e when iface is down

2009-02-12 Thread David Miller
From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Thu, 12 Feb 2009 17:10:22 -0800 On Tue, Feb 10, 2009 at 8:35 AM, Andre Detsch adet...@br.ibm.com wrote: When running ethtool -t on an interface that was just brought down, the link test was failing. That's because we need to perform a