Re: [E1000-devel] [PATCH] e1000: Fix tests of unsigned in e1000_tx_map()

2009-12-22 Thread Jeff Kirsher
On Tue, Dec 15, 2009 at 11:02, Roel Kluin roel.kl...@gmail.com wrote: The variables count and i are unsigned so the (|=) 0 tests do not work. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Found using coccinelle: http://coccinelle.lip6.fr/ This should be all with this pattern. As

[E1000-devel] [PATCH] e1000: Fix tests of unsigned in e1000_tx_map()

2009-12-15 Thread Roel Kluin
The variables count and i are unsigned so the (|=) 0 tests do not work. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Found using coccinelle: http://coccinelle.lip6.fr/ I wasn't able to test this, so please review. diff --git a/drivers/net/e1000/e1000_main.c

Re: [E1000-devel] [PATCH] e1000: Fix tests of unsigned in e1000_tx_map()

2009-12-15 Thread roel kluin
On Tue, Dec 15, 2009 at 7:18 PM, Roel Kluin roel.kl...@gmail.com wrote: The variables count and i are unsigned so the (|=) 0 tests do not work. I now see there are similar issues in igb and friends, I'll post a patch that includes these as well. Roel