Re: [E1000-devel] [PATCH] igb in linux-3.18.0: some potential bugs

2014-12-20 Thread David Miller
From: "Jia-Ju Bai" Date: Sat, 20 Dec 2014 20:59:18 +0800 > Thank for the reply! Please do not top-post. Etiquette on these mailing lists is that you quote a minimal amount of material from the email you are replying to to give enough context to the reader, than you give your response _after_ th

Re: [E1000-devel] [PATCH] igb in linux-3.18.0: some potential bugs

2014-12-20 Thread Jia-Ju Bai
Thank for the reply! For the first reply: I let some functions fail on purpose to test error handling code, and then run the driver in reality as well as monitor the function calls in runtime. The results are in my report. For the second reply: I admit you are right, and my code style need to b

[E1000-devel] [PATCH] igb in linux-3.18.0: some potential bugs

2014-12-20 Thread Jia-Ju Bai
I have actually tested igb driver on the real hardware(Intel 82575EB PCI-E Gigabit Ethernet Controller), and find some potential bugs: The target file is drivers/net/ethernet/intel/igb/igb_main.c (1) In the normal process of igb, pci_enable_pcie_error_reporting and pci_disable_pcie_error_reporting