Re: [E1000-devel] [PATCH] ixgbe: missing parentheses

2009-04-16 Thread Andrew Morton
(cc netdev) On Thu, 16 Apr 2009 23:05:00 +0200 Roel Kluin roel.kl...@gmail.com wrote: `!' has a higher precedence than `' Signed-off-by: Roel Kluin roel.kl...@gmail.com --- diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index febde45..49a9037 100644 ---

Re: [E1000-devel] [PATCH] ixgbe: missing parentheses

2009-04-16 Thread Kirsher, Jeffrey T
On Thursday, April 16, 2009 Andrew Morton wrote: (cc netdev) On Thu, 16 Apr 2009 23:05:00 +0200 Roel Kluin roel.kl...@gmail.com wrote: `!' has a higher precedence than `' Signed-off-by: Roel Kluin roel.kl...@gmail.com --- diff --git a/drivers/net/ixgbe/ixgbe_main.c

Re: [E1000-devel] [PATCH] ixgbe: missing parentheses

2009-04-16 Thread David Miller
From: Kirsher, Jeffrey T jeffrey.t.kirs...@intel.com Date: Thu, 16 Apr 2009 14:25:44 -0700 Dave - Can we pull this fix into net-2.6? Just toss me a patch and I'll apply it directly. -- Stay on top of everything new and

Re: [E1000-devel] [PATCH] ixgbe: missing parentheses

2009-04-16 Thread David Miller
From: Andrew Morton a...@linux-foundation.org Date: Thu, 16 Apr 2009 14:16:10 -0700 @@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work) } hw-mac.ops.setup_sfp(hw); -if (!adapter-flags IXGBE_FLAG_IN_SFP_LINK_TASK) +if