Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Eliezer Tamir
On 20/05/2013 19:22, Andi Kleen wrote: diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index f98ca63..cfcf0ea 100644 --- a/Documentation/networking/ip-sysctl.txt +++ b/Documentation/networking/ip-sysctl.txt @@ -19,6 +19,11 @@ ip_no_pmtu_disc -

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Sun, 19 May 2013 13:25:33 +0300 +#ifndef _LINUX_NET_LL_POLL_H +#define _LINUX_NET_LL_POLL_H +#ifdef CONFIG_INET_LL_RX_POLL Please put an empty line before the final ifdef test here. +static inline void sk_mark_ll(struct sock *sk,

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 20 May 2013 01:29:47 -0700 On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote: From: Eliezer Tamir eliezer.ta...@linux.intel.com [] { struct socket *sock; + unsigned int poll_result; Please order local variable declarations

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread Andi Kleen
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index f98ca63..cfcf0ea 100644 --- a/Documentation/networking/ip-sysctl.txt +++ b/Documentation/networking/ip-sysctl.txt @@ -19,6 +19,11 @@ ip_no_pmtu_disc - BOOLEAN Disable Path MTU

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Mon, 20 May 2013 12:39:59 +0300 On 20/05/2013 10:54, David Miller wrote: From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Sun, 19 May 2013 13:25:33 +0300 +#else /* CONFIG_INET_LL_RX_FLUSH */ + +#define sk_valid_ll(sk) 0

[E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-19 Thread Eliezer Tamir
Adds a new ndo_ll_poll method and the code that supports and uses it. This method can be used by low latency applications to busy poll ethernet device queues directly from the socket code. The ip_low_latency_poll sysctl entry controls how many cycles to poll. Set to zero to disable.