Re: [E1000-devel] [PATCH 2/2] e1000e: start network tx queue only when link is up

2019-04-29 Thread Oleksandr Natalenko
On Wed, Apr 17, 2019 at 11:13:20AM +0300, Konstantin Khlebnikov wrote: > Driver does not want to keep packets in tx queue when link is lost. > But present code only reset NIC to flush them, but does not prevent > queuing new packets. Moreover reset sequence itself could generate > new packets via n

Re: [E1000-devel] [PATCH 2/2] e1000e: start network tx queue only when link is up

2019-04-25 Thread Brown, Aaron F
> From: Konstantin Khlebnikov [mailto:khlebni...@yandex-team.ru] > Sent: Wednesday, April 17, 2019 1:13 AM > To: net...@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Kirsher, Jeffrey T > Cc: Sasha Levin ; Joseph Yasi ; > Brown, Aaron F ; Alexander Duyck > ; e1

Re: [E1000-devel] [PATCH 2/2] e1000e: start network tx queue only when link is up

2019-04-22 Thread Joseph Yasi
On Wed, Apr 17, 2019 at 4:13 AM Konstantin Khlebnikov wrote: > > Driver does not want to keep packets in tx queue when link is lost. > But present code only reset NIC to flush them, but does not prevent > queuing new packets. Moreover reset sequence itself could generate > new packets via netconso

Re: [E1000-devel] [PATCH 2/2] e1000e: start network tx queue only when link is up

2019-04-22 Thread Joseph Yasi
On Wed, Apr 17, 2019 at 4:13 AM Konstantin Khlebnikov < khlebni...@yandex-team.ru> wrote: > Driver does not want to keep packets in tx queue when link is lost. > But present code only reset NIC to flush them, but does not prevent > queuing new packets. Moreover reset sequence itself could generate