Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-06 Thread Stephen Hemminger
On Thu, 5 Sep 2013 23:01:18 -0700 Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: diff --git a/drivers/net/ethernet/intel/i40e/Kbuild b/drivers/net/ethernet/intel/i40e/Kbuild new file mode 100644 index 000..479b2c4 Dumb question why is this named Kbuild instead of Makefile like almost

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-06 Thread Jesse Brandeburg
On Fri, 6 Sep 2013 14:01:41 -0400 David Miller da...@davemloft.net wrote: Please rename this Kbuild file to the normal Makefile instead of trying to be different from every single other driver in the networking for the sake of an issue that is your, and your problem alone. Thanks Dave, will

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-06 Thread Williams, Mitch A
; net...@vger.kernel.org; go...@redhat.com; sassm...@redhat.com Subject: Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper On Fri, 2013-09-06 at 06:28 +, Brandeburg, Jesse wrote: On Sep 5, 2013, at 11:15 PM, Stephen Hemminger step...@networkplumber.orgmailto:step

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-06 Thread David Miller
I'm kind of getting sick of the we'll fix it in a follow up patch talk. Please rename this Kbuild file to the normal Makefile instead of trying to be different from every single other driver in the networking for the sake of an issue that is your, and your problem alone. You guys should really

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-06 Thread David Miller
From: Joe Perches j...@perches.com Date: Fri, 06 Sep 2013 11:20:15 -0700 On Fri, 2013-09-06 at 17:28 +, Williams, Mitch A wrote: My goal was to make our out-of-tree driver as close as possible - including the makefiles - to the upstream driver. Doing this makes it simpler for us to