Re: [E1000-devel] [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown

2014-03-07 Thread Marcelo Tosatti
On Thu, Mar 06, 2014 at 07:24:31PM -0800, Jeff Kirsher wrote: On Thu, 2014-03-06 at 23:04 -0300, Marcelo Tosatti wrote: There is a race on the shutdown path of the e1000 driver that allows the card to DMA into free'd memory. The symptoms are similar to those described at commit

Re: [E1000-devel] ixgbe-3.17.3 :VLAN tagged packets does not work when using PF-PACKET socket ,

2014-03-07 Thread Vijay Agrawal
Thanks for replying Emli. We really appreciate and are really thankful for your efforts on this. Please let us know when you have any update on this. Thanks Regards Vijay Agrawal -Original Message- From: Tantilov, Emil S [mailto:emil.s.tanti...@intel.com] Sent: 07 March 2014 01:57

Re: [E1000-devel] [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown

2014-03-07 Thread David Miller
From: Marcelo Tosatti mtosa...@redhat.com Date: Fri, 7 Mar 2014 12:14:35 -0300 checkpatch.pl did not complain about those - feel free to fix them, thanks. The problem is that GIT does when the maintainer applies your patch. You can sanity check your patch using GIT without commiting it into

Re: [E1000-devel] [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown

2014-03-07 Thread Joe Perches
On Fri, 2014-03-07 at 12:14 -0300, Marcelo Tosatti wrote: On Thu, Mar 06, 2014 at 07:24:31PM -0800, Jeff Kirsher wrote: On Thu, 2014-03-06 at 23:04 -0300, Marcelo Tosatti wrote: There is a race on the shutdown path of the e1000 driver that allows the card to DMA into free'd memory. []

Re: [E1000-devel] [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown

2014-03-07 Thread Marcelo Tosatti
On Thu, Mar 06, 2014 at 07:24:31PM -0800, Jeff Kirsher wrote: On Thu, 2014-03-06 at 23:04 -0300, Marcelo Tosatti wrote: There is a race on the shutdown path of the e1000 driver that allows the card to DMA into free'd memory. The symptoms are similar to those described at commit

Re: [E1000-devel] [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown

2014-03-07 Thread Jeff Kirsher
On Fri, 2014-03-07 at 18:00 -0300, Marcelo Tosatti wrote: On Thu, Mar 06, 2014 at 07:24:31PM -0800, Jeff Kirsher wrote: On Thu, 2014-03-06 at 23:04 -0300, Marcelo Tosatti wrote: There is a race on the shutdown path of the e1000 driver that allows the card to DMA into free'd memory.

[E1000-devel] [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown (v2)

2014-03-07 Thread Marcelo Tosatti
There is a race on the shutdown path of the e1000 driver that allows the card to DMA into free'd memory. The symptoms are similar to those described at commit d5bc77a223b0e9b9dfb002048d2b34a79e7d0b48, e1000: don't enable dma receives until after dma address has been setup, where memory

Re: [E1000-devel] [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown (v2)

2014-03-07 Thread Jeff Kirsher
On Fri, 2014-03-07 at 17:59 -0300, Marcelo Tosatti wrote: There is a race on the shutdown path of the e1000 driver that allows the card to DMA into free'd memory. The symptoms are similar to those described at commit d5bc77a223b0e9b9dfb002048d2b34a79e7d0b48, e1000: don't enable dma receives