Re: [E1000-devel] rx_missed_errors with e1000e on 82571EB chip only on HP, not on Intel card // nearly SOLVED

2015-03-26 Thread Wolfgang Rosner
Hello, Alex, Sorry, it's me, again ;-) Can I control the assignment of PCIe lanes at the linux level? After understanding the PCIe tree, I'm back where I started. I now _understand_ what happened, but still want to be able to _change_ that. Compare my previous / after settings:

Re: [E1000-devel] [PATCH net-next 3/7] net: Move check for multiple vlans to drivers

2015-03-26 Thread Eric Dumazet
On Thu, 2015-03-26 at 14:01 +0900, Toshiaki Makita wrote: To allow drivers to handle the features check for multiple tags, move the check to ndo_features_check(). As no drivers currently handle multiple tagged TSO, introduce dflt_features_check() and call it if the driver does not have

Re: [E1000-devel] [PATCH net-next 2/7] vlan: Introduce helper functions to check if skb is tagged

2015-03-26 Thread Eric Dumazet
On Thu, 2015-03-26 at 14:01 +0900, Toshiaki Makita wrote: Separate the two checks for single vlan and multiple vlans in netif_skb_features(). This allows us to move the check for multiple vlans to another function later. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp ---

Re: [E1000-devel] [PATCH net-next 3/7] net: Move check for multiple vlans to drivers

2015-03-26 Thread Toshiaki Makita
On 2015/03/26 20:55, Eric Dumazet wrote: ... +/** + * vlan_features_check - drop unsafe features for skb with multiple tags. + * @skb: skbuff to query + * @features: features to be checked + * + * Returns features without unsafe ones if the skb has multiple tags. + */ +static inline

[E1000-devel] [PATCH v2 net-next 7/7] igb: Enable TSO for stacked vlan

2015-03-26 Thread Toshiaki Makita
As datasheets for igb (I210, I350, 82576, etc.) say, maclen can be from 14 to 127, which is enough for reasonable number of vlan tags. My netperf test showed I350's TSO works pretty fine with multiple vlans. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Acked-by: Jeff Kirsher

[E1000-devel] [PATCH v2 net-next 0/7] Stacked vlan TSO

2015-03-26 Thread Toshiaki Makita
On the basis of Netdev 0.1 discussion[1], I made a patch set to enable TSO for packets with multiple vlans. Currently, packets with multiple vlans are always segmented by software, which is caused by that netif_skb_features() drops most feature flags for multiple tagged packets. To allow NICs to

[E1000-devel] [PATCH v2 net-next 1/7] vlan: Add features for stacked vlan device

2015-03-26 Thread Toshiaki Makita
Stacked vlan devices curretly have few features (GRO, HIGHDMA, LLTX). Since we have software fallbacks in case the NIC can not handle some features for multiple vlans, we can add the same features as the lower vlan devices for stacked vlan devices. This allows stacked vlan devices to create large

[E1000-devel] [PATCH v2 net-next 2/7] vlan: Introduce helper functions to check if skb is tagged

2015-03-26 Thread Toshiaki Makita
Separate the two checks for single vlan and multiple vlans in netif_skb_features(). This allows us to move the check for multiple vlans to another function later. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp --- include/linux/if_vlan.h | 45

[E1000-devel] [PATCH v2 net-next 4/7] net: Introduce passthru_features_check

2015-03-26 Thread Toshiaki Makita
As there are a number of (especially virtual) devices that don't need the multiple vlan check, introduce passthru_features_check() for convenience. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp --- include/linux/netdevice.h | 3 +++ net/core/dev.c| 8 2 files

[E1000-devel] [PATCH v2 net-next 5/7] bonding: Don't segment multiple tagged packets on bonding device

2015-03-26 Thread Toshiaki Makita
Bonding devices don't need to segment multiple tagged packets since their slaves can segment them. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp --- drivers/net/bonding/bond_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bonding/bond_main.c

[E1000-devel] [PATCH v2 net-next 6/7] team: Don't segment multiple tagged packets on team device

2015-03-26 Thread Toshiaki Makita
Team devices don't need to segment multiple tagged packets since their slaves can segment them. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp --- drivers/net/team/team.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index

[E1000-devel] [PATCH v2 net-next 3/7] net: Move check for multiple vlans to drivers

2015-03-26 Thread Toshiaki Makita
To allow drivers to handle the features check for multiple tags, move the check to ndo_features_check(). As no drivers currently handle multiple tagged TSO, introduce dflt_features_check() and call it if the driver does not have ndo_features_check(). Signed-off-by: Toshiaki Makita

Re: [E1000-devel] [linux-nics] [PATCH net-next 7/7] igb: Enable TSO for stacked vlan

2015-03-26 Thread Jeff Kirsher
On Thu, 2015-03-26 at 14:01 +0900, Toshiaki Makita wrote: As datasheets for igb (I210, I350, 82576, etc.) say, maclen can be from 14 to 127, which is enough for reasonable number of vlan tags. My netperf test showed I350's TSO works pretty fine with multiple vlans. Signed-off-by: Toshiaki