Re: [E1000-devel] [PATCH] catch up device stats when multicast > total frames

2008-08-05 Thread Neil Horman
On Tue, Aug 05, 2008 at 09:52:28AM -0700, Ronciak, John wrote: > The total packet count in the driver was done so that the count is always > right even in between stats updates. Believe it or not there are some people > that think this is an important thing for some reason. We don't understand

Re: [E1000-devel] [PATCH] catch up device stats when multicast >total frames

2008-08-05 Thread Neil Horman
On Tue, Aug 05, 2008 at 09:43:19AM -0700, Brandeburg, Jesse wrote: > Neil Horman wrote: > > On Tue, Aug 05, 2008 at 01:15:29PM +0100, Ben Hutchings wrote: > >>> REcently observed a problem wherein, if a BMC or other IPMI > device > >>> is attached to a NIC, multicast frames can be consumed by the

Re: [E1000-devel] [PATCH] catch up device stats when multicast >total frames

2008-08-05 Thread Ingo Oeser
Hi all, Neil Horman schrieb: > Agreed, theres no great solution here. There maybe: 1. store software counters counted in software in stat_soft_last 2. store software counters counted in hardware in stat_hard_last 3. diff them after getting the fresh counters from hardware and software 4. wait for

Re: [E1000-devel] [PATCH] catch up device stats when multicast > total frames

2008-08-05 Thread Ronciak, John
The total packet count in the driver was done so that the count is always right even in between stats updates. Believe it or not there are some people that think this is an important thing for some reason. We don't understand that but agreed to do this to correct what they were seeing with the

Re: [E1000-devel] [PATCH] catch up device stats when multicast >total frames

2008-08-05 Thread Brandeburg, Jesse
Neil Horman wrote: > On Tue, Aug 05, 2008 at 01:15:29PM +0100, Ben Hutchings wrote: >>> REcently observed a problem wherein, if a BMC or other IPMI device >>> is attached to a NIC, multicast frames can be consumed by the >>> aformentioned device without ever being seen by the driver. Since >>>

Re: [E1000-devel] [PATCH] catch up device stats when multicast > total frames

2008-08-05 Thread Neil Horman
On Tue, Aug 05, 2008 at 01:15:29PM +0100, Ben Hutchings wrote: > Neil Horman wrote: > > Hey- > > REcently observed a problem wherein, if a BMC or other IPMI device is > > attached to a NIC, multicast frames can be consumed by the aformentioned > > device > > without ever being seen by the driv

[E1000-devel] [PATCH] catch up device stats when multicast > total frames

2008-08-05 Thread Neil Horman
Hey- REcently observed a problem wherein, if a BMC or other IPMI device is attached to a NIC, multicast frames can be consumed by the aformentioned device without ever being seen by the driver. Since multicast frames are counted in the hardware and the total frame counter is counted in the

Re: [E1000-devel] [PATCH] catch up device stats when multicast > total frames

2008-08-05 Thread Ben Hutchings
Neil Horman wrote: > Hey- > REcently observed a problem wherein, if a BMC or other IPMI device is > attached to a NIC, multicast frames can be consumed by the aformentioned > device > without ever being seen by the driver. Since multicast frames are counted in > the hardware and the total f