Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-03-09 Thread Hiroshi Shimamoto
On 03/08/2015 02:15 PM, Or Gerlitz wrote: On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: [...] We discussed this during NetConf last week, and Don is correct that a custom sysfs interface is not the way we want to handle this. We agreed upon a

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-03-09 Thread Jeff Kirsher
On Mon, 2015-03-09 at 18:52 -0700, Jeff Kirsher wrote: On Tue, 2015-03-10 at 01:42 +, Hiroshi Shimamoto wrote: On 03/08/2015 02:15 PM, Or Gerlitz wrote: On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: [...] We discussed this during NetConf

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-03-09 Thread Jeff Kirsher
On Tue, 2015-03-10 at 01:42 +, Hiroshi Shimamoto wrote: On 03/08/2015 02:15 PM, Or Gerlitz wrote: On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: [...] We discussed this during NetConf last week, and Don is correct that a custom sysfs

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-03-09 Thread Jeff Kirsher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 03/08/2015 02:15 PM, Or Gerlitz wrote: On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: [...] We discussed this during NetConf last week, and Don is correct that a custom sysfs interface is not the way we

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-03-08 Thread Or Gerlitz
On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: [...] We discussed this during NetConf last week, and Don is correct that a custom sysfs interface is not the way we want to handle this. We agreed upon a generic interface so that any NIC is able to turn on or

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-02-23 Thread Edward Cree
On 20/02/15 21:05, Skidmore, Donald C wrote: If a vender specific interface is objectionable maybe a simpler and more generic interface would be for the PF to be able to set a given VF into trusted mode... I admit exactly what 'trusted' meant would vary from vender to vender, but it would

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-02-23 Thread Skidmore, Donald C
-Original Message- From: Edward Cree [mailto:ec...@solarflare.com] Sent: Monday, February 23, 2015 5:53 AM To: Skidmore, Donald C Cc: Hiroshi Shimamoto; vyase...@redhat.com; Kirsher, Jeffrey T; Alexander Duyck; Bjørn Mork; e1000-devel@lists.sourceforge.net; net...@vger.kernel.org;

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-02-23 Thread Jeff Kirsher
On Mon, 2015-02-23 at 06:29 -0800, Skidmore, Donald C wrote: -Original Message- From: Edward Cree [mailto:ec...@solarflare.com] Sent: Monday, February 23, 2015 5:53 AM To: Skidmore, Donald C Cc: Hiroshi Shimamoto; vyase...@redhat.com; Kirsher, Jeffrey T; Alexander Duyck; Bjørn

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-02-20 Thread Edward Cree
On 20/02/15 01:00, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Add netlink directives and ndo entry to allow VF multicast promiscuous mode. The administrator wants to allow dedicatedly multicast promiscuous per VF. If I'm properly understanding, this seems to be

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-02-20 Thread Skidmore, Donald C
-Original Message- From: Edward Cree [mailto:ec...@solarflare.com] Sent: Friday, February 20, 2015 5:52 AM To: Hiroshi Shimamoto Cc: Skidmore, Donald C; vyase...@redhat.com; Kirsher, Jeffrey T; Alexander Duyck; Bjørn Mork; e1000-devel@lists.sourceforge.net; net...@vger.kernel.org;

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-02-19 Thread Or Gerlitz
On Fri, Feb 20, 2015, Hiroshi Shimamoto h-shimam...@ct.jp.nec.com wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Add netlink directives and ndo entry to allow VF multicast promiscuous mode. The administrator wants to allow dedicatedly multicast promiscuous per VF. Jeff, Hiroshi, I

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-02-19 Thread Jeff Kirsher
On Fri, 2015-02-20 at 01:00 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Add netlink directives and ndo entry to allow VF multicast promiscuous mode. The administrator wants to allow dedicatedly multicast promiscuous per VF. Signed-off-by: Hiroshi

[E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-02-19 Thread Hiroshi Shimamoto
From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Add netlink directives and ndo entry to allow VF multicast promiscuous mode. The administrator wants to allow dedicatedly multicast promiscuous per VF. Signed-off-by: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Reviewed-by: Hayato Momma