On 10/19/2011 08:16 PM, Flavio Leitner wrote:
> On Wed, 19 Oct 2011 12:49:48 +0800
> wangyun wrote:
>
>> Hi, Flavio
>>
>> I am new to join the community, work on e1000e driver currently,
>> And I found a thing strange in this issue, please check below.
>>
&g
On 10/21/2011 10:03 PM, Flavio Leitner wrote:
> On Fri, 21 Oct 2011 14:15:12 +0800
> Michael Wang wrote:
>
>> On 10/19/2011 08:16 PM, Flavio Leitner wrote:
>>> On Wed, 19 Oct 2011 12:49:48 +0800
>>> wangyun wrote:
>>>
>>>> Hi, Flavio
&g
On 10/25/2011 12:26 AM, Flavio Leitner wrote:
> On Mon, 24 Oct 2011 16:26:28 +0800
> Michael Wang wrote:
>
>> On 10/21/2011 10:03 PM, Flavio Leitner wrote:
>>> On Fri, 21 Oct 2011 14:15:12 +0800
>>> Michael Wang wrote:
>>>
>>>> On 10/19/201
On 10/25/2011 11:57 PM, Jesse Brandeburg wrote:
> On Mon, 24 Oct 2011 23:29:34 -0700
> Michael Wang wrote:
>> May be you can just search macro
>> "E1000_TXDCTL_DMA_BURST_ENABLE"
>> in "drivers/net/e1000e/e1000.h", change it to:
>>
>> #defi
Hi, Flavio, Jesse
I have send out the patch, which I hope can do some help.
Because this is my first time to send a patch, I am sorry if
I have done some silly thing.
And please tell me if there are some problem about it.
Thanks & Best regards,
Michael
ce flush, set a bit flag in the TX ring and schedule
> watchdog with a short period
> 4) if the TXDW interrupt happens, cleans up and reset the bit flag.
> 5) if not, the watchdog will expire, that bit flag will remain set
> then it will take any action assuming a real hang has occurred.
.
Best regards,
Michael Wang
Original Message
Subject:Re: May be a bug in scatterlist.c
Date: Mon, 07 Nov 2011 14:45:45 +0800
From: Michael Wang
To: kernel-ment...@selenic.com
On 11/07/2011 12:01 PM, Michael Wang wrote:
Hi, Experts
I found there are may be
From: Michael Wang
Descriptors may not be write-back while checking TX hang with flag
FLAG2_DMA_BURST on.
So when we detect hang, we just flush the descriptor and detect
again for once.
Signed-off-by: Michael Wang
---
drivers/net/e1000e/e1000.h |1 +
drivers/net/e1000e/netdev.c | 18
been write-back.
So we need flush the descriptor and do recheck, not just stop the tx
when detect hang.
Flavio:
Please sign-off the patch and provide the test information.
Thanks & Best regards,
Michael Wang
On 11/18/2011 09:37 AM, Michael Wang wrote:
> From: Michael Wang
>
> De
From: Michael Wang
Use true and false instead of 1 and 0 when assign value to a bool type
variable.
Signed-off-by: Michael Wang
---
drivers/net/ethernet/intel/e1000e/netdev.c | 34
++--
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net
On 12/06/2011 01:28 AM, Jesse Brandeburg wrote:
> On Sun, 4 Dec 2011 20:04:52 -0800
> Michael Wang wrote:
>
>> From: Michael Wang
>>
>> Use true and false instead of 1 and 0 when assign value to a bool type
>> variable.
>>
>> Signed-off-by: Michae
From: Michael Wang
Descriptors may not be write-back while checking TX hang with flag
FLAG2_DMA_BURST on.
So when we detect hang, we just flush the descriptor and detect
again for once.
v2: Change 0, 1 to false and true, remove excessive parenthesis.
Signed-off-by: Michael Wang
---
drivers
ut I want to do the edition
by my self, I am sorry and must apologize to you for you time.
Please check the patch and help the submit.
Thanks & Best regards
Michael Wang
On 12/06/2011 10:39 AM, Michael Wang wrote:
> From: Michael Wang
>
> Descriptors may not be write-back whil
On 12/07/2011 04:10 AM, Jesse Brandeburg wrote:
> On Mon, 5 Dec 2011 17:04:09 -0800
> Michael Wang wrote:
>> Actually, I make this change because of my last patch:
>> e1000e: Avoid wrong check on TX hang
>>
>> And I get the suggestion from David, the mail like be
From: Michael Wang
Use true and false instead of 1 and 0 when assign value to a bool type
variable.
This patch is try to keep the style of driver, and according to David's
suggestion on patch "e1000e: Avoid wrong check on TX hang":
http://marc.info/?l=linux-netdev&m=1322
On 12/07/2011 12:14 PM, Joe Perches wrote:
> On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote:
>> On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote:
>>> From: Michael Wang
>>> Use true and false instead of 1 and 0 when assign value to a bool type
>>>
On 12/07/2011 02:01 PM, Joe Perches wrote:
> On Wed, 2011-12-07 at 12:49 +0800, Michael Wang wrote:
>> On 12/07/2011 12:14 PM, Joe Perches wrote:
>>
>>> On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote:
>>>> On Tue, 2011-12-06 at 18:33 -0800, Michael
On 12/07/2011 02:19 PM, Joe Perches wrote:
> On Wed, 2011-12-07 at 14:08 +0800, Michael Wang wrote:
>> I'm not good at script, if you are interested, we can work together to
>> fix all the remain cases, and send out some patches.
>
> You should try coccinelle and spatc
On 12/07/2011 05:04 PM, Jeff Kirsher wrote:
> On Tue, 2011-12-06 at 22:36 -0800, Michael Wang wrote:
>> On 12/07/2011 02:19 PM, Joe Perches wrote:
>>
>>> On Wed, 2011-12-07 at 14:08 +0800, Michael Wang wrote:
>>>> I'm not good at script, if you are intere
19 matches
Mail list logo
