Re: [Ecryptfs-devel] eCryptfs Key Module interface

2007-11-09 Thread Alon Bar-Lev
On 11/10/07, Michael Halcrow <[EMAIL PROTECTED]> wrote: > On Sat, Nov 10, 2007 at 01:05:55AM +0200, Alon Bar-Lev wrote: > > I guess we are back on business? > > Can you please address these point? > > Your suggestions make sense. I don't have a lot of time over the next > 4 weeks to work on anythin

Re: [Ecryptfs-devel] eCryptfs Key Module interface

2007-11-09 Thread Michael Halcrow
On Sat, Nov 10, 2007 at 01:05:55AM +0200, Alon Bar-Lev wrote: > I guess we are back on business? > Can you please address these point? Your suggestions make sense. I don't have a lot of time over the next 4 weeks to work on anything but critical bugfixes (kernel oops/segfault type stuff). If someo

Re: [Ecryptfs-devel] [PATCH] Interactive prompt

2007-11-09 Thread Alon Bar-Lev
And also this one. Alon. On Monday 15 October 2007, Alon Bar-Lev wrote: > On 10/14/07, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > > On 10/14/07, Michael Halcrow <[EMAIL PROTECTED]> wrote: > > > wake_up_process() is not doing what we want it to do when we want it > > > to do it. I'll have to inves

Re: [Ecryptfs-devel] [Issue] Umount as regular user

2007-11-09 Thread Alon Bar-Lev
What about these two? 1. Support user= addition during mount so umount may operate without root privilege. 2. Support noauto (ignore), as commonly added at /etc/fstab. Alon. On Thursday 18 October 2007, Alon Bar-Lev wrote: > On Thursday 18 October 2007, Alon Bar-Lev wrote: > > On Wednesday 03 O

Re: [Ecryptfs-devel] eCryptfs PK padding

2007-11-09 Thread Alon Bar-Lev
Did not get a response for this. On Monday 15 October 2007, Alon Bar-Lev wrote: > Hello Michael, > > We have a minor issue if you use OpenSSL key module and then import > the keys into smartcard. > > OpenSSL key module uses RSA_PKCS1_OAEP_PADDING, while the minimum > common ground for smartcard

Re: [Ecryptfs-devel] eCryptfs Key Module interface

2007-11-09 Thread Alon Bar-Lev
Hello Michael, I guess we are back on business? Can you please address these point? Thanks! Alon Bar-Lev. On Tuesday 16 October 2007, Alon Bar-Lev wrote: > Hello Michael, > > Here are some of my thoughts regarding the key module interface. I > wrote some in the past but I got no response regar

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Michael Halcrow
On Fri, Nov 09, 2007 at 11:38:37PM +0200, Alon Bar-Lev wrote: > Also very strange... > I cannot access the repository using git protocol. > And when I use http, I don't see your recent changes. > Hmmm? It looks like it takes a little while for the external GIT view to sync up with the master G

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
Also very strange... I cannot access the repository using git protocol. And when I use http, I don't see your recent changes. Hmmm? Alon. On 11/9/07, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > On 11/9/07, Michael Halcrow <[EMAIL PROTECTED]> wrote: > > I had some build failures while I was test

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
On 11/9/07, Michael Halcrow <[EMAIL PROTECTED]> wrote: > I had some build failures while I was testing on RHEL 5 yesterday > (e.g., with missing *.png files and *_html/ directories), so I have > more than I really need in the repository for now until I can get > those build issues resolved. Can I

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Michael Halcrow
On Fri, Nov 09, 2007 at 11:01:37PM +0200, Alon Bar-Lev wrote: > Also... > > 1. find . -name '*.rej' | xargs git rm > 2. You have a lot of generated files at doc/design_doc, you need to > leave: *.tex, *.toc, *.dia, *.eps I had some build failures while I was testing on RHEL 5 yesterday (e.g., wit

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
And final left over. --- diff --git a/src/key_mod/ecryptfs_key_mod_pkcs11_helper.c b/src/key_mod/ecryptfs_key_mod_pkcs11_helper.c index 8f7b0e6..d201191 100644 --- a/src/key_mod/ecryptfs_key_mod_pkcs11_helper.c +++ b/src/key_mod/ecryptfs_key_mod_pkcs11_helper.c @@ -1567,7 +1567,7 @@ static int

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
Also... 1. find . -name '*.rej' | xargs git rm 2. You have a lot of generated files at doc/design_doc, you need to leave: *.tex, *.toc, *.dia, *.eps Alon. On 11/9/07, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > And at doc you need to ignore all intermediate outputs... > > On 11/9/07, Alon Bar-Lev

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
And at doc you need to ignore all intermediate outputs... On 11/9/07, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > Please also add the following to ignore list, so it will be easier to > find exceptions. > > Makefile > Makefile.in > aclocal.m4 > autom4te.cache > compile > config.* > configure > depco

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
Please also add the following to ignore list, so it will be easier to find exceptions. Makefile Makefile.in aclocal.m4 autom4te.cache compile config.* configure depcomp install-sh libtool ltmain.sh missing stamp-h1 .deps .libs *.o *.la *.so *.a *.pc ecryptfs.7 ecryptfs-add-passphrase ecryptfs-ins

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
On 11/9/07, Michael Halcrow <[EMAIL PROTECTED]> wrote: > On Fri, Nov 09, 2007 at 09:26:32PM +0200, Alon Bar-Lev wrote: > > Looking at the tree... > > 1. You can delete config.in from the tree. > > Do you mean config.h.in? Yes, sorry. Alon.

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Michael Halcrow
On Fri, Nov 09, 2007 at 09:26:32PM +0200, Alon Bar-Lev wrote: > Looking at the tree... > 1. You can delete config.in from the tree. Do you mean config.h.in? > 2. bootstrap.sh should be only "autoreconf -i -v -f", I don't think > you need all the other commands. Okay. > 3. What are the build-*-s

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
Looking at the tree... 1. You can delete config.in from the tree. 2. bootstrap.sh should be only "autoreconf -i -v -f", I don't think you need all the other commands. 3. What are the build-*-stamp files? Alon. On 11/9/07, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > On 11/7/07, Michael Halcrow <[EMA

[Ecryptfs-devel] Ignore errors from addmntent()

2007-11-09 Thread Drew Moseley
Hi, If ecryptfs is used on a system where /etc/mtab is a symlink to /proc/mounts, the call to addmntent() will return an error if uclibc is used. Essentially the file is read-only and the addmntent() function calls fseek() which returns an error. glibc apparently does not have this error. The p

Re: [Ecryptfs-devel] [PATCH] Build system update

2007-11-09 Thread Alon Bar-Lev
On 11/7/07, Michael Halcrow <[EMAIL PROTECTED]> wrote: > On Mon, Oct 08, 2007 at 08:48:49PM +0200, Alon Bar-Lev wrote: > > And BTW, where do you keep your source control? The CVS at > > sourceforge seems to be out of date. > > I have placed the source tree for ecryptfs-utils on my kernel.org > acco