Re: [edk2-buildtools] Portability bug in BuildReport.py

2014-01-08 Thread Andrew Fish
On Jan 8, 2014, at 10:00 PM, Liu, Yingke D wrote: > Hi Andrew, > > Thanks for your explanation. The patch is attached according to your comments. > Dennis, The patch looks good. Thanks, Andrew Fish > Thanks, > Dennis -

Re: [edk2-buildtools] Portability bug in BuildReport.py

2014-01-08 Thread Liu, Yingke D
Hi Andrew, Thanks for your explanation. The patch is attached according to your comments. Thanks, Dennis From: Andrew Fish [mailto:[email protected]] Sent: Thursday, January 09, 2014 7:35 AM To: [email protected] Cc: [email protected] Subject: [edk2-buildto

[edk2-buildtools] Portability bug in BuildReport.py

2014-01-08 Thread Andrew Fish
This statement is not portable in Python and it crashes on a Mac since it tries to read 20 bytes. struct.unpack("LHH", DepexFile.read(16)) The problem with unpack() is this form uses native size and alignment and unsigned long is a different size on Windows and Mac OS (64-bit Python).