On Jan 23, 2014, at 4:01 PM, Tian, Hot wrote:
> I think the long term perfect solution is using eol-style attribute. But I’m
> not sure whether souceforge support this feature. And for short term, I’ve
> fixed the mixed use of CR and CRLF. The recommendation is CRLF for all
> sources except
Good catch! I will roll back the change for BaseTools/gcc/mingw-gcc-build.py as
it has executable attribute set.
-Original Message-
From: Olivier Martin [mailto:[email protected]]
Sent: Friday, January 24, 2014 8:18 AM
To: Tian, Hot; Andrew Fish
Cc: [email protected]
Sorry Hot, I actually saw your CRLF changes in EDK2 yesterday. But I missed
the one in BaseTools.
As the page I quoted before says and Andrew also confirmed, Python scripts set
as executable (ie: you could run it from the shell) must have the LF (not CRLF)
line endings on their first line.
I ca
I think the long term perfect solution is using eol-style attribute. But I'm
not sure whether souceforge support this feature. And for short term, I've
fixed the mixed use of CR and CRLF. The recommendation is CRLF for all sources
except .sh scripts. You can also find similar recommendation in
On Jan 23, 2014, at 2:47 AM, Olivier Martin wrote:
> Do you confirm the EDK2 BaseTools coding style apply to BaseTools too?
>
> It would mean C sources must have CRLF line endings.
>
> What about Python source files? It looks there is no requirement on the line
> endings in Python source fi
Do you confirm the EDK2 BaseTools coding style apply to BaseTools too?
It would mean C sources must have CRLF line endings.
What about Python source files? It looks there is no requirement on the line
endings in Python source files. The Python Coding style in EDK2:
https://sourceforge.net/a
