Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-07-07 Thread Andrew Fish
On Jul 7, 2014, at 5:40 PM, Gao, Liming wrote: > Martin: > What is 0x0AFF for? Is it an address or a value? This value is the recommended constant if you can not generate a real random number for the “canary” value. It has NULL (will terminate strings), LF, and -1. http://wiki.osdev.org/G

Re: [edk2-buildtools] [PATCH 1/3] BaseTools: Added support for GCC stack protector for ARM architecture

2014-07-07 Thread Liu, Yingke D
Hi Olivier, The patch looks good. Reviewed-by: Yingke Liu Dennis -Original Message- From: Olivier Martin [mailto:[email protected]] Sent: Monday, July 07, 2014 11:44 PM To: Kinney, Michael D; [email protected] Cc: [email protected]; [email protected]

Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-07-07 Thread Gao, Liming
Martin: What is 0x0AFF for? Is it an address or a value? +/// "canary" value that is inserted by the compiler into the stack frame. +VOID *__stack_chk_guard = (VOID*)0x0AFF; And, this library instance is used as NULL class instance. Its library class should be NULL. Thanks Liming -Orig

Re: [edk2-buildtools] [PATCH 0/3] Added support for GCC stack protector for ARM architectures (BaseTools & MdePkg)

2014-07-07 Thread Olivier Martin
Note: Andrew's email is not correct into the patchset. It should have been '[email protected]'. > -Original Message- > From: Olivier Martin [mailto:[email protected]] > Sent: 07 July 2014 16:44 > To: [email protected]; edk2-buildtools- > [email protected] > Cc: edk2-d

[edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-07-07 Thread Olivier Martin
This library only support GCC and XCode for now. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish Signed-off-by: Olivier Martin + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + w

[edk2-buildtools] [PATCH 3/3] ARM Packages: Added support for GCC stack protector

2014-07-07 Thread Olivier Martin
Change-Id: Ib0b1487816b6b37ed11916b828c4f6b695fa2890 --- ArmPkg/ArmPkg.dsc | 8 +- ArmPlatformPkg/ArmPlatformPkg-2ndstage.dsc | 21 ++-- ArmPlatformPkg/ArmPlatformPkg.dsc | 22 ++-- .../ArmRealViewEbPkg/ArmRealViewEb.dsc.inc |

[edk2-buildtools] [PATCH 0/3] Added support for GCC stack protector for ARM architectures (BaseTools & MdePkg)

2014-07-07 Thread Olivier Martin
The initial code has been sent by Andrew Fish on the mainling-list. This library only supports GCC and XCode for now. I have only enables this code for ARM architectures but it should also work on other architectures. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fi

[edk2-buildtools] [PATCH 1/3] BaseTools: Added support for GCC stack protector for ARM architecture

2014-07-07 Thread Olivier Martin
Change-Id: Ifcc8c94297bb91cfec958718ac4d4727da9d506a --- BaseTools/Conf/tools_def.template | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index 4d2c01c..21092fb 100755 --- a/BaseT

[edk2-buildtools] [PATCH] BaseTools: Add AArch64 ADR_PREL_LO21 and R_AARCH64_CONDBR19 relocations

2014-07-07 Thread Olivier Martin
Dear BaseTools maintainers, Please find the attached patch that adds support for these two AArch64 relocations: - ADR_PREL_LO21: support for loading a PC relative label offset. - R_AARCH64_CONDBR19: support for conditional branch instruction (ELF64 code: 280). If none of the maintainers d