Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-07-08 Thread Gao, Liming
Martin: Per Andrew comment, this value is the recommended constant. If so, we don't need to add one PCD for it unless someone has the strong request to configure it. Thanks Liming From: Olivier Martin [mailto:[email protected]] Sent: Tuesday, July 08, 2014 9:26 PM To: 'Andrew Fish'; Gao,

Re: [edk2-buildtools] Update the Guid.xref file to have only upper case GUIDs.

2014-07-08 Thread Liu, Yingke D
The change is good to me. Reviewed-by: Yingke Liu Dennis From: Andrew Fish [mailto:[email protected]] Sent: Tuesday, July 08, 2014 11:54 PM To: [email protected]; [email protected] Subject: [edk2-buildtools] Update the Guid.xref file to have only upper cas

[edk2-buildtools] Update the Guid.xref file to have only upper case GUIDs.

2014-07-08 Thread Andrew Fish
I ran into some 3rd party INF files that use mixed case for the FILE_GUID and this was confusing my debugger Python scripts. I think it is better for the Guid.xref file to output the GUID strings in upper case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish

Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-07-08 Thread Olivier Martin
Actually, I was thinking to replace this canary value by a FixedPcd but I do not remember why I have not done it. I might have just forgot it. Olivier From: Andrew Fish [mailto:[email protected]] Sent: 08 July 2014 02:14 To: Gao, Liming Cc: Olivier Martin; Mike Kinney; edk2-buildtools-devel@lis