Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-08-04 Thread Gao, Liming
Martin: I am fine to use FixedPcd for value 0x0AFF. Have you plan to add this PCD in your patch? Thanks Liming From: Olivier Martin [mailto:[email protected]] Sent: Monday, August 04, 2014 11:51 PM To: 'Andrew Fish' Cc: Gao, Liming; Kinney, Michael D; [email protected]

Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-08-04 Thread Andrew Fish
On Aug 4, 2014, at 8:50 AM, Olivier Martin wrote: > The benefit of the FixedPcd was to be an easy alternative between the > recommended constant value and the random number. > A Firmware vendor might want to use a different canary value as the open > source project. > I guess the PCD could

Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-08-04 Thread Olivier Martin
The benefit of the FixedPcd was to be an easy alternative between the recommended constant value and the random number. A Firmware vendor might want to use a different canary value as the open source project. Olivier From: Andrew Fish [mailto:[email protected]] Sent: 04 August 2014 16:44 To

Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-08-04 Thread Andrew Fish
On Aug 4, 2014, at 8:30 AM, Olivier Martin wrote: > Recommended value does not mean unique value. Anyway, no one has commented > whether this value should be kept in the code or be replaced by a PCD. So, I > will keep the original code. > I will send a new patchset in the next couple of minute

Re: [edk2-buildtools] [PATCH 2/3] MdePkg: Introduced BaseStackCheckLib

2014-08-04 Thread Olivier Martin
Recommended value does not mean unique value. Anyway, no one has commented whether this value should be kept in the code or be replaced by a PCD. So, I will keep the original code. I will send a new patchset in the next couple of minutes to define this class instance as NULL instead of BASE. O