Re: [edk2-buildtools] Portability bug in BuildReport.py

2014-01-09 Thread Andrew Fish
facebook | amd.com > > From: Andrew Fish [mailto:[email protected]] > Sent: Thursday, January 09, 2014 12:03 AM > To: Liu, Yingke D > Cc: [email protected]; > [email protected] > Subject: Re: [edk2-buildtools] Portability bug in Buil

Re: [edk2-buildtools] Portability bug in BuildReport.py

2014-01-09 Thread Kirkendall, Garrett
e004] facebook<https://www.facebook.com/AMD> | amd.com<http://www.amd.com/> From: Andrew Fish [mailto:[email protected]] Sent: Thursday, January 09, 2014 12:03 AM To: Liu, Yingke D Cc: [email protected]; [email protected] Subject: Re: [edk2-buildto

Re: [edk2-buildtools] Portability bug in BuildReport.py

2014-01-08 Thread Andrew Fish
On Jan 8, 2014, at 10:00 PM, Liu, Yingke D wrote: > Hi Andrew, > > Thanks for your explanation. The patch is attached according to your comments. > Dennis, The patch looks good. Thanks, Andrew Fish > Thanks, > Dennis -

Re: [edk2-buildtools] Portability bug in BuildReport.py

2014-01-08 Thread Liu, Yingke D
-buildtools] Portability bug in BuildReport.py This statement is not portable in Python and it crashes on a Mac since it tries to read 20 bytes. struct.unpack("LHH", DepexFile.read(16)) The problem with unpack() is this form uses native size and alignment and unsigned long is a diff

[edk2-buildtools] Portability bug in BuildReport.py

2014-01-08 Thread Andrew Fish
This statement is not portable in Python and it crashes on a Mac since it tries to read 20 bytes. struct.unpack("LHH", DepexFile.read(16)) The problem with unpack() is this form uses native size and alignment and unsigned long is a different size on Windows and Mac OS (64-bit Python).