Re: [edk2] [RFC] OpenSSL HEAD WIP

2015-07-28 Thread David Woodhouse
On Tue, 2015-07-28 at 01:44 +, Long, Qin wrote: Automatically generate the file list from running 'make files', and also configure OpenSSL normally using its Configure script (with all the no-xxx arguments that we require). David, this configuration requires PERL to be

Re: [edk2] [PATCH] ArmPkg: Move FDT offset higher in RAM

2015-07-28 Thread Leif Lindholm
Apologies for top-posting, I think this conversation should drop edk2-devel and move to linaro-uefi (added to cc), until there is consensus/conclusion. Could the next person replying to this thread delete edk2-devel from the recipient list please? / Leif On Tue, Jul 28, 2015 at 10:41:29AM

Re: [edk2] [PATCH] ArmPkg: Move FDT offset higher in RAM

2015-07-28 Thread Ard Biesheuvel
On 28 July 2015 at 11:41, Ryan Harkin ryan.har...@linaro.org wrote: On 28 July 2015 at 10:26, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 28 July 2015 at 11:01, Ryan Harkin ryan.har...@linaro.org wrote: [+ Tixy as he's interested in making sure UEFI follows the Linux requirements]

Re: [edk2] [RFC] OpenSSL HEAD WIP

2015-07-28 Thread Long, Qin
-Original Message- From: David Woodhouse [mailto:dw...@infradead.org] Sent: Tuesday, July 28, 2015 3:42 PM To: Long, Qin; Laszlo Ersek; edk2-de...@ml01.01.org Subject: Re: [edk2] [RFC] OpenSSL HEAD WIP On Tue, 2015-07-28 at 01:44 +, Long, Qin wrote: Automatically generate

Re: [edk2] [RFC] OpenSSL HEAD WIP

2015-07-28 Thread David Woodhouse
On Tue, 2015-07-28 at 08:08 +, Long, Qin wrote: This sounds good. Where this new-generated opensslconf.h will be placed? In /openssl/crypto/ or EDKII-package include path? We still need one script to install / replace this file? It looks like the tarball releases of OpenSSL contain a

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Fan, Jeff
I did not receive the patch 42. I have only gotten 38,39,40,41. OK, If this mtrr setting stored in ACPI NVS is for CpuS3DataDxe to store into SMRAM, that's fine. Then, another question, what's requirement to save MTRR setting into ACPI NVS on this case? And need one PCD to switch on/off it?

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Fan, Jeff
Yes. I think BootServiceData is ok. If OVMF is built without SMRAM support, it's ovmf platform's responsibility to get it and save it into ACPI NVS. Jeff -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Tuesday, July 28, 2015 3:34

[edk2] [PATCH] MdeModulePkg: Include CapsuleX64 in MdeModulePkg.dsc [Components.X64]

2015-07-28 Thread Star Zeng
It was forgotten to be included in MdeModulePkg.dsc when created. Cc: Feng Tian feng.t...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z...@intel.com --- MdeModulePkg/MdeModulePkg.dsc | 4 1 file changed, 4 insertions(+) diff --git

Re: [edk2] [PATCH] ArmPkg: Move FDT offset higher in RAM

2015-07-28 Thread Ryan Harkin
[+ Tixy as he's interested in making sure UEFI follows the Linux requirements] On 28 July 2015 at 07:39, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 27 July 2015 at 22:42, Ryan Harkin ryan.har...@linaro.org wrote: Device tree files in recent kernels (eg. Linux 4.2) can be 16KB. The

Re: [edk2] [patch] MdeModulePkg/Usb: Adjust TPL to not block async transfer during usb enum.

2015-07-28 Thread Zeng, Star
Reviewed-by: Star Zeng star.z...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tian Feng Sent: Tuesday, July 28, 2015 1:41 PM To: Zeng, Star Cc: edk2-devel@lists.01.org; Tian, Feng Subject: [edk2] [patch] MdeModulePkg/Usb: Adjust TPL

Re: [edk2] [PATCH 2/2] CryptoPkg/OpensslLib: Undefine NO_BUILTIN_VA_FUNCS to fix varargs breakage

2015-07-28 Thread David Woodhouse
On Tue, 2015-07-28 at 01:45 +, Long, Qin wrote: Reviewed-by: Qin Long qin.l...@intel.com And Ersek, could you kindly help to double-check it will not break any shim scenario? That would be very much appreciated; thanks. I have done *no* testing other than build testing so far. It would

Re: [edk2] [PATCH] ArmPkg: Move FDT offset higher in RAM

2015-07-28 Thread Ryan Harkin
On 28 July 2015 at 10:26, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 28 July 2015 at 11:01, Ryan Harkin ryan.har...@linaro.org wrote: [+ Tixy as he's interested in making sure UEFI follows the Linux requirements] On 28 July 2015 at 07:39, Ard Biesheuvel ard.biesheu...@linaro.org

Re: [edk2] [patch] MdeModulePkg: Fix the issue cannot boot to UEFI Network

2015-07-28 Thread Fu, Siyuan
Patch is good, please remember to update the copyright year when commit it. Reviewed-by: Fu Siyuan siyuan...@intel.com -Original Message- From: Zhang, Lubo Sent: Tuesday, July 28, 2015 4:47 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin Subject: [patch]

[edk2] [PATCH] IntelFrameworkPkg FrameworkUefiLib: Fix ASSERT in CatVSPrint

2015-07-28 Thread Hao Wu
The second parameter 'DestMax' of StrCpyS() should be the number of unicode characters, not the size in bytes. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu hao.a...@intel.com --- IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLibPrint.c | 2 +- 1 file changed, 1

Re: [edk2] [patch] MdeModulePkg: Fix the issue cannot boot to UEFI Network

2015-07-28 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu jiaxin...@intel.com -Original Message- From: Zhang, Lubo Sent: Tuesday, July 28, 2015 4:47 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin Subject: [patch] MdeModulePkg: Fix the issue cannot boot to UEFI Network DHCP4 service allows only one of

Re: [edk2] [patch] NetworkPkg: Fix the issue cannot boot to UEFI Network

2015-07-28 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu jiaxin...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, Jiaxin Sent: Tuesday, July 28, 2015 8:59 AM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan Subject: Re: [edk2] [patch] NetworkPkg:

[edk2] [Patch] BaseTools/Trim: Fixed a bug that cannot trim long values

2015-07-28 Thread Yingke Liu
The long value substitution must move to the front of HEX substitution. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yingke Liu yingke.d@intel.com --- BaseTools/Source/Python/Trim/Trim.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [Patch] BaseTools/Trim: Fixed a bug that cannot trim long values

2015-07-28 Thread Gao, Liming
Yingke: Could you help update build_rule.txt for *.asm and *.asm16 with trimlong option? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yingke Liu Sent: Wednesday, July 29, 2015 9:06 AM To: edk2-devel@lists.01.org Subject:

[edk2] [patch] MdeModulePkg: Fix the issue cannot boot to UEFI Network

2015-07-28 Thread Zhang Lubo
DHCP4 service allows only one of its children to be configured in the active state,If the DHCP4 D.O.R.A started by IP4 auto configuration and has not been completed, the Dhcp4 state machine will not be in the right state for the PXE to start a new round D.O.R.A. so we need to switch it's policy to

Re: [edk2] [RFC] OpenSSL HEAD WIP

2015-07-28 Thread David Woodhouse
On Tue, 2015-07-28 at 08:55 +, Long, Qin wrote: The instructions will be: - extract tarball - copy opensslconf.h to $(OPENSSL_PATH)/include/openssl/opensslconf.h Unless you want to put it in CryptoPkg/Include/openssl/ and you're *sure* it'll always get included before the

Re: [edk2] [PATCH] ArmPkg: Move FDT offset higher in RAM

2015-07-28 Thread Ard Biesheuvel
On 28 July 2015 at 11:01, Ryan Harkin ryan.har...@linaro.org wrote: [+ Tixy as he's interested in making sure UEFI follows the Linux requirements] On 28 July 2015 at 07:39, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 27 July 2015 at 22:42, Ryan Harkin ryan.har...@linaro.org wrote:

Re: [edk2] Vlv2TbltDevicePkg: Fix the UEFI version reported in the Minnowboard MAX information screen

2015-07-28 Thread He, Tim
Sure, we'll apply the patch to change the string. Thank you Bruce. Best Regards, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bruce Cran Sent: Wednesday, July 29, 2015 12:31 PM To: Wei, David; He, Tim Cc: edk2-devel@lists.01.org Subject:

Re: [edk2] [PATCH] MdeModulePkg: Include CapsuleX64 in MdeModulePkg.dsc [Components.X64]

2015-07-28 Thread Tian, Feng
Reviewed-by: Feng Tian feng.t...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Tuesday, July 28, 2015 4:56 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [edk2] [PATCH] MdeModulePkg: Include CapsuleX64 in

Re: [edk2] [PATCH] Vlv2TbltDevicePkg: Exclude CapsuleX64 from IA32 build

2015-07-28 Thread He, Tim
Reviewed-by: Tim He tim...@intel.com -Original Message- From: Zeng, Star Sent: Tuesday, July 28, 2015 6:08 PM To: edk2-devel@lists.01.org Cc: Wei, David; He, Tim Subject: [PATCH] Vlv2TbltDevicePkg: Exclude CapsuleX64 from IA32 build CapsuleX64 is for 64bits capsule data access in PEI

Re: [edk2] [patch 1/2] MdeModulePkg/Variable: Fix VS2015 warning about uninitialized local var.

2015-07-28 Thread Zeng, Star
Reviewed-by: Star Zeng star.z...@intel.com -Original Message- From: Tian, Feng Sent: Wednesday, July 29, 2015 11:26 AM To: Zeng, Star; Ni, Ruiyu Cc: edk2-devel@lists.01.org; Kinney, Michael D Subject: [patch 1/2] MdeModulePkg/Variable: Fix VS2015 warning about uninitialized local var.

[edk2] [patch 2/2] MdeModulePkg/PciBus: Simplify an complex if statement to pass VS2015

2015-07-28 Thread Tian Feng
The logic in an if statement in PciIo is too complex and hard to understand and make VS2015 build failure. The fix simplifies the logic. Cc: Ruiyu Ni ruiyu...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael D Kinney michael.d.kin...@intel.com Reviewed-by:

[edk2] [patch 1/2] MdeModulePkg/Variable: Fix VS2015 warning about uninitialized local var.

2015-07-28 Thread Tian Feng
This fix is used to solve VS2015 warning local variable is not initialized before use Cc: Star Zeng star.z...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael D Kinney michael.d.kin...@intel.com Reviewed-by: Feng Tian feng.t...@intel.com ---

[edk2] [PATCH 2/4] ArmVirtPkg: use 'auto' alignment and FIXED placement for XIP modules

2015-07-28 Thread Ard Biesheuvel
Now that GenFw correctly propagates the minimum alignment of the ELF input sections to the PE/COFF binary, we can simply select 'auto' alignment in the FDF Rule section instead of tweaking it by hand. Also add the FIXED FFS attribute to the module types that may execute in place. This enables a

[edk2] [PATCH 4/4] BaseTools: add support for CLANG compiler to GCC family

2015-07-28 Thread Ard Biesheuvel
This adds support for building the AARCH64 platforms using the Clang frontend combined with the GNU binutils (cross-)toolchain. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- BaseTools/Conf/tools_def.template | 49

[edk2] [PATCH 3/4] BaseTools/GenFw: allow AArch64 tiny and small code model relocations

2015-07-28 Thread Ard Biesheuvel
The AArch64 small C model makes extensive use of ADRP/ADD and ADRP/{LDR,STR} pairs to emit PC-relative symbol references with a +/- 4 GB range. Since the relocation pair splits the relative offset into a relative page offset and an absolute offset into a 4 KB page, we need to take extra care to

[edk2] [PATCH 1/4] ArmPkg: don't redefine GICv3 sysreg names to generic names

2015-07-28 Thread Ard Biesheuvel
The GNU assembler supports a generic notation for sysregs, to allow the use of system registers defined by newer versions of the architecture by older versions of the toolchain. Clang does not support this generic notation, nor does it need to in the particular case of the GICv3 support code,

Re: [edk2] [PATCH v2 0/6] ArmPkg/ArmVirtPkg: GIC revision detection

2015-07-28 Thread Leif Lindholm
Hi Ard, Sorry for delay. On Sun, Jul 26, 2015 at 02:50:24PM +0200, Ard Biesheuvel wrote: On 26 July 2015 at 13:46, Leif Lindholm leif.lindh...@linaro.org wrote: On Sun, Jul 26, 2015 at 01:08:20PM +0200, Ard Biesheuvel wrote: So ... had a look through, looks sane, have a couple of minor

Re: [edk2] [PATCH 2/2] CryptoPkg/OpensslLib: Undefine NO_BUILTIN_VA_FUNCS to fix varargs breakage

2015-07-28 Thread Laszlo Ersek
On 07/28/15 11:32, David Woodhouse wrote: On Tue, 2015-07-28 at 01:45 +, Long, Qin wrote: Reviewed-by: Qin Long qin.l...@intel.com And Ersek, could you kindly help to double-check it will not break any shim scenario? That would be very much appreciated; thanks. I have done *no*

Re: [edk2] [PATCH 17/58] OvmfPkg: import PiSmmCpuDxeSmm from Quark_EDKII_v1.1.0/IA32FamilyCpuBasePkg

2015-07-28 Thread Jordan Justen
Note: Cc: edk2-devel Mike, Can you *please* help out with this?? We've been discussing this since April... 1. Why should we import all this code under the OVMF platform? 2. Why should we have a different license from the rest of EDK II if this is all Intel code? Last time we talked about

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-28 Thread Leif Lindholm
Hi Jordan, Sorry, (metaphorically) snowed under for a few days. On Fri, Jul 17, 2015 at 02:44:10PM -0700, Jordan Justen wrote: Does this depend on ArmPkg / EmbeddedPkg, or is this just a generic PCI based driver? It could be nice to have a generic place for such drivers, but I think

Re: [edk2] [PATCH v2 1/7] BaseTools: add unified GCC linker script for all archs and versions

2015-07-28 Thread Jordan Justen
On 2015-07-24 05:08:34, Ard Biesheuvel wrote: This unifies all GCC linker scripts into a single parametrised GCC linker script that can be used for all GCC versions and architectures. The two parameters that can be set on the linker command line are: - PECOFF_HEADER_SIZE, this is a build

Re: [edk2] [PATCH v2 7/7] BaseTools/X86|IA32: move to unified GCC linker script

2015-07-28 Thread Jordan Justen
On 2015-07-24 05:08:40, Ard Biesheuvel wrote: Drop the GCC 4.4/X86 and 4.9/X86 specific linker scripts and use the new unified one instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- BaseTools/Conf/tools_def.template

Re: [edk2] [PATCH 11/58] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-07-28 Thread Laszlo Ersek
On 07/25/15 01:00, Laszlo Ersek wrote: The EFI_SMM_COMMUNICATION_PROTOCOL implementation that is provided by the SMM core depends on EFI_SMM_CONTROL2_PROTOCOL; see the mSmmControl2-Trigger() call in the SmmCommunicationCommunicate() function [MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c].

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
On 07/28/15 09:33, Paolo Bonzini wrote: On 28/07/2015 09:09, Fan, Jeff wrote: I did not receive the patch 42. I have only gotten 38,39,40,41. OK, If this mtrr setting stored in ACPI NVS is for CpuS3DataDxe to store into SMRAM, that's fine. Then, another question, what's requirement to

Re: [edk2] [PATCH v2 7/7] BaseTools/X86|IA32: move to unified GCC linker script

2015-07-28 Thread Ard Biesheuvel
On 28 July 2015 at 20:51, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-07-24 05:08:40, Ard Biesheuvel wrote: Drop the GCC 4.4/X86 and 4.9/X86 specific linker scripts and use the new unified one instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
On 07/28/15 08:51, Paolo Bonzini wrote: On 28/07/2015 08:05, Fan, Jeff wrote: Ersek, I have one comment for PCD PcdCpuSyncMtrrToAcpiNvs. I knew OvmfPkg implemented LockBox based on ACPI NVS. Saving MTRR setting in AcpiNVS is OK for OvmfPkg. If I understand correctly what you are

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
On 07/28/15 09:56, Fan, Jeff wrote: Yes. I think BootServiceData is ok. Okay. At the moment I think I agree with the idea that BootServicesData should be sufficient. If that's what you'd like to see, I'll evaluate it in more depth, and try to update the code accordingly, for v2. For some more

Re: [edk2] How could I allocate aligned memory?

2015-07-28 Thread Laszlo Ersek
On 07/28/15 07:14, winddy wrote: Dear Experts, Now I want to allocate some reserved memory which should be aligned at 64MB. And if I use gBS-AllocatePages() it return OK(AllocateSize = NeedSize + AlignSize, then use ALIGN_VALUE()). But I think in this method I will waste much space for

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Fan, Jeff
Ersek, I have one comment for PCD PcdCpuSyncMtrrToAcpiNvs. I knew OvmfPkg implemented LockBox based on ACPI NVS. Saving MTRR setting in AcpiNVS is OK for OvmfPkg. But other platform may want to use more safe solution to save MTRR based on in SMM. I think that, for long term, saving MTRR

Re: [edk2] [PATCH] ArmPkg: Move FDT offset higher in RAM

2015-07-28 Thread Ard Biesheuvel
On 27 July 2015 at 22:42, Ryan Harkin ryan.har...@linaro.org wrote: Device tree files in recent kernels (eg. Linux 4.2) can be 16KB. The max offset of 0x4000 meant that the device tree would be allocated at a random address, which more often than not was above the recommended 128MiB boundary.

Re: [edk2] [PATCH v2 1/7] BaseTools: add unified GCC linker script for all archs and versions

2015-07-28 Thread Jordan Justen
On 2015-07-28 12:37:31, Ard Biesheuvel wrote: On 28 July 2015 at 20:48, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-07-24 05:08:34, Ard Biesheuvel wrote: This unifies all GCC linker scripts into a single parametrised GCC linker script that can be used for all GCC versions and

Re: [edk2] [PATCH v2 0/6] ArmPkg/ArmVirtPkg: GIC revision detection

2015-07-28 Thread Ard Biesheuvel
On 28 July 2015 at 19:34, Leif Lindholm leif.lindh...@linaro.org wrote: Hi Ard, Sorry for delay. On Sun, Jul 26, 2015 at 02:50:24PM +0200, Ard Biesheuvel wrote: On 26 July 2015 at 13:46, Leif Lindholm leif.lindh...@linaro.org wrote: On Sun, Jul 26, 2015 at 01:08:20PM +0200, Ard Biesheuvel

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Yao, Jiewen
HI Laszlo I like the diagram in GMANE. Good work! Will you consider the option to merge CpuS3DataDxe into CpuMpDxe? Then we can reduce the driver number. Or can we put CpuS3DataDxe to UefiCpuPkg? Same question for PiSmmCpuDxeSmm. Can we put it to UefiCpuPkg, if it is generic enough? I also