Re: [edk2] Status of porting acpidump to edk2 ?

2015-08-13 Thread Moore, Robert
A couple of things jumped out at me: It has only two lines of changes to the ACPICA code, and the intent was to get those two lines rolled into ACPICA if possible. We certainly would like to see these ASAP. I propose that this get pulled into AppPkg since the code is modelled after those

Re: [edk2] Library refinement: OptionRomPkg/BltLib

2015-08-13 Thread Jordan Justen
Did you get a chance to review the commit message on caebd915 / r11520? On 2015-08-09 20:09:54, Ni, Ruiyu wrote: Jordan and Laszlo, I reviewed the OptionRomPkg/BltLib again and would like to discuss with you about the potential API refinement. I attached two versions of the

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Ard Biesheuvel
On 13 August 2015 at 08:27, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 12 August 2015 at 23:48, David Woodhouse dw...@infradead.org wrote: On Wed, 2015-08-12 at 09:08 +0200, Ard Biesheuvel wrote: Is there any reason these are kept out of sync? Are UNIXGCC and CYGGCC known to be widely

Re: [edk2] [patch] MdeModulePkg:Fix the issue that Commit changes and Exit fail when add driver option

2015-08-13 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin shumin@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Thursday, August 13, 2015 4:40 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [edk2] [patch] MdeModulePkg:Fix the issue

Re: [edk2] [PATCH v2] BaseTools IA32/X64: prevent .eh_frame sections from being generated

2015-08-13 Thread Ard Biesheuvel
On 13 August 2015 at 07:44, Gao, Liming liming@intel.com wrote: Reviewed-by: Liming Gao liming@intel.com Thanks Committed as SVN r18217 -- Ard. -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, August 13, 2015 1:19 PM To:

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Bruce Cran
On 8/12/15 11:47 PM, Gao, Liming wrote: Add -std=gnu89 to the CC flags. This is the default for gcc 4.x, so it doesn't change anything for those tool chains (other than making the command line slightly longer). GCC5 however, defaults to -std=gnu11. By adding -std=gnu89, gcc5 will behave

[edk2] [PATCH] ArmPkg: Bug fix for UncachedMemoryAllocationLib

2015-08-13 Thread Heyi Guo
NewNode is the node we found, while Node is the last node in the list. Also update mFreedBufferSize. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo heyi@linaro.org Cc: Leif Lindholm leif.lindh...@linaro.org Cc: Ard Biesheuvel ard.biesheu...@linaro.org ---

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Scott Duplichan
Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: ]Sent: Thursday, August 13, 2015 01:40 AM ]To: David Woodhouse dw...@infradead.org ]Cc: Justen, Jordan L jordan.l.jus...@intel.com; edk2-devel@lists.01.org edk2-de...@ml01.01.org; Liu, Yingke D ]yingke.d@intel.com; Gao, Liming

Re: [edk2] [Patch] MdeModulePkg: Fix issue about Ip4Dxe implementation for DHCP DORA process

2015-08-13 Thread El-Haj-Mahmoud, Samer
Thanks Jiaxin. Are you going to submit a patch to fix the ifconfig issue caused by this change? -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Wednesday, August 12, 2015 8:54 PM To: El-Haj-Mahmoud, Samer samer.el-haj-mahm...@hp.com; Ye, Ting ting...@intel.com;

Re: [edk2] [Patch] MdeModulePkg: Fix issue about Ip4Dxe implementation for DHCP DORA process

2015-08-13 Thread Wu, Jiaxin
Yes, Samer, I will create a new patch to fix this issue. Thanks. Jiaxin -Original Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] Sent: Friday, August 14, 2015 1:49 AM To: Wu, Jiaxin; Ye, Ting; edk2-devel@lists.01.org Cc: Fu, Siyuan; Subramanian, Sriram

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread David Woodhouse
On Thu, 2015-08-13 at 21:25 +0200, Ard Biesheuvel wrote: Another reason to unify the GCC compiler and linker flags: we do use -ffunction-sections -fdata-sections and --gc-sections, but only for GCC44 - GCC49, and these flags are not inherited by UNIXGCC et al Ah, I didn't realise we did.

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Ard Biesheuvel had to walk into mine at 12:25:31 on Thursday 13 August 2015 and say: On 13 August 2015 at 21:14, David Woodhouse dw...@infradead.org wrote: On Thu, 2015-08-13 at 13:25 -0500, Scott Duplichan wrote: A while back I

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread David Woodhouse
On Thu, 2015-08-13 at 13:25 -0500, Scott Duplichan wrote: A while back I experimented with mingw as a Windows hosted gcc tool chain for EDK2. It is usable, but has limitations. From a 2014 email to this list: 1) Image is big due to dead library code in final image. 2) Default calling

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Ard Biesheuvel
On 13 August 2015 at 21:14, David Woodhouse dw...@infradead.org wrote: On Thu, 2015-08-13 at 13:25 -0500, Scott Duplichan wrote: A while back I experimented with mingw as a Windows hosted gcc tool chain for EDK2. It is usable, but has limitations. From a 2014 email to this list: 1) Image is

[edk2] [Patch] BaseTools: Add /arch:IA32 option in VS2012 and VS2013

2015-08-13 Thread Liming Gao
VS2012 and VS2013 turn on optimizations by default that generate the use of CMOV instruction. This is a change from previous version VS2008. This means when you build with VS2012 or VS2013, it will generate UD exceptions on Quark. To resolve it, add /arch:IA32 options to not use enhanced

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Scott Duplichan
David Woodhouse [mailto:dw...@infradead.org] wrote: ]Sent: Thursday, August 13, 2015 02:15 PM ]To: Scott Duplichan sc...@notabs.org; 'Ard Biesheuvel' ard.biesheu...@linaro.org ]Cc: 'Justen, Jordan L' jordan.l.jus...@intel.com; 'edk2-devel@lists.01.org' edk2-de...@ml01.01.org; 'Liu, ]Yingke D'

Re: [edk2] [PATCH] MdeModulePkg Variable: Handle variable Attributes mismatch case

2015-08-13 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: Zeng, Star Sent: Monday, August 10, 2015 6:10 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ruiyu...@intel.com Subject: [PATCH] MdeModulePkg Variable: Handle variable Attributes mismatch case between variable HOB and NV