Re: [edk2] [PATCH v2 3/5] ArmPkg/Mmu: Fix literal number left shift bug

2015-09-09 Thread Ard Biesheuvel
rge enough to use 512GB block size. > > Use LowBitSet64() in BaseLib instead to fix the bug. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo <heyi@linaro.org> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel

Re: [edk2] [PATCH v2 1/5] ArmPkg/Mmu: Fix bug of aligning new allocated page table

2015-09-09 Thread Ard Biesheuvel
gned-off-by: Heyi Guo <heyi@linaro.org> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 11 ++

Re: [edk2] [PATCH v2 5/5] ArmPkg/Mmu: Fix potential page table memory leak

2015-09-09 Thread Ard Biesheuvel
On 9 September 2015 at 12:35, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 9 September 2015 at 11:53, Heyi Guo <heyi@linaro.org> wrote: >> During page entry attribute update, if there are table entries >> between starting BlockEntry and LastBlockEntry, t

Re: [edk2] [PATCH 3/3] ArmVirtPkg: set max physical address width to 40 bits

2015-09-09 Thread Ard Biesheuvel
On 9 September 2015 at 15:59, Laszlo Ersek <ler...@redhat.com> wrote: > On 09/08/15 19:35, Ard Biesheuvel wrote: >> When executing on a LPAE capable 32-bit ARM platform, we support >> up to 40 bits of physical address space so set PcdPrePiCpuMemorySize >> according

Re: [edk2] [PATCH 1/3] ArmPlatformPkg/MemoryInitPeim: handle memory above 4 GB on 32-bit ARM

2015-09-09 Thread Ard Biesheuvel
On 9 September 2015 at 16:53, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Wed, Sep 09, 2015 at 04:38:08PM +0200, Ard Biesheuvel wrote: >> On 9 September 2015 at 16:31, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> > On Tue, Sep 08, 2015 at 07:35:40

Re: [edk2] [PATCH 1/3] ArmPlatformPkg/MemoryInitPeim: handle memory above 4 GB on 32-bit ARM

2015-09-09 Thread Ard Biesheuvel
On 9 September 2015 at 16:31, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Sep 08, 2015 at 07:35:40PM +0200, Ard Biesheuvel wrote: >> Make sure that the PEI memory region is carved out of memory that is >> 32-bit addressable, by taking MAX_ADDRESS into account

Re: [edk2] Section Alignment of elf binaries compiled with GCC(Linux)

2015-09-09 Thread Ard Biesheuvel
On 9 September 2015 at 17:26, Gao, Liming wrote: > Michael: > Do you use the linker script BaseTools/Scripts/GccBase.lds and -z > common-page-size=4096? > Are you building for 32-bit ARM by any chance? That does not have this feature wired up yet. I posted a v2 of my

Re: [edk2] Section Alignment of elf binaries compiled with GCC(Linux)

2015-09-09 Thread Ard Biesheuvel
> On 9 sep. 2015, at 18:10, Michael Zimmermann <sigmaepsilo...@gmail.com> wrote: > > Yes I'm using 32bit ARM :) > thx for the patches - unfortunatelythe patches fail for me. > Did you regenerate Conf/tools_def.txt and rebuild the BaseTools/ ? >> On Wed,

Re: [edk2] [PATCH] BaseTools/GenFw: align RVA of debug

2015-09-11 Thread Ard Biesheuvel
On 9 September 2015 at 11:44, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > SVN commit r18077 ("BaseTools/GenFw: move .debug contents to .data to > save space") removed the separate .debug section after moving its > contents into .text or .data. However,

Re: [edk2] [PATCH] BaseTools/GenFw: align RVA of debug

2015-09-11 Thread Ard Biesheuvel
new maintainer? Regards, Ard. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Friday, September 11, 2015 2:53 PM > To: edk2-devel@lists.01.org; Gao, Liming; Liu, Yingke D > Cc: Laszlo Ersek; Leif Lin

Re: [edk2] [PATCH] ShellPkg: Fix Shell fail when execute command in ShellProtocol.Execute().

2015-09-17 Thread Ard Biesheuvel
On 16 September 2015 at 07:51, Qiu Shumin wrote: > When execute a command with tailing blank spaces in ShellProtocol.Execute() > Shell will fail. This patch move the TrimSpaces operation into > ParseCommandLineToArgs function to fix the problem. > > Cc: Ruiyu Ni

Re: [edk2] [PATCH] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Ard Biesheuvel
On 17 September 2015 at 05:04, Qiu Shumin wrote: > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Yang Jadis > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qiu Shumin

Re: [edk2] [PATCH] ArmVirtPkg: PlatformIntelBdsLib: signal ReadyToBoot on direct kernel boot

2015-09-17 Thread Ard Biesheuvel
laim and (optionally) installs variable usage statistics as > a vendor config table; > > - OnReadyToBoot() in > "SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c" > installs the image execution info table if it doesn't exist yet, in > SecureBoot-en

Re: [edk2] [PATCH v3] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Ard Biesheuvel
> of the function. > > Difference with the 2nd version > Remove the redundant code. > > Cc: Jaben Carsey <jaben.car...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Yang Jadis <jadis.y...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@lin

Re: [edk2] [PATCH v2] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Ard Biesheuvel
t in the remainder > of the function. > OK, much better. Still some comments below, though. > Cc: Jaben Carsey <jaben.car...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Yang Jadis <jadis.y...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contr

[edk2] [PATCH 2/4] ArmPkg/AArch64Mmu: add functions to set/clear RO and XN bits on regions

2015-09-14 Thread Ard Biesheuvel
Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Include/Library/ArmLib.h| 24 ++ ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 83 ArmPkg/Library/ArmLib/ArmV7/ArmV7Mmu.c | 36 + 3 files changed, 143 inse

[edk2] [PATCH 3/4] MdeModulePkg/DxeIplPeim: implement non-exec stack for ARM/AARCH64

2015-09-14 Thread Ard Biesheuvel
Mark the DXE stack region as non-executable right before handing off to the DXE core, by invoking the appropriate ArmLib function. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoad

[edk2] [PATCH 0/4] non-exec DXE stack for AARCH64

2015-09-14 Thread Ard Biesheuvel
right after it has been allocated (patch #3). Patch #4 enables the feature for ArmVirtQemu if building for AARCH64. Ard Biesheuvel (4): ArmPkg/AArch64Mmu: move page table traversal code to separate function ArmPkg/AArch64Mmu: add functions to set/clear RO and XN bits on regions MdeModulePkg

[edk2] [PATCH 4/4] ArmVirtPkg/ArmVirtQemu: enable non-exec DXE stack for AARCH64

2015-09-14 Thread Ard Biesheuvel
Enable the non-exec DXE stack feature when building for AARCH64. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ArmVirtPkg/ArmVirtQemu

[edk2] [PATCH 2/2] MdePkg/PeCoffLoader: fix handling of ARM MOVW/MOVT instruction relocs

2015-09-29 Thread Ard Biesheuvel
instructions, and the second pass should be performed unconditionally. But let's just fix it for now. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdePkg/Library/BasePeCoffLib/Arm/PeCoffLoaderEx.c | 1 + 1 file chan

[edk2] [PATCH 1/2] BaseTools/PeCoffLoader: fix handling of ARM MOVW/MOVT instruction relocs

2015-09-29 Thread Ard Biesheuvel
Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Source/C/Common/PeCoffLoaderEx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/Common/PeCoffLoaderEx.c b/BaseTools/Source/C/Common/PeCoffLoaderEx.c

Re: [edk2] [PATCH] OvmfPkg: set 4 KB section alignment for DXE_RUNTIME modules

2015-09-30 Thread Ard Biesheuvel
On 30 September 2015 at 10:53, Laszlo Ersek <ler...@redhat.com> wrote: > Ard, > > On 09/29/15 18:48, Laszlo Ersek wrote: >> On 09/29/15 18:05, Ard Biesheuvel wrote: >>> Increase the section alignment to 4 KB for DXE_RUNTIME modules. This >>> allows the OS

Re: [edk2] [PATCH v4 1/2] BaseTools/ARM: move to unified GCC linker script

2015-10-01 Thread Ard Biesheuvel
On 1 October 2015 at 14:52, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Oct 01, 2015 at 02:30:56PM +0200, Ard Biesheuvel wrote: >> On 25 September 2015 at 03:08, Ard Biesheuvel <ard.biesheu...@linaro.org> >> wrote: >> > Instead of using the ARM b

[edk2] [PATCH v5 2/3] ArmVirtPkg: use 4 KB section alignment for ARM DXE_RUNTIME_DRIVER modules

2015-10-01 Thread Ard Biesheuvel
In order to support the Properties Table memory protection feature on 32-bit ARM, build DXE_RUNTIME_MODULE type binaries with 4 KB section alignment by setting the common-page-size linker command line option. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v5 1/3] BaseTools/ARM: move to unified GCC linker script

2015-10-01 Thread Ard Biesheuvel
Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Tested-by: Michael Zimmermann <sigmaepsilo...@gmail.com> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> --- BaseTools/Conf/tools_def.template | 10 +- 1 file changed, 9 insertions(+), 1

[edk2] [PATCH v5 3/3] ArmVExpressPkg: use 4 KB section alignment for ARM DXE_RUNTIME_DRIVER modules

2015-10-01 Thread Ard Biesheuvel
In order to support the Properties Table memory protection feature on 32-bit ARM, build DXE_RUNTIME_DRIVER type binaries with 4 KB section alignment by setting the common-page-size linker command line option. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v5 3/3] ArmVExpressPkg: use 4 KB section alignment for ARM DXE_RUNTIME_DRIVER modules

2015-10-01 Thread Ard Biesheuvel
On 1 October 2015 at 15:53, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Oct 01, 2015 at 03:40:42PM +0200, Ard Biesheuvel wrote: >> In order to support the Properties Table memory protection feature >> on 32-bit ARM, build DXE_RUNTIME_DRIVER type binar

Re: [edk2] Unable to use EFI firmware in Xen ARM guest after 41f8901

2015-10-01 Thread Ard Biesheuvel
On 1 October 2015 at 17:58, Julien Grall wrote: > Hi, > > We tried today to use the UEFI binary provided by Linaro for Xen [1] and > noticed the guest doesn't boot anymore. > Thanks for reporting. My LAVA job appears to have been offline for a while because the Xen

[edk2] [PATCH] ArmPkg/Mmu: do not configure block translations at level 0

2015-10-02 Thread Ard Biesheuvel
-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c b/ArmPkg/Library/Ar

[edk2] [PATCH] BaseTools/AARCH64: use large code model for GCC <= 4.8

2015-10-02 Thread Ard Biesheuvel
Stabellini <stefano.stabell...@eu.citrix.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Conf/tools_def.template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Conf/tools_

Re: [edk2] [Xen-devel] Unable to use EFI firmware in Xen ARM guest after 41f8901

2015-10-02 Thread Ard Biesheuvel
On 2 October 2015 at 14:43, Ian Campbell <ian.campb...@citrix.com> wrote: > On Fri, 2015-10-02 at 14:18 +0200, Ard Biesheuvel wrote: >> Is there any reasonable upper bound to the domU PA space >> other than what is communicated in the ID registers? > > You mean the PAS

Re: [edk2] [Xen-devel] Unable to use EFI firmware in Xen ARM guest after 41f8901

2015-10-02 Thread Ard Biesheuvel
On 1 October 2015 at 18:32, Julien Grall <julien.gr...@gmail.com> wrote: > > On 1 Oct 2015 17:07, "Ard Biesheuvel" <ard.biesheu...@linaro.org> wrote: >> >> On 1 October 2015 at 17:58, Julien Grall <julien.gr...@citrix.com> wrote: >> > Hi, &

Re: [edk2] [PATCH] BaseTools/AARCH64: use large code model for GCC <= 4.8

2015-10-02 Thread Ard Biesheuvel
On 2 October 2015 at 16:38, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Fri, Oct 02, 2015 at 03:55:10PM +0200, Ard Biesheuvel wrote: >> As it turns out, upstream GCC only supports the AArch64 'tiny' code >> model as of version 4.9. Since the default 'small' code m

Re: [edk2] [PATCH] ArmPkg/Mmu: do not configure block translations at level 0

2015-10-02 Thread Ard Biesheuvel
On 2 October 2015 at 16:44, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Fri, Oct 02, 2015 at 02:50:35PM +0200, Ard Biesheuvel wrote: >> Now that the AArch64 MMU code correctly identifies and handles >> naturally aligned regions of more than 2 MB in size, it will

Re: [edk2] Section Alignment of elf binaries compiled with GCC(Linux)

2015-09-09 Thread Ard Biesheuvel
hat usable, how the maintainers test it? because > usually people don't post git links. > > On Wed, Sep 9, 2015 at 6:31 PM, Ard Biesheuvel <ard.biesheu...@linaro.org> > wrote: >> >> On 9 September 2015 at 18:21, Michael Zimmermann >> <sigmaepsilo...@gmail.com> wro

Re: [edk2] [PATCH 2/2] ArmVirtPkg: QemuFwCfgLib: read bytes from fw-cfg with DMA when available

2015-09-24 Thread Ard Biesheuvel
On 24 September 2015 at 04:26, Laszlo Ersek <ler...@redhat.com> wrote: > The protocol is documented in "docs/specs/fw_cfg.txt" in the QEMU tree. > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH 1/2] ArmVirtPkg: VirtFdtDxe: detect fw-cfg DMA interface from the DTB

2015-09-24 Thread Ard Biesheuvel
Make VirtFdtDxe > expose this register if it is present. > > Please see "docs/specs/fw_cfg.txt" in the QEMU tree for more information. > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by

Re: [edk2] [PATCH 3/3] ArmVirtPkg: build the TFTP command into the UEFI shell

2015-09-24 Thread Ard Biesheuvel
in the FVMAIN_COMPACT volume is merely 1976 bytes. > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>

Re: [edk2] [PATCH] MdePkg: remove fixup from ARM MOVW/MOVT relocations

2015-09-24 Thread Ard Biesheuvel
(adding Leif and Andrew, who merged this code originally) On 23 September 2015 at 21:31, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > The base relocation type EFI_IMAGE_REL_BASED_ARM_MOV32T patches an > absolute address into the immediate fields of an adjacent movt/movw > i

Re: [edk2] [PATCH] MdePkg: remove fixup from ARM MOVW/MOVT relocations

2015-09-25 Thread Ard Biesheuvel
On 25 September 2015 at 10:23, Andrew Fish <af...@apple.com> wrote: > > On Sep 24, 2015, at 6:03 PM, Ard Biesheuvel <ard.biesheu...@linaro.org> > wrote: > > (adding Leif and Andrew, who merged this code originally) > > > Does this pa

[edk2] [PATCH v2 1/4] ArmPkg/AArch64Mmu: remove cache maintenance for page tables

2015-09-21 Thread Ard Biesheuvel
for ensuring that these changes make it to main memory. So just remove the explicit cache maintenance completely. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 6 --

[edk2] [PATCH] ArmPkg/AArch64Mmu: remove cache maintenance for page tables

2015-09-21 Thread Ard Biesheuvel
for ensuring that these changes make it to main memory. So just remove the explicit cache maintenance completely. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 6 --

Re: [edk2] [PATCH] ArmVirtPkg: reduce preallocation of boot services data pages

2015-09-22 Thread Ard Biesheuvel
On 22 September 2015 at 02:11, Laszlo Ersek <ler...@redhat.com> wrote: > On 09/21/15 20:51, Ard Biesheuvel wrote: >> Commit SVN r18503 ("MdeModulePkg DxeCore: Take the range in resource >> HOB for PHIT as higher priority") changed the GCD init logic to take

[edk2] [PATCH 2/2] BaseTools/GenFw: disable RVCT linker size optimization

2015-09-18 Thread Ard Biesheuvel
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Conf/tools_def.template | 2 +- BaseTools/Source/C/GenFw/Elf32Convert.c | 29 +--- 2 files changed, 8 insertions(+), 23 deletions(-) diff

[edk2] [PATCH 0/2] BaseTools GenFw: remove ARM special case for incorrect alignment

2015-09-18 Thread Ard Biesheuvel
-bit ELF code. Anyone with access to RVCT able to test this? I would highly appreciate it. Ard Biesheuvel (2): BaseTools/GenFw: remove ARM and RVCT references from ELF64 code BaseTools/GenFw: disable RVCT linker size optimization BaseTools/Conf/tools_def.template | 2 +- BaseTools/Source

[edk2] [PATCH 1/2] BaseTools/GenFw: remove ARM and RVCT references from ELF64 code

2015-09-18 Thread Ard Biesheuvel
ARM and RVCT apply to 32-bit code only, so remove any references to them (including the workaround for the linker) from the 64-bit version of ElfConvert.c Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/So

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe/Gcd: remove set but not used variables

2015-09-18 Thread Ard Biesheuvel
noCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/MdeModulePkg/Core/Dxe/Gcd

[edk2] [PATCH] ArmVirtPkg: reduce preallocation of boot services data pages

2015-09-21 Thread Ard Biesheuvel
ually need to preallocate 20,000 pages' worth of BootServicesData memory, reduce this figure to the more reasonable 12,000. Reported-by: Mark Rutland <mark.rutl...@arm.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmV

Re: [edk2] [PATCH] ArmPkg/CpuDxe: Disable interrupt before restoring context

2015-09-21 Thread Ard Biesheuvel
(I can fix up the comment myself) Leif? Thanks, Ard. > On 08/24/2015 07:05 PM, Ard Biesheuvel wrote: >> >> On 23 August 2015 at 17:59, Ard Biesheuvel <ard.biesheu...@linaro.org> >> wrote: >>> >>> On 23 August 2015 at 15:39, Heyi Guo <heyi...

[edk2] [PATCH] MdePkg: remove fixup from ARM MOVW/MOVT relocations

2015-09-23 Thread Ard Biesheuvel
the relocation for runtime unconditionally. So remove the fixup handling for this relocation type. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdePkg/Library/BasePeCoffLib/Arm/PeCoffLoaderEx.c | 14 ++ 1 file chan

[edk2] [PATCH v4 0/2] 4 KB section alignment for ARM

2015-09-24 Thread Ard Biesheuvel
Now that the BaseTools/GenFw changes for RVCT have been merged, we can move to the unified linker script for ARM/GCC, and enable the 4 KB section alignment for DXE_RUNTIME modules. Ard Biesheuvel (2): BaseTools/ARM: move to unified GCC linker script ArmVirtPkg: use 4 KB section alignment

Re: [edk2] [PATCH] ArmPlatformPkg/RTSM: remove obsolete Foundation model libraries

2015-10-06 Thread Ard Biesheuvel
On 6 October 2015 at 13:18, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Fri, Sep 04, 2015 at 12:01:24PM +0200, Ard Biesheuvel wrote: >> These are no longer used by any platform in the tree, nor are they >> of any significance to any out of tree platforms. > >

[edk2] [PATCH v3 0/5] non-exec DXE stack for AARCH64

2015-10-06 Thread Ard Biesheuvel
- added Laszlo's R-b to patch #4 Ard Biesheuvel (5): ArmPkg/AArch64Mmu: use architecturally correct definitions for XN/UXN ArmPkg/AArch64Mmu: move page table traversal code to separate function ArmPkg/ArmLib MMU: add functions to set/clear RO and XN bits on regions MdeModulePkg

[edk2] [PATCH v3 4/5] MdeModulePkg/DxeIplPeim: implement non-exec stack for ARM/AARCH64

2015-10-06 Thread Ard Biesheuvel
Mark the DXE stack region as non-executable right before handing off to the DXE core, by invoking the appropriate ArmLib function. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@l

[edk2] [PATCH v3 2/5] ArmPkg/AArch64Mmu: move page table traversal code to separate function

2015-10-06 Thread Ard Biesheuvel
arbitrary bits on each block entry as the page tables are traversed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch

Re: [edk2] [PATCH 00/23] ArmPkg|ArmPlatformPkg|ArmVirtPkg: remove ArmGlobalVariableLib

2015-11-27 Thread Ard Biesheuvel
On 27 November 2015 at 16:11, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Nov 26, 2015 at 01:10:45PM +0100, Ard Biesheuvel wrote: >> As pointed out by Eugene, the use of the ArmPlatformGlobalVariableLib to >> store >> the PEI services pointer violates the

Re: [edk2] [PATCH] ArmPkg/PrePeiCore: adhere to architectural stack alignment requirement

2015-12-07 Thread Ard Biesheuvel
On 7 December 2015 at 18:12, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Mon, Dec 07, 2015 at 04:59:49PM +0100, Ard Biesheuvel wrote: >> Instead of using fuzzy arithmetic with a hardcoded stack alignment value >> of 0x4, use the symbolic constant CPU_STACK_ALIGNME

Re: [edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

2015-12-07 Thread Ard Biesheuvel
On 7 December 2015 at 14:32, Cohen, Eugene wrote: > Ard, > >> As far as patch #4 is concerned, let's wait for confirmation from Eugene, >> also >> regarding the issue of reporting defect against RVCT (if there is a point in >> doing so) > > You're referring to "[PATCH 4/4]

[edk2] [PATCH] ArmPkg/PrePeiCore: use explicit UINTN cast in VOID* arithmetic

2015-12-08 Thread Ard Biesheuvel
RVCT does not like the arithmetic involving a VOID* pointer that was introduced in SVN r19163, so use explicit casts instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/PrePeiCore/MainMPCore.

[edk2] [PATCH] CryptoPkg: fix build support under RVCT

2015-12-08 Thread Ard Biesheuvel
the CryptoPkg libraries from a platform .DSC Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- This supersedes '[PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT' that I sent out last week. Cry

Re: [edk2] [PATCH v2] BaseTools GCC: avoid the use of COMMON symbols

2015-12-07 Thread Ard Biesheuvel
On 7 December 2015 at 16:23, Laszlo Ersek <ler...@redhat.com> wrote: > On 12/07/15 10:52, Ard Biesheuvel wrote: >> The default behavior of the GCC compiler is to emit uninitialized globals >> into a COMMON section, where duplicate definitions are merged. This may >> re

Re: [edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

2015-12-08 Thread Ard Biesheuvel
On 8 December 2015 at 08:50, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 7 December 2015 at 14:32, Cohen, Eugene <eug...@hp.com> wrote: >> Ard, >> >>> As far as patch #4 is concerned, let's wait for confirmation from Eugene, >>> also >&g

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

2015-12-08 Thread Ard Biesheuvel
it". Could we do something like that? > > Thanks, > > Eugene > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf >> Of Michael Zimmermann >> Sent: Monday, November 16, 2015 8:04 AM >> To: Ard Bieshe

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

2015-12-08 Thread Ard Biesheuvel
ility is implemented to decide whether to use the shareable attribute or not (i.e., use the same behavior the PCD gives you in that case) -- Ard. >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf >> Of Michael Zimmermann >&

[edk2] [PATCH] ArmPlatformPkg/ArmVExpress-CTA15-A7: remove stale ArmPlatformGlobalVariable PCD

2015-12-08 Thread Ard Biesheuvel
Now that we removed the complete ArmPlatformGlobalVariable implementation, remove stale PCD references to it from ArmVExpress-CTA15-A7.dsc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/ArmVExpr

[edk2] [PATCH] ArmPkg/PrePeiCore: adhere to architectural stack alignment requirement

2015-12-07 Thread Ard Biesheuvel
-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- This issue was masked before by the fact that some of the stack space was used by the ArmPlatformGlobalVariableLib allocation. Currently, the PEI phase stack is set to value that is not aligned to 8 bytes, causing no end of troubl

Re: [edk2] [PATCH] ArmPkg/PrePeiCore: use explicit UINTN cast in VOID* arithmetic

2015-12-08 Thread Ard Biesheuvel
On 8 December 2015 at 15:09, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Dec 08, 2015 at 09:57:40AM +0100, Ard Biesheuvel wrote: >> RVCT does not like the arithmetic involving a VOID* pointer that was >> introduced in SVN r19163, so use explicit casts instead. &g

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2015-12-08 Thread Ard Biesheuvel
On 8 December 2015 at 14:05, Cohen, Eugene <eug...@hp.com> wrote: > Reviewed-by: Eugene Cohen <eug...@hp.com> > Thanks Eugene @Leif: any concerns? >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Monday, De

[edk2] [PATCH] ArmPkg/ArmV7Mmu: prefer non shareable memory on non-coherent hardware

2015-12-08 Thread Ard Biesheuvel
to the original behavior in that case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/ArmV7/ArmV7Mmu.c | 38 ++-- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/ArmPkg/L

[edk2] [PATCH v2] ArmPkg/ArmV7Mmu: prefer non shareable memory on non-coherent hardware

2015-12-08 Thread Ard Biesheuvel
to the original behavior in that case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- v2: use symbolic constants for the various shift and mask values default to shareable on unexpected values, but ASSERT() as well

Re: [edk2] [PATCH] ArmPlatformPkg/ArmVExpress-CTA15-A7: remove stale ArmPlatformGlobalVariable PCD

2015-12-08 Thread Ard Biesheuvel
On 8 December 2015 at 15:06, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Dec 08, 2015 at 11:17:33AM +0100, Ard Biesheuvel wrote: >> Now that we removed the complete ArmPlatformGlobalVariable implementation, >> remove stale PCD references to it from Arm

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2015-12-08 Thread Ard Biesheuvel
On 8 December 2015 at 16:49, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Dec 08, 2015 at 04:19:47PM +0100, Ard Biesheuvel wrote: >> On 8 December 2015 at 14:05, Cohen, Eugene <eug...@hp.com> wrote: >> > Reviewed-by: Eugene Cohen <eug...@hp.com>

[edk2] [PATCH v3 2/3] BaseTools/GenFw RVCT: fix relocation processing of PT_DYNAMIC sections

2015-12-02 Thread Ard Biesheuvel
, it was purely by chance. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Source/C/GenFw/Elf32Convert.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/BaseTools/Source/C

[edk2] [PATCH v3 1/3] BaseTools RVCT: use scatter file to enforce minimum section alignment

2015-12-02 Thread Ard Biesheuvel
layouts are identical between ELF and PE/COFF. Also add a 4 KB aligned version that can be used to build DXE_RUNTIME_DRIVER modules with runtime memory protection enabled. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Re

Re: [edk2] [PATCH 2/3] ArmPkg: create RVCT assembler macro to centralize EXPORT, AREA, and function label definition

2015-12-02 Thread Ard Biesheuvel
it's in its own section > for code size reasons) and the function label itself. > > This patch is just the macro, PATCH 3/3 contains the assembly source changes. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eugene Cohen <eug...@hp.com> >

Re: [edk2] [PATCH 1/3] BaseTools: add include for AutoGen.h when invoking the preprocessor with RVCT

2015-12-02 Thread Ard Biesheuvel
On 25 November 2015 at 20:06, Cohen, Eugene <eug...@hp.com> wrote: > Ensure that AutoGen.h is force-included when the RVCT preprocessor is invoked. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eugene Cohen <eug...@hp.com> Reviewed-by: Ard

Re: [edk2] [PATCH 3/3] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

2015-12-02 Thread Ard Biesheuvel
On 25 November 2015 at 20:11, Cohen, Eugene wrote: > This has the effect of splitting assembly functions into their own sections > so the linker can remove unused ones to save space. > > This has been tested to build with ArmPkg.dsc with RVCT 4. > > The majority of the conversion

[edk2] [PATCH 2/5] MdeModulePkg: remove unreachable code

2015-12-02 Thread Ard Biesheuvel
Some compilers (like RVCT) are finicky about unreachable code, so remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c | 3 --- MdeModulePkg/Uni

[edk2] [PATCH 1/5] IntelFrameworkModulePkg: remove unreachable code

2015-12-02 Thread Ard Biesheuvel
Some compilers (like RVCT) are finicky about unreachable code, so remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c | 1 - 1 file changed, 1 deletion(-)

[edk2] [PATCH 4/5] ShellPkg: add missing SHELL_STATUS cast

2015-12-02 Thread Ard Biesheuvel
The prototype of ShellCommandRunIfconfig() indicates that it returns a SHELL_STATUS, so returning a EFI_STATUS requires an explicit cast. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ShellPkg/L

[edk2] [PATCH 3/5] SecurityPkg: put missing empty lines at the end of some header files

2015-12-02 Thread Ard Biesheuvel
Some compilers (like RVCT) reject input files that do not end in a newline. So add missing newlines to some SecurityPkg header files. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- SecurityPkg/Library/DxeImageVerificat

[edk2] [PATCH 5/5] ArmVirtPkg: use explicit KERNEL_BLOB_TYPE cast

2015-12-02 Thread Ard Biesheuvel
Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/Library/PlatformIntelBdsLib/QemuKernel.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmVirtPkg/Library/PlatformIntelBdsLib/QemuKernel.c b/ArmVirtPkg/Library/PlatformIntelBdsLib/QemuKe

Re: [edk2] asm/S assembler files

2015-12-02 Thread Ard Biesheuvel
On 2 December 2015 at 19:50, Michael Zimmermann wrote: >> But, I believe -- I could be wrong -- that for ARM/AARCH64 the assembly >> syntax has been uniquely determined anyway. (If this is not the case, I >> hope I'll be corrected.) > > Unfortunately not. From

[edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

2015-12-03 Thread Ard Biesheuvel
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- CryptoPkg/Include/OpenSslSupport.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Include/OpenSslSupport.h b/CryptoPkg/Include/OpenSslSup

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 12:44, David Woodhouse <dw...@infradead.org> wrote: > On Thu, 2015-12-03 at 12:32 +0100, Ard Biesheuvel wrote: >> >> >> ... or maybe not (I hit send too soon) >> >> It does not appear that there are any tests for those #defines >

[edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-03 Thread Ard Biesheuvel
Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- NOTE: this patch will result in build failures until we fix the code to make at least some instances of mVirtualAddressChangeEvent STATIC BaseTools/Conf/tools_def.template | 2 +- BaseTools/Scripts/GccBase.lds

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 12:19, David Woodhouse <dw...@infradead.org> wrote: > On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: >> This comments out the pqueue and ts_* source files from the >> OpensslLib build, since they have no users. > > These are goin

Re: [edk2] [PATCH 2/2] ArmVirtPkg: Add memory space for the memory nodes except the lowest one

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 12:52, Laszlo Ersek <ler...@redhat.com> wrote: > Ard, > > On 11/30/15 18:48, Laszlo Ersek wrote: >> On 11/30/15 12:48, Ard Biesheuvel wrote: >>> On 30 November 2015 at 12:09, Laszlo Ersek <ler...@redhat.com> wrote: >>

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 13:46, David Woodhouse <dw...@infradead.org> wrote: > On Thu, 2015-12-03 at 13:13 +0100, Ard Biesheuvel wrote: >> >> OK, then I think we're good. I can still build my secure boot enabled >> platform with those files removed from OpensslL

Re: [edk2] [PATCH 2/4] CryptoPkg/BaseCryptLib: make mVirtualAddressChangeEvent STATIC

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 11:50, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Make mVirtualAddressChangeEvent STATIC to prevent it from conflicting > with other variables of the same name that may be defined in other > libraries (e.g., MdeModulePkg/Universal/Variable/RuntimeDxe)

Re: [edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 12:17, David Woodhouse <dw...@infradead.org> wrote: > On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: >> The RVCT compiler chokes on a couple of issues in upstream OpenSSL >> that >> can be confirmed to be non-issues by inspection. So ju

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 12:29, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 3 December 2015 at 12:19, David Woodhouse <dw...@infradead.org> wrote: >> On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: >>> This comments out the pqueue and ts_* source

Re: [edk2] [PATCH 0/5] coding style/whitespace/cast fixes for RVCT

2015-12-03 Thread Ard Biesheuvel
On 2 December 2015 at 18:02, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > This fixes a couple of coding style and white space issues and missing casts > that > the RVCT warns about, which means they are breaking the build in > warnings-as-errors > mode. > I have d

Re: [edk2] [PATCH 3/5] SecurityPkg: put missing empty lines at the end of some header files

2015-12-03 Thread Ard Biesheuvel
On 2 December 2015 at 18:02, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Some compilers (like RVCT) reject input files that do not end in a > newline. So add missing newlines to some SecurityPkg header files. > > Contributed-under: TianoCore Contribution Agreement 1.0 &g

Re: [edk2] [PATCH 4/5] ShellPkg: add missing SHELL_STATUS cast

2015-12-03 Thread Ard Biesheuvel
fine to me. I could not apply it from this email, but I pulled it from the list instead. Note that I get lots of whitespace errors when applying it, so please get rid of the trailing whitespace Tested-by: Ard Biesheuvel <ard.biesheu...@linaro.org> With the whitespace errors cleaned up: Revi

[edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

2015-12-03 Thread Ard Biesheuvel
This comments out the pqueue and ts_* source files from the OpensslLib build, since they have no users. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 24 ++---

[edk2] [PATCH 2/4] CryptoPkg/BaseCryptLib: make mVirtualAddressChangeEvent STATIC

2015-12-03 Thread Ard Biesheuvel
Make mVirtualAddressChangeEvent STATIC to prevent it from conflicting with other variables of the same name that may be defined in other libraries (e.g., MdeModulePkg/Universal/Variable/RuntimeDxe) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

[edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

2015-12-03 Thread Ard Biesheuvel
. This series, combined with the other patch, should supersede the combined patch sent out by Eugene on the 24th of Nov. Ard Biesheuvel (4): CryptoPkg ARM: add ArmSoftFloatLib resolution to CryptoPkg.dsc CryptoPkg/BaseCryptLib: make mVirtualAddressChangeEvent STATIC CryptoPkg/OpensslLib: comment out

[edk2] [PATCH 1/4] CryptoPkg ARM: add ArmSoftFloatLib resolution to CryptoPkg.dsc

2015-12-03 Thread Ard Biesheuvel
In order to build the ARM version of CryptoPkg from its own .DSC file, it needs a resolution for the ArmSoftFloatLib dependency of OpensslLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- CryptoPkg/CryptoPkg.dsc | 3

[edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

2015-12-03 Thread Ard Biesheuvel
The RVCT compiler chokes on a couple of issues in upstream OpenSSL that can be confirmed to be non-issues by inspection. So just ignore these warnings entirely. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- CryptoPkg/L

<    1   2   3   4   5   6   7   8   9   10   >