Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-04 Thread Ard Biesheuvel
e two copies of mVirtualAddressChangeEvent are mapped onto the same memory location? > Reviewed-by: Liming Gao <liming@intel.com> > Thanks > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, December 03, 2015 8:54 PM > To: edk2-devel@lists.0

Re: [edk2] [PATCH v3 2/2] ArmVirtPkg: Add memory space for the high memory nodes

2015-12-04 Thread Ard Biesheuvel
On 4 December 2015 at 12:53, Laszlo Ersek wrote: > Nice in general; I have three comments: > > On 12/04/15 11:13, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Here we add the memory space for the high memory nodes except the lowest >> one in FDT. So

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: upgrade to openssl-1.0.2e

2015-12-04 Thread Ard Biesheuvel
way forward. Thanks, Ard. > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Long, >> Qin >> Sent: Friday, December 4, 2015 10:25 PM >> To: Ard Biesheuvel; edk2-devel@lists.01.org; dw...@infradead.org >&g

Re: [edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 12:26, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 3 December 2015 at 12:17, David Woodhouse <dw...@infradead.org> wrote: >> On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: >>> The RVCT compiler chokes on a couple

Re: [edk2] GICv3 support

2015-12-03 Thread Ard Biesheuvel
On 1 December 2015 at 19:39, Supreeth Venkatesh wrote: > Meenakshi, > > Are you using any EL3 firmware with GICv3 support in it? > Is "PcdArmGicV3WithV2Legacy" being used? > Is the ARM Architectural Timer working for you? (If this works, keyboard > input work fine.) >

[edk2] [PATCH 0/3] remove v2 override for GICv3

2015-12-03 Thread Ard Biesheuvel
from FVP-AArch64 (which is its only user) Ard Biesheuvel (3): ArmPkg/ArmGic: fix bug in GICv3 distributor configuration ArmVExpressPkg/ArmVExpress-FVP-AArch64: run GICv3 in v3 mode ArmPkg/ArmGic: remove GICv3 legacy override ArmPkg/ArmPkg.dec | 3

[edk2] [PATCH 3/3] ArmPkg/ArmGic: remove GICv3 legacy override

2015-12-03 Thread Ard Biesheuvel
1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/ArmPkg.dec | 3 -- ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 1 - ArmPkg/Drivers/ArmGic/ArmGicLib.c | 6 ++-- ArmPkg/Drivers/ArmGic/ArmGicLib.inf | 3 -- ArmPkg/Drivers/

[edk2] [PATCH 1/3] ArmPkg/ArmGic: fix bug in GICv3 distributor configuration

2015-12-03 Thread Ard Biesheuvel
kat...@arm.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib

Re: [edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

2015-12-04 Thread Ard Biesheuvel
On 3 December 2015 at 10:32, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > The header file OpenSslSupport.h not only defines a type 'struct timeval' > but also defines a global variable 'timeval' of that type. The RVCT > compiler does not merge this definition into a common sy

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-04 Thread Ard Biesheuvel
On 4 December 2015 at 17:27, Laszlo Ersek wrote: > On 12/04/15 17:23, Paolo Bonzini wrote: >> >> >> On 04/12/2015 11:39, Laszlo Ersek wrote: >>> (4) Linking those two files into a complete program is a violation of >>> "6.7 External definitions": >>> >>> [...] If an

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-06 Thread Ard Biesheuvel
On 6 December 2015 at 09:03, Jordan Justen <jordan.l.jus...@intel.com> wrote: > On 2015-12-05 22:26:53, Ard Biesheuvel wrote: >> On 6 December 2015 at 01:44, Jordan Justen <jordan.l.jus...@intel.com> wrote: >> > On 2015-12-04 11:21:18, Ard Biesheuvel wrote: [...]

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-05 Thread Ard Biesheuvel
On 6 December 2015 at 01:44, Jordan Justen <jordan.l.jus...@intel.com> wrote: > On 2015-12-04 11:21:18, Ard Biesheuvel wrote: >> On 4 December 2015 at 20:13, Jordan Justen <jordan.l.jus...@intel.com> wrote: >> > On 2015-12-04 08:43:29, Ard Biesheuvel wrote: >

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-04 Thread Ard Biesheuvel
On 4 December 2015 at 20:20, Daryl McDaniel <edk2-li...@mc2research.org> wrote: [...] >> On 12/03/15 13:54, Ard Biesheuvel wrote: >>> The default behavior of the GCC compiler is to emit uninitialized >>> globals into a COMMON section, where duplicate definitions a

Re: [edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 19:09, Long, Qin <qin.l...@intel.com> wrote: > Sorry, I missed this patch. Yes, this looks good. > > Reviewed-by: Qin Long <qin.l...@intel.com> > Thanks Qin, Committed as SVN r19135 >> -Original Message- >> From: Ard Biesheuv

Re: [edk2] [PATCH v2 03/20] ArmPlatformPkg: Convert all .uni files to utf-8

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 21:13, Jordan Justen <jordan.l.jus...@intel.com> wrote: > To convert these files I ran: > > $ python3 BaseTools/Scripts/ConvertUni.py ArmPlatformPkg > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu..

Re: [edk2] [PATCH v2 02/20] ArmPkg: Convert all .uni files to utf-8

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 21:13, Jordan Justen <jordan.l.jus...@intel.com> wrote: > To convert these files I ran: > > $ python3 BaseTools/Scripts/ConvertUni.py ArmPkg > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.or

Re: [edk2] [PATCH v2 06/20] EmbeddedPkg: Convert all .uni files to utf-8

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 21:13, Jordan Justen <jordan.l.jus...@intel.com> wrote: > To convert these files I ran: > > $ python3 BaseTools/Scripts/ConvertUni.py EmbeddedPkg > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.or

[edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2015-12-06 Thread Ard Biesheuvel
n Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Include/Library/ArmLib.h| 8 +++- ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c | 2 +- ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 6 +

Re: [edk2] [PATCH 2/3] SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/Deployed

2015-12-07 Thread Ard Biesheuvel
On 7 December 2015 at 03:04, Zhang, Chao B wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang, Chao > Reviewed-by: Zeng Star > Reviewed-by: Long Qin > --- This patch

[edk2] [PATCH v2] BaseTools GCC: avoid the use of COMMON symbols

2015-12-07 Thread Ard Biesheuvel
definitions after inlining all invocations or perform constant propagation on variables. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Liming Gao <liming@intel.com> Reviewed-by: Laszlo Ersek <ler...@red

Re: [edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

2015-12-07 Thread Ard Biesheuvel
ns raised. As far as patch #4 is concerned, let's wait for confirmation from Eugene, also regarding the issue of reporting defect against RVCT (if there is a point in doing so) Thanks, Ard. >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> S

Re: [edk2] [PATCH 2/3] SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/Deployed

2015-12-07 Thread Ard Biesheuvel
On 7 December 2015 at 09:57, Zhang, Chao B <chao.b.zh...@intel.com> wrote: > Ard: > Sorry for the inconvenience, your fix is good. > Thank you Chao > > > > > Thanks & Best regards > Chao Zhang > > -Original Message- > From: Ard Bieshe

Re: [edk2] [PATCH v3 2/3] BaseTools/GenFw RVCT: fix relocation processing of PT_DYNAMIC sections

2015-12-07 Thread Ard Biesheuvel
On 2 December 2015 at 17:06, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Unlike GNU ld, which can be instructed to emit symbol based static > relocations into fully linked binaries using the --emit-relocs command > line switch, the RVCT armlink tool can only emit dyna

Re: [edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

2015-12-03 Thread Ard Biesheuvel
On 3 December 2015 at 16:02, David Woodhouse <dw...@infradead.org> wrote: > On Thu, 2015-12-03 at 15:26 +0100, Ard Biesheuvel wrote: >> On 3 December 2015 at 12:26, Ard Biesheuvel wrote: >> > On 3 December 2015 at 12:17, David Woodhouse <dw...@infradead.org> wrote: &

Re: [edk2] [PATCH v2] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

2015-12-03 Thread Ard Biesheuvel
by: Eugene Cohen <eug...@hp.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@gmail.com> Committed as SVN r19109 Thanks Eugene! > --- > .../ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm | 5 +- > ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.asm | 26 ++--- > ArmPkg/Libr

[edk2] [PATCH v2] ArmPkg/ArmSoftfloatLib: add missing entry points for RVCT

2015-12-01 Thread Ard Biesheuvel
Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- v2: - correctly preserve r0 - r3 across the entire call - use ALU instructions rather than direct CPSR manipulation to set the C and Z condition flags ArmPkg/Library/ArmSoftFloatLib/Arm/__aeabi_cdcmp.as

[edk2] [PATCH v2 1/3] BaseTools RVCT: use scatter file to implement minimum section alignment

2015-12-01 Thread Ard Biesheuvel
DXE_RUNTIME_DRIVER modules with runtime memory protection enabled. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Conf/tools_def.template | 2 +- BaseTools/Scripts/Rvct-Align32.sct | 25 BaseTools/S

[edk2] [PATCH v2 0/3] ARM: RVCT: fix ELF to PE/COFF conversion

2015-12-01 Thread Ard Biesheuvel
enable 4 KB section alignment for DXE_RUNTIME_DRIVER modules. Ard Biesheuvel (3): BaseTools RVCT: use scatter file to implement minimum section alignment BaseTools/GenFw RVCT: fix relocation processing of PT_DYNAMIC sections ArmVirtPkg RVCT: build DXE_RUNTIME_DRIVER modules with 4 KB

[edk2] [PATCH v2 2/3] BaseTools/GenFw RVCT: fix relocation processing of PT_DYNAMIC sections

2015-12-01 Thread Ard Biesheuvel
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Source/C/GenFw/Elf32Convert.c | 33 ++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c b/BaseTools/

[edk2] [PATCH v2 3/3] ArmVirtPkg RVCT: build DXE_RUNTIME_DRIVER modules with 4 KB alignment

2015-12-01 Thread Ard Biesheuvel
This adds the RVCT armlink command line switches to build modules of type DXE_RUNTIME_DRIVER with 4 KB PE/COFF section alignment, allowing the OS to apply stricter permissions to the .text and .data sections. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2 1/3] BaseTools RVCT: use scatter file to implement minimum section alignment

2015-12-01 Thread Ard Biesheuvel
: the last time around (when changing AARCH64) I missed some DS-5 scripts that I did not even know we had in the tree. > Reviewed-by: Eugene Cohen <eug...@hp.com> > Thanks! -- Ard. >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> S

Re: [edk2] [PATCH] ArmPkg: Convert whole-cache InvalidateInstructionCache to just ASSERT

2015-12-01 Thread Ard Biesheuvel
1.0 > Signed-off-by: Eugene Cohen <eug...@hp.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Arm

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-04 Thread Ard Biesheuvel
On 4 December 2015 at 20:13, Jordan Justen <jordan.l.jus...@intel.com> wrote: > On 2015-12-04 08:43:29, Ard Biesheuvel wrote: >> On 4 December 2015 at 17:27, Laszlo Ersek <ler...@redhat.com> wrote: >> > On 12/04/15 17:23, Paolo Bonzini wrote: >> >> >

Re: [edk2] [PATCH v2] ArmPkg/ArmV7Mmu: prefer non shareable memory on non-coherent hardware

2015-12-15 Thread Ard Biesheuvel
On 15 December 2015 at 11:28, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Dec 15, 2015 at 11:10:49AM +0100, Ard Biesheuvel wrote: >> On 8 December 2015 at 16:11, Ard Biesheuvel <ard.biesheu...@linaro.org> >> wrote: >> > Commit SVN r18778 made

Re: [edk2] [PATCH 1/2] BaseTools CLANG35: use -target in PP flags as well

2015-12-17 Thread Ard Biesheuvel
On 17 December 2015 at 10:04, Gao, Liming <liming@intel.com> wrote: > Ard: > Do GCC_VFRPP_FLAGS and GCC_ASLPP_FLAGS require this change? > Probably, let me change that. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent

Re: [edk2] [PATCH] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-17 Thread Ard Biesheuvel
as well. Note that these problems are new in Clang 3.7, they were not noticed in 3.5 or 3.6 > Thanks > Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, December 16, 2015 6:49 PM > To: edk2-devel@lists.01.org; Gao, Liming

[edk2] [PATCH 2/8] MdeModulePkg: use VA_COPY for assigning va_list types

2015-12-17 Thread Ard Biesheuvel
Clang does not allow straight assignment of va_list types, so use the correct VA_COPY() instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 4 ++-- 1 file chan

[edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-17 Thread Ard Biesheuvel
C99 does not define left-shifting negative values, so make all [positive] preprocessor constants unsigned explicitly, so they do not become negative values after bitwise negation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

[edk2] [PATCH 7/8] BaseTools CLANG35: use GNU target triplets explicitly

2015-12-17 Thread Ard Biesheuvel
Since we are combining Clang with the GNU linker, make that explicit in the target triplet. This affects certain builtin defines and other compiler behavior that may be unspecified otherwise. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

[edk2] [PATCH 5/8] BaseTools/GenFw: allow SHN_UNDEF symbol references in R_X86_64_NONE relocs

2015-12-17 Thread Ard Biesheuvel
Clang for X86 emits lots of R_X86_64_NONE relocations when using -ffunction-sections -fdata-sections. These can safely be ignored, which means we should also not error out if these relocs do not refer to valid symbols. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard

[edk2] [PATCH 8/8] BaseTools CLANG35: add support for IA32 and X64

2015-12-17 Thread Ard Biesheuvel
This adds preliminary support for building for the IA32 and X64 architectures using the CLANG35 toolchain. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Conf/tools_def.template | 53 Bas

[edk2] [PATCH 0/8] add IA32 and X64 support to CLANG35 toolchain

2015-12-17 Thread Ard Biesheuvel
in { 5 .. 8 } Ard Biesheuvel (8): MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift MdeModulePkg: use VA_COPY for assigning va_list types PcAtChipsetPkg: remove unitialized variable warnings PcAtChipsetPkg: make preprocessor constants explicitly unsigned BaseTools/GenFw

[edk2] [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-17 Thread Ard Biesheuvel
a way that prevents compilers from this century from doing whacky things with it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdePkg/Library/BaseLib/Math64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 10:59, M.V.R. Ravikanth wrote: > Thanks Biesheuvel! > I cross checked the tool chain configuration and -mcmodel=large is > present.Also to add,I am facing this issue ONLY WHEN COMPILING CPP > programs.When I compile and C program,everything goes fine.

[edk2] [PATCH 2/5] ArmPlatformPkg/ArmJunoLib: use declared PPI rather than module local var

2015-12-14 Thread Ard Biesheuvel
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under [Ppis] in the library's .inf so there is no need to copy it into a module local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatf

[edk2] [PATCH 5/5] ArmPlatformPkg/RTSM: use declared PPI rather than module local var

2015-12-14 Thread Ard Biesheuvel
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under [Ppis] in the library's .inf so there is no need to copy it into a module local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatf

[edk2] [PATCH 0/5] ArmPlatformPkg: fix gArmMpCoreInfoPpiGuid declaration

2015-12-14 Thread Ard Biesheuvel
This fixes five copy-pasted instances where the gArmMpCoreInfoPpiGuid PPI is redeclared in an open-coded fashion rather than simply declared in the module .inf. Ard Biesheuvel (5): ArmPlatformPkg/ArmPlatformLibNull: use declared PPI rather than module local var ArmPlatformPkg/ArmJunoLib

[edk2] [PATCH 3/5] ArmPlatformPkg/CTA15-A7: use declared PPI rather than module local var

2015-12-14 Thread Ard Biesheuvel
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under [Ppis] in the library's .inf so there is no need to copy it into a module local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatf

Re: [edk2] [PATCH] ArmPkg/CpuDxe: drop ARMv4 exception handling code

2015-12-15 Thread Ard Biesheuvel
On 15 December 2015 at 10:51, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Dec 15, 2015 at 10:47:56AM +0100, Ard Biesheuvel wrote: >> Since we do not support anything below ARMv7, let's promote the ARMv6 >> exception handling code in CpuDxe to the only version

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-15 Thread Ard Biesheuvel
>> >> > suffice here? >> >> > >> >> >> >> No. The C++ runtime is tightly coupled to the C library, which in turn >> >> is tightly coupled to the OS. >> >> >> >> It does depend on what C++ features you need: exce

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-15 Thread Ard Biesheuvel
menting new and delete should >> not be that difficult. >> >> > Also,when I compiled my CPP code with Visual studio/WinDDK compiler in >> > UDK >> > environment,I did not re write the standard library inline with EFI >> > environment.But the efi imag

[edk2] [PATCH] ArmPkg/CpuDxe: drop ARMv4 exception handling code

2015-12-15 Thread Ard Biesheuvel
Since we do not support anything below ARMv7, let's promote the ARMv6 exception handling code in CpuDxe to the only version we provide for ARM. This means we can drop the unused ARMv4 version. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

Re: [edk2] [PATCH 2/5] ArmPkg/CompilerIntrinsicsLib: add GCC version of __aeabi_memset()

2015-12-15 Thread Ard Biesheuvel
On 14 December 2015 at 18:11, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Mon, Dec 14, 2015 at 05:25:03PM +0100, Ard Biesheuvel wrote: >> CLANG for ARM may emit calls to __aeabi_memset(), which is subtly different >> from the default memset() [arguments

Re: [edk2] [PATCH v2] ArmPkg/ArmV7Mmu: prefer non shareable memory on non-coherent hardware

2015-12-15 Thread Ard Biesheuvel
On 8 December 2015 at 16:11, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Commit SVN r18778 made all mappings of normal memory (inner) shareable, > even on hardware that implements shareability as uncached accesses. > The original concerns that prompted the change, regardi

Re: [edk2] [PATCH] ArmPlatformPkg/Sec: fix return_from_exception code and comment

2015-12-14 Thread Ard Biesheuvel
>> both may have been broken at some point, and that they weren't fixed >> in the same way nor at the same time. >> >> So bring the GCC version in line with the RVCT version, and at the >> same time, deobfuscate the comment. >> >> Contributed-under: TianoC

[edk2] [PATCH 0/5] add CLANG support for ARM

2015-12-14 Thread Ard Biesheuvel
This series consists of 4 patches that tweak existing ARM code so it can be built with Clang, and a final patch against tools_def.template that introduces the defines so that '-a ARM' can be combined with '-t CLANG35' Ard Biesheuvel (5): ArmPkg: use unified asm syntax for CLANG ArmPkg

[edk2] [PATCH 1/5] ArmPkg: use unified asm syntax for CLANG

2015-12-14 Thread Ard Biesheuvel
to the unified syntax, and replace 'empty descending' with 'decrement after' or 'increment before' as appropriate. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.S

[edk2] [PATCH 3/5] ArmPkg/ArmV7Lib: add CLANG alternative for FPEXC access

2015-12-14 Thread Ard Biesheuvel
-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/ArmV7/ArmV7Support.S | 4 1 file changed, 4 insertions(+) diff --git a/ArmPkg/Library/ArmLib/ArmV7/ArmV7Support.S b/ArmPkg/Library/ArmLib/ArmV7/ArmV7Support.S index 7de1b11ef818..50c760f335de 100644 --- a/ArmPkg/L

Re: [edk2] linux x86_64 build error

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 14:51, Gabriel L. Somlo wrote: > Ard, > > I recently updated my edk2 git repo, and ever since commit 214a3b7 > (BaseTools GCC: avoid the use of COMMON symbols), I get a build error: > Hi, You need to update your Conf/tools_def.txt. If you have no local

Re: [edk2] [PATCH 0/5] ArmPlatformPkg: fix gArmMpCoreInfoPpiGuid declaration

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 13:15, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Mon, Dec 14, 2015 at 11:59:00AM +0100, Ard Biesheuvel wrote: >> This fixes five copy-pasted instances where the gArmMpCoreInfoPpiGuid PPI >> is redeclared in an open-coded fashion rather

Re: [edk2] [PATCH 5/5] BaseTools ARM: add CLANG35 support

2015-12-14 Thread Ard Biesheuvel
(adding Yonghong and Liming) On 14 December 2015 at 17:25, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > This extends the existing CLANG35 toolchain definition with support for > building for the ARM architecture. In order to be able to reuse the existing > ARM GCC defi

[edk2] [PATCH 5/5] BaseTools ARM: add CLANG35 support

2015-12-14 Thread Ard Biesheuvel
Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Conf/tools_def.template | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index fc79bd

Re: [edk2] [PATCH 1/5] ArmPkg: use unified asm syntax for CLANG

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 17:40, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Mon, Dec 14, 2015 at 05:25:02PM +0100, Ard Biesheuvel wrote: >> The CLANG assembler does not support the legacy, non-unified assembler >> syntax, >> i.e., it does not support the

Re: [edk2] [PATCH 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 18:24, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Mon, Dec 14, 2015 at 05:25:05PM +0100, Ard Biesheuvel wrote: >> The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not >> supported by CLANG. So restrict its use to GCC 4.6

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-15 Thread Ard Biesheuvel
the information Andrew! >> >> >> > >> >> >> > So,I have to re write the entire standard library code which is in >> >> >> > line >> >> >> > with >> >> >> > EFI environm

Re: [edk2] [ubuntu] build EmulatorPkg failed

2015-12-12 Thread Ard Biesheuvel
On 12 December 2015 at 17:59, endless wrote: > is there any one could help me to solve the compile problem? Could you make sure that your Conf/tools_def.txt is not out of date? You can simply remove it and re-run 'source edksetup.sh' if you have not made any changes to it

Re: [edk2] [PATCH 3/8] PcAtChipsetPkg: remove unitialized variable warnings

2015-12-17 Thread Ard Biesheuvel
On 17 December 2015 at 14:59, Zeng, Star <star.z...@intel.com> wrote: > On 2015/12/17 18:00, Ard Biesheuvel wrote: >> >> LcrParity and LcrStop may end up being referenced without being >> initialized, so make sure they always have a value. >> >> Contributed-

Re: [edk2] [PATCH] CryptoPkg: fix build support under RVCT

2015-12-17 Thread Ard Biesheuvel
On 8 December 2015 at 09:54, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > The RVCT compiler chokes on a couple of issues in upstream OpenSSL that > can be confirmed to be non-issues by inspection. So just ignore these > warnings entirely. > > Also, move the dummy -

Re: [edk2] [PATCH 2/8] MdeModulePkg: use VA_COPY for assigning va_list types

2015-12-17 Thread Ard Biesheuvel
On 17 December 2015 at 15:23, Zeng, Star <star.z...@intel.com> wrote: > On 2015/12/17 18:00, Ard Biesheuvel wrote: >> >> Clang does not allow straight assignment of va_list types, so use the >> correct VA_COPY() instead. >> >> Contributed-under: TianoCore C

Re: [edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-17 Thread Ard Biesheuvel
On 17 December 2015 at 15:10, Zeng, Star <star.z...@intel.com> wrote: > On 2015/12/17 18:01, Ard Biesheuvel wrote: >> >> C99 does not define left-shifting negative values, so make all >> [positive] preprocessor constants unsigned explicitly, so they >> do not bec

Re: [edk2] [PATCH] CryptoPkg: fix build support under RVCT

2015-12-17 Thread Ard Biesheuvel
On 17 December 2015 at 17:52, Long, Qin <qin.l...@intel.com> wrote: > Looks I missed this one. It's OK for me. > > Reviewed-by: Qin Long <qin.l...@intel.com> > Thank you, Qin Commited as SVN r19328 >> -Original Message- >> From: Ard Biesheuvel [mailt

Re: [edk2] [PATCH v2 1/5] OvfmPkg/XenHypercallLib: add missing GCC_ASM_EXPORT to XenHypercall2

2015-12-17 Thread Ard Biesheuvel
On 17 December 2015 at 18:05, Jordan Justen <jordan.l.jus...@intel.com> wrote: > On 2015-12-17 00:14:04, Ard Biesheuvel wrote: >> (adding Jordan) >> >> On 16 December 2015 at 14:45, Ard Biesheuvel <ard.biesheu...@linaro.org> >> wrote: >> > GCC_ASM_

Re: [edk2] [PATCH 2/8] MdeModulePkg: use VA_COPY for assigning va_list types

2015-12-18 Thread Ard Biesheuvel
On 18 December 2015 at 11:15, Zeng, Star <star.z...@intel.com> wrote: > On 2015/12/17 23:05, Ard Biesheuvel wrote: >> >> On 17 December 2015 at 15:23, Zeng, Star <star.z...@intel.com> wrote: >>> >>> On 2015/12/17 18:00, Ard Biesheuvel wrote: >>&g

[edk2] [PATCH v2 4/5] ArmVirtPkg/ArmXenRelocatablePlatformLib: add ARM support

2015-12-16 Thread Ard Biesheuvel
1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Acked-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/ARM/RelocatableVirtHelper.S | 140 ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/ArmXenRelocatablePla

[edk2] [PATCH v2 1/5] OvfmPkg/XenHypercallLib: add missing GCC_ASM_EXPORT to XenHypercall2

2015-12-16 Thread Ard Biesheuvel
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- OvmfPkg/Library/XenHypercallLib/Arm/Hypercall.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/Library/XenHypercallLib/Arm/Hypercall.S b/OvmfPkg/L

[edk2] [PATCH v2 2/5] ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB memory node retrieval in C

2015-12-16 Thread Ard Biesheuvel
: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Acked-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/AARCH64/MemnodeParser.S | 237 ArmVirtPkg/Library/ArmXenRelocatabl

[edk2] [PATCH v2 5/5] ArmVirtPkg/ArmVirtXen: add ARM support

2015-12-16 Thread Ard Biesheuvel
-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Acked-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/ArmVirtXen.dsc | 7 +++ ArmVirtPkg/ArmVirtXen.fdf | 21 ++-- 2 files changed, 22 insertions(+), 6 deleti

Re: [edk2] [PATCH] ShellPkg: Fix unhandled value in switch statement

2015-12-16 Thread Ard Biesheuvel
l.com> > Cc: Shumin Qiu <shumin@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paulo Alcantara <paulo.alc.cavalca...@hp.com> Acked-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Please apply asap. > --- > ShellPkg/Applic

[edk2] [PATCH v2 3/5] ArmVirtPkg/PrePiRelocatable: add ARM support

2015-12-16 Thread Ard Biesheuvel
-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Acked-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/PrePi/Arm/ArchPrePi.c| 26 +++ ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S | 196 ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatab

[edk2] [PATCH v2 0/5] ArmVirtPkg: add ARM support to ArmVirtXen

2015-12-16 Thread Ard Biesheuvel
this series - new patch #1 which fixes an interworking issue with XenHypercall2() - added Laszlo's acks to patches #2 to #5 Ard Biesheuvel (5): OvfmPkg/XenHypercallLib: add missing GCC_ASM_EXPORT to XenHypercall2 ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB memory node retrieval in C

Re: [edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Ard Biesheuvel
On 16 December 2015 at 13:23, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Wed, Dec 16, 2015 at 12:16:01PM +, Mark Rutland wrote: >> On Wed, Dec 16, 2015 at 12:24:30PM +0100, Ard Biesheuvel wrote: >> > On 16 December 2015 at 12:18, Mark Rutland <

Re: [edk2] [PATCH 3/3] ArmPkg/ArmGic: remove GICv3 legacy override

2015-12-15 Thread Ard Biesheuvel
On 15 December 2015 at 13:45, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Thu, Dec 03, 2015 at 02:58:38PM +0100, Ard Biesheuvel wrote: > > The need for a v2 legacy override to drive a GICv3 in v2 mode is no > > longer necessary, now that the code that ena

Re: [edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Ard Biesheuvel
On 16 December 2015 at 12:18, Mark Rutland <mark.rutl...@arm.com> wrote: > On Wed, Dec 16, 2015 at 10:37:39AM +0100, Ard Biesheuvel wrote: >> Unfortunately, Clang does not support the use of symbol references in .org >> directives, and bails with the following error messa

[edk2] [PATCH] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-16 Thread Ard Biesheuvel
a way that prevents compilers from this century from doing whacky things with it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- Starting with version 3.7, Clang warns about the use of a negative left hand operand whe

Re: [edk2] [PATCH] ShellPkg: Fix unhandled value in switch statement

2015-12-16 Thread Ard Biesheuvel
On 16 December 2015 at 17:37, Carsey, Jaben <jaben.car...@intel.com> wrote: > Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > Committed as SVN r19304 Thanks >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sen

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 19:24, M.V.R. Ravikanth wrote: > Below are the detailed steps which I perform: > > 1.Compile CPP program with linaro GCC on windows. > 2.Linking >->If my code contains reference to standard C++ libraries,then I > include the libstdc++ and

[edk2] [PATCH v2 1/5] ArmPkg: use unified asm syntax for CLANG

2015-12-15 Thread Ard Biesheuvel
to the unified syntax, and replace 'empty descending' with 'decrement after' or 'increment before' as appropriate. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> --- ArmPkg/Dr

[edk2] [PATCH v2 2/5] ArmPkg/CompilerIntrinsicsLib: add GCC version of __aeabi_memset()

2015-12-15 Thread Ard Biesheuvel
CLANG for ARM may emit calls to __aeabi_memset(), which is subtly different from the default memset() [arguments 2 and 3 are reversed] Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/CompilerIntrinsicsL

[edk2] [PATCH v2 3/5] ArmPkg/ArmV7Lib: add CLANG alternative for FPEXC access

2015-12-15 Thread Ard Biesheuvel
-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> --- ArmPkg/Library/ArmLib/ArmV7/ArmV7Support.S | 4 1 file changed, 4 insertions(+) diff --git a/ArmPkg/Library/ArmLib/ArmV7/ArmV7Support.S b/ArmPkg/Library/ArmLib/ArmV7/ArmV7Sup

[edk2] [PATCH v2 5/5] BaseTools ARM: add CLANG35 support

2015-12-15 Thread Ard Biesheuvel
Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> Reviewed-by: Liming Gao <liming@intel.com> --- BaseTools/Conf/tools_def.template | 28 +--- 1 file changed, 25 insertions(+), 3 deleti

[edk2] [PATCH v2 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

2015-12-15 Thread Ard Biesheuvel
The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not supported by CLANG. So restrict its use to GCC 4.6, which is the oldest version we support for ARM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

Re: [edk2] [PATCH v2 0/5] add CLANG support for ARM

2015-12-15 Thread Ard Biesheuvel
On 15 December 2015 at 15:24, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > This series consists of 4 patches that tweak existing ARM code so it can be > built with Clang, and a final patch against tools_def.template that introduces > the defines so that '-a ARM' can be co

[edk2] [PATCH v2 0/5] add CLANG support for ARM

2015-12-15 Thread Ard Biesheuvel
) - added R-b's from Leif (#1, #3, #5) and Liming (#5) Ard Biesheuvel (5): ArmPkg: use unified asm syntax for CLANG ArmPkg/CompilerIntrinsicsLib: add GCC version of __aeabi_memset() ArmPkg/ArmV7Lib: add CLANG alternative for FPEXC access ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option

[edk2] [PATCH] ArmPkg: rewrite vector table population macros

2015-12-16 Thread Ard Biesheuvel
ed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- Surprisingly, this worked fine in Clang-3.5 but not in 3.6 or 3.7 ArmPkg/Include/Chipset/AArch64.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/Include/Chipset/AAr

[edk2] [PATCH 1/2] BaseTools CLANG35: use -target in PP flags as well

2015-12-16 Thread Ard Biesheuvel
The Clang preprocessor may rely on builtin defines that are target dependent, so we should add the -target argument also when invoking the preprocessor directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTool

[edk2] [PATCH 2/2] BaseTools CLANG35: use GNU target triplets explicitly

2015-12-16 Thread Ard Biesheuvel
Since we are combining Clang with the GNU linker, make that explicit in the target triplet. This affects certain builtin defines and other compiler behavior that may be unspecified otherwise. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

Re: [edk2] [PATCH 4/6] ArmVirtPkg: use small code model for all UEFI_APPLICATION modules

2016-01-04 Thread Ard Biesheuvel
On 4 January 2016 at 19:27, Laszlo Ersek <ler...@redhat.com> wrote: > On 12/24/15 14:03, Ard Biesheuvel wrote: >> Unfortunately, compiling the DEBUG shell using the small code model is >> not sufficient in all cases to get a successful build when the toolchain >> defa

[edk2] [PATCH 2/2] BaseTools AARCH64: build XIP modules with strict alignment

2016-01-04 Thread Ard Biesheuvel
modules or static libraries that may execute with the MMU off with -mstrict-align. Other modules don't need this switch, so we can remove it from the CLANG35/AARCH64 common CC flags. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

[edk2] [PATCH 0/2] BaseTools AARCH64: build XIP modules with strict alignment

2016-01-04 Thread Ard Biesheuvel
overrides to be set, and use it to set the -mstrict-align CC flag for BASE, SEC, PEI_CORE and PEIM modules. (XIPFLAGS has been suggest by Andrew Fish a couple of months ago, when a similar issue came up) Ard Biesheuvel (2): BaseTools: add separate build rule for modules that may execute in place

Re: [edk2] [PATCH v2 0/5] AARCH64 code model and toolchain updates

2016-01-04 Thread Ard Biesheuvel
On 31 December 2015 at 13:57, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > This is a followup to the patch 'BaseTools AARCH64: add -mstrict-align to > all AARCH64 GCC flavors' that I sent out on the 23rd. As it turns out, using > strict alignment results in a code size increa

<    1   2   3   4   5   6   7   8   9   10   >