Re: [edk2] ArmVirt: About RTC PL031 in ACPI

2016-01-07 Thread Ard Biesheuvel
On 7 January 2016 at 03:47, Shannon Zhao wrote: > Hi, > > I notice that when booting with DTS UEFI will disable RTC device PL031 > in the DTS by following codes. And it turns out that only rtc-efi shows > up in guest. > > // > // UEFI takes ownership of the RTC hardware,

Re: [edk2] [PATCH 0/2] BaseTools AARCH64: build XIP modules with strict alignment

2016-01-07 Thread Ard Biesheuvel
It does have impact. It results in a 2% increase in the compressed footprint of the firmware image. That is exactly why I needed to make these changes as I did. Thanks, Ard. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel &g

Re: [edk2] [PATCH 0/2] BaseTools AARCH64: build XIP modules with strict alignment

2016-01-07 Thread Ard Biesheuvel
ode-File.SEC.AARCH64,C-Code-File.PEI_CORE.AARCH64,C-Code-File.PEIM.AARCH64] > Yes, that is also fine. > -----Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, January 08, 2016 3:14 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org; l

Re: [edk2] [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-31 Thread Ard Biesheuvel
On 18 December 2015 at 04:05, Gao, Liming <liming@intel.com> wrote: > Reviewed-by: Liming Gao <liming@intel.com> > Thanks. Committed as SVN r19580 > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, December

Re: [edk2] [PATCH 3/6] BaseTools AARCH64: reduce tiny model function alignment

2015-12-31 Thread Ard Biesheuvel
On 27 December 2015 at 21:34, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 27 December 2015 at 20:14, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> On Sun, Dec 27, 2015 at 08:02:34PM +0100, Ard Biesheuvel wrote: >>> On 27 December 2015 at 18

[edk2] [PATCH v2 2/5] BaseTools CLANG35: use -target in PP flags as well

2015-12-31 Thread Ard Biesheuvel
The Clang preprocessor may rely on builtin defines that are target dependent, so we should add the -target argument also when invoking the preprocessor directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by:

[edk2] [PATCH v2 5/5] BaseTools AARCH64: add -mstrict-align to all AARCH64 GCC flavors

2015-12-31 Thread Ard Biesheuvel
the -mstrict-align compiler switch to the shared define for all AARCH64 GCC versions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Liming Gao <liming@intel.com> Reviewed-by: Leif Lindholm <leif.lind

[edk2] [PATCH v2 0/5] AARCH64 code model and toolchain updates

2015-12-31 Thread Ard Biesheuvel
an issue spotted by the Ubuntu/Debian folks (and which they kindly never reported upstream, afaict) here: https://bugs.launchpad.net/ubuntu/+source/edk2/+bug/1489560 Ard Biesheuvel (5): BaseTools CLANG35: use GNU target triplets explicitly BaseTools CLANG35: use -target in PP flags as well BaseTools

[edk2] [PATCH v2 3/5] BaseTools AARCH64: move DEBUG GCC49 to the small code model

2015-12-31 Thread Ard Biesheuvel
. This way, there is no need for workarounds that are specific to UEFI_APPLICATION modules in general, or the Shell application in particular. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Conf/tools_def.templat

[edk2] [PATCH v2 4/5] ShellPkg AARCH64: remove DEBUG BuildOptions override

2015-12-31 Thread Ard Biesheuvel
.DSC anyway, there is no point in setting these options here as well. So remove them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Liming Gao <liming@intel.com> --- ShellPkg/Application/Shell/S

[edk2] [PATCH v2 1/5] BaseTools CLANG35: use GNU target triplets explicitly

2015-12-31 Thread Ard Biesheuvel
Since we are combining Clang with the GNU linker, make that explicit in the target triplet. This affects certain builtin defines and other compiler behavior that may be unspecified otherwise. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

Re: [edk2] [PATCH v2 5/5] BaseTools AARCH64: add -mstrict-align to all AARCH64 GCC flavors

2015-12-31 Thread Ard Biesheuvel
On 31 December 2015 at 13:57, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > GCC for AARCH64 recognizes byte swapping load and store sequences > and may replace them with wider loads or stores combined with rev > instructions. In some cases (i.e., with GCC version 5 and la

Re: [edk2] WriteSections64() Error

2015-12-30 Thread Ard Biesheuvel
On 30 December 2015 at 20:07, Narinder Dhillon wrote: > Hi All, > > Synced up to the latest on EDK2 and compiled for AARCH64 platform, > getting this error. > Any hints appreciated. This means your toolchain definitions are out of sync. Can you make sure your

[edk2] [PATCH] BaseTools AARCH64: add -mstrict-align to all AARCH64 GCC flavors

2015-12-23 Thread Ard Biesheuvel
for all AARCH64 GCC versions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/Bas

Re: [edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-18 Thread Ard Biesheuvel
On 18 December 2015 at 10:45, Zeng, Star <star.z...@intel.com> wrote: > On 2015/12/17 23:47, Ard Biesheuvel wrote: >> >> On 17 December 2015 at 15:10, Zeng, Star <star.z...@intel.com> wrote: >>> >>> On 2015/12/17 18:01, Ard Biesheuvel wrote: >

Re: [edk2] [PATCH 3/6] BaseTools AARCH64: reduce tiny model function alignment

2015-12-27 Thread Ard Biesheuvel
On 27 December 2015 at 20:14, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Sun, Dec 27, 2015 at 08:02:34PM +0100, Ard Biesheuvel wrote: >> On 27 December 2015 at 18:58, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> > On Thu, Dec 24, 2015 at 02:03:16

Re: [edk2] [PATCH 3/6] BaseTools AARCH64: reduce tiny model function alignment

2015-12-27 Thread Ard Biesheuvel
On 27 December 2015 at 18:58, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Dec 24, 2015 at 02:03:16PM +0100, Ard Biesheuvel wrote: >> The tiny code model for AARCH64 is the most efficient model, since its >> symbol references are relative via a single 3

Re: [edk2] [PATCH 6/6] BaseTools AARCH64: add -mstrict-align to all AARCH64 GCC flavors

2015-12-27 Thread Ard Biesheuvel
On 27 December 2015 at 19:02, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Dec 24, 2015 at 02:03:19PM +0100, Ard Biesheuvel wrote: >> GCC for AARCH64 recognizes byte swapping sequences and replaces them >> with rev instructions. In some cases (i.e., with GC

Re: [edk2] [PATCH 1/6] BaseTools CLANG35: use GNU target triplets explicitly

2015-12-27 Thread Ard Biesheuvel
On 27 December 2015 at 20:22, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Sun, Dec 27, 2015 at 08:08:27PM +0100, Ard Biesheuvel wrote: >> On 27 December 2015 at 19:06, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> > On Thu, Dec 24, 2015 at 02:03:14

Re: [edk2] [PATCH 7/8] BaseTools CLANG35: use GNU target triplets explicitly

2015-12-24 Thread Ard Biesheuvel
On 17 December 2015 at 11:01, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Since we are combining Clang with the GNU linker, make that explicit in > the target triplet. This affects certain builtin defines and other compiler > behavior that may be unspecified otherwise.

[edk2] [PATCH 5/6] ShellPkg AARCH64: remove DEBUG BuildOptions override

2015-12-24 Thread Ard Biesheuvel
.DSC anyway, there is no point in setting these options here as well. So remove them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ShellPkg/Application/Shell/Shell.inf | 7 --- 1 file changed, 7 deletions(-) diff

[edk2] [PATCH 0/6] AARCH64 code model and toolchain updates

2015-12-24 Thread Ard Biesheuvel
they kindly never reported upstream, afaict) here: https://bugs.launchpad.net/ubuntu/+source/edk2/+bug/1489560 Ard Biesheuvel (6): BaseTools CLANG35: use GNU target triplets explicitly BaseTools CLANG35: use -target in PP flags as well BaseTools AARCH64: reduce tiny model function alignment

[edk2] [PATCH 6/6] BaseTools AARCH64: add -mstrict-align to all AARCH64 GCC flavors

2015-12-24 Thread Ard Biesheuvel
for all AARCH64 GCC versions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Liming Gao <liming@intel.com> --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[edk2] [PATCH 4/6] ArmVirtPkg: use small code model for all UEFI_APPLICATION modules

2015-12-24 Thread Ard Biesheuvel
affect all Shell component libraries in addition to the Shell core binary. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirt.dsc.inc | 21 1 file changed, 21 insertions(+) diff

[edk2] [PATCH 1/6] BaseTools CLANG35: use GNU target triplets explicitly

2015-12-24 Thread Ard Biesheuvel
Since we are combining Clang with the GNU linker, make that explicit in the target triplet. This affects certain builtin defines and other compiler behavior that may be unspecified otherwise. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

[edk2] [PATCH 2/6] BaseTools CLANG35: use -target in PP flags as well

2015-12-24 Thread Ard Biesheuvel
The Clang preprocessor may rely on builtin defines that are target dependent, so we should add the -target argument also when invoking the preprocessor directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by:

Re: [edk2] [PATCH v2 0/5] ArmVirtPkg: add ARM support to ArmVirtXen

2015-12-23 Thread Ard Biesheuvel
On 21 December 2015 at 18:59, Stefano Stabellini <stefano.stabell...@eu.citrix.com> wrote: > On Wed, 16 Dec 2015, Ard Biesheuvel wrote: >> By special request, this implements ARM support to the ArmVirtXen >> platform. This time, I managed to test it myself under Xen on actua

Re: [edk2] [PATCH 0/3] ArmVirtPkg: add support for UEFI secure boot to 32-bit ARM

2015-11-27 Thread Ard Biesheuvel
On 27 November 2015 at 12:56, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Fri, Nov 27, 2015 at 09:51:50AM +0100, Ard Biesheuvel wrote: >> Since UEFI on 32-bit ARM does not allow floating point arithmetic in >> hardware, >> running OpenSslLib unmodified r

Re: [edk2] [PATCH] ArmPkg: add typecast in UncachedMemoryAllocationLib to fix build warning

2015-11-25 Thread Ard Biesheuvel
On 25 November 2015 at 17:35, Cohen, Eugene wrote: > Small warning fix. > Hello Eugene, Presumably, the warning is about the variable potentially being used uninitialized? If so, please drop the cast in the initializer, and update your $subject accordingly. I am not sure (cc'ing

Re: [edk2] [PATCH] ArmPkg: add missing MigratePeiServicesTablePointer function required by update to the PeiServicesTablePointerLib in svn 15115

2015-11-25 Thread Ard Biesheuvel
One > of these days I might actually get all the parts of a patch submission > correct. > OK, I hadn't spotted that. The patch itself looks fine. Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> I trimmed the subject line, word wrapped the commit log, moved your Contributed-un

Re: [edk2] [PATCH 0/3] ArmVirtPkg: add support for UEFI secure boot to 32-bit ARM

2015-11-27 Thread Ard Biesheuvel
On 27 November 2015 at 14:47, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Fri, Nov 27, 2015 at 01:26:51PM +0100, Ard Biesheuvel wrote: >> On 27 November 2015 at 12:56, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> > On Fri, Nov 27, 2015 at 09:51:50

[edk2] [PATCH v2 1/4] ArmPkg: factor out softfloat support from StdLib/LibC/SoftFloat

2015-11-27 Thread Ard Biesheuvel
In order to support software floating point in the context of DXE drivers etc, this factors out the core ARM softfloat support into a separate library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Li

[edk2] [PATCH v2 4/4] CryptoPkg: add softfloat dependency for ARM

2015-11-27 Thread Ard Biesheuvel
UEFI on 32-bit ARM does not allow the use of hardware floating point, so in order to be able to run OpenSslLib, we need to fulfil its floating point arithmetic dependencies using a software library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

[edk2] [PATCH v2 2/4] ArmPkg/ArmSoftFloatLib: add support for RVCT

2015-11-27 Thread Ard Biesheuvel
drop all of them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmSoftFloatLib/Arm/__aeabi_dcmpeq.c | 1 - ArmPkg/Library/ArmSoftFloatLib/Arm/__aeabi_dcmpge.c | 1 - ArmPkg/Library/ArmSoftFloatL

Re: [edk2] CryptoPkg: OpenSSL build issue with RVCT

2015-11-24 Thread Ard Biesheuvel
without major surgery on the perlasm files) Then, we can see what issues remain in the EDK2 integration, the most important of which is the lack of softfloat support (but perhaps we can port the code from StdLibPkg so that it can be used in DXE?) Regards, Ard. > -Original Message---

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

2015-11-24 Thread Ard Biesheuvel
re not configured yet, or configured incorrectly. Note that I introduced a new feature PCD 'PcdNormalMemoryNonshareableOverride' that reverts to the old behavior. Regards, Ard. > On Wed, Nov 18, 2015 at 12:16 PM, Ard Biesheuvel <ard.biesheu...@linaro.org> > wrote: >> >> On

Re: [edk2] ArmPlatformPkg: Non-compliant PeiServicesTablePointerLib implementation

2015-11-24 Thread Ard Biesheuvel
On 24 November 2015 at 18:16, Cohen, Eugene wrote: > In ArmPlatformPkg there is an implementation of the PeiServicesTablePointer > library that uses the "global variable" creation. (I don't know what the > purpose is of these "global variables" but they seem to be incompatible

Re: [edk2] [PATCH] ArmPkg: add missing MigratePeiServicesTablePointer function required by update to the PeiServicesTablePointerLib in svn 15115

2015-11-24 Thread Ard Biesheuvel
On 24 November 2015 at 18:09, Cohen, Eugene wrote: > As of SVN 15115 the PEI core needs a MigratePeiServicesTablePointer function. > > Background: The ArmPkg variant of the PeiServicesTablePointerLib implements > the standard PEI Services table retrieval mechanism as defined in

Re: [edk2] [PATCH v2 0/4] ArmVirtPkg: add support for UEFI secure boot to 32-bit ARM

2015-11-30 Thread Ard Biesheuvel
On 27 November 2015 at 16:21, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Since UEFI on 32-bit ARM does not allow floating point arithmetic in hardware, > running OpenSslLib unmodified requires a softfloat library. > > This series factors out the minimally required b

Re: [edk2] [PATCH 2/2] ArmVirtPkg: Add memory space for the memory nodes except the lowest one

2015-11-30 Thread Ard Biesheuvel
On 30 November 2015 at 11:01, Laszlo Ersek <ler...@redhat.com> wrote: > On 11/30/15 10:50, Laszlo Ersek wrote: >> On 11/30/15 10:28, Ard Biesheuvel wrote: >>> On 30 November 2015 at 10:22, Shannon Zhao <zhaoshengl...@huawei.com> wrote: >>>> >>

[edk2] [PATCH] BaseTools RVCT: use scatter file to implement minimum section alignment

2015-12-01 Thread Ard Biesheuvel
-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTools/Conf/tools_def.template | 2 +- BaseTools/Scripts/Rvct-Align32.sct | 25 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template

Re: [edk2] Strange behavior of the DS-5 debugger on AARCH64 with step-by-step debugging in uefi

2015-11-30 Thread Ard Biesheuvel
5 debugger on AARCH64 with >> step-by-step debugging in uefi >> >> >> > On Nov 23, 2015, at 11:31 PM, Ard Biesheuvel <ard.biesheu...@linaro.org> >> wrote: >> > >> > On 24 November 2015 at 00:38, Vladimir Olovyannikov >> > <volov...

Re: [edk2] Armv8 64bit: System error booting linux from the UEFI

2015-12-01 Thread Ard Biesheuvel
de1597a356b6d2d5 > Thanks for sharing that. I hope it will be useful to other. Since the Intel BDS support is fairly recent, please don't hesitate to share observations or questions. There may be some issues lurking that we haven't spotted yet ourselves. Thanks, Ard. > On Tue, Nov 24, 2015

Re: [edk2] [PATCH 1/2] ArmVirtPkg: Find the lowest memory node

2015-11-29 Thread Ard Biesheuvel
On 29 November 2015 at 07:31, Shannon Zhao wrote: > From: Shannon Zhao > > If there are more than one /memory nodes in FDT, it needs to find the > lowest one, and set PcdSystemMemorySize with thes size of this node. > > Contributed-under:

Re: [edk2] [PATCH 2/2] ArmVirtPkg: Add memory space for the memory nodes except the lowest one

2015-11-30 Thread Ard Biesheuvel
On 30 November 2015 at 12:09, Laszlo Ersek <ler...@redhat.com> wrote: > On 11/30/15 11:03, Ard Biesheuvel wrote: [...] >> >> Couldn't we simply add EFI_RESOURCE_SYSTEM_MEMORY resource descriptor >> HOBs the first time we enumerate the nodes? > > I didn't sugg

[edk2] [PATCH 03/23] BeagleBoardPkg: remove ArmPlatformGlobalVariableLib resolution

2015-11-26 Thread Ard Biesheuvel
Remove the ArmPlatformGlobalVariableLib library class resolution now that BeagleBoardPkg no longer has a transitive dependency on it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BeagleBoardPkg/BeagleBoardPkg.dsc | 2

[edk2] [PATCH 10/23] ArmVirtPkg/PrePi: remove global variable allocation from lowlevel init

2015-11-26 Thread Ard Biesheuvel
Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to allocate and clear out the global variable region in the PrePi init code. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

[edk2] [PATCH 09/23] ArmPlatformPkg: remove all ArmPlatformGlobalVariableLib implementations

2015-11-26 Thread Ard Biesheuvel
This removes the SEC, PEI and DXE variants of ArmPlatformGlobalVariableLib, which is no longer used, and should not be used since it violates the PI spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/I

[edk2] [PATCH 11/23] ArmPlatformPkg/PrePi: remove global variable allocation from lowlevel init

2015-11-26 Thread Ard Biesheuvel
Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to allocate and clear out the global variable region in the PrePi init code. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

[edk2] [PATCH 04/23] ArmVirtPkg/ArmVirtQemu: move to ArmPkg version of PeiServicesTablePointerLib

2015-11-26 Thread Ard Biesheuvel
of this library, which does adhere to the PI spec. Reported-by: Eugene Cohen <eug...@hp.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirt.dsc.inc | 6 +++--- 1 file changed, 3 insertions(+),

[edk2] [PATCH 01/23] ArmPlatformPkg/PrePiHobListPointerLib: use thread ID register

2015-11-26 Thread Ard Biesheuvel
1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/ArmPlatformPkg.dec| 3 ++- ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c | 12 +++- ArmPlatformPkg/Library/PrePiHobListPoin

[edk2] [PATCH 08/23] ArmPlatformPkg: remove PeiServicesTablePointerLib implementation

2015-11-26 Thread Ard Biesheuvel
This removes the PeiServicesTablePointerLib implementation under ArmPlatformPkg that violates the PI spec, and hence should not be used. Instead, the implementation that resides under ArmPkg should be used. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 07/23] ArmPlatformPkg: drop ArmPlatformGlobalVariableLib resolutions

2015-11-26 Thread Ard Biesheuvel
We can remove all mention of ArmPlatformGlobalVariableLib now that there are no remaining [transitive] dependencies on it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/ArmJunoPkg/ArmJu

[edk2] [PATCH 12/23] ArmPlatformPkg/PlatformPeim: remove ArmGlobalVariable lowlevel init

2015-11-26 Thread Ard Biesheuvel
Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to query the ArmGlobalVariable PPI and install the ArmGlobalVariable HOB. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

[edk2] [PATCH 13/23] ArmPlatformPkg/PrePeiCore: remove global variable allocation from lowlevel init

2015-11-26 Thread Ard Biesheuvel
Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to allocate and clear out the global variable region in the PrePeiCore init code. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

[edk2] [PATCH 20/23] ArmPlatformPkg/EblCmdLib: drop bogus ArmGlobalVariableHob.h include

2015-11-26 Thread Ard Biesheuvel
EblCmdLib does not use anything that is declared by ArmGlobalVariableHob.h, so remove the include. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/Library/EblCmdLib/EblCmdFdt.c | 1 - 1 file changed, 1 de

[edk2] [PATCH 18/23] ArmPlatformPkg/ArmJunoDxe: drop bogus gArmGlobalVariableGuid dependency

2015-11-26 Thread Ard Biesheuvel
ArmJunoDxe does not use gArmGlobalVariableGuid so drop the declaration from the .inf. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 - 1 file chan

[edk2] [PATCH 06/23] ArmPlatformPkg: move to ArmPkg version of PeiServicesTablePointerLib

2015-11-26 Thread Ard Biesheuvel
of this library, which does adhere to the PI spec. Reported-by: Eugene Cohen <eug...@hp.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/ArmPlatformPkg.dsc | 4 ++-- ArmPlatformPkg/Ar

[edk2] [PATCH 15/23] EmbeddedPkg/AndroidFastboot: drop bogus gArmGlobalVariableGuid dependency

2015-11-26 Thread Ard Biesheuvel
This application lists gArmGlobalVariableGuid as a dependency, but does not actually need it. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf

[edk2] [PATCH 19/23] ArmPlatformPkg/ArmVExpressFastBootDxe: drop bogus gArmGlobalVariableGuid dep

2015-11-26 Thread Ard Biesheuvel
ArmVExpressFastBootDxe does not use gArmGlobalVariableGuid so drop the declaration from the .inf. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressFastBootDxe/ArmVExpressFastBootD

[edk2] [PATCH 16/23] ArmPkg/BdsLib: drop bogus gArmGlobalVariableGuid dependency

2015-11-26 Thread Ard Biesheuvel
The BdsLib implementation under ArmPkg never references gArmGlobalVariableGuid so it should not list it as a dependency. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/BdsLib/BdsLib.inf | 1 - 1 file chan

[edk2] [PATCH 02/23] ArmPkg: remove ArmPlatformGlobalVariableLib resolution from ArmPkg.dsc

2015-11-26 Thread Ard Biesheuvel
ArmPkg does not depend on ArmPlatformGlobalVariableLib, and this library is about to be removed, so remove all mention of it from ArmPkg.dsc. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/ArmPkg.dsc | 3 ---

[edk2] [PATCH 14/23] ArmPlatformPkg/Sec: remove global variable allocation from lowlevel init

2015-11-26 Thread Ard Biesheuvel
Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to allocate and clear out the global variable region in the PrePi init code. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

[edk2] [PATCH 22/23] ArmPlatformPkg: remove ArmGlobalVariable PCD, GUID and PPI definitions

2015-11-26 Thread Ard Biesheuvel
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/ArmPlatformPkg.dec | 20 --- ArmPlatformPkg/Include/Guid/ArmGlobalVariableHob.h | 51 -- ArmPlatformPkg/Include/Ppi/ArmGlobalVari

[edk2] [PATCH 05/23] ArmVirtPkg: drop ArmPlatformGlobalVariableLib dependency

2015-11-26 Thread Ard Biesheuvel
Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirt.dsc.inc | 4 ArmVirtPkg/ArmVirtQemu.dsc | 5 + ArmVirtPkg/ArmVirtXen.dsc | 1 - ArmVirtPkg/Library/ArmVirtPlatf

[edk2] [PATCH 21/23] ArmPlatformPkg/PlatformIntelBdsLib: drop bogus gArmGlobalVariableGuid dep

2015-11-26 Thread Ard Biesheuvel
PlatformIntelBdsLib does not use gArmGlobalVariableGuid so drop the declaration from the .inf. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 1 -

[edk2] [PATCH 17/23] ArmPlatformPkg/Bds: drop bogus ArmGlobalVariable dependencies

2015-11-26 Thread Ard Biesheuvel
Remove the GUID references to gArmGlobalVariableGuid and includes of ArmGlobalVariableHob.h since they are not used by the ARM BDS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/Bds/Bds.inf

[edk2] [PATCH 23/23] ArmPkg: remove SetPrimaryStack and InitializePrimaryStack macros

2015-11-26 Thread Ard Biesheuvel
The SetPrimaryStack and InitializePrimaryStack macros are no longer used now that we removed support for ArmPlatformGlobalVariableLib. So remove the various versions of them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

2015-11-26 Thread Ard Biesheuvel
On 20 November 2015 at 13:46, Mark Rutland <mark.rutl...@arm.com> wrote: > On Fri, Nov 20, 2015 at 01:39:26PM +0100, Ard Biesheuvel wrote: >> The PrePeiCore vector table for AArch64 mode is only half populated. >> However unlikely, if exceptions from lower exception lev

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

2015-11-26 Thread Ard Biesheuvel
On 26 November 2015 at 16:09, Mark Rutland <mark.rutl...@arm.com> wrote: > On Thu, Nov 26, 2015 at 04:06:40PM +0100, Ard Biesheuvel wrote: >> On 20 November 2015 at 13:46, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On Fri, Nov 20, 2015 at 01:39:26

Re: [edk2] [PATCH 04/23] ArmVirtPkg/ArmVirtQemu: move to ArmPkg version of PeiServicesTablePointerLib

2015-11-26 Thread Ard Biesheuvel
On 26 November 2015 at 17:45, Laszlo Ersek <ler...@redhat.com> wrote: > On 11/26/15 13:10, Ard Biesheuvel wrote: >> As pointed out by Eugene, the ArmPlatformPkg implementation of >> PeiServicesTablePointerLib violates the PI sec, since it uses >> ArmPlatformGlobalV

Re: [edk2] please DO NOT commit unreviewed patches to subversion!

2015-11-27 Thread Ard Biesheuvel
On 26 November 2015 at 23:23, Laszlo Ersek wrote: > I notice that recently there have been patches committed to the > subversion repository that had *never* been posted to the list, in the > ultimately committed form. Examples: > > (1) Patches on the list: > >

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

2015-11-27 Thread Ard Biesheuvel
On 26 November 2015 at 17:35, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Nov 26, 2015 at 04:20:00PM +0100, Ard Biesheuvel wrote: >> On 26 November 2015 at 16:09, Mark Rutland <mark.rutl...@arm.com> wrote: >> > On Thu, Nov 26, 2015 at 04:06:40

[edk2] [PATCH 3/3] ArmVirtPkg: add secure boot support to 32-bit ARM targets

2015-11-27 Thread Ard Biesheuvel
Building the 32-bit ARM targets with secure boot enabled requires a library resolution for the ArmSoftfloatLib dependency of OpenSslLib. So provide one. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmV

[edk2] [PATCH 2/3] CryptoPkg: add softfloat dependency for ARM

2015-11-27 Thread Ard Biesheuvel
UEFI on 32-bit ARM does not allow the use of hardware floating point, so in order to be able to run OpenSslLib, we need to fulfil its floating point arithmetic dependencies using a software library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

[edk2] [PATCH v3 2/7] ArmPkg/ArmV7Lib: add support for reading the ID_MMFR0 system register

2015-11-18 Thread Ard Biesheuvel
-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.h | 6 ++ ArmPkg/Library/ArmLib/ArmV7/ArmV7Support.S | 5 + ArmPkg/Library/ArmLib/ArmV7/ArmV7Support.asm | 5 + 3 files changed, 16 insertions(+) diff --git a/ArmPkg/Library/ArmLib

[edk2] [PATCH v3 6/7] ArmPkg/ArmV7Lib: fix definition of TTBR_NON_INNER_CACHEABLE

2015-11-18 Thread Ard Biesheuvel
The definition of TTBR_NON_INNER_CACHEABLE should be bit 0 cleared, not bit 0 set. Furthermore, the name is inconsistent with the other definitions so rename it to TTBR_INNER_NON_CACHEABLE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

[edk2] [PATCH v3 0/7] ArmPkg: ARMv7 MMU fixes

2015-11-18 Thread Ard Biesheuvel
#6 fixes the definition of TTBR_NON_INNER_CACHEABLE, whose name and value are inconsistent and incorrect, respectively Patch #7 changes the TTBR memory attributes on systems without the multiprocessing extensions. Ard Biesheuvel (7): ArmPkg/ArmV7Mmu: fix write-through translation table accesses

[edk2] [PATCH v3 4/7] ArmPkg/ArmV7Mmu: make cached translation table accesses shareable

2015-11-18 Thread Ard Biesheuvel
To align with the way normal cacheable memory is mapped, set the shareable bit for cached accesses performed by the page table walker. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Include/Chipset/ArmV7Mmu.h

[edk2] [PATCH v3 5/7] ArmPkg/ArmV7Mmu: introduce feature PCD to map normal memory non-shareable

2015-11-18 Thread Ard Biesheuvel
introduce a PCD PcdNormalMemoryNonshareableOverride that makes cacheable mappings of normal memory non-shareable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>

[edk2] [PATCH v3 1/7] ArmPkg/ArmV7Mmu: fix write-through translation table accesses

2015-11-18 Thread Ard Biesheuvel
it to TTBR_WRITE_THROUGH and update the definition to reflect the name. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> --- ArmPkg/Include/Chipset/ArmV7Mmu.h | 2 +- ArmPkg/Li

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

2015-11-18 Thread Ard Biesheuvel
On 16 November 2015 at 16:03, Michael Zimmermann wrote: > Unfortunately I can't tell you much about how the L2 works or if it's > configurable because it's a proprietary hw(I'm a opensource dev working with > Qualcomm Android devices). > > Also, I'm using ARM PrePi so

Re: [edk2] [PATCH v3 0/4] improve handling of device attributes on ARM/AARCH64

2015-11-18 Thread Ard Biesheuvel
On 18 November 2015 at 12:47, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Wed, Nov 18, 2015 at 11:29:15AM +, Leif Lindholm wrote: >> On Wed, Nov 18, 2015 at 09:25:55AM +0100, Ard Biesheuvel wrote: >> > This series fixes some issues that exist in the

[edk2] [PATCH v3 7/7] ArmPkg/ArmV7Lib: take MP extensions into account when programming TTBR

2015-11-18 Thread Ard Biesheuvel
Bits 0 and 6 of the TTBRx system registers have different meanings depending on whether a system implements the Multiprocessing Extensions. So use separate memory attribute definitions for MP and non-MP. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v3 3/7] ArmPkg/ArmV7Lib: add function to test for presence of MP extensions

2015-11-18 Thread Ard Biesheuvel
Some MMU manipulation is dependent on the presence of the multiprocessing extensions. So add a function that returns this information. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/ArmV7/ArmLibSup

Re: [edk2] [PATCH 0/3] AppPkg/Python-2.7.10/edk2module.c: Reviewable Revision Resubmission

2015-11-18 Thread Ard Biesheuvel
On 12 November 2015 at 23:52, Daryl McDaniel wrote: > AppPkg/Python-2.7.10: Present patch in three reviewable chunks. > > Due to the large number of changes, the previous submission of this patch > was not reviewable. This patch set presents the changes as three

[edk2] [PATCH v3 4/4] ArmPkg/Mmu: set required XN attributes for device mappings

2015-11-18 Thread Ard Biesheuvel
ving all accesses to a client domain since permission attributes like XN are ignored from a manager domain. The use of a client domain is actually mandated explicitly by the UEFI spec. Reported-by: Heyi Guo <heyi@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-o

[edk2] [PATCH v3 3/4] ArmVExpressPkg/ArmVExpressLibRTSM: map NOR flash as cached

2015-11-18 Thread Ard Biesheuvel
DXE driver is perfectly capable of setting the correct attributes for the region it needs to write to, and since we will be executing from DRAM by that time anyway, we can simply map the NOR flash as normal memory initially. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard

[edk2] [PATCH v3 2/4] ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region as device

2015-11-18 Thread Ard Biesheuvel
of the FD image, wherever it resides. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/Library/ArmVirtPlatformLib/VirtMem.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg/L

[edk2] [PATCH v3 1/4] ArmPkg/AArch64Mmu: remove unused GcdAttributeToArmAttribute()

2015-11-18 Thread Ard Biesheuvel
Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Include/Chipset/AArch64.h | 5 --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 42 2 files changed, 47 deletions(-) diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/I

[edk2] [PATCH v3 0/4] improve handling of device attributes on ARM/AARCH64

2015-11-18 Thread Ard Biesheuvel
and RTSM-A15_MPCore. (new in v2) Patch #4 makes the changes to ensure that all device mappings have the XN bit set. The v2 version now covers ARM as well. Ard Biesheuvel (4): ArmPkg/AArch64Mmu: remove unused GcdAttributeToArmAttribute() ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region

Re: [edk2] [PATCH v3 2/4] ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region as device

2015-11-18 Thread Ard Biesheuvel
On 18 November 2015 at 10:02, Laszlo Ersek <ler...@redhat.com> wrote: > On 11/18/15 09:25, Ard Biesheuvel wrote: >> The ARM architecture version 7 and later mandates that device mappings >> have the XN (non-executable) bit set, to prevent speculative instruction >>

Re: [edk2] [PATCH v3 2/4] ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region as device

2015-11-18 Thread Ard Biesheuvel
On 19 November 2015 at 00:55, Heyi Guo <heyi@linaro.org> wrote: > > > On 11/18/2015 04:25 PM, Ard Biesheuvel wrote: >> >> The ARM architecture version 7 and later mandates that device mappings >> have the XN (non-executable) bit set, to prevent speculative

Re: [edk2] Armv8 64bit: System error booting linux from the UEFI

2015-11-18 Thread Ard Biesheuvel
On 19 November 2015 at 05:48, Vladimir Olovyannikov <volov...@broadcom.com> wrote: > > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Tuesday, November 17, 2015 11:03 PM >> To: Mark Rutland >> Cc: Vlad

[edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

2015-11-20 Thread Ard Biesheuvel
r18904 ("ArmPkg/ArmPlatformPkg: position vectors relative to base"). So add the missing entries, and wire them up to the default handler. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/PrePeiCore/AAr

Re: [edk2] [PATCH] ArmPkg: Flush cache after allocating UC memory

2015-11-20 Thread Ard Biesheuvel
n data making it to main memory only due to a subsequent clean performed by the next owner of the memory range, I'd much rather make it explicit. And clean + invalidate is obviously more costly. Leif? > On 11/20/2015 02:25 PM, Ard Biesheuvel wrote: >> >> On 20 November 2015

Re: [edk2] [PATCH] ArmPkg: ArmLib: purge incorrect ArmDrainWriteBuffer () alias

2015-11-20 Thread Ard Biesheuvel
ment 1.0 > Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPkg/Include/Library/ArmLib.h| 6 -- > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 8 > ArmPkg/Library/Arm

Re: [edk2] [PATCH V2 08/12] BeagleBoardPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2015-11-19 Thread Ard Biesheuvel
m <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng <star.z...@intel.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > BeagleBoard

Re: [edk2] [PATCH V2 12/12] EmbeddedPkg: Remove SerialDxe and SerialPortExtLib libraries

2015-11-19 Thread Ard Biesheuvel
On 17 November 2015 at 12:07, Star Zeng <star.z...@intel.com> wrote: > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming@intel.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@lin

Re: [edk2] [PATCH] ArmPkg: Flush cache after allocating UC memory

2015-11-19 Thread Ard Biesheuvel
uted-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo <heyi@linaro.org> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > .../Library/UncachedMemoryAllocationLib/UncachedMemoryAllocati

<    2   3   4   5   6   7   8   9   10   11   >