[edk2] [PATCH v4 2/2] ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher

2016-02-23 Thread Ard Biesheuvel
v1.0b), but this may change in the future, so let's choose a meaningful value right away. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/ArmVirtQemu.dsc | 4

[edk2] [PATCH v4 0/2] lift AARCH64 4GB allocation restriction

2016-02-23 Thread Ard Biesheuvel
on arm64 anyway. - drop BdsDxe patch for now, more discussion is needed - implement review feedback from Star Ard Biesheuvel (2): MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher ArmVirtPkg/ArmVirtQemu.dsc

Re: [edk2] [PATCH v3 1/4] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-23 Thread Ard Biesheuvel
On 23 February 2016 at 04:03, Zeng, Star <star.z...@intel.com> wrote: > Ard, > > On 2016/2/19 21:15, Ard Biesheuvel wrote: >> >> AARCH64 systems never require compatibility with legacy ACPI OSes, and >> may not have any 32-bit addressable system RAM. To support

Re: [edk2] [PATCH] MdePkg: Fix AArch64 DAIF interrupt mask definitions

2016-02-23 Thread Ard Biesheuvel
On 23 February 2016 at 08:21, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > (+ Liming) > > On 22 February 2016 at 22:59, Cohen, Eugene <eug...@hp.com> wrote: >> The AArch64 DAIF bits are different for reading (mrs) versus writing (msr). >> The bitmask defin

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Ard Biesheuvel
On 22 February 2016 at 13:40, Yao, Jiewen wrote: > I did a search on current MdeModulePkg. I found there are more modules > allocating Below4G memory. > > Besides BDS, we have BootGraphicsResourceTableDxe, BootScriptExecutorDxe, > FirmwarePerformanceDataTableDxe,

[edk2] [PATCH] MdeModulePkg: DxeCore: fully initialize image context before passing it on

2016-02-29 Thread Ard Biesheuvel
Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c index 0a3471

[edk2] [PATCH] ArmVirtPkg: ArmVirtQemu: make ACPI support AARCH64 only

2016-02-22 Thread Ard Biesheuvel
No ARM support for ACPI is planned under any OS we intend to run under ArmVirtQemu-ARM, so remove the drivers from the ARM build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirtQemu.ds

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Ard Biesheuvel
On 22 February 2016 at 13:42, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 22 February 2016 at 13:40, Yao, Jiewen <jiewen@intel.com> wrote: >> I did a search on current MdeModulePkg. I found there are more modules >> allocating Below4G memory.

Re: [edk2] [PATCH 0/4] Rework the pl061 driver for better readability

2016-02-26 Thread Ard Biesheuvel
in preparation for the > improvements. > For the series: Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > Changes since RFC: > - Rework the initialization code based on feedback from Ard. > - Bugfix reported by Ard and tested by Haojian. > - Moved the Linaro Copyright introd

Re: [edk2] [PATCH v4 1/2] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-25 Thread Ard Biesheuvel
On 25 February 2016 at 17:07, David Woodhouse <dw...@infradead.org> wrote: > On Tue, 2016-02-23 at 18:35 +0100, Ard Biesheuvel wrote: >> AARCH64 systems never require compatibility with legacy ACPI OSes, and >> may not have any 32-bit addressable system RAM. To support ACPI on

[edk2] [PATCH] MdeModulePkg: AcpiTableDxe: fix VS2008 build by merging adjacent if blocks

2016-02-25 Thread Ard Biesheuvel
move it and merge the two conditional blocks together. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 22 +--- 1 file changed, 10 insertions(

Re: [edk2] [PATCH] ArmPkg: Fix AArch64 interrupt read masks

2016-02-22 Thread Ard Biesheuvel
we tested that code (rhetorical question) Anyway, thanks for fixing this. Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> @Leif: mind if I fold in the follow change when applying? diff --git a/ArmPkg/Library/ArmLib/Common/AArch64/ArmLibSupport.S b/ArmPkg/Library/ArmLib/Common/

Re: [edk2] [PATCH] ArmPkg: LinuxLoader: fix typo in help string

2016-01-20 Thread Ard Biesheuvel
insertions(+), 2 deletions(-) > I'm impressed that we *have* a help string :-) Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Committed as SVN r19698 Thanks! > diff --git a/ArmPkg/Application/LinuxLoader/LinuxLoader.uni > b/ArmPkg/Application/LinuxLoader/Linux

Re: [edk2] [PATCH 0/3] MdeModulePkg: fix cursor movement keys on ARM FVP / Juno

2016-01-19 Thread Ard Biesheuvel
r. It works correctly on FVP Foundation model Tested-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> -- Ard. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] BaseTools/GenFw AARCH64: add support for relative data relocations

2016-02-15 Thread Ard Biesheuvel
On 15 February 2016 at 10:27, Gao, Liming <liming@intel.com> wrote: > Reviewed-by: Liming Gao <liming@intel.com> > Thanks. Pushed to master. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, February 12, 20

Re: [edk2] [PATCH] ArmPkg: DefaultExceptionHandler fixes for use with DxeCore

2016-02-15 Thread Ard Biesheuvel
On 12 February 2016 at 11:19, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 11 February 2016 at 00:05, Cohen, Eugene <eug...@hp.com> wrote: >> Modify the DefaultExceptionHandler (uefi-variant) so it can be used by >> DxeCore (via CpuExceptionHandlerLib)

Re: [edk2] [PATCH] ArmPlatformPkg: delete Juno ACPI tables

2016-02-16 Thread Ard Biesheuvel
Lindholm <leif.lindh...@linaro.org> Acked-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > .../ArmJunoPkg/AcpiTables/AcpiSsdtRootPci.asl | 190 > .../ArmJunoPkg/AcpiTables/AcpiTables.inf | 52 -- > ArmPlatform

Re: [edk2] [Patch 3/3] BaseTools/GenFw: Correct datatypes in diagnostic messages and check for string termination

2016-02-17 Thread Ard Biesheuvel
On 1 February 2016 at 03:10, Liming Gao wrote: > From: Michael LeMay > > This patch revises multiple diagnostic messages to use correct > datatypes. It also checks that a symbol name that is about to be used > in a diagnostic message is terminated

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-02-17 Thread Ard Biesheuvel
@lists.01.org] On Behalf Of Yao, > Jiewen > Sent: Tuesday, February 16, 2016 8:51 AM > To: Laszlo Ersek; Ard Biesheuvel > Cc: edk2-de...@ml01.01.org; Gao, Liming > Subject: Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support. > > Thanks. I think it is easy to j

Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Ard Biesheuvel
y: "Yao, Jiewen" <jiewen@intel.com> > Cc: "Gao, Liming" <liming@intel.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > MdeModulePkg/MdeModulePkg.dec | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > di

[edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Ard Biesheuvel
to the memory allocation calls in AcpiTableDxe/AcpiTableProtocol.c Note that this will inhibit the publishing of any tables that carry only 32-bit addresses, i.e., RSDPv1, RSDTv1 and RSDTv3. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Ard Biesheuvel
On 17 February 2016 at 16:11, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/17/16 15:48, Ard Biesheuvel wrote: >> AARCH64 systems never require compatibility with legacy ACPI OSes, and >> may not have any 32-bit addressable system RAM. To support ACPI on these >>

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Ard Biesheuvel
On 17 February 2016 at 18:07, Graeme Gregory <graeme.greg...@linaro.org> wrote: > > > On 17/02/2016 16:04, Laszlo Ersek wrote: >> >> On 02/17/16 16:34, Ard Biesheuvel wrote: >>> >>> On 17 February 2016 at 16:11, Laszlo Ersek <ler...@redhat.com>

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Ard Biesheuvel
On 17 February 2016 at 18:40, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/17/16 18:23, Ard Biesheuvel wrote: >> On 17 February 2016 at 18:07, Graeme Gregory <graeme.greg...@linaro.org> >> wrote: >>> >>> >>> On 17/02/2016 16:04, Laszlo Er

[edk2] [PATCH] ArmVirtQemu: expose SMBIOS 3.0 entry point only

2016-02-18 Thread Ard Biesheuvel
memory below 4 GB. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- Note to Laszlo: For some background, this is not just about saving a couple of KB of memory, it is about a) saving memory below 4 GB for 32-b

[edk2] [PATCH v2] ArmVirtPkg: ArmVirtQemu: expose only 64-bit entry point for v3.0+ SMBIOS

2016-02-18 Thread Ard Biesheuvel
3.0 or later. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- v2: - reworked commit log and PCD comment per Laszlo's feedback, primarily to clarify that the PCD only takes effect if the actual version of the

[edk2] [PATCH] ArmVirtPkg: ArmVirtQemu: disable PropertiesTable memory protection feature

2016-02-18 Thread Ard Biesheuvel
Linux, and enabling it here is pointless. So set PcdPropertiesTableEnable to FALSE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirtQemu.dsc | 12 1 file changed, 12 insertions(+) diff

Re: [edk2] [PATCH] ArmVirtPkg: ArmVirtQemu: disable PropertiesTable memory protection feature

2016-02-18 Thread Ard Biesheuvel
On 18 February 2016 at 13:17, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/18/16 12:56, Ard Biesheuvel wrote: >> The PropertiesTable feature is poorly named, since the feature this PCD >> controls is only a single bit in its MemoryProtectionAttrib

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-18 Thread Ard Biesheuvel
is an architecture, not a platform. Every AARCH64 platform has complete freedom as to where peripherals live and where system RAM lives, and some platforms have their RAM starting at 0x80__0000 So every such region could be anywhere in the address space. > -Original Message- >

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-18 Thread Ard Biesheuvel
moment, and we can always expand it later if we need to. > > -Original Message- > From: Yao, Jiewen > Sent: Thursday, February 18, 2016 11:05 PM > To: Ard Biesheuvel > Cc: Tian, Feng; Graeme Gregory; edk2-devel@lists.01.org; Leif Lindholm; Gao, > Liming; Laszlo Ersek

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-18 Thread Ard Biesheuvel
gt; OK, that makes sense. But I will only implement the difference between 'all supported' and 'all except 1.0B supported' > -Original Message----- > From: Yao, Jiewen > Sent: Thursday, February 18, 2016 11:27 PM > To: Ard Biesheuvel > Cc: Tian, Feng; Graeme Gregory; edk2-devel@li

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-02-18 Thread Ard Biesheuvel
tiesTable support code > in DxeCore. (PropertiesTable support is removed.) > > Personally, I do not suggest we choose 3), because this table is still > defined in UEFI specification. We can remove it after UEFI spec removes it > later. > I do not have strong opinion for o

[edk2] [PATCH v2 3/3] ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher

2016-02-18 Thread Ard Biesheuvel
v1.0b), but this may change in the future, so let's choose a meaningful value right away. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ArmV

[edk2] [PATCH v2 2/3] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB on ACPI 1.0

2016-02-18 Thread Ard Biesheuvel
Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf | 1 + IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff

[edk2] [PATCH v2 1/3] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-18 Thread Ard Biesheuvel
are emitted. Note that this will inhibit the publishing of any tables that carry only 32-bit addresses, i.e., RSDPv1, RSDTv1 and RSDTv3. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdeModulePkg/MdeModuleP

[edk2] [PATCH v2 0/3] lift AARCH64 ACPI 4GB allocation restriction

2016-02-18 Thread Ard Biesheuvel
data memory as well. Finally, set the PCD for ArmVirtQemu. Ard Biesheuvel (3): MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB on ACPI 1.0 ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher ArmVirtPkg

Re: [edk2] [PATCH v2 3/3] ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher

2016-02-18 Thread Ard Biesheuvel
On 18 February 2016 at 21:14, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/18/16 21:03, Ard Biesheuvel wrote: >> The ACPI spec predates the AARCH64 architecture by 5 versions, so there >> is no point in supporting anything below v5.0. So set the PCD that >> control

Re: [edk2] [PATCH v2 3/3] ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher

2016-02-18 Thread Ard Biesheuvel
On 18 February 2016 at 21:16, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 18 February 2016 at 21:14, Laszlo Ersek <ler...@redhat.com> wrote: >> On 02/18/16 21:03, Ard Biesheuvel wrote: >>> The ACPI spec predates the AARCH64 architecture by 5 vers

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-02-18 Thread Ard Biesheuvel
f6a [Runtime Code |RUN| | | | |RO] > 0x00013f6b-0x00013f6d [Runtime Code |RUN| |XP| | | ] > > 0x00013f6f-0x00013f80 [Runtime Data |RUN| |XP| | | ] > > > > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]

Re: [edk2] [patch] MdeModulePkg: Fix Memory Attributes table type issue

2016-02-19 Thread Ard Biesheuvel
a, but > it should be RTCode. > > This patch fixed the issue. It is validated with or > without PropertiesTable. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" <jiewen@intel.com> > Cc: "Ard Biesheuvel" &

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB on ACPI 1.0

2016-02-19 Thread Ard Biesheuvel
it DXE core on a 64-bit capable machine. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, February 19, 2016 4:03 AM > To: edk2-devel@lists.01.org; Tian, Feng; Zeng, Star; > leif.lindh...@linaro.org; graeme.greg...@linaro.org; ler...@redhat.com

[edk2] [PATCH] OvmfPkg: implement UEFI driver for Virtio RNG devices

2016-02-19 Thread Ard Biesheuvel
This implements a UEFI driver model driver for Virtio devices of type VIRTIO_SUBSYSTEM_ENTROPY_SOURCE, and exposes them via instances of the EFI_RNG_PROTOCOL protocol, supporting the EFI_RNG_ALGORITHM_RAW algorithm only. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard

Re: [edk2] [PATCH] OvmfPkg: implement UEFI driver for Virtio RNG devices

2016-02-19 Thread Ard Biesheuvel
On 19 February 2016 at 11:54, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > This implements a UEFI driver model driver for Virtio devices of type > VIRTIO_SUBSYSTEM_ENTROPY_SOURCE, and exposes them via instances of > the EFI_RNG_PROTOCOL protocol, supporting the EFI_RN

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB on ACPI 1.0

2016-02-19 Thread Ard Biesheuvel
On 19 February 2016 at 10:56, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/19/16 09:53, Ard Biesheuvel wrote: >> On 19 February 2016 at 09:45, Yao, Jiewen <jiewen@intel.com> wrote: >>> I can explain the reason on allocating <4G. It is because this data wil

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB on ACPI 1.0

2016-02-19 Thread Ard Biesheuvel
On 19 February 2016 at 13:14, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/19/16 12:52, Ard Biesheuvel wrote: >> On 19 February 2016 at 10:56, Laszlo Ersek <ler...@redhat.com> wrote: >>> On 02/19/16 09:53, Ard Biesheuvel wrote: >>>> On 19 F

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB on ACPI 1.0

2016-02-19 Thread Ard Biesheuvel
On 19 February 2016 at 13:33, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/19/16 13:18, Ard Biesheuvel wrote: >> On 19 February 2016 at 13:14, Laszlo Ersek <ler...@redhat.com> wrote: >>> On 02/19/16 12:52, Ard Biesheuvel wrote: >>>> On 19 February 2016

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB on ACPI 1.0

2016-02-19 Thread Ard Biesheuvel
On 19 February 2016 at 13:48, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/19/16 13:40, Ard Biesheuvel wrote: >> On 19 February 2016 at 13:33, Laszlo Ersek <ler...@redhat.com> wrote: > >>> I think customizing this code for MDE_CPU_AARCH64, on the source code >

[edk2] [PATCH v3 0/4] lift AARCH64 4GB allocation restriction

2016-02-19 Thread Ard Biesheuvel
) Changes since v2: - folded suggestion and added R-b from Jiewen (#1) - update patch #2 to use a dedicated PCD rather than reusing the ACPI table version on - move setting of first PCD to AARCH64 specific section - added patch to set the second PCD for ArmVirt.dsc.inc Ard Biesheuvel (4

[edk2] [PATCH v3 1/4] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-19 Thread Ard Biesheuvel
that this will inhibit the publishing of any tables that carry only 32-bit addresses, i.e., RSDPv1, RSDTv1 and RSDTv3. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: "Yao, Jiewen" <jiewen@intel.com

[edk2] [PATCH v3 3/4] ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher

2016-02-19 Thread Ard Biesheuvel
v1.0b), but this may change in the future, so let's choose a meaningful value right away. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirtQemu.dsc | 4 1 file changed, 4 insertions(+) diff

[edk2] [PATCH v3 4/4] ArmVirtPkg/ArmVirt.dsc.inc: lift 4 GB limit for PEI accessible memory

2016-02-19 Thread Ard Biesheuvel
exists below the 4 GB mark. So set gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdPeiAllocMemLimit4GB to FALSE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirt.dsc.inc | 2 ++ 1 file changed, 2 inse

[edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-19 Thread Ard Biesheuvel
memory to be served from anywhere. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 6 ++ IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.in

Re: [edk2] [PATCH] OvmfPkg: implement UEFI driver for Virtio RNG devices

2016-02-19 Thread Ard Biesheuvel
On 19 February 2016 at 14:49, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/19/16 11:54, Ard Biesheuvel wrote: >> This implements a UEFI driver model driver for Virtio devices of type >> VIRTIO_SUBSYSTEM_ENTROPY_SOURCE, and exposes them via instances of >> th

Re: [edk2] [PATCH] OvmfPkg: implement UEFI driver for Virtio RNG devices

2016-02-19 Thread Ard Biesheuvel
On 19 February 2016 at 16:00, Laszlo Ersek <ler...@redhat.com> wrote: > On 02/19/16 11:54, Ard Biesheuvel wrote: >> This implements a UEFI driver model driver for Virtio devices of type >> VIRTIO_SUBSYSTEM_ENTROPY_SOURCE, and exposes them via instances of >> th

Re: [edk2] [patch] MdeModulePkg: Fix Memory Attributes table type issue

2016-02-19 Thread Ard Biesheuvel
0x > NumberOfPages - 0x0010 > Attribute - 0x0002 > Entry (0xA61E368) > Type - 0x5 > PhysicalStart - 0x00013F6B > VirtualStart - 0x > NumberOfPages - 0x00

[edk2] [PATCH v2 0/2] UEFI driver model driver for VirtIO-RNG

2016-02-19 Thread Ard Biesheuvel
=/tmp/unrandom,id=rng0 \ -device virtio-rng-pci,rng=rng0,max-bytes=19,period=1000 \ on the QEMU command line Ard Biesheuvel (1): OvmfPkg: implement UEFI driver for Virtio RNG devices Laszlo Ersek (1): OvmfPkg: VirtioFlush(): return the number of bytes written by the host OvmfPkg

[edk2] [PATCH v2 2/2] OvmfPkg: implement UEFI driver for Virtio RNG devices

2016-02-19 Thread Ard Biesheuvel
k <ler...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- OvmfPkg/VirtioRngDxe/VirtioRng.c | 607 OvmfPkg/VirtioRngDxe/VirtioRng.h | 32 ++ OvmfPkg/VirtioRngDxe/VirtioRngDxe.inf

[edk2] [PATCH v2 1/2] OvmfPkg: VirtioFlush(): return the number of bytes written by the host

2016-02-19 Thread Ard Biesheuvel
only to set up its rings). However, the virtio entropy device, to be covered in the upcoming patches, reports the amount of randomness produced by the host only through this quantity. Cc: Jordan Justen <jordan.l.jus...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Sign

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-02-14 Thread Ard Biesheuvel
be published. The reason that the definition remains in the text is for the OS side, not for the reference implementation of the firmware side, which should steer clear from it entirely. -- Ard. >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>

[edk2] [PATCH v3 2/3] OvmfPkg: implement UEFI driver for Virtio RNG devices

2016-02-22 Thread Ard Biesheuvel
k <ler...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- Note that, instead of returning EFI_DEVICE_ERROR when more than MAX_UINT32 bytes of entropy are requested, I simply use the existing loop to

[edk2] [PATCH v3 1/3] OvmfPkg: VirtioFlush(): return the number of bytes written by the host

2016-02-22 Thread Ard Biesheuvel
only to set up its rings). However, the virtio entropy device, to be covered in the upcoming patches, reports the amount of randomness produced by the host only through this quantity. Cc: Jordan Justen <jordan.l.jus...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Sign

[edk2] [PATCH v3 3/3] ArmVirtPkg: ArmVirtQemu: add driver for Virtio-RNG device

2016-02-22 Thread Ard Biesheuvel
This adds the new Virtio-RNG DXE module to the default build of ArmVirtQemu. Note that QEMU needs to be invoked with the 'device virtio-rng-pci' option in order for this device to be exposed to the guest. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v3 0/3] UEFI driver model driver for VirtIO-RNG

2016-02-22 Thread Ard Biesheuvel
; done | \ xxd -r -p | dd iflag=fullblock count=2 bs=1M of=/tmp/unrandom and pass -object rng-random,filename=/tmp/unrandom,id=rng0 \ -device virtio-rng-pci,rng=rng0,max-bytes=19,period=1000 \ on the QEMU command line Ard Biesheuvel (2): OvmfPkg: implement UEFI driver

Re: [edk2] [patch V2] MdeModulePkg: Fix Memory Attributes table type issue

2016-02-22 Thread Ard Biesheuvel
a, but > it should be RTCode. > > This patch fixed the issue. It is validated with or > without PropertiesTable. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" <jiewen@intel.com> > Cc: "Ard Biesheuvel" &

Re: [edk2] [PATCH] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

2016-03-01 Thread Ard Biesheuvel
On 1 March 2016 at 20:36, Cohen, Eugene wrote: > Ard, > > The incorrect DataOffset appears to stem from the "PROCESSING_REQUIRED = > FALSE" statement. Remove this and both the rebase and SEC/PEI core discovery > should work. > > Perhaps someone with more background on why this

Re: [edk2] PL180MciDxe problem with TC2

2016-03-01 Thread Ard Biesheuvel
On 1 March 2016 at 08:50, Ryan Harkin <ryan.har...@linaro.org> wrote: > Thanks for jumping in! > > On 29 February 2016 at 20:59, Ard Biesheuvel <ard.biesheu...@linaro.org> > wrote: >> On 29 February 2016 at 21:05, Laszlo Ersek <ler...@redhat.com> wrote: >

Re: [edk2] [PATCH] MdeModulePkg: DxeCore: fully initialize image context before passing it on

2016-03-01 Thread Ard Biesheuvel
On 1 March 2016 at 03:05, Zeng, Star <star.z...@intel.com> wrote: > On 2016/3/1 0:16, Ard Biesheuvel wrote: >> >> When the DXE core is loaded, it invokes the PeCoffExtraActionLib library >> function 'PeCoffLoaderRelocateImageExtraAction' explicitly, which may be >>

Re: [edk2] [PATCH 0/6] more cleanups for DebugLib.h, then sync DSCs with it

2016-03-01 Thread Ard Biesheuvel
On 1 March 2016 at 10:58, Laszlo Ersek <ler...@redhat.com> wrote: > Public branch: > <https://github.com/lersek/edk2/commits/debugh_comment_fix>. > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Lei

Re: [edk2] PL180MciDxe problem with TC2

2016-03-01 Thread Ard Biesheuvel
On 1 March 2016 at 10:36, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Mar 01, 2016 at 09:39:18AM +0100, Ard Biesheuvel wrote: >> >> As far as the Primecell ID is concerned, let's just whitelist whatever >> >> TC2 exposes, even if in error. &g

Re: [edk2] [PATCH v2] ShellPkg: Per UEFI Shell 2.2 SPEC to make Shell supports 'NoNesting'.

2016-03-16 Thread Ard Biesheuvel
On 15 March 2016 at 14:17, Qiu Shumin wrote: > This patch makes Shell support -nonesting invocation option. This option > specifies that EFI_SHELL_PROTOCOL.Execute API nesting of a new Shell > instance is optional and dependent on the 'nonesting' Shell environment >

Re: [edk2] Tftp boot on UEFI

2016-03-14 Thread Ard Biesheuvel
nvolved in UEFI on ARM in the first place) is not the way to get help. I am sure there are knowledgeable people in your own company that can help you with basic questions like this one. -- Ard. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sen

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

2016-03-08 Thread Ard Biesheuvel
On 9 March 2016 at 07:53, David Woodhouse <dw...@infradead.org> wrote: > On Wed, 2016-03-09 at 07:49 +0700, Ard Biesheuvel wrote: >> >> I agree that they should be allowed, but i share the concern that >> merging puts the burden of fixing up conflicts on th

Re: [edk2] [PATCH] ArmVirtPkg/VirtFdtDxe: set /chosen/linux, pci-probe-only to 1 in DTB

2016-03-11 Thread Ard Biesheuvel
On 11 March 2016 at 18:47, Laszlo Ersek <ler...@redhat.com> wrote: > On 03/11/16 03:53, Ard Biesheuvel wrote: >> Unlike Linux on x86, which typically honors the PCI configuration performed >> by the firmware, Linux on ARM assumes that the PCI subsystem needs to be >&

Re: [edk2] [PATCH v2] ArmVirtPkg/VirtFdtDxe: set /chosen/linux, pci-probe-only to 1 in DTB

2016-03-11 Thread Ard Biesheuvel
On 11 March 2016 at 19:25, Laszlo Ersek <ler...@redhat.com> wrote: > On 03/11/16 13:19, Ard Biesheuvel wrote: >> Unlike Linux on x86, which typically honors the PCI configuration performed >> by the firmware, Linux on ARM assumes that the PCI subsystem needs to be >&

[edk2] [PATCH v2] ArmVirtPkg/VirtFdtDxe: set /chosen/linux, pci-probe-only to 1 in DTB

2016-03-11 Thread Ard Biesheuvel
resource allocations for the framebuffer are not overridden, since that would cause the framebuffer to stop working. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 27 +

Re: [edk2] Tftp boot on UEFI

2016-03-12 Thread Ard Biesheuvel
On 12 March 2016 at 17:23, Shaveta Leekha wrote: > Hi, > > I was trying "kernel boot" using Tftp on UEFI. > > For this I had created an "Add Boot Device Entry" using "Boot Manager" which > is like: > > [2] Tftp boot > - >

[edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: move to ARM version of CpuExceptionHandlerLib

2016-03-19 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirt.dsc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index 5938cb4ebfcb..db31b2dc4cfe 100644 --- a/ArmVirtPkg/ArmVirt.dsc.inc +++ b/ArmV

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

2016-03-19 Thread Ard Biesheuvel
On 18 March 2016 at 17:22, Laszlo Ersek wrote: > On 03/18/16 15:48, Gao, Liming wrote: >> Laszlo: >> >> I understand the request to BaseTools is that AutoGen code can pass >> GCC or MSFT compiler without any warning. If so, EDKII module can enable >> non default warnings in

[edk2] [PATCH 5/7] ArmPkg/ArmExceptionLib: make build time define visible to the compiler

2016-03-19 Thread Ard Biesheuvel
is set) static as well, so that the compiler can eliminate it completely if we are using the vector table in place. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c | 6 --

Re: [edk2] [PATCH v2] ShellPkg: Per UEFI Shell 2.2 SPEC to make Shell supports 'NoNesting'.

2016-03-19 Thread Ard Biesheuvel
On 16 March 2016 at 14:30, Laszlo Ersek <ler...@redhat.com> wrote: > On 03/16/16 10:06, Ard Biesheuvel wrote: >> On 15 March 2016 at 14:17, Qiu Shumin <shumin@intel.com> wrote: >>> This patch makes Shell support -nonesting invocation opt

Re: [edk2] [PATCH v2 3/3] ArmPkg: Update CpuDxe to use CpuExceptionHandlerLib

2016-03-16 Thread Ard Biesheuvel
On 7 March 2016 at 16:16, Cohen, Eugene wrote: > Use the new ARM/AArch64 implementation of the base > CpuExceptionHandlerLib library from CpuDxe to centralize > exception handling. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eugene Cohen

[edk2] [PATCH 1/2] BeagleBoardPkg: move to ARM version of CpuExceptionHandlerLib

2016-03-18 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc index 37e285af1b25..17f9f8e7d5ad 100644 --- a/BeagleBo

[edk2] [PATCH] ArmVirtPkg/VirtFdtDxe: set /chosen/linux, pci-probe-only to 1 in DTB

2016-03-10 Thread Ard Biesheuvel
resource allocations for the framebuffer are not overridden, since that would cause the framebuffer to stop working. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 23 +

Re: [edk2] [PATCH] MdeModulePkg: consistent AllocatePages() support for tables above 4 GB's

2016-03-29 Thread Ard Biesheuvel
(+ Al, Graeme) On 29 March 2016 at 19:06, Duran, Leo <leo.du...@amd.com> wrote: >> -Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Tuesday, March 29, 2016 11:14 AM >> To: Duran, Leo; Charles Garcia-Tobin; Achin Gu

Re: [edk2] [PATCH] MdeModulePkg: consistent AllocatePages() support for tables above 4 GB's

2016-03-29 Thread Ard Biesheuvel
On 29 March 2016 at 18:06, Leo Duran wrote: > Signed-off-by: Leo Duran Hi Leo, This particular instance was also discussed in the context of the patch that introduces the AcpiExposedTableVersions PCD. The problem with this particular allocation is that it

[edk2] [PATCH] ArmPlatformPkg/DS-5: fix 64-bit PE/COFF header parsing bug

2016-03-31 Thread Ard Biesheuvel
converted to TE format. So replace the fixed offset with a dereference of the appropriate header field. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reported-by: Vladimir Olovyannikov <vladimir.olovyanni...@bro

Re: [edk2] [EDK2]an issue that PXE boot failed when received a NACK from the DHCP server

2016-03-31 Thread Ard Biesheuvel
On 31 March 2016 at 08:40, Liuxilong (A) wrote: > Hi Folks: > > Recently, we used our board to do some tests about PXE booting and > encountered an issue . Sometimes the PXE booting would fail when the PXE > client sent a request to confirm IP but received the NACK from

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
On 31 March 2016 at 10:48, Yao, Jiewen wrote: > Hi Ard > I think you replied mail say this patch works fine at Wednesday, February 24, > 2016 4:15 PM. > > May I know if this is new issue or old issue? > This is a new issue. > > Also, in order to narrow down issue, would

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
t; Sent: Thursday, March 31, 2016 4:51 PM >> To: Yao, Jiewen <jiewen@intel.com>; Ard Biesheuvel >> <ard.biesheu...@linaro.org> >> Cc: edk2-devel@lists.01.org <edk2-de...@ml01.01.org>; Gao, Liming >> <liming@intel.com> >> Subject: RE: [edk2]

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
Full log attached. I have confirmed that the issue also occurs on this DEBUG build On 31 March 2016 at 10:57, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 31 March 2016 at 10:54, Yao, Jiewen <jiewen@intel.com> wrote: >> Correct typo. meat->meet >>

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
Thanks, Ard. > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" <jiewen@intel.com> > Cc: "Ard Biesheuvel" <ard.biesheu...@linaro.org> > Cc: "Gao, Liming" <liming@intel.com> >

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Ard Biesheuvel
On 7 April 2016 at 14:02, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/07/16 13:44, Ard Biesheuvel wrote: >> On 7 April 2016 at 13:18, Laszlo Ersek <ler...@redhat.com> wrote: > >>> I tried to round up users of the lib class ArmGicArchLib. I found two >&

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Ard Biesheuvel
On 7 April 2016 at 14:26, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/07/16 14:04, Ard Biesheuvel wrote: >> On 7 April 2016 at 14:02, Laszlo Ersek <ler...@redhat.com> wrote: >> Does that mean you are going to ignore my v2? > > I certainly don't *want*

Re: [edk2] [patch 0/4] Add EDKII SD/MMC stack to manage SD/EMMC device

2016-04-07 Thread Ard Biesheuvel
On 23 March 2016 at 03:51, Feng Tian wrote: > The EDKII SD/MMC stack includes: > 1. Dxe phase support by: >i. SdMmcPciHcDxe driver to consume PciIo and produce SdMmcPassThru >ii. SdDxe driver to consume SdMmcPassThru to produce BlkIo1/BlkIo2 >iii.EmmcDxe driver

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Ard Biesheuvel
On 7 April 2016 at 13:18, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/06/16 18:15, Ard Biesheuvel wrote: >> Instead of relying on VirtFdtDxe to populate the GIC related PCDs, move >> this handling to our implementation of ArmGicArchLib, and retrieve the >> require

[edk2] [PATCH 1/2] ArmVirtPkg: remove linux loader from ARM builds

2016-04-07 Thread Ard Biesheuvel
The built in Linux loader was a temporary solution to boot ARM Linux without EFI support in the OS. Now that EFI support is merged in the upstream v4.5 release, we no longer need it. So drop it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.bies

[edk2] [PATCH 2/2] ArmVirtPkg: drop bogus ArmPlatformSecExtraActionLib resolution

2016-04-07 Thread Ard Biesheuvel
Nothing we use on any of the ArmVirtPkg platforms depends on the ArmPlatformSecExtraActionLib library class, so drop the resolution from ArmVirt.dsc.inc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmV

Re: [edk2] [wave 3 PATCH 06/15] OvmfPkg: IndustryStandard: add definitions from the VirtIo 1.0 spec

2016-04-05 Thread Ard Biesheuvel
inimal, and intentionally kept apart >> >> from the VirtIo 0.9.5 headers. >> >> >> >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> >> Contributed-under: TianoCore Contr

Re: [edk2] [PATCH 04/21] ArmVirtPkg/FdtClientDxe: implement new driver

2016-04-07 Thread Ard Biesheuvel
On 7 April 2016 at 09:57, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/07/16 09:32, Ard Biesheuvel wrote: >> On 6 April 2016 at 22:25, Laszlo Ersek <ler...@redhat.com> wrote: > >>> (5) For new code, please strive to keep the Packages / LibraryClasses / >

Re: [edk2] [PATCH 20/21] ArmVirtPkg/VirtFdtDxe: drop RTC handling

2016-04-07 Thread Ard Biesheuvel
On 6 April 2016 at 18:15, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > The RTC driver no longer relies on VirtFdtDxe to set the pl031 RTC base > address in a dynamic PCD, so drop the handling altogether. > > Contributed-under: TianoCore Contribution Agreement 1.0 &g

<    4   5   6   7   8   9   10   11   12   13   >