[edk2] [Patch] BaseTools: Enable component override functionality

2019-01-10 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1449 This patch enable build tools to recognize that when two given files have the same GUID, file path and ARCH in Dsc, The later one's definition will be used. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc:

[edk2] [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools

2019-01-09 Thread BobCF
From: "Feng, Bob C" https://bugzilla.tianocore.org/show_bug.cgi?id=1350 Remove ECP support from BaseTools C code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 - 1

[edk2] [Patch 3/3 V2] BaseTools: Remove unused logic from C tools

2019-01-09 Thread BobCF
From: "Feng, Bob C" https://bugzilla.tianocore.org/show_bug.cgi?id=1350 Remove IA64 support from BaseTools C code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/C/Common/BasePeCoff.c| 14 +-

[edk2] [Patch 1/3 V2] BaseTools: Remove unused logic for EDKI

2019-01-08 Thread BobCF
From: "Feng, Bob C" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350 Remove EDK module type support from BaseTools python code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey ---

[edk2] [Patch 3/3] BaseTools: Remove unused logic from C tools

2019-01-08 Thread BobCF
From: "Feng, Bob C" Remove EDK module and IA64 support from BaseTools C code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/C/Common/BasePeCoff.c| 14 +-

[edk2] [Patch 1/3] BaseTools: Remove unused logic for EDKI

2019-01-08 Thread BobCF
From: "Feng, Bob C" Remove EDK module type support from BaseTools C code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py| 93 ++---

[edk2] [Patch 2/3] BaseTools: Remove unused logic for IPF

2019-01-08 Thread BobCF
From: "Feng, Bob C" Remove IPF support from BaseTools C code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/Python/Common/DataType.py| 19 +- .../Source/Python/CommonDataClass/FdfClass.py | 20 --

[edk2] [Patch 0/3] BaseTools: Remove unused logic in BaseTools

2019-01-08 Thread BobCF
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1104 Based on the requestion the above BZ, this patch serial removes the BaseTools C and Python code for EDKI, IPF support. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [Patch] BaseTools: Report Error if use SET in Dsc

2019-01-02 Thread BobCF
Build tool do not support SET syntax in DSC. If the SET statement is used in DSC, build tool just ignore it. That behavior confused some users that they think SET statement works in DSC like in FDF. To avoid such confusion, build tool report ERROR if there is "SET" statement in Dsc file.

[edk2] [Patch] BaseTools: Fixed build report issue.

2018-12-29 Thread BobCF
From: "Feng, Bob C" This patch is going to fix the regression issue by 72a1d77694d51914c0dd6aa97dbfa58634b0a4a5 After enable PCD array, the Pcd.OverrideStruct has a new key, array index, but the build report is not changed correspondingly. Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch] BaseTools: Correct PcdArray value assigment statement

2018-12-29 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1410 BaseTools should not generate C structure array initial value if the value is not specified with CODE style. This patch is going to remove the incorrect initial value statement and correct the Pcd Array value assignment statement.

[edk2] [Patch] BaseTools: Reset FdsGlobalVariable

2018-12-20 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1418 This patch is going to fix a regression issue that is introduced by commit b3497bad1221704a5dbc5da0b10f42625f1ad2ed. Before commit b3497b, build launched a external GenFds.py to generate Fd, so the global variable in GenFds.py was reset in each

[edk2] [Patch V2] BaseTools: Fixed metafile parser issues

2018-12-17 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1406 This patch is going to fix the regressions that is introduced by commit 2f818ed0fb57d98985d151781a2ce9b8683129ee The internal array for storing the metadata info should be cached so that the meta file is parsed only once in one build.

[edk2] [Patch] BaseTools: Fixed metafile parser issues

2018-12-15 Thread BobCF
This patch is going to fix the regressions that is introduced by commit 2f818ed0fb57d98985d151781a2ce9b8683129ee The meta file should be parsed only once in one build. So adding cache for meta file data array and check if the meta file is already parsed before start parsing file. Change the meta

[edk2] [Patch V2] BaseTools: Fix PcdArray issue

2018-12-14 Thread BobCF
From: "Feng, Bob C" https://bugzilla.tianocore.org/show_bug.cgi?id=1390 1. support hex number for array index 2. support Non-Dynamic Pcd for array data type 3. support {} and {CODE()} for array data type 4. Change GetStructurePcdMaxSize to be a static function since it need to be called in

[edk2] [Patch] BaseTools: Fix PcdArray issue

2018-12-14 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1390 1. support hex number for array index 2. support Non-Dynamic Pcd for array data type 3. support {} and {CODE()} for array data type Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Ard

[edk2] [Patch V3] BaseTools: Fix PcdNvStoreDefaultValueBuffer Value.

2018-12-11 Thread BobCF
From: "Feng, Bob C" https://bugzilla.tianocore.org/show_bug.cgi?id=1385 This patch is going to fix the regression issue that is introduced by commit e6eae3b4c7b9b756263ecec79694de5f1e85b73a and commit 0b6c5954e1d9a17e01eee7d5ef840a5b4790e2e8. PcdNvStoreDefaultValueBuffer value is update to Vpd

[edk2] [Patch V3] BaseTools: Fixed the build fail issue for cases

2018-12-11 Thread BobCF
From: "Feng, Bob C" https://bugzilla.tianocore.org/show_bug.cgi?id=1386 This patch is going to fix the regression issue that is introduced by commit 72a1d77694d51914c0dd6aa97dbfa58634b0a4a5 The issue will happen in the following cases: 1. There is no Pcd value assignment in Dsc file 2. There

[edk2] [Patch V3] BaseTools: Fixed bugs in CopyDict function

2018-12-11 Thread BobCF
From: "Feng, Bob C" https://bugzilla.tianocore.org/show_bug.cgi?id=1387 This patch is going to fix the regression issue which is introduced by commit bf9e636605188e291d33ab694ff1c5926b6f0800. This patch Remove the CopyDict incorrect usage for non-dict input data. Add a check for CopyDict

[edk2] [Patch V2] BaseTools: Fix PcdNvStoreDefaultValueBuffer Value.

2018-12-09 Thread BobCF
From: "Feng, Bob C" V2: update the commit log. This issue is related to the commit e6eae3b4c7b9b756263ecec79694de5f1e85b73a and 0b6c5954e1d9a17e01eee7d5ef840a5b4790e2e8 V1: https://bugzilla.tianocore.org/show_bug.cgi?id=1385 PcdNvStoreDefaultValueBuffer value is update to Vpd Info File, but it

[edk2] [Patch V2] BaseTools: Fixed bugs in CopyDict function

2018-12-09 Thread BobCF
From: "Feng, Bob C" V2: update commit log. This issue is introduced by commit bf9e636605188e291d33ab694ff1c5926b6f0800 V1: https://bugzilla.tianocore.org/show_bug.cgi?id=1387 Remove the CopyDict incorrect usage for non-dict input data. Add a check for CopyDict input. Contributed-under:

[edk2] [Patch V2] BaseTools: Fixed the build fail issue for cases

2018-12-09 Thread BobCF
From: "Feng, Bob C" V2: update the commit log. This issue is introduced by the commit 72a1d77694d51914c0dd6aa97dbfa58634b0a4a5 V1: https://bugzilla.tianocore.org/show_bug.cgi?id=1386 1. There is no Pcd value assignment in Dsc file 2. There are duplicate Pcd filed assignment Contributed-under:

[edk2] [Patch] BaseTools: Fixed the build fail issue for cases

2018-12-09 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1386 1. There is no Pcd value assignment in Dsc file 2. There are duplicate Pcd filed assignment Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2] [Patch] BaseTools: Fix PcdNvStoreDefaultValueBuffer Value.

2018-12-09 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1385 PcdNvStoreDefaultValueBuffer value is update to Vpd Info File, but it is not update into a internal cache. This patch is going to fix this incorrect value in that internal cache. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [Patch] BaseTools: Fixed bugs in CopyDict function

2018-12-09 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1387 Remove the CopyDict incorrect usage for non-dict input data. Add a check for CopyDict input Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Common/Misc.py|

[edk2] [Patch] BaseTools: Correct CCFLAG for PcdValueInit

2018-11-28 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1361 This patch is going to correct the CCFlag for building PcdValueInit Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: BobCF Cc: Liming Gao --- .../Source/Python/Workspace/DscBuildData.py | 24 +-- 1 file

[edk2] [Patch] Edk2: Update BaseTools Maintainers

2018-11-27 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: BobCF Cc: Yonghong Zhu Cc: Liming Gao --- Maintainers.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 9a36f0232b..babed93284 100644 --- a/Maintainers.txt

[edk2] [Patch] BaseTools: Fix the problem using FILE_GUID override in .dsc

2018-11-15 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1330 This patch is going to fix the problem using FILE_GUID override in .dsc. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: BobCF Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/Python/GenFds/FdfParser.py | 18

[edk2] [Patch V2] BaseTools: Replace the sqlite database with list

2018-11-09 Thread BobCF
tement and the time of write database to file system Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: BobCF Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/Python/GenFds/GenFds.py | 3 +- .../Source/Python/Workspace/MetaDataTable.py | 93 ++- .../Source/

[edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-08 Thread BobCF
list in a loop and using "".join(stringlist) after the loop will be much faster. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: BobCF Cc: Liming Gao Cc: Jaben Carsey --- BaseTools/Source/Python/AutoGen/StrGather.py | 39 +-- BaseTools/Sou

[edk2] [Patch] BaseTools: Add cache for UniToHexList

2018-11-07 Thread BobCF
From: "bob.c.f...@intel.com" https://bugzilla.tianocore.org/show_bug.cgi?id=1288 This patch is one of build tool performance improvement series patches. This patch is going to add cache for UniToHexList function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [Patch] BaseTools: Customize deepcopy function.

2018-11-07 Thread BobCF
usage we just need to copy the data we care about recursively. By implementing __deepcopy__ for SkuClass, PcdClassObject, we can customize deepcopy function for them. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: BobCF Cc: Liming Gao Cc: Jaben Carsey --- BaseTools

[edk2] [PATCH] BaseTools: Enable Pcd Array support.

2018-11-07 Thread BobCF
From: "bob.c.f...@intel.com" https://bugzilla.tianocore.org/show_bug.cgi?id=1292 This patch is going to enable Array data type for PCD. 1. Support Pcd ARRAY as Structure PCD type including basic datatype array and structure array. For example:

[edk2] [Patch V3] BaseTools: Use common cc flag for building PcdValueInit.

2018-11-01 Thread BobCF
V3: Update the patch to avoid "reduce" function fail. V2: Support to extract the common cc flag from a combined cc flag string. For example MSFT:*_*_IA32_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES /DDEF_IA32 MSFT:*_*_X64_CC_FLAGS = /DDEF_X64 /D DISABLE_NEW_DEPRECATED_INTERFACES V1: Use

[edk2] [Patch V2] BaseTools: Use common cc flag for building PcdValueInit.

2018-11-01 Thread BobCF
V2: Support to extract the common cc flag from a combined cc flag string. For example MSFT:*_*_IA32_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES /DDEF_IA32 MSFT:*_*_X64_CC_FLAGS = /DDEF_X64 /D DISABLE_NEW_DEPRECATED_INTERFACES V1: Use common cc flags for building pcdinitvalue. The common cc

[edk2] [Patch] BaseTools: Use common cc flag for building PcdValueInit.

2018-11-01 Thread BobCF
Use common cc flags for building PcdValueInit. The common cc flags include the cc flag which is under common Arch and under all build Arches. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/DscBuildData.py | 48

[edk2] [Patch] BaseTools: Add checking to EFI variable attribute.

2018-11-01 Thread BobCF
This patch is going to add a check that only if the attribute of a EFI variable include 'NV', it will be added into PcdNvStoreDefaultValueBuffer. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 ++

[edk2] [Patch] BaseTool: Filter out unused structure pcds

2018-11-01 Thread BobCF
V2: Fixed the issue that V1 adds new check to the Pcds in the platform unused library INF files. It breaks the existing platform. V1: The current code handle all the structure pcds even if there is no module or library use them. This patch is going to filter out the unused structure pcds.

[edk2] [Patch] BaseTools: Rollback Filter out unused structure pcds

2018-10-26 Thread BobCF
This reverts commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795. commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 adds new check of Pcds in the platform unused library INF files. It breaks the existing platform. To avoid the impact, roll back this change first. Contributed-under: TianoCore

[edk2] [Patch] BaseTools: Move PcdValueInit to platform build folder

2018-10-21 Thread BobCF
PcdValueInit tool is platform scope. It should be generated into Platform output directory. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob C Feng Cc: Liming Gao --- .../Source/Python/Workspace/DscBuildData.py | 25 +-- 1 file changed, 17

[edk2] [Patch] BaseTools: Fixed a key error code bug.

2018-10-21 Thread BobCF
There is a code bug that used a wrong key. This Patch is to correct it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [Patch] BaseTool: Filter out unused structure pcds

2018-10-19 Thread BobCF
The current code handle all the structure pcds even if there is no module or library use them. This patch is going to filter out the unused structure pcds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2] [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.

2018-10-17 Thread BobCF
PcdValueInit tool is Arch independent, the Arch specific build options should be removed from PcdValueInit makefile. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob C Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- 1 file changed, 1

[edk2] [Patch] BaseTool: Replace dict with OrderedDict.

2018-09-14 Thread BobCF
Replace dict with OrderedDict for PCD so that the pcd list has same order. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/GenFds/FdfParser.py | 7 +++-- .../Python/Workspace/BuildClassObject.py | 11 ---

[edk2] [PATCH] BaseTool: Support different PCDs to refer to the same EFI variable.

2018-09-12 Thread BobCF
From: "bob.c.f...@intel.com" If Structure PCD and Normal Pcd refer to the same EFI variable, do EFI variable merge, otherwise, do EFI variable combination. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2] [Patch] BaseTool: Variable Merge.

2018-09-07 Thread BobCF
If Structure PCD and Normal Pcd refer to the same variable, do variable merge. Enhance error message. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 3 +-

[edk2] [Patch] BaseTool: Variable Merge.

2018-09-06 Thread BobCF
If Structure PCD and Normal Pcd refer to the same variable, do variable merge. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 3 +- BaseTools/Source/Python/AutoGen/GenVar.py | 71

[edk2] [Patch] BaseTools: Structure Pcd value override incorrect.

2018-09-04 Thread BobCF
This patch is going to fix the issue that The Pcd field value is override incorrectly when there is no Pcd overall value assignment in Dsc file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py

[edk2] [Patch] BaseTool: Variable Merge.

2018-09-02 Thread BobCF
If Structure PCD and Normal Pcd refer to the same variable, do variable merge. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 3 +- BaseTools/Source/Python/AutoGen/GenVar.py | 71

[edk2] [Patch] BaseTools: Involve Dec default value to calculate Maxsize

2018-09-02 Thread BobCF
Involve Dec default value to calculate Maxsize for structure PCD Cc: Liming Gao Cc: Yonghong Zhu Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng --- .../Source/Python/Workspace/BuildClassObject.py| 34 +++--- 1 file

[edk2] [Patch] BaseTools: Involve Dec default value to calculate Maxsize

2018-08-29 Thread BobCF
Involve Dec default value to calculate Maxsize for structure PCD Cc: Bob Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 9 + 1 file changed, 9 insertions(+) diff --git

[edk2] [Patch] BaseTools: Dynamic Pcd value override from command line.

2018-08-29 Thread BobCF
Fixed the pcd value override issue when Dynamic Pcd is from command line but is not list in Dsc file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 7 ++- 1 file changed, 6

[edk2] [Patch] BaseTools: Fixed the PcdValue trailing zero issue.

2018-08-28 Thread BobCF
1. Not append trailing zero for PcdValue 2. make sure the point to Variable Name in PCD DataBase 2 bytes aligned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 6 ++

[edk2] [PATCH] BaseTools: Check pcd DefaultValue and SkuId EBNF.

2018-08-26 Thread BobCF
From: Zhaozh1x 1. When assign dynamic hii pcd value in dsc file, missed the DefaultValue, build should be fail. 2. Check the EBNF of SkuId. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhiqiangX Zhao Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng ---

[edk2] [Patch] BaseTools: Fixed build Ovmfpkg failed issue.

2018-07-16 Thread BobCF
Fixed a code bug. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py

[edk2] [PATCH] BaseTool: Fixed the incorrect cache key.

2018-07-10 Thread BobCF
From: "bob.c.f...@intel.com" This patch is to fix the incorrect cache key of skip ModuleAutoGen cache. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2] [Patch] BaseTools: Remove a unused function.

2018-07-09 Thread BobCF
the call statement of _CheckDuplicateInFV() was commented out in 2014. There is no call statement of _CheckDuplicateInFV(), so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu ---

[edk2] [Patch] BaseTool: Add cache for the result of SkipAutogen.

2018-07-01 Thread BobCF
Add a cache for the value of skip ModuleAutoGen process flag. This cache can improve build performance. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4

[edk2] [Patch] BaseTools: Enable structure pcd in FDF file

2018-06-25 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 3 +- BaseTools/Source/Python/AutoGen/GenC.py| 4 + BaseTools/Source/Python/GenFds/FdfParser.py| 81 --

[edk2] [Patch] BaseTools: Structure pcd value assignment

2018-06-25 Thread BobCF
Enable Structure pcd value assigned by FixedPcd Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/MetaFileParser.py | 23 +++--- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git

[edk2] [Patch] BaseTool: Fixed the bug of Boolean Hii Pcd packing.

2018-06-13 Thread BobCF
When packing HiiPcd into PcdNvStoreDefaultValueBuffer, The boolean type pcd value packing incorrect. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenVar.py | 2 +- 1 file changed, 1 insertion(+), 1

[edk2] [Patch] BaseTool: Fixed the issue of empty PcdDB.

2018-03-22 Thread BobCF
If there is no dynamic pcds, there should be DB header in the Pcd DataBase. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 9 + 1 file changed,

[edk2] [Patch] BaseTool: Error handling for PCD datumtype.

2018-03-18 Thread BobCF
Report error if the Pcd DatumType is wrong. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 ++

[edk2] [Patch] BaseTools: Detect structure pcd header file change.

2018-03-16 Thread BobCF
Detect structure pcd header file change Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 188 +++--- 1 file changed, 134

[edk2] [Patch] BaseTools: Detect structure pcd header file change.

2018-03-16 Thread BobCF
Detect structure pcd header file change Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 190 -- 1 file changed, 136

[edk2] [Patch] BaseTools: Fixed Pcd from command line issue.

2018-03-07 Thread BobCF
Save the pcd command line value in Pcd object Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenC.py| 15 +++

[edk2] [Patch] BaseTools: Fixed Pcd from command line issue.

2018-03-07 Thread BobCF
Save the pcd command line value in Pcd object Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenC.py| 15 +++

[edk2] [Patch] BaseTool: Enhance error message.

2018-03-05 Thread BobCF
Enhance the error message when the PCD from commandline can not be found. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 7 --- 1 file

[edk2] [Patch] BaseTools: Support H"{}" format for Sructure Pcd.

2018-03-04 Thread BobCF
Support H"{}" format for Sructure Pcd from CommandLine Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 1 - 1 file changed, 1 deletion(-) diff

[edk2] [Patch] BaseTool: Error handling for PCD datumtype.

2018-03-04 Thread BobCF
Report error if the Pcd DatumType is wrong. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 ++

[edk2] [Patch] BaseTools: Pcd Value override issue.

2018-03-02 Thread BobCF
For the case that the structure PCD has no value assignment in DSC, but has value assignment in command line. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2] [Patch 2/2] BaseTools: Fixed build failed issue.

2018-03-02 Thread BobCF
Case 1. A Pcd has no default sku setting in DSC. Case 2. Build as Single SKU. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 21

[edk2] [Patch 1/2] BaseTools: Fixed Pcd value override issue.

2018-03-02 Thread BobCF
1. Handle the Pcd maxsize issue for the case that the length of Pcd value from CommandLine bigger that its maxsize 2. The Pcd value override in commandline. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao

[edk2] [Patch] BaseTools: Fixed build failed issue.

2018-03-01 Thread BobCF
Case 1. A Pcd has no default sku setting in DSC. Case 2. Build as Single SKU. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 21

[edk2] [Patch] BaseTools: Fixed Pcd value override issue.

2018-03-01 Thread BobCF
The Pcd value override in commandline. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/BuildClassObject.py| 4 + BaseTools/Source/Python/Workspace/DscBuildData.py |

[edk2] [Patch 4/4] BaseTools: Improve build performance

2018-02-27 Thread BobCF
Optimized the PcdValueInit.c size. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/BuildClassObject.py| 4 + BaseTools/Source/Python/Workspace/DscBuildData.py | 211

[edk2] [Patch 2/4] BaseTools: Improve build performance

2018-02-27 Thread BobCF
Add cache for building PcdValueInit.c. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/GenFds/GenFds.py | 1 + BaseTools/Source/Python/Workspace/DecBuildData.py |

[edk2] [Patch 3/4] BaseTool: GUID assignment fail.

2018-02-27 Thread BobCF
Structure PCD GUID assignment fail. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DecBuildData.py | 3 +- BaseTools/Source/Python/Workspace/DscBuildData.py | 289

[edk2] [Patch 1/4] BaseTools: Fixed the pcd value override issue.

2018-02-27 Thread BobCF
1. the issue in the overriding value from command line. 2. dec fully value < dec field assign value < dsc fully value < dsc field assign value Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2] [Patch] BaseTool: GUID assignment fail.

2018-02-23 Thread BobCF
Structure PCD GUID assignment fail. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DecBuildData.py | 3 ++- BaseTools/Source/Python/Workspace/DscBuildData.py | 11

[edk2] [Patch 2/2] BaseTools: Fixed the pcd value override issue.

2018-02-23 Thread BobCF
1. the issue in the overriding value from command line. 2. dec fully value < dec field assign value < dsc fully value < dsc field assign value Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2] [Patch 1/2] BaseTools: Improve build performance

2018-02-23 Thread BobCF
Add cache for building PcdValueInit.c. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/GenFds/GenFds.py | 1 + BaseTools/Source/Python/Workspace/DecBuildData.py |

[edk2] [Patch] BaseTools: Improve build performance

2018-02-08 Thread BobCF
Add cache for building PcdValueInit.c. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/GenFds/GenFds.py | 1 + BaseTools/Source/Python/Workspace/DscBuildData.py |

[edk2] [Patch] BaseTools: Improve build performance

2018-02-06 Thread BobCF
Add cache for building PcdValueInit.c. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 140 +++--- 1 file changed, 71

[edk2] [Patch] BaseTools: Fixed incorrect Structure Pcd Value.

2018-02-06 Thread BobCF
When structurePCD only has overall value assigned in Dsc under different SKU, the value under default sku is used. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2] [Patch] BaseTool: Fixed Pcd issues.

2018-02-06 Thread BobCF
1. Check variable offset when merging Hii Pcds 2. Fixed the issue of Hii value inherit with default store. 3. Error handling for incorrect structure pcd declare. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao

[edk2] [Patch] BaseTools: Fixed Build failed issue.

2018-02-05 Thread BobCF
If the PCD is not used in DSC file and user set that PCD value from Command line, build will fail. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py |

[edk2] [Patch] BaseTool: Add comments in PcdValueInit.c.

2018-01-31 Thread BobCF
Add Comments for __FLEXIBLE_SIZE () statement. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 10 ++ 1 file changed, 6 insertions(+), 4

[edk2] [Patch] BaseTool: Enhance error handling.

2018-01-31 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 116 - .../Source/Python/Workspace/MetaFileParser.py | 3 + 2 files

[edk2] [Patch] BaseTools: Structure Pcd in CommandLine.

2018-01-31 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py| 110 +++- BaseTools/Source/Python/Common/Expression.py | 2 +-

[edk2] [Patch] BaseTools: Support multiple .h file

2018-01-28 Thread BobCF
for structure Pcd declaration in DEC file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 +-

[edk2] [Patch] BaseTools: Structure Pcd in CommandLine.

2018-01-28 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py| 110 +++- BaseTools/Source/Python/Common/Expression.py | 2 +-

[edk2] [Patch] BaseTool: Enhance error handling.

2018-01-28 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 113 - .../Source/Python/Workspace/MetaFileParser.py | 3 + 2 files

[edk2] [Patch] BaseTool: Fixed the StructurePcd incorrect value.

2018-01-24 Thread BobCF
If user not set Structure overall value in Dsc, Structure Pcd value would be incorrect. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 9

[edk2] [Patch] BaseTools: Fixed incorrect VPD size.

2018-01-23 Thread BobCF
The VPD size is incorrect if that VPD is not used in Module. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Feng Bob C Reviewed-by: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 10 -- 1 file changed, 4

[edk2] [Patch] BaseTools: Fixed some small issues 1. The structure pcd default value should use the default value under sku. 2. Incorrect VpdOffset value for those un-used in module Vpd 3. Add a check

2018-01-22 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++-- BaseTools/Source/Python/Workspace/DscBuildData.py | 7 +--

[edk2] [Patch] BaseTools: Add comments for the Structure Pcd definition in PcdValueInit.c file

2018-01-22 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 4 BaseTools/Source/Python/Workspace/DecBuildData.py | 2 ++

[edk2] [Patch] BaseTools: Support multiple .h file for structure Pcd declaration in DEC file.

2018-01-22 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 4 ++-- BaseTools/Source/Python/Workspace/DecBuildData.py | 2 +-

[edk2] [Patch] BaseTool: Combine the HiiPcd value if they link to same Variable

2018-01-22 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- BaseTools/Source/Python/AutoGen/GenVar.py | 36 -- 2 files changed, 35

[edk2] [Patch] BaseTools: Fixed build failure for the case that A pcd is initialized under one SKU but is uninitialized under another SKU.

2018-01-22 Thread BobCF
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git

  1   2   >