Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 10:47 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 10:47 AM > To: edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Chiu, Chasel > ; Gao, Liming ; Kinney, Michael > D > Subject: [edk2-platforms/devel-M

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 10:47 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 9:23 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 9:23 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Chiu, Chasel
Hi Michael, Please see below inline. Thanks! Chasel > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 9:23 AM > To: edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Chiu, Chasel > ; Gao, Liming ; Kinney, Michael > D > Subjec

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 6:48 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-

Re: [edk2] [edk2-platforms][PATCH v1 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Monday, April 1, 2019 7:28 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [e

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 6:48 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Chiu, Chasel
Hi Michael, A question in below patch inline, please help to check it. Thanks! Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, April 2, 2019 8:09 AM > To: Kubacki, Michael A ; > edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Gao, Liming ; &

Re: [edk2] [PATCH V7 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-31 Thread Chiu, Chasel
No change from V5. Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Monday, April 1, 2019 9:08 AM > To: edk2-devel@lists.01.org > Cc: Bret Barkelew ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean B

Re: [edk2] [PATCH V7 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-31 Thread Chiu, Chasel
No change from V5. Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Monday, April 1, 2019 9:08 AM > To: edk2-devel@lists.01.org > Cc: Bret Barkelew ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean B

Re: [edk2] [PATCH V5 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-28 Thread Chiu, Chasel
No change from V4. Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 28, 2019 4:10 PM > To: edk2-devel@lists.01.org > Cc: Bret Barkelew ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean B

Re: [edk2] [PATCH V5 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-28 Thread Chiu, Chasel
No change from V4. Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 28, 2019 4:10 PM > To: edk2-devel@lists.01.org > Cc: Bret Barkelew ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean B

Re: [edk2] [PATCH V4 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-21 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 21, 2019 10:05 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew

Re: [edk2] [PATCH V4 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-21 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 21, 2019 10:05 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew

Re: [edk2] [PATCH V3 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, March 19, 2019 11:26 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew

Re: [edk2] [PATCH V3 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, March 19, 2019 11:26 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew

Re: [edk2] [PATCH V2 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add a new api DebugVPrint

2019-03-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Friday, March 15, 2019 1:18 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew &g

Re: [edk2] [PATCH V2 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add a new api DebugVPrint

2019-03-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Friday, March 15, 2019 1:18 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew &g

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Chiu, Chasel
> -Original Message- > From: Ni, Ray > Sent: Thursday, February 14, 2019 4:20 PM > To: Chiu, Chasel ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming > Subject: RE: [PATCH 2/3] MdeModulePkg/PeiMain: Support > EFI_PEI_CORE_FV

Re: [edk2] [PATCH v2 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Chiu, Chasel
> -Original Message- > From: Ni, Ray > Sent: Thursday, February 14, 2019 4:25 PM > To: Chiu, Chasel ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [PATCH v2 3/3] UefiCpuPkg/SecCore: Support > EFI_PEI_CORE_FV_LOCATION_PPI > > &

Re: [edk2] [Patch edk2 Wiki] Add three features for edk2-stable201903

2019-02-13 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Wednesday, February 13, 2019 12:24 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch edk2 Wiki] Add three features for edk2-stable201903

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-12 Thread Chiu, Chasel
No issue, I will remove UINT32 casting. Thanks! > -Original Message- > From: Wang, Jian J > Sent: Wednesday, February 13, 2019 9:14 AM > To: Chiu, Chasel ; edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ray ; Zeng, Star > ; Gao, Liming > Subject: RE: [PATCH 2/3]

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 1/1] ReadMe.md: Update Minimum Platform details

2019-02-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, February 6, 2019 1:34 AM > To: Kubacki, Michael A ; > edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Sinha, Ankit > ; Chiu, Chasel ; Oram, Isaac W > ; Gao, Limi

Re: [edk2] [PATCH v1 1/1] Maintainers.txt: Update MinPlatformPkg maintainers

2019-01-22 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, January 23, 2019 6:16 AM > To: Kubacki, Michael A ; > edk2-devel@lists.01.org > Cc: Wu, Hao A ; Gao, Liming ; > Chiu, Chasel ; Kinney, Michael D > > Subject: RE: [PATCH v1 1

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Fix a bug that may wrongly set memory <1MB to UC

2019-01-21 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Ni, Ray > Sent: Monday, January 21, 2019 11:17 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Dong, Eric ; Chiu, Chasel > > Subject: [PATCH] UefiCpuPkg/MtrrLib: Fix a bug that may wrongly set memory > &l

Re: [edk2] [PATCH] MinPlatformPkg: Support TCO base locked by FSP

2019-01-15 Thread Chiu, Chasel
Good point! I will send another patch for this. Thanks! Chasel > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, January 15, 2019 4:12 PM > To: Chiu, Chasel ; edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: RE: [

Re: [edk2] [PATCH] MinPlatformPkg: Support TCO base locked by FSP

2019-01-14 Thread Chiu, Chasel
+ Michael to review this too. Thanks! Chasel > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, January 15, 2019 12:07 PM > To: edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Zeng, Star > ; Chiu, Chasel > Subject: [PATCH] MinPlatformPkg: Support T

Re: [edk2] [PATCH V2 3/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Tuesday, December 18, 2018 2:08 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH V2 3/7

Re: [edk2] [PATCH V2 4/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported

2018-12-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Tuesday, December 18, 2018 2:08 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH V2 4/7

Re: [edk2] [PATCH V2 7/7] MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs

2018-12-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Tuesday, December 18, 2018 2:08 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH V2 7/7

Re: [edk2] [PATCH V2 1/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv

2018-12-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Tuesday, December 18, 2018 2:08 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH V2 1/7

Re: [edk2] [PATCH 1/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 1/7

Re: [edk2] [PATCH 3/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 3/7

Re: [edk2] [PATCH 4/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 4/7

Re: [edk2] [PATCH 7/7] MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 7/7

Re: [edk2] [edk2-platforms PATCH 1/2] KabylakeOpenBoardPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:43 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Chiu, Chasel ; Kubacki, Michael A Subject: [edk2-platforms PATCH 1/2] KabylakeOpenBoardPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Fix system hang when no PCI Option ROM exists

2018-12-12 Thread Chiu, Chasel
1). > It causes the final MEM32 alignment requirement is as big as > 0x_. > > The patch fixes this issue by only creating virtual BAR for option ROM > when there is PCI option ROM. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiy

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Support FSP Dispatch mode

2018-11-06 Thread Chiu, Chasel
Hi Jiewen, No special reason in this patch. I'm verifying the change for switching to "if" instead of "#if", and will re-send a new patch later. Thanks! Chasel -Original Message- From: Yao, Jiewen Sent: Tuesday, November 6, 2018 7:38 PM To: Chiu, Chasel Cc: edk

Re: [edk2] [PATCH] IntelFsp2Pkg: Fixed potentially NULL pointer accessing

2018-10-28 Thread Chiu, Chasel
Yes. We can do that. I will send patch V2 soon. Thanks! Chasel -Original Message- From: Yao, Jiewen Sent: Friday, October 26, 2018 10:24 PM To: Chiu, Chasel ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] IntelFsp2Pkg: Fixed potentially NULL pointer accessing Hi Chasel Can we

Re: [edk2] [PATCH v2] IntelFsp2Pkg: FSP should not override IDT

2018-10-23 Thread Chiu, Chasel
Hello, Please see my reply below inline. Thanks! Chasel -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Tuesday, October 23, 2018 6:29 PM To: Chiu, Chasel Cc: edk2-devel@lists.01.org; Yao, Jiewen Subject: Re: [edk2] [PATCH v2] IntelFsp2Pkg: FSP should

Re: [edk2] [PATCH] IntelFsp2Pkg: FSP should not override IDT

2018-10-23 Thread Chiu, Chasel
o let boot loader know that it cannot support. Thanks! Chasel -Original Message- From: Yao, Jiewen Sent: Tuesday, October 23, 2018 2:09 PM To: Chiu, Chasel ; edk2-devel@lists.01.org Cc: Desimone, Nathaniel L Subject: RE: [PATCH] IntelFsp2Pkg: FSP should not override IDT Hi Chasel

Re: [edk2] [PATCH] IntelFsp2Pkg: Support FSP API mode indicator

2018-10-11 Thread Chiu, Chasel
: Thursday, October 11, 2018 9:41 PM To: Chiu, Chasel ; edk2-devel@lists.01.org Cc: Desimone, Nathaniel L Subject: RE: [PATCH] IntelFsp2Pkg: Support FSP API mode indicator Thanks Chasel. I suggest we test the real function besides just pass build. Please make sure your test below combination: 1) FSP

Re: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo in SplitFspBin

2018-09-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Desimone, Nathaniel L Sent: Tuesday, September 18, 2018 11:04 PM To: Patrick Georgi ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo in

Re: [edk2] [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs

2018-08-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zhang, Shenglei Sent: Tuesday, August 28, 2018 11:43 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Chiu, Chasel ; Laszlo Ersek Subject: [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs The PCDs

Re: [edk2] [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD

2018-08-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zhang, Shenglei Sent: Tuesday, August 28, 2018 11:43 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Chiu, Chasel ; Laszlo Ersek Subject: [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD The PCD below

Re: [edk2] [PATCH 2/5] IntelFsp2Pkg: Remove unused PCDs

2018-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zhang, Shenglei Sent: Thursday, August 16, 2018 1:32 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Chiu, Chasel Subject: [PATCH 2/5] IntelFsp2Pkg: Remove unused PCDs The PCDs below are unused, so they have been removed from inf

Re: [edk2] [PATCH 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

2018-06-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Ni, Ruiyu Sent: Friday, June 1, 2018 1:39 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Chiu, Chasel Subject: [PATCH 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 1/4] MdeModulePkg/AtaAtapiPassThru: Spin up Power up in Standby devices

2018-06-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Ni, Ruiyu Sent: Friday, June 1, 2018 1:39 PM To: edk2-devel@lists.01.org Cc: Chiu, Chasel ; Wu, Hao A Subject: [PATCH 1/4] MdeModulePkg/AtaAtapiPassThru: Spin up Power up in Standby devices The patch adds support to certain devices

Re: [edk2] [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

2018-06-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Ni, Ruiyu Sent: Friday, June 1, 2018 1:39 PM To: edk2-devel@lists.01.org Cc: Chiu, Chasel ; Wu, Hao A Subject: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 2/2] MdeModulePkg/PciBus: Do not enable MemWriteAndInvalidate bit for PCIE

2018-05-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu <chasel.c...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Friday, May 25, 2018 6:03 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Chiu, Chasel <chasel.c...@intel.com> Subject: [PATCH 2/2] MdeModulePkg/Pci

Re: [edk2] [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level to DEBUG_INFO

2018-04-08 Thread Chiu, Chasel
Thanks! Reviewed-by: Chasel Chiu <chasel.c...@intel.com> -Original Message- From: Zeng, Star Sent: Wednesday, April 4, 2018 4:39 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; Chiu, Chasel <chasel.c...@

Re: [edk2] [PATCH] MdeModulePkg Variable: Align TPL level for (Smm)EndOfDxe callback

2018-03-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu <chasel.c...@intel.com> -Original Message- From: Zeng, Star Sent: Wednesday, March 28, 2018 5:31 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Chiu, Chasel <chasel.c...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com&

Re: [edk2] [PATCH] MdeModulePkg CapsulePei: Sort and merge memory resource entries

2017-12-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu <chasel.c...@intel.com> -Original Message- From: Zeng, Star Sent: Monday, December 4, 2017 6:01 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; Chiu, Chasel <chasel.c...@intel

Re: [edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Skip measurement for OEM type

2017-09-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu <chasel.c...@intel.com> -Original Message- From: Zeng, Star Sent: Thursday, September 14, 2017 7:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; Chiu, Chasel <chasel.c...@intel