Re: [edk2] [Patch V2] BaseTools: Fixed issue in MultiThread Genfds function

2019-04-02 Thread Feng, Bob C
If user does not use multiple thread genfds, there will be no problem. -Original Message- From: Gao, Liming Sent: Wednesday, April 3, 2019 10:49 AM To: Feng, Bob C Cc: edk2-devel@lists.01.org Subject: RE: [Patch V2] BaseTools: Fixed issue in MultiThread Genfds function Bob: Thanks

[edk2] [Patch V2] BaseTools: Fixed issue in MultiThread Genfds function

2019-04-02 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1450 In the Multiple thread Genfds feature, build tool generates GenSec, GenFFS command in Makefile. The Non-Hii Driver does not generate .offset file for uni string offset, but the build tool has not knowledge about this in autogen phase. So in this

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-04-02 Thread Feng, Bob C
BZ for remove additional copy action. https://bugzilla.tianocore.org/show_bug.cgi?id=1673 -Original Message- From: Gao, Liming Sent: Friday, March 29, 2019 10:09 PM To: Feng, Bob C ; edk2-devel@lists.01.org Subject: RE: [Patch] BaseTools: Fixed issue in MultiThread Genfds function Yes

Re: [edk2] [Patch] BaseTools:Enable the /MP option of MSVC compiler

2019-04-02 Thread Feng, Bob C
Liming, I add the performance data on the BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1672 Thanks, Bob -Original Message- From: Gao, Liming Sent: Friday, March 29, 2019 10:20 PM To: Feng, Bob C ; edk2-devel@lists.01.org Cc: Fan, ZhijuX Subject: RE: [Patch] BaseTools:Enable

Re: [edk2] [Patch] BaseTools:Enable the /MP option of MSVC compiler

2019-04-01 Thread Feng, Bob C
Hi Kilian, It's a good suggestion. Would you please enter a new BZ for this request? I think implement this request in a separate patch would be better. Thanks, Bob From: Minnow Ware [mailto:minnoww...@outlook.com] Sent: Saturday, March 30, 2019 4:15 PM To: Ni, Ray ; Feng, Bob C ; edk2-devel

Re: [edk2] [PATCH] BaseTools:Coding problems caused by special characters

2019-03-31 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, March 29, 2019 1:54 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Coding problems caused by special characters BZ:https://bugzilla.tianocore.org/show_bug.cgi?id

Re: [edk2] [Patch] BaseTools:Enable the /MP option of MSVC compiler

2019-03-30 Thread Feng, Bob C
Yes. Commit fb94f83131f032cd5ce027ea706c45513c1a799e removed the /Gm option from MSVC tool chain. -Original Message- From: Ni, Ray Sent: Saturday, March 30, 2019 9:42 AM To: Feng, Bob C ; edk2-devel@lists.01.org Cc: Gao, Liming Subject: RE: [edk2] [Patch] BaseTools:Enable the /MP

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Feng, Bob C
That will impact the original GenFds since the command is generate by reusing the GenFds functions. What about enter a new BZ to do that change? Thanks, Bob -Original Message- From: Gao, Liming Sent: Friday, March 29, 2019 8:33 PM To: Feng, Bob C ; edk2-devel@lists.01.org Subject: RE

[edk2] [Patch] BaseTools:Enable the /MP option of MSVC compiler

2019-03-29 Thread Feng, Bob C
From: Zhiju Fan https://bugzilla.tianocore.org/show_bug.cgi?id=1672 The /MP option of MSVC compiler can reduce the total time to compile the source files on the command line. This patch is going to enable this MSVC option in BaseTools. Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Feng, Bob C
-Original Message- From: Gao, Liming Sent: Friday, March 29, 2019 7:42 PM To: Feng, Bob C ; edk2-devel@lists.01.org Subject: RE: [Patch] BaseTools: Fixed issue in MultiThread Genfds function Bob: Could you list the more information on why update build_rule.txt? > -Original Mess

[edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1450 In the Multiple thread Genfds feature, build tool generates GenSec, GenFFS command in Makefile. The Non-Hii Driver does not generate .offset file for uni string offset, but the build tool has not knowledge about this in autogen phase. So in this

[edk2] [Patch] BaseTool: Fixed an issue of Structure PCD

2019-03-26 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1665 Build fail when the structure pcd has member of flexible size array Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 14 +++--- 1

[edk2] [Patch] BaseTools: Remove EDK_GLOBAL related logic

2019-03-16 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350 Macros defined using EDK_GLOBAL are only valid when processing EDK libraries and components. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Common/DataType.py

[edk2] [Patch] BaseTools: Remove EDKI related logic from Trim tool

2019-03-15 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350 Remove EDKI related logic from Trim tool. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Trim/Trim.py | 160 --- 1 file changed, 160

[edk2] [Patch] BaseTools: Remove the logic SourceOverridePath

2019-03-15 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350 SOURCE_OVERRIDE_PATH is for EDK component INF files. The corresponding logic should be removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py

Re: [edk2] [patch] BaseTools: Add missing license and copyright info

2019-03-15 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Bi, Dandan Sent: Friday, March 15, 2019 4:23 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming ; Kinney, Michael D Subject: [patch] BaseTools: Add missing license and copyright info Cc: Bob Feng Cc: Liming Gao Cc: Michael D

[edk2] [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall failed.

2019-03-14 Thread Feng, Bob C
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1622 There is duplicated $(PYTHON_COMMAND) in the command of cleanall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/C/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [edk2] [PATCH] BaseTool/Build: Add --disable-include-path-check.

2019-03-14 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Yao, Jiewen Sent: Thursday, March 14, 2019 6:11 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [PATCH] BaseTool/Build: Add --disable-include-path-check. BZ: https://bugzilla.tianocore.org

[edk2] [Patch V2 1/1] Document: Add PCD flexible format value EBNF in Fdf.

2019-03-06 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=541 This patch is to add flexible PCD value format EBNF into Fdf spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu --- 3_edk_ii_fdf_file_format/32_fdf_definition.md | 25

[edk2] [Patch V2 0/1] Document: Add PCD flexible format value EBNF in Fdf.

2019-03-06 Thread Feng, Bob C
V2: Update the revision history in README.md This patch is to add flexible PCD value format EBNF into Fdf spec. Feng, Bob C (1): Document: Add PCD flexible format value EBNF in Fdf. 3_edk_ii_fdf_file_format/32_fdf_definition.md | 25 + 3_edk_ii_fdf_file_format

Re: [edk2] EDK II Specifications for edk2-stable201903 tag

2019-03-06 Thread Feng, Bob C
: Thursday, March 7, 2019 12:59 AM To: Gao, Liming ; Feng, Bob C ; edk2-devel@lists.01.org; Kinney, Michael D Subject: EDK II Specifications for edk2-stable201903 tag Hi Liming and Bob, I see several EDK II specification updates. I do not see consistent updates to the Revision History

[edk2] [Patch V2 0/1] Document: Update FDF spec to remove EDK and IPF related contents

2019-03-06 Thread Feng, Bob C
V2: Update the table of content and update history. Update commit message and fixed a bug. Feng, Bob C (1): Document: Update FDF spec to remove EDK and IPF related contents 1_introduction/11_overview.md | 22

[edk2] [Patch 1/1] Document: Update FDF spec to remove EDK and IPF related contents

2019-03-06 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK and IPF related contents inf Fdf spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md

[edk2] [Patch V2 1/1] Document: Update DSC spec to remove EDK and IPF related contents

2019-03-06 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK and IPF related contents inf Dsc spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md

[edk2] [Patch V2 0/1] Document: Update DSC spec to remove EDK and IPF related contents

2019-03-06 Thread Feng, Bob C
V2: Update the table of contents and the update history. Feng, Bob C (1): Document: Update DSC spec to remove EDK and IPF related contents 1_introduction/11_overview.md | 14 -- 2_dsc_overview/{211_

[edk2] [Patch V2 1/1] Document: Update Inf spec to remove EDK and IPF related contents

2019-03-06 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK and IPF related contents Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md

[edk2] [Patch V2 0/1] Document: Update Inf spec to remove EDK and IPF related contents

2019-03-06 Thread Feng, Bob C
V2: Update the table of content and update history. Update commit message and fixed a bug. Feng, Bob C (1): Document: Update Inf spec to remove EDK related contents 1_introduction/11_overview.md | 4 ++-- 2_inf_overview

Re: [edk2] [Patch] Document: Update Inf spec to remove EDK related contents

2019-03-06 Thread Feng, Bob C
Wednesday, March 6, 2019 4:02 PM To: Feng, Bob C ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: RE: [edk2] [Patch] Document: Update Inf spec to remove EDK related contents Bob: I have some comments. 1) Please update the commit message. The change is to remove EDK and IPF related co

[edk2] [Patch V2 0/1] Document: Update DEC spec to remove EDK related contents

2019-03-05 Thread Feng, Bob C
V2: Update top level README to add update history. Feng, Bob C (1): Document: Update DEC spec to remove EDK related contents 2_dec_file_overview/210_pcd_usage.md | 4 +--- 2_dec_file_overview/25_[includes]_usage.md | 6 +- 2_dec_file_overview/26_[guids

[edk2] [Patch V2 1/1] Document: Update DEC spec to remove EDK related contents

2019-03-05 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents from DEC spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 2_dec_file_overview/210_pcd_usage.md | 4 +---

[edk2] [Patch V2 1/1] Document: Update Build spec to remove EDK related contents

2019-03-05 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents from Build spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 10_post-build_imagegen_stage_-_flash/103_build_intermediate_images.md | 3

[edk2] [Patch V2 0/1] Document: Update Build spec to remove EDK related

2019-03-05 Thread Feng, Bob C
V2: Update the top level README to add the update history. Feng, Bob C (1): Document: Update Build spec to remove EDK related contents 10_post-build_imagegen_stage_-_flash/103_build_intermediate_images.md | 3 +-- 12_build_changes_and_customizations/README.md | 4

Re: [edk2] [PATCH] BaseTools:Guid.xref will change after increment build

2019-03-05 Thread Feng, Bob C
Hi Zhiju, Since you changed a set() to a list, I think you need to check if the item is already in the list before appending it. Thanks, Bob -Original Message- From: Fan, ZhijuX Sent: Tuesday, March 5, 2019 4:48 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject

[edk2] [Patch] Document: Add PCD flexible format value EBNF in Fdf.

2019-03-05 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=541 This patch is to add flexible PCD value format EBNF into Fdf spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu --- 3_edk_ii_fdf_file_format/32_fdf_definition.md | 25

[edk2] [Patch] Document: Update Build spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents from Build spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- .../103_build_intermediate_images.md | 3 +-

[edk2] [Patch] Document: Update DSC spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents inf Dsc spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md | 14 +-- ...=>

Re: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-03-04 Thread Feng, Bob C
Hi, This patch is to fix the a regression issue introduced by python3 patch set. I'd like to push this patch for Q1 stable tag. Would you approve it? Thanks, Bob -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, Bob C Sent: Monday, March

[edk2] [Patch] Document: Update DEC spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents from DEC spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 2_dec_file_overview/210_pcd_usage.md | 4 +---

[edk2] [Patch] Document: Update FDF spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents inf Fdf spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md | 22 +-

[edk2] [Patch] Document: Update Inf spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md | 2 +- 2_inf_overview/210_[ppis]_section.md

Re: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-03-03 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, March 1, 2019 10:52 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed The reason for this problem is that the file

Re: [edk2] [Patch] Document: Update Dsc spec to all empty value for HIIPcd

2019-02-28 Thread Feng, Bob C
Please ignore this mail. Sorry. -Original Message- From: Feng, Bob C Sent: Friday, March 1, 2019 10:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: RE: [Patch] Document: Update Dsc spec to all empty value for HIIPcd Would you give the reviewed-by? -Original Message

Re: [edk2] [Patch] Document: Update Dsc spec to all empty value for HIIPcd

2019-02-28 Thread Feng, Bob C
Would you give the reviewed-by? -Original Message- From: Feng, Bob C Sent: Thursday, February 28, 2019 10:11 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming Subject: [Patch] Document: Update Dsc spec to all empty value for HIIPcd https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2] [PATCH] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-02-28 Thread Feng, Bob C
Zhiju, If the file is binary, it's no need to do more process since this function is to get "include" information. Thanks, Bob -Original Message- From: Fan, ZhijuX Sent: Friday, March 1, 2019 9:33 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subje

Re: [edk2] [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-28 Thread Feng, Bob C
Hi Phil, Your suggested code is good but it still print the call stack. I changed it a little, it only print the error message now. Thanks, Bob -Original Message- From: Feng, Bob C Sent: Thursday, February 28, 2019 9:19 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming

[edk2] [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-28 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1509 Add python3-distutils Ubuntu package checking. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Tests/RunTests.py | 7 +++ 1 file changed, 7 insertions(+) diff --git

[edk2] [Patch] Document: Update the INF spec about [Depex] section

2019-02-27 Thread Feng, Bob C
::= {"BEFORE"} {"AFTER"} should be ::= [{"BEFORE"} {"AFTER"}] The "BEFORE" or "AFTER" is optional key words in current implementation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- 3_edk_ii_inf_file_format/314_[depex]_sections.md | 2 +-

[edk2] [Patch] Document: Update Dsc spec to all empty value for HIIPcd

2019-02-27 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1466 Update Dsc spec to all empty value for HIIPcd. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- 2_dsc_overview/29_pcd_sections.md| 4 ++--

Re: [edk2] [Patch] Revert "BaseTools:BaseTools supports to the driver combination."

2019-02-27 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, February 25, 2019 8:15 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Revert "BaseTools:BaseTools supports to the driver combination." This

[edk2] [Patch V2] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1509 V2: Remove OS/Package specific words. Print the error info which is from python error message. Add python3-distutils Ubuntu package checking. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Feng, Bob C
-Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Wednesday, February 27, 2019 4:26 PM To: Feng, Bob C Cc: Ard Biesheuvel ; edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking On Wed, Feb 27, 2019

Re: [edk2] [PATCH V2] BaseTools:PackageDocumentTools import lib error occurs.

2019-02-26 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Monday, February 25, 2019 1:13 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH V2] BaseTools:PackageDocumentTools import lib error occurs. Steps: 1. Download edk2 tree 2. Build

Re: [edk2] [PATCH] BaseTools:The BOM character is processed when python reads a file

2019-02-26 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, February 26, 2019 2:58 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:The BOM character is processed when python reads a file When python3 reads an XML file

Re: [edk2] [PATCH] Convert PosixLike scripts to sh, reduce duplication and fix some bugs

2019-02-25 Thread Feng, Bob C
Hi Rebecca, I like the change of moving duplicated code into common files and the bug fix looks good. I tested this patch on our CI system, it break the build on MacOS. There is no realpath command on MacOs shell. For the patch itself, it need to pass the check of

Re: [edk2] [PATCH] BaseTools:PackageDocumentTools import lib error occurs.

2019-02-25 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, February 22, 2019 2:14 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:PackageDocumentTools import lib error occurs. Steps: 1. Download edk2 tree 2. Build

[edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-25 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1509 Add python3-distutils Ubuntu package checking. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Tests/RunTests.py | 14 ++ 1 file changed, 14 insertions(+) diff --git

[edk2] [Patch 2/2] BaseTools: Fix a Eot issue.

2019-02-25 Thread Feng, Bob C
FirmwareVolume.UnDispatchedFfsDict is mutated during iteration, convert the FirmwareVolume.UnDispatchedFfsDict.keys() to a new list to resolve this problem. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2] [Patch 1/2] BaseTools: Eot failed when enable python3

2019-02-25 Thread Feng, Bob C
The Eot will report error when python3 enabled. We replaced sdict with collections.OrderedDict in python3 patch set, but the sdict implement "append" method which is not implemented in collections.OrderedDict. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc:

[edk2] [Patch V2] BaseTools: Add parameter check for the AsciiStringToUint64

2019-02-23 Thread Feng, Bob C
If the input parameter AsciiString length is greater than 255, the GenFv will hang. This patch is to fix this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/C/Common/ParseInf.c | 2 +- 1 file changed, 1 insertion(+),

Re: [edk2] [Patch] BaseTools: Enable component override functionality

2019-02-23 Thread Feng, Bob C
, February 23, 2019 6:06 AM To: Feng, Bob C ; edk2-devel@lists.01.org Cc: Carsey, Jaben ; Gao, Liming Subject: RE: [edk2] [Patch] BaseTools: Enable component override functionality Bob, Do you know if DSC specification has been updated to document this new behavior? If not, it should be updated

[edk2] [Patch] BaseTools: Add parameter check for the AsciiStringToUint64

2019-02-22 Thread Feng, Bob C
If the input parameter AsciiString length is greater than 255, the GenFv will hang. This patch is to fix this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/C/Common/ParseInf.c | 4 ++-- 1 file changed, 2

Re: [edk2] [PATCH V2] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED.

2019-02-21 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Yao, Jiewen Sent: Thursday, February 21, 2019 9:38 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [PATCH V2] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED. https

[edk2] [Patch V2] BaseTools: Correct the value assignment for StructurePcd

2019-02-21 Thread Feng, Bob C
This patch is to fix the code bug in StructurePcd overall value assignment logic. If a Pcd Array size is fixed but the size of actual value in Dsc or Dec is bigger than the Pcd array size, the tool will report error about such setting and stop build. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH] BaseTools:Some build generated files content are not ordered on linux

2019-02-20 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, February 21, 2019 1:18 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Some build generated files content are not ordered on linux If the WORKSPACE environment

Re: [edk2] [PATCH] BaseTools:Build fail if define [DEPEX] in library inf

2019-02-20 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, February 21, 2019 9:34 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:Build fail if define [DEPEX] in library inf When define [DEPEX] in lib inf to build, it will fail

[edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-20 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1540 This issue in introduced by commit d943b0c339fe3d35ffdf9f580ccb7a55915c6854 To convert bytes to string, we need to use bytes.decode() instead of using str(bytes). If the source file is not a txt file, ignore that file.

[edk2] [Patch] BaseTool: Fixed incremental rebuild issue.

2019-02-20 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1540 This issue in introduced by commit d943b0c339fe3d35ffdf9f580ccb7a55915c6854 To convert bytes to string, we need to use bytes.decode() instead of using str(bytes) Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob

Re: [edk2] [PATCH] BaseTools:PCD value error in structure pcd sku case.

2019-02-19 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Monday, February 18, 2019 5:53 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:PCD value error in structure pcd sku case. Defined 2 PCDs(Test4 & Test401) and 2 SKUs(DEF

[edk2] [Patch V2] BaseTools: replace Sdict with OrderedDict in UPT

2019-02-19 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1504 V2: import OrderredDict as Sdict in Misc.py instead updating all the py files. Sdict class is removed on the commit 174a9d3cc8f74f7a731ac5f16ce6864c8eb359ec but there are still some py files import it. This patch is to use

[edk2] [Patch] BaseTools: replace Sdict with OrderedDict in UPT

2019-02-19 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1504 Sdict class is removed on the commit 174a9d3cc8f74f7a731ac5f16ce6864c8eb359ec but there are still some py files import it. This patch is to use collections.OrderedDict to replace Sdict. Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH] BaseTools:Fixed build failure when specifying multiple BUILDTARGET

2019-02-19 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, February 19, 2019 6:56 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Fixed build failure when specifying multiple BUILDTARGET With Python3, the dict.value

Re: [edk2] [Patch] BaseTools: Remove unused txt files

2019-02-19 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Friday, February 15, 2019 10:32 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Remove unused txt files externals.txt is to refer to the

[edk2] [Patch] BaseTools: Fix a bug about Structure PCD

2019-02-19 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1535 If there is Hii Structure Pcd, build will fail, root cause is that there is an incorrect variable access method used in code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

Re: [edk2] [PATCH] BaseTools:Fix a ECC issue

2019-02-18 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Monday, February 18, 2019 2:24 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Fix a ECC issue BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1522 A property error

Re: [edk2] [Patch] BaseTools: Correct the value assignment for StructurePcd

2019-02-18 Thread Feng, Bob C
Hi Felix, Good point. I'll update the patch. Thanks, Bob -Original Message- From: Felix Polyudov [mailto:fel...@ami.com] Sent: Tuesday, February 19, 2019 12:57 AM To: Feng, Bob C ; edk2-devel@lists.01.org Cc: Gao, Liming Subject: RE: [edk2] [Patch] BaseTools: Correct the value

[edk2] [Patch] BaseTools: Fixed a bug in Vpd handling

2019-02-18 Thread Feng, Bob C
If there are multiple sku used in a platform and gEfiMdeModulePkgTokenSpaceGuid.PcdNvStoreDefaultValueBuffer PCD is used, build will fail. This is a regression issue introduced by the commit: 5695877ec8f636bd4ad873ef50eceb9da7a0f382 which only update the Vpd offset for default SKU but not other

[edk2] [Patch] BaseTools: Fix a ParseDevPathValue function issue.

2019-02-16 Thread Feng, Bob C
In ParseDevPathValue, the binary data need to convert to string for python3 and python2 compatiblity. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Common/Misc.py | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function

2019-02-16 Thread Feng, Bob C
MaxSizeUserSet is missing in Pcd deepcopy function. This patch is to add it back to Pcd deepcopy function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 1 + 1 file changed, 1

[edk2] [Patch] BaseTools: Correct the value assignment for StructurePcd

2019-02-15 Thread Feng, Bob C
This patch is to fix the code bug in StructurePcd overall value assignment logic. If a Pcd Array size is fixed but the size of actual value in Dsc or Dec is bigger than the Pcd array size, the tool only copy the data as same as that Pcd Array size. Contributed-under: TianoCore Contribution

[edk2] [Patch] BaseTools: Fixed a code bug for Pcd Array.

2019-02-15 Thread Feng, Bob C
For example, PCD gUefiOvmfPkgTokenSpaceGuid.Test001 datatype is Array: TEST1[2] and the filed TEST1UINT64ARRAY in TEST1 is also an array: UINT64 TEST1UINT64ARRAY[2]; Then the following filed assignment in DSC will cause build failure.

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-14 Thread Feng, Bob C
mailto:ler...@redhat.com] Sent: Thursday, February 14, 2019 11:32 PM To: Feng, Bob C Cc: Gao, Liming ; Bi, Dandan ; Carsey, Jaben ; edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function Hi Bob, On 02/14/19 03:51, Feng, Bob C wrote: > Hi Laszlo,

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-13 Thread Feng, Bob C
019 10:02 PM To: Gao, Liming ; Feng, Bob C ; Bi, Dandan Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function On 02/12/19 14:33, Gao, Liming wrote: > Laszlo: > To install python3-distutils should resolve this issue. I expect BaseTools >

[edk2] [Patch 3/3] BaseTools: Fix a bug about PcdArray

2019-02-03 Thread Feng, Bob C
This patch is going to fix the bug that there is an incorrect variable access method. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [Patch 1/3] BaseTools: Fixed a build report issue.

2019-02-03 Thread Feng, Bob C
Generate report fail when -Y EXECUTION_ORDER in build command. This patch is going to fix this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Eot/EotMain.py | 3 ++-

[edk2] [Patch 2/3] BaseTools: Fixed an issue about StructurePcd

2019-02-03 Thread Feng, Bob C
If use a structure pcd in fdf, build tool crash This is a regression issue introduced by py3 patch set. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 +- 1 file changed, 1

[edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-02 Thread Feng, Bob C
library. Feng, Bob C (3): BaseTools: Implement splitquoted function in Build tool BaseTools: Implement splitquoted function in UPT BaseTools: unit test for splitquoted function BaseTools/Source/Python/AutoGen/UniClassObject.py | 50

[edk2] [Patch 3/3] BaseTools: unit test for splitquoted function

2019-02-02 Thread Feng, Bob C
unit test for splitquoted function Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Tests/TestStringSplit.py | 38 ++ 1 file changed, 38 insertions(+) diff --git

[edk2] [Patch 1/3] BaseTools: Implement splitquoted function in Build tool

2019-02-02 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1509 On some Linux environment, there may be no distutils.util library for python3 that will cause build tool crash. This patch implement distutils.util.split_quoted in BaseTools so that the build tool will be independent with distutils.util library.

[edk2] [Patch 2/3] BaseTools: Implement splitquoted function in UPT

2019-02-02 Thread Feng, Bob C
On some Linux environment, there may be no distutils.util library for python3 that will cause UPT crash. This patch implement distutils.util.split_quoted in BaseTools so that the UPT tool will be independent with distutils.util library. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [Patch] BaseTools: Correct the PcdDatabase Info in AutoGen

2019-02-01 Thread Feng, Bob C
From: Zhaozh1x PcdDriver AutoGen code shows PCD DB format for debug purpose only. But now, AutoGen code doesn't exactly match the generated PCD DB binary file. It brings the complex for Pcd driver debug. This patch is going to fix that issue. Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch] BaseTools: Correct the error message for UPT

2019-02-01 Thread Feng, Bob C
This patch is going to correct the error message for UPT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hess Chen Cc: Liming Gao --- .../Python/UPT/Library/UniClassObject.py | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

Re: [edk2] [PATCH V2] BaseTools: PCD value incorrect in structure pcd sku case.

2019-02-01 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, February 1, 2019 3:41 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH V2] BaseTools: PCD value incorrect in structure pcd sku case. Defined 2 PCDs(Test4 & Test401) and 2

Re: [edk2] [PATCH] BaseTools:StructurePCD value display incorrect in "Not used" section.

2019-02-01 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, February 1, 2019 10:11 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:StructurePCD value display incorrect in "Not used" section. StructurePCD val

Re: [edk2] [PATCH] BaseTools/ECC: Add a new type of exception

2019-02-01 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, Bob C Sent: Wednesday, January 30, 2019 4:49 PM To: edk2-devel@lists.01.org Cc: Chen, Hess Subject: [edk2] [PATCH] BaseTools/ECC: Add a new type of exception From

[edk2] [Patch] BaseTools: Fix the build report issue about Structure PCD

2019-02-01 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1472 build report use incorrect method to parse DynamicDefault/DynamicExDefault and DynamicVpd/DynamicExVpd structure Pcd value. This patch is to fix this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc:

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-01-31 Thread Feng, Bob C
I have pushed py3 patch set to edk2 master. Thanks, Bob -Original Message- From: Gao, Liming Sent: Thursday, January 31, 2019 4:24 PM To: Feng, Bob C ; Laszlo Ersek Cc: edk2-devel@lists.01.org Subject: RE: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set Bob: I have

[edk2] [Patch] BaseTools: Fixed incorrect line number in PcdValueInit.c

2019-01-30 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1435 This patch is going to fix the issue of incorrect line number in PcdValueInit.c Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/MetaFileTable.py | 2 +-

[edk2] [PATCH] BaseTools/ECC: Add a new type of exception

2019-01-30 Thread Feng, Bob C
From: Hess Chen Add a new type of exception for function body checkpoint. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hess Chen --- BaseTools/Source/Python/Ecc/c.py | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-01-29 Thread Feng, Bob C
-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, January 29, 2019 9:07 PM > To: Feng, Bob C > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch > set > > Hi Bob, > > On 01/29

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-01-29 Thread Feng, Bob C
Hi Laszlo, Thank you very much for the testing. Thanks! Bob -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, January 29, 2019 9:07 PM To: Feng, Bob C Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

  1   2   3   >