Re: [edk2] aarch64-linux-gnu-gcc.exe: error due to loss ‘/’in code path in in Jenkins server

2019-04-03 Thread Gao, Liming
I mean to manually trig build in Jenkins server and see what happen. Thanks Liming From: wang xiaofeng [mailto:winggundu...@163.com] Sent: Wednesday, April 3, 2019 8:16 PM To: Gao, Liming Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; leif.lindh...@linaro.org Subject: Re:Re: [edk2

Re: [edk2] aarch64-linux-gnu-gcc.exe: error due to loss ‘/’in code path in in Jenkins server

2019-04-03 Thread Gao, Liming
Are your local server the same environment to Jenkins server? Can you login in Jenkins sever and verify gcc tool? Thanks Liming From: wang xiaofeng [mailto:winggundu...@163.com] Sent: Wednesday, April 3, 2019 3:55 PM To: Gao, Liming ; edk2-devel@lists.01.org; ard.biesheu...@linaro.org

Re: [edk2] [PATCH 1/2] MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c

2019-04-03 Thread Gao, Liming
Can you also clean up BaseLib to remove the support of INTEL tool chain? > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, April 3, 2019 4:30 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH 1/2] MdePkg/BaseI

Re: [edk2] [Patch V2] BaseTools: Fixed issue in MultiThread Genfds function

2019-04-02 Thread Gao, Liming
Bob: Thanks for your updating. If user only update BaseTools, and don't update Conf\build_rule.txt. What problem will happen? Thanks Liming > -Original Message- > From: Feng, Bob C > Sent: Wednesday, April 3, 2019 10:17 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob

Re: [edk2] [Patch] BaseTools:Enable the /MP option of MSVC compiler

2019-04-02 Thread Gao, Liming
Liming > -Original Message- > From: Feng, Bob C > Sent: Wednesday, April 3, 2019 10:12 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Fan, ZhijuX > Subject: RE: [Patch] BaseTools:Enable the /MP option of MSVC compiler > > Liming, > > I add the perfo

Re: [edk2] [PATCH V7 00/17] Add new APIs DebugVPrint for DebugLib

2019-03-31 Thread Gao, Liming
Reviewed-by: Liming Gao for this serial. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Zhichao Gao >Sent: Monday, April 01, 2019 9:08 AM >To: edk2-devel@lists.01.org >Cc: Bret Barkelew ; Wu, Hao A >; Justen, Jordan L ;

Re: [edk2] [PATCH V6 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-31 Thread Gao, Liming
Zhichao: DebugAssert() implementation should be DeadLoop() or Break() bases on PCD gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask when PPI is not loaded. Thanks Liming >-Original Message- >From: Gao, Zhichao >Sent: Monday, April 01, 2019 7:50 AM >To: edk2-devel@lists.01.

Re: [edk2] [Patch] BaseTools:Enable the /MP option of MSVC compiler

2019-03-29 Thread Gao, Liming
with this option. Thanks Liming > -Original Message- > From: Feng, Bob C > Sent: Friday, March 29, 2019 8:30 PM > To: edk2-devel@lists.01.org > Cc: Fan, ZhijuX ; Feng, Bob C ; > Gao, Liming > Subject: [Patch] BaseTools:Enable the /MP option of MSVC compiler > >

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Gao, Liming
Yes. Please submit one BZ for it. > -Original Message- > From: Feng, Bob C > Sent: Friday, March 29, 2019 8:40 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Subject: RE: [Patch] BaseTools: Fixed issue in MultiThread Genfds function > > That will impact the

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Gao, Liming
$(FFS_OUTPUT_DIR)\$(MODULE_GUID)SEC2.1.1.1.pe32 $(DEBUG_DIR)\LogoDxe.efi Thanks Liming > -Original Message- > From: Feng, Bob C > Sent: Friday, March 29, 2019 8:00 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Subject: RE: [Patch] BaseTools: Fixed issue in MultiThread

Re: [edk2] [PATCH V3] BaseTools:Trim will trig exception when input asl UTF8 format file

2019-03-29 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Thursday, March 28, 2019 11:21 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Feng, Bob C > Subject: [edk2][PATCH V3] BaseTools:Trim will trig exception when input asl > UTF8 form

Re: [edk2] [PATCH V2 0/2] Change reset logic related on capsule

2019-03-29 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Gao, Zhichao > Sent: Friday, March 22, 2019 11:07 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; Ni, > Ray ; Zeng, Star > ; Gao, Liming ; Ard Biesheuvel > > Subject: [PATCH V2 0/2]

Re: [edk2] [PATCH v3 00/12] Remove .S files for IA32 and X64 arch in MdePkg and UefiCpuPkg

2019-03-29 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Friday, March 29, 2019 3:28 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; Dong, Eric ; Ni, Ray > > Subject: [PATCH v3 00/12] Remove .S files for IA3

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Gao, Liming
Bob: Could you list the more information on why update build_rule.txt? > -Original Message- > From: Feng, Bob C > Sent: Friday, March 29, 2019 7:07 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Fixed issue in MultiThre

Re: [edk2] [PATCH 00/10] Remove .S files for IA32 and X64 arch in MdePkg and UefiCpuPkg

2019-03-28 Thread Gao, Liming
>-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Shenglei Zhang >Sent: Thursday, March 07, 2019 10:30 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Laszlo Ersek >; Dong, Eric ; Gao, Liming > >Subject: [edk2] [P

Re: [edk2] [PATCH V2] BaseTools:Trim will trig exception when input asl UTF8 format file

2019-03-27 Thread Gao, Liming
What error message is reported? >-Original Message- >From: Fan, ZhijuX >Sent: Thursday, March 28, 2019 10:13 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Feng, Bob C >Subject: [edk2][PATCH V2] BaseTools:Trim will trig exception when input asl >UTF8 fo

Re: [edk2] [PATCH V4 12/17] IntelFramworkModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-27 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Gao, Zhichao >Sent: Thursday, March 21, 2019 10:05 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Sean Brogan >; Michael Turner >; Bret Barkelew > >Subject: [PATCH V4 12/17] >IntelFramworkModulePkg/PeiDx

Re: [edk2] [PATCH V4 15/17] MdeModulePkg: Add a PEIM to install Debug PPI

2019-03-27 Thread Gao, Liming
Zhichao: One .c file is enough for this PEIM. You can implement all in one C file. Thanks Liming >-Original Message- >From: Gao, Zhichao >Sent: Thursday, March 21, 2019 10:05 PM >To: edk2-devel@lists.01.org >Cc: Wang, Jian J ; Wu, Hao A ; >Ni, Ray ; Zeng, Star ; G

Re: [edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-27 Thread Gao, Liming
as the specific prefix name to avoid the name confliction. 4) What test is done for this library instance? Thanks Liming >-Original Message- >From: Gao, Zhichao >Sent: Thursday, March 21, 2019 10:05 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Wang, Jian J >; W

Re: [edk2] [Patch] BaseTool: Fixed an issue of Structure PCD

2019-03-26 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Tuesday, March 26, 2019 5:34 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTool: Fixed an issue of Structure PCD > > https://bugzilla.tianocore.

Re: [edk2] [edk2-announce] [RFC] TianoCore Design Meetings

2019-03-25 Thread Gao, Liming
Stephano: April 5th (Friday in PRC) is Chinese public holiday. Could we place one day ahead, how about April 3th (PST)? Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > stephano > Sent: Saturday, March 23, 2019 8:29 AM > To:

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror

2019-03-25 Thread Gao, Liming
This change is good. Reviewed-by: Liming Gao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, March 25, 2019 7:50 PM > To: Rebecca Cran ; edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: Re: [edk2] [PATCH] Fix links in Maintain

Re: [edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-25 Thread Gao, Liming
gt;From: Gao, Zhichao >Sent: Friday, March 22, 2019 11:07 AM >To: edk2-devel@lists.01.org >Cc: Wang, Jian J ; Wu, Hao A ; >Ni, Ray ; Zeng, Star ; Gao, Liming >; Ard Biesheuvel >Subject: [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache >flush function >

Re: [edk2] [PATCH] PcAtChipsetPkg/PcatChipsetPkg.dsc: Add a driver to build

2019-03-24 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Zhichao Gao >Sent: Thursday, March 21, 2019 10:45 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [PATCH] PcAtChipsetPkg/Pc

Re: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dsc: Add a driver to build

2019-03-24 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Gao, Zhichao >Sent: Thursday, March 21, 2019 10:44 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ray ; Chaganty, Rangasai V >; Gao, Liming >Subject: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dsc: Add a driver t

Re: [edk2] [PATCH v2 0/3] Improve performance of boundary validation in MakeTable()

2019-03-22 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >shenglei >Sent: Thursday, March 21, 2019 2:32 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [edk2] [PATCH v2

Re: [edk2] [PATCH 2/3] Maintainers.txt: Remove EdkCompatibilityPkg information

2019-03-22 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Shenglei Zhang >Sent: Friday, March 22, 2019 10:35 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Laszlo Ersek > >Subject: [edk2] [PATCH 2/3] Maintainers.txt:

Re: [edk2] [PATCH 3/3] EdkCompatibilityPkg: Remove EdkCompatibilityPkg

2019-03-22 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhang, Shenglei >Sent: Friday, March 22, 2019 10:35 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [PATCH 3/3] EdkCompatibilityPkg: Remove EdkCompatibilityPkg > >If this patch contains

Re: [edk2] Debugging why Build Rebuilds Something

2019-03-21 Thread Gao, Liming
Could you help check the timestamp of AutoGen files in OpenSslLib output directory? After the first build, copy OpenSslLib output directory to another directory After the second build, compare the output directory between two builds, please check whether there is the difference for

Re: [edk2] [PATCH V3 01/17] MdePkg/DebugLib.h: Add new APIs for DebugLib

2019-03-21 Thread Gao, Liming
Reviewed-by: Liming Gao for MdePkg. >-Original Message- >From: Gao, Zhichao >Sent: Tuesday, March 19, 2019 11:26 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >; Sean Brogan ; >Michael Turner ; Bret Barkelew > >Subject: [PATCH V3 01/17]

Re: [edk2] [PATCH V3 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-21 Thread Gao, Liming
Liming >-Original Message- >From: Gao, Zhichao >Sent: Tuesday, March 19, 2019 11:26 PM >To: edk2-devel@lists.01.org >Cc: Wang, Jian J ; Wu, Hao A ; >Ni, Ray ; Zeng, Star ; Gao, Liming >; Sean Brogan ; >Michael Turner ; Bret Barkelew > >Subject: [PATCH V3 13/17] >MdeM

Re: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib

2019-03-19 Thread Gao, Liming
that the developer bases on current process, pass PatchCheck and code review. Thanks Liming >-Original Message- >From: Justen, Jordan L >Sent: Tuesday, March 19, 2019 2:34 AM >To: Gao, Liming ; Gao, Zhichao >; edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Bret Barkelew >; Michael

Re: [edk2] [Patch 1/1] Document: Update FDF spec to remove EDK and IPF related contents

2019-03-19 Thread Gao, Liming
;To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >; Carsey, Jaben >Subject: [Patch 1/1] Document: Update FDF spec to remove EDK and IPF >related contents > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 > >Remove EDK and IPF related contents inf Fd

Re: [edk2] [Patch V2 1/1] Document: Update Inf spec to remove EDK and IPF related contents

2019-03-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, March 06, 2019 4:54 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >; Carsey, Jaben >Subject: [Patch V2 1/1] Document: Update Inf spec to remove EDK and IPF >relat

Re: [edk2] [Patch] BaseTools: Remove EDK_GLOBAL related logic

2019-03-19 Thread Gao, Liming
-devel-boun...@lists.01.org] On Behalf Of >Feng, Bob C >Sent: Saturday, March 16, 2019 10:35 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: Remove EDK_GLOBAL related logic > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350 > &g

Re: [edk2] [Patch] BaseTools: Remove the logic SourceOverridePath

2019-03-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Friday, March 15, 2019 11:18 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Remove the logic SourceOverridePath > >BZ: https://bugzilla.tianocore.

Re: [edk2] [Patch] BaseTools: Remove EDKI related logic from Trim tool

2019-03-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Friday, March 15, 2019 11:22 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Remove EDKI related logic from Trim tool > >BZ: https://bugzilla.tiano

Re: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib

2019-03-18 Thread Gao, Liming
-devel@lists.01.org > Cc: Kinney, Michael D ; Bret Barkelew > ; Michael Turner > ; Gao, Liming > Subject: RE: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api > DebugVPrint for DebugLib > > On 2019-03-17 17:14:40, Gao, Zhichao wrote: > > > -Original

Re: [edk2] [patch] BaseTools: Add missing license and copyright info

2019-03-17 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Friday, March 15, 2019 1:23 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming ; > Kinney, Michael D > Subject: [patch] BaseTools: Add missing license and copyright info &g

Re: [edk2] [Patch] SecurityPkg/OpalPassword: Fix incorrect line ending issue.

2019-03-17 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric >Dong >Sent: Friday, March 01, 2019 10:34 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] SecurityPkg/OpalPasswor

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

2019-03-14 Thread Gao, Liming
those nasm files only for INTEL compiler. Thanks Liming From: af...@apple.com [mailto:af...@apple.com] Sent: Friday, March 8, 2019 4:15 PM To: Kinney, Michael D Cc: Yao, Jiewen ; Gao, Liming ; edk2-devel-01 Subject: Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly

Re: [edk2] [PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type

2019-03-14 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, March 12, 2019 8:45 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type > >

Re: [edk2] F29 Build Issue.

2019-03-14 Thread Gao, Liming
This is seemly deprecated https://github.com/tianocore/buildtools-BaseTools. We should use BaseTools in https://github.com/tianocore/edk2. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, March 14, 2019 2:34

Re: [edk2] [PATCH] BaseTools: Enable compiler cache support in edk2 build

2019-03-10 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Shi, Steven >Sent: Wednesday, January 30, 2019 12:18 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [PATCH] BaseTools: Enable compiler cache support in edk2 build > >https://bugzilla.tianocore.

[edk2] [edk2-announce] EDK II Stable Tag release edk2-stable201903 completed

2019-03-08 Thread Gao, Liming
Hi, all The tag edk2-stable201903 has been created. https://github.com/tianocore/edk2/releases/tag/edk2-stable201903 git clone -b edk2-stable201903 https://github.com/tianocore/edk2.git The tag edk2-stable201903 has been added into the main EDK II Wiki page.

Re: [edk2] [PATCH v2 0/2] Fix bugs in HiiDatabase driver

2019-03-08 Thread Gao, Liming
to:ler...@redhat.com] > Sent: Friday, March 8, 2019 4:51 AM > To: Gao, Liming ; Wang, Jian J ; > Ni, Ray ; edk2-devel@lists.01.org; > Kinney, Michael D ; af...@apple.com; Leif > Lindholm > Cc: Cetola, Stephano > Subject: Re: [edk2] [PATCH v2 0/2] Fix bugs in HiiDatabase dr

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Gao, Liming
rdson, Brian > ; Gao, Liming ; > edk2-devel@lists.01.org > Subject: Re: [edk2] [edk2-announce] Hard Feature Freeze starts from > 2019-03-01(00:00:00 UTC-8) for edk2-stable201903 > > On 03/08/19 15:30, Tian, Hot wrote: > > For this specific question from Laszlo, I do not hav

[edk2] [edk2-announce] EDK II Stable Tag edk2-stable201903 will be created based on commit 89910a

2019-03-08 Thread Gao, Liming
Hi, all Sorry for a little late announce. I wait for some time to collect the feedback on the CEV fix. There is no rejection on CVE fix. So, I add it to this tag release. I will create edk2-stable201903 based on current edk2 trunk (commit 89910a MdeModulePkg/HiiImage: Fix stack overflow when

Re: [edk2] [PATCH v2 0/2] Fix bugs in HiiDatabase driver

2019-03-07 Thread Gao, Liming
This is to fix the security issue. I agree it is an import bug fix. I am OK to push it for edk2-stable201903 tag Thanks Liming > -Original Message- > From: Wang, Jian J > Sent: Thursday, March 7, 2019 7:17 PM > To: Ni, Ray ; edk2-devel@lists.01.org > Cc: Cetola, Stephan

Re: [edk2] [PATCH 0/2] Fix bugs in HiiDatabase driver

2019-03-07 Thread Gao, Liming
Please follow CVE format in https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ray Ni > Sent: Thursday, March 7, 2019 6:21 PM > To: edk2-devel@lists.01.org > Subject:

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

2019-03-06 Thread Gao, Liming
Thanks for your clarification. Now, we will focus on SetJump/LongJump() first. Thanks Liming From: af...@apple.com [mailto:af...@apple.com] Sent: Wednesday, March 6, 2019 10:45 PM To: Yao, Jiewen Cc: Kinney, Michael D ; Gao, Liming ; edk2-devel-01 Subject: Re: [edk2] [PATCH 3/3] MdePkg

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

2019-03-06 Thread Gao, Liming
Andrew: I want to keep only one implementation. If inline assembly c source is preferred, I suggest to remove its nasm implementation. Thanks Liming From: af...@apple.com [mailto:af...@apple.com] Sent: Tuesday, March 5, 2019 2:44 PM To: Gao, Liming Cc: Zhang, Shenglei ; edk2-devel-01

Re: [edk2] [Patch] Document: Add PCD flexible format value EBNF in Fdf.

2019-03-06 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Tuesday, March 5, 2019 12:16 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming ; > Zhu, Yonghong > Subject: [Patch] Document: Add PCD flexible format value EBNF i

Re: [edk2] [Patch V2 0/1] Document: Update Build spec to remove EDK related

2019-03-06 Thread Gao, Liming
sts.01.org] On Behalf Of Gao, > Liming > Sent: Wednesday, March 6, 2019 12:29 AM > To: Feng, Bob C ; edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch V2 0/1] Document: Update Build spec to remove EDK > related > > 1. 2.12 [UserExtensions] Section and ## 2.

Re: [edk2] [Patch] Document: Update DSC spec to remove EDK related contents

2019-03-06 Thread Gao, Liming
t: Monday, March 4, 2019 7:49 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming ; > Carsey, Jaben > Subject: [Patch] Document: Update DSC spec to remove EDK related contents > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 > > Remove

Re: [edk2] [Patch V2 0/1] Document: Update Build spec to remove EDK related

2019-03-06 Thread Gao, Liming
1. 2.12 [UserExtensions] Section and ## 2.11 [UserExtensions] Section are inconsistent. There are the similar issue in this patch. Please check them to make sure they are same. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [Patch V2 1/1] Document: Update DEC spec to remove EDK related contents

2019-03-06 Thread Gao, Liming
Update commit message and version info to remove EDK and IFP related contents from DEC spec. With this change, Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Tuesday, March 5, 2019 11:50 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob

Re: [edk2] [Patch] Document: Update FDF spec to remove EDK related contents

2019-03-06 Thread Gao, Liming
, March 4, 2019 7:00 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming ; > Carsey, Jaben > Subject: [Patch] Document: Update FDF spec to remove EDK related contents > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 > > Remove EDK related contents inf

Re: [edk2] [Patch] Document: Update Inf spec to remove EDK related contents

2019-03-06 Thread Gao, Liming
f Feng, > Bob C > Sent: Monday, March 4, 2019 5:52 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Gao, Liming > Subject: [edk2] [Patch] Document: Update Inf spec to remove EDK related > contents > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 &g

Re: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification before calculate CheckSum32

2019-03-05 Thread Gao, Liming
This is a bug. I agree to add it into Q1 stable tag. Thanks Liming > -Original Message- > From: Ni, Ray > Sent: Tuesday, March 5, 2019 9:35 PM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Dong, Eric ; Ni, Ray ; Chen, Chen > A > Subject: RE: [edk2] [PATCH] U

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

2019-03-05 Thread Gao, Liming
; From: af...@apple.com [mailto:af...@apple.com] > Sent: Tuesday, March 5, 2019 12:58 PM > To: Zhang, Shenglei > Cc: edk2-devel-01 ; Kinney, Michael D > ; Gao, Liming > Subject: Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline > X86 assembly code > >

Re: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-03-04 Thread Gao, Liming
This is a bug. I agree to fix it for Q1 stable tag. > -Original Message- > From: Feng, Bob C > Sent: Monday, March 4, 2019 5:02 PM > To: Gao, Liming ; Fan, ZhijuX ; > edk2-devel@lists.01.org > Cc: Feng, Bob C > Subject: RE: [edk2] [PATCH V2] BaseTools:Run packaged

Re: [edk2] [PATCH 0/3] MdePkg: Remove inline X86 assembly code

2019-03-04 Thread Gao, Liming
Shenglei: The request is for X86, IA32 and X64. Please don't change ARM or AARCH64. Thanks Liming > -Original Message- > From: Zhang, Shenglei > Sent: Monday, March 4, 2019 5:41 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subjec

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-02 Thread Gao, Liming
Ashish: This seems a feature. Now, we are in Hard Feature Freeze. So, it will not be added until edk2-stable201903 tag is created at 2019-03-08. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ashish > Singhal > Sent:

[edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-01 Thread Gao, Liming
01.org] On Behalf Of Gao, >Liming >Sent: Friday, February 22, 2019 10:26 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2- >stable201903 > >Hi, all > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-28 Thread Gao, Liming
OK. To be clear, I take your suggestion. wiki page has been updated. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 28, 2019 7:58 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [edk2-announce] S

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-27 Thread Gao, Liming
Laszlo: >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, February 28, 2019 3:54 AM >To: Gao, Liming >Cc: edk2-devel@lists.01.org >Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze s

Re: [edk2] [PATCH v2 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-27 Thread Gao, Liming
I update https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format with CVE example. Please check it. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, February 28, 2019 3:31 AM >

Re: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

2019-02-27 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, February 28, 2019 5:22 AM >To: edk2-devel-01 >Cc: Gao, Liming ; Kinney, Michael D > >Subject: [edk2] [PATCH]

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-27 Thread Gao, Liming
Laszlo: Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, February 26, 2019 7:55 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [edk2-announce] Soft

Re: [edk2] [PATCH v2 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-27 Thread Gao, Liming
Laszlo: I add my comments. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 27, 2019 4:58 PM > To: Wu, Hao A ; Gao, Liming ; > edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [PATCH

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-25 Thread Gao, Liming
/edk2-devel/2019-February/037137.html Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, > Liming > Sent: Friday, February 22, 2019 10:26 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [edk2-announce] Soft Fea

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

2019-02-25 Thread Gao, Liming
Yes. This is a bug fix. I agree to push it for Q1 release. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Tuesday, February 26, 2019 3:36 AM >To: Gao, Liming ; Rebecca Cran >; edk2-devel@lists.01.org >

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

2019-02-25 Thread Gao, Liming
I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2. Seemly, it doesn't work. So, I agree to remove it. Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Monday, February 25,

Re: [edk2] [Patch 2/2] BaseTools: Fix a Eot issue.

2019-02-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, > Bob C > Sent: Monday, February 25, 2019 5:23 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch 2/2] BaseT

Re: [edk2] [Patch 1/2] BaseTools: Eot failed when enable python3

2019-02-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Monday, February 25, 2019 5:22 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch 1/2] BaseTools: Eot failed when enable python3 > > The Eot will report er

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-23 Thread Gao, Liming
> To: Gao, Liming ; edk2-devel@lists.01.org > Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for > edk2-stable201903 > > Hi Liming, > > On 02/22/19 15:25, Gao, Liming wrote: > > Hi, all > > > > https://github.com/tianocore/tianocore.g

Re: [edk2] [Patch V2] BaseTools: Add parameter check for the AsciiStringToUint64

2019-02-23 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Saturday, February 23, 2019 5:42 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch V2] BaseTools: Add parameter check for the AsciiStringToUint64 > >

Re: [edk2] [patch edk2-wiki] Update ECC wiki page

2019-02-22 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi, > Dandan > Sent: Monday, February 18, 2019 3:36 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [patch edk2-wiki]

Re: [edk2] [Patch] BaseTools: Add parameter check for the AsciiStringToUint64

2019-02-22 Thread Gao, Liming
.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Add parameter check for the AsciiStringToUint64 > > If the input parameter AsciiString length is greater > than 255, the GenFv will hang. > > This patch is to fix this issue. > > Contributed-unde

Re: [edk2] [Patch edk2 wiki] Add new feature: WiFi Connection Manager for edk2-stable201903 in EDK-II-Release-Planning

2019-02-22 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Wang, Fan > Sent: Wednesday, February 13, 2019 11:27 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch edk2 wiki] Add new feature: WiFi Connection Manager for > edk2-stable201903 in EDK-II-Rel

[edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-22 Thread Gao, Liming
Hi, all https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning lists edk2-stable201903 tag planning. Now, we enter into Soft Feature Freeze phase. In this phase, the feature without Reviewed-by or Acked-by tags will be delayed after the upcoming stable tag. The patch

Re: [edk2] [Patch] BaseTools: Fix a bug about Structure PCD

2019-02-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, February 19, 2019 9:30 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Fix a bug about Structure PCD > >BZ: https://bugzilla.tianocore.

Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, February 20, 2019 11:22 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch V2] BaseTool: Fixed incremental rebuild issue. > >BZ: https://bugzilla.tiano

Re: [edk2] [PATCH 0/3] Add SMM CET support

2019-02-21 Thread Gao, Liming
Acked-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Jiewen Yao >Sent: Friday, February 22, 2019 12:16 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric ; Gao, Liming ; >Yao, Jiewen ; Kinney, Michael D >

Re: [edk2] [Patch edk2 Wiki] Add three features for edk2-stable201903

2019-02-21 Thread Gao, Liming
Sorry for confuse. I just realize this patch wrongly remove SMM CET support in Q1 planning. This change is not in this patch scope. I will add back it. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Liming Gao >Sent: Wednesday,

Re: [edk2] [Patch edk2 Wiki] Add ATA Security feature set support for edk2-stable201903

2019-02-21 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Thursday, February 21, 2019 2:05 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Gao, Liming > Subject: [Patch edk2 Wiki] Add ATA Security feature set support for > edk2-stable20190

Re: [edk2] [PATCH v4 0/7] ResetSystemLib changings

2019-02-20 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhichao Gao > Sent: Thursday, February 21, 2019 9:00 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH v4 0/7] Res

Re: [edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

2019-02-20 Thread Gao, Liming
Christopher: Please separate the patch per package. The patch can't cross the different packages. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Zurcher, Christopher J >Sent: Thursday, February 21, 2019 7:56 AM >To:

Re: [edk2] Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages

2019-02-20 Thread Gao, Liming
Laszlo: I mostly use local editor to edit wiki and send the patch. This way can't see the preview wiki page in web. It may cause the mistake. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Wednesday,

Re: [edk2] [PATCH v3 0/6] ResetSystemLib changings

2019-02-20 Thread Gao, Liming
age- > From: Gao, Zhichao > Sent: Wednesday, February 20, 2019 4:39 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Gao, Liming > Subject: [PATCH v3 0/6] ResetSystemLib changings > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 > Add a new API ResetSystem in

Re: [edk2] [PATCH v3 1/6] MdeModulePkg: change the function name ResetSystem

2019-02-20 Thread Gao, Liming
bruary 20, 2019 4:39 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Gao, Liming > Subject: [PATCH v3 1/6] MdeModulePkg: change the function name ResetSystem > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 > > Change the function name form ResetSystem to Ef

Re: [edk2] [PATCH] ShellPkg: add array index check for shell delay option

2019-02-20 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Gao, Zhichao > Sent: Monday, February 18, 2019 4:28 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ray > Subject: [PATCH] ShellPkg: add array index check for shell delay option > > BZ: https:

Re: [edk2] [PATCH] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED.

2019-02-20 Thread Gao, Liming
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen > Yao > Sent: Wednesday, February 20, 2019 7:55 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH] BaseTool/GenC: Fix build error when type is BA

Re: [edk2] [Patch] BaseTool: Fixed incremental rebuild issue.

2019-02-20 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Wednesday, February 20, 2019 6:09 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTool: Fixed incremental rebuild issue. > > BZ: https://bugzilla.ti

Re: [edk2] [PATCH V3] BaseTools:BaseTools supports to the driver combination.

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Tuesday, February 19, 2019 6:47 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2][PATCH V3] BaseTools:BaseTools supports to the driver > combination. > > BZ:htt

Re: [edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

2019-02-19 Thread Gao, Liming
Ray: In PI spec, TEMPORARY_RAM_SUPPORT_PPI is described as an optional PPI that is only required for platforms that may have side effects when both Temporary RAM and Permanent RAM are enabled. If a platform does not have any side effects when both Temporary RAM and Permanent RAM are

Re: [edk2] [PATCH v2 0/2] Add sanity check for FilePath device path

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian >J Wang >Sent: Tuesday, February 19, 2019 5:22 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [PATCH v2 0/2] Add sanity check for FilePath device path > >> v2: fix

Re: [edk2] [Patch] BaseTools: Fixed a code bug for Pcd Array.

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Feng, Bob C >Sent: Saturday, February 16, 2019 1:54 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: Fixed a c

Re: [edk2] [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function

2019-02-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Saturday, February 16, 2019 10:55 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function > >MaxSizeUserSet is

  1   2   3   4   5   6   7   8   9   10   >