Re: [edk2] [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GUIDs in declaration file.

2019-03-29 Thread Jin, Eric
With that Reviewed-by: Eric Jin Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Friday, March 29, 2019 7:12 AM To: edk2-devel@lists.01.org Cc: Supreeth Venkatesh ; Jin, Eric Subject: [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GUIDs in de

Re: [edk2] [edk2-test][PATCH v2] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2019-03-29 Thread Jin, Eric
Hi Supreeth, This patch can't be applied to the lasted code base SHA-1: 33022e. One patch from may already fix the issue. Please check again. Best Regards Eric -Original Message- From: edk2-devel On Behalf Of Supreeth Venkatesh Sent: Friday, March 29, 2019 7:08 AM To:

Re: [edk2] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Size in EraseBlocks() is in bytes

2019-03-22 Thread Jin, Eric
Supreeth, Thank for the rewording suggestion. Will commit the patch with accurate message. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Tuesday, March 19, 2019 3:45 AM To: Jin, Eric ; edk2-devel@lists.01.org Subject: Re: [edk2-test][Patch 1/1] uefi-sct/SctPkg

Re: [edk2] [edk2-test][Patch 1/1] uefi-sct/SctPkg:Fix flaw in BBTestCreateEventEx_Func_Sub3

2019-03-08 Thread Jin, Eric
Supreeth, Thank for the comment and add buffer layout description in committed code for better readable. Thanks. Best Regards Eric -Original Message- From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com] Sent: Friday, March 8, 2019 5:25 AM To: Jin, Eric ; edk2-devel@lists.01

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct Enable parameter in ReceiveFilters test

2019-01-17 Thread Jin, Eric
Supreeth, Yes, the MAC here is the purpose for test data only. I will add the comment to clarify it when I push the code. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Friday, January 18, 2019 5:01 AM To: Jin, Eric ; edk2-devel@lists.01.org Subject: Re: [edk2

Re: [edk2] [edk2-test][RFC] Integrating SBBR tests into SCT - A design proposal

2019-01-14 Thread Jin, Eric
nt to hear the comments from Supreeth on this baseline). Best Regards Eric -Original Message- From: Sakar Arora Sent: Friday, January 11, 2019 8:23 PM To: Jin, Eric ; Supreeth Venkatesh ; edk2-devel@lists.01.org Cc: Prasanth Pulla Subject: RE: [edk2][edk2-test][RFC] Integrating SBBR test

Re: [edk2] [edk2-test][PATCH v1 1/1] uefi-sct: Change line endings to CR LF.

2019-01-08 Thread Jin, Eric
Reviewed-by: Eric Jin -Original Message- From: Supreeth Venkatesh Sent: Thursday, December 13, 2018 5:44 AM To: edk2-devel@lists.01.org Cc: Jin, Eric ; Supreeth Venkatesh Subject: [edk2][edk2-test][PATCH v1 1/1] uefi-sct: Change line endings to CR LF. No functionality change. Change

Re: [edk2] [edk2-test][RFC] Integrating SBBR tests into SCT - A design proposal

2019-01-07 Thread Jin, Eric
and look at SBBR spec. Any input is welcome. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Tuesday, January 8, 2019 4:14 AM To: Sakar Arora ; edk2-devel@lists.01.org; Jin, Eric Cc: Prasanth Pulla Subject: RE: [edk2][edk2-test][RFC] Integrating SBBR tests into SCT

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Jin, Eric
conversion is tried on the branch until it is validated? Best Regards Eric -Original Message- From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com] Sent: Saturday, December 15, 2018 7:54 AM To: Laszlo Ersek ; Leif Lindholm ; Andrew Fish ; Kinney, Michael D Cc: edk2-devel@lists.01.o

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test

2018-12-13 Thread Jin, Eric
hange " on my side. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Thursday, December 13, 2018 5:07 AM To: Jin, Eric ; edk2-devel@lists.01.org Cc: Leif Lindholm Subject: Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Te

Re: [edk2] SCT bugzilla topic?

2018-12-10 Thread Jin, Eric
r 10, 2018 4:14 PM To: Kinney, Michael D Cc: Jin, Eric ; Supreeth Venkatesh ; edk2-devel@lists.01.org; Dong Wei Subject: Re: SCT bugzilla topic? Hi Mike, I think we're agreed on an "EDK2 Test" product with an "SCT" component. (Although that should probably be "UEFI

Re: [edk2] SCT bugzilla topic?

2018-12-09 Thread Jin, Eric
- From: Supreeth Venkatesh Sent: Tuesday, December 4, 2018 3:37 AM To: Leif Lindholm ; edk2-devel@lists.01.org Cc: Jin, Eric ; Kinney, Michael D ; Dong Wei Subject: RE: SCT bugzilla topic? Leif, Earlier, we used to use UTWG Mantis (for feature requests - https://mantis.uefi.org/mantis/view.php

Re: [edk2] [edk2-test][v2 Patch 0/3] Add VerifySignature() Test

2018-12-04 Thread Jin, Eric
Hi Laszlo, Thank for the comments. Will send out new patch series later. Best Regards Eric -Original Message- From: Laszlo Ersek Sent: Monday, December 3, 2018 9:50 PM To: Jin, Eric Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [edk2-test][v2 Patch 0/3] Add VerifySignature() Test

Re: [edk2] [edk2-test][Patch 3/3] uefi-sct/SctPkg:Add VerifySignature() Conf Test

2018-12-02 Thread Jin, Eric
Hello Supreeth, Thank you for the comments. V2 will be sent out. All clean up will be merged into the patch 1/3 with INF version update. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Saturday, December 1, 2018 6:28 AM To: Jin, Eric ; edk2-devel@lists.01.org

Re: [edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-20 Thread Jin, Eric
Please don't forget to change the copyright info when commit patch. Reviewed-by: Eric Jin -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 2:50 PM To: edk2-devel@lists.01.org; supreeth.venkat...@arm.com; Jin, Eric Cc: Lokesh B V Subject: [edk2-test][PATCH] SctPkg

Re: [edk2] [edk2-test][PATCH] SctPkg/UEFI: Fix invalid GUID value format error

2018-11-20 Thread Jin, Eric
Please don't forget to change the copyright info when commit patch. Reviewed-by: Eric Jin -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 2:50 PM To: edk2-devel@lists.01.org; supreeth.venkat...@arm.com; Jin, Eric Cc: Lokesh B V Subject: [edk2-test][PATCH] SctPkg

Re: [edk2] [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7

2018-11-20 Thread Jin, Eric
Please don't forget to change the copyright info when commit patch. Reviewed-by: Eric Jin -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 2:50 PM To: edk2-devel@lists.01.org; supreeth.venkat...@arm.com; Jin, Eric Cc: Lokesh B V Subject: [edk2-test][PATCH

Re: [edk2] [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test.

2018-11-19 Thread Jin, Eric
Add the maintainer Supreeth. Hello Sakar, Thank for the patches in this series. The common comments is: The keyword 'SBBR' exists on the FilePath or in the FileName. But 'SBBR' string or related description is not mentioned in UEFI spec at all. Could you please add more detail for the

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle state

2018-11-08 Thread Jin, Eric
. Besides above, more comments are added to describe the checkpoint intention. The Patch V3 will be sent out later. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Thursday, November 8, 2018 4:00 AM To: Jin, Eric ; edk2-devel@lists.01.org Subject: Re: [edk2-test

Re: [edk2] [edk2-test][Patch v2] uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle state

2018-11-06 Thread Jin, Eric
It is the patch v2 below. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Jin Sent: Wednesday, November 7, 2018 2:48 PM To: edk2-devel@lists.01.org Subject: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle

Re: [edk2] [edk2-test][PATCH] uefi-sct/SctPkg:Add the checkpoint of Toggle state of ReadKeyStrokeEx

2018-11-06 Thread Jin, Eric
Hi Supreeth, Thank for comment. The magic num 7 will be removed in the v2 patch. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Monday, October 15, 2018 10:18 AM To: Jin, Eric ; edk2-devel@lists.01.org Cc: Wu, Jiaxin Subject: Re: [PATCH] uefi-sct/SctPkg:Add

Re: [edk2] [PATCH] uefi-sct/SctPkg:The Lun display order issue in iSCSI device path text

2018-11-02 Thread Jin, Eric
Original Message- From: Supreeth Venkatesh Sent: Monday, October 15, 2018 10:23 AM To: Jin, Eric ; edk2-devel@lists.01.org Cc: Wu, Jiaxin Subject: Re: [PATCH] uefi-sct/SctPkg:The Lun display order issue in iSCSI device path text On 10/13/2018 05:33 PM, Eric Jin wrote: > Cc: S

Re: [edk2] [edk2-test][Patch v2] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName.

2018-11-01 Thread Jin, Eric
Supreeth, Thank you for the reminder. I correct them in the commit. Thanks. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Friday, November 2, 2018 4:23 AM To: Jin, Eric ; edk2-devel@lists.01.org Subject: Re: [edk2-test][Patch v2] uefi-sct/SctPkg:Assign 0

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Assign 0 to the tail of the HwErrRecVariableName

2018-10-31 Thread Jin, Eric
-Original Message- From: Supreeth Venkatesh Sent: Thursday, November 1, 2018 12:24 AM To: Jin, Eric ; edk2-devel@lists.01.org Cc: Wu, Jiaxin Subject: Re: [edk2-test][Patch] uefi-sct/SctPkg:Assign 0 to the tail of the HwErrRecVariableName On Wed, 2018-10-31 at 02:29 +, Jin, Eric wrote: >

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Assign 0 to the tail of the HwErrRecVariableName

2018-10-30 Thread Jin, Eric
the recovery data (HwErrRecVariableName) It is not applicable macro definition and just code logic here. What is your opinion? Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Wednesday, October 31, 2018 1:00 AM To: Jin, Eric ; edk2-devel@lists.01.org Cc: Wu, Jiaxin

Re: [edk2] [edk2-test] [PATCH 1/1] uefi-sct: Update "how to build" instructions.

2018-10-10 Thread Jin, Eric
Reviewed-by: Eric Jin Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Thursday, October 11, 2018 12:46 PM To: edk2-devel@lists.01.org Cc: Jin, Eric ; Supreeth Venkatesh Subject: [edk2-test] [PATCH 1/1] uefi-sct: Update "how to build" instructions. Up

[edk2] [edk2-test] The initial version of UEFI SCT has been uploaded

2018-10-09 Thread Jin, Eric
Hi All, The initial version of UEFI SCT has been uploaded to https://github.com/tianocore/edk2-test and under the uefi-sct sub directory. If you have interest, please help review. If you find any issue, please contact Supreeth and Eric in the cc-list. Thank you. Best Regards Eric

Re: [edk2] SCT forum help

2017-11-23 Thread Jin, Eric
Hi Amit Kumar, Please send email to u...@uefi.org for the UEFI SCT discussion. BTW, please make sure to provide more detail, such as the log, and your concern. I don't see any attachment in your before email - [edk2] [NVMe SCT] Mistakes in nvmepassthru sct test case.. Best Regards Eric

Re: [edk2] [PATCH v2][Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

2017-08-02 Thread Jin, Eric
Jiaxin, In V2, the input parameter, TextDeviceNode, in the DevPathFromTextDns() is parsed by GetNextParamStr() twice. After the first parse, the content of TextDeviceNode is modified and can convert to correct device path node. Suggest to duplicate the TextDeviceNode or restore the return

Re: [edk2] SCT Test failed

2017-07-04 Thread Jin, Eric
Hi karunakar, I forward this discussion to UTWG since the UEFI SCT is not opensource project. Best Regards Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Karunakar P Sent: Tuesday, July 4, 2017 8:38 PM To: edk2-devel@lists.01.org Subject:

Re: [edk2] UEFI SCT2.5A cannot run with exception

2017-06-06 Thread Jin, Eric
Hi Xiaofeng, Could you please resend the email to u...@uefi.org for this question? I mean UEFI SCT is not the scope of the EDK2 community. Please don't forget to attach the log file. I don't see it or filtered by system. Thanks. Best Regards Eric -Original Message- From: edk2-devel

Re: [edk2] SCT 2.3.1 v1.3

2017-01-21 Thread Jin, Eric
I agree it is the gap between current UEFI SCT and UEFI Spec. Removing the checkpoint from the test is simple. But the Spec enhancement on these missed error description is the better choice. Best Regards Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

Re: [edk2] BootableImageSupportTest\StorageSecurityCommandProtocolTest

2016-09-07 Thread Jin, Eric
If possible, it could be in the version of coming Seattle Plugfest. Thanks Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ramesh R. Sent: Thursday, September 8, 2016 1:14 PM To: Jin, Eric <eric@intel.com>; Tian, Feng &

Re: [edk2] BootableImageSupportTest\StorageSecurityCommandProtocolTest

2016-09-04 Thread Jin, Eric
case, change the code to if(Status == EFI_SUCCESS) ||(Status == EFI_DEVICE_ERROR) || (Status == EFI_WARN_BUFFER_TOO_SMALL)){ Thanks Eric -Original Message- From: Tian, Feng Sent: Monday, September 5, 2016 11:18 AM To: Ramesh R. <rame...@ami.com>; edk2-devel <edk2-devel@lis

Re: [edk2] BootableImageSupportTest\StorageSecurityCommandProtocolTest

2016-08-31 Thread Jin, Eric
are returned and plus the pad data. Best Regards Eric -Original Message- From: Tian, Feng Sent: Thursday, September 1, 2016 10:42 AM To: Ramesh R. <rame...@ami.com>; edk2-devel <edk2-devel@lists.01.org>; Jin, Eric <eric@intel.com> Cc: Tian, Feng <feng.t...@i

Re: [edk2] [Patch] MdeModulePkg/PciSioSerialDxe: Do not flush the UART

2016-05-10 Thread Jin, Eric
Reviewed-by: Eric Jin <eric@intel.com> -Original Message- From: Ni, Ruiyu Sent: Monday, May 9, 2016 1:04 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Jin, Eric <eric@intel.com> Subject: [Patch] MdeModulePkg/PciSioSerialDxe: Do not flush t

Re: [edk2] SCT compilation failed with UEFI spec 2.5

2016-01-28 Thread Jin, Eric
Meenakshi, Could you please the more information about the build step and the SCT/EDK2 version? BTW, since SCT is not the open source project, please send email to u...@uefi.org for discussion. Best Regards Eric -Original Message- From: edk2-devel

Re: [edk2] [Patch] Nt32Pkg: Fix PlatformBootManagerLib to respect PcdShellFile.

2015-09-16 Thread Jin, Eric
Reviewed-by: Eric Jin <eric@intel.com> -Original Message- From: Ni, Ruiyu Sent: Wednesday, September 16, 2015 2:10 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Jin, Eric Subject: [Patch] Nt32Pkg: Fix PlatformBootManagerLib to respect PcdShellFile. Fix the code to use PcdShe