Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-03 Thread Laszlo Ersek
On 04/03/19 17:49, Kinney, Michael D wrote: > Laszlo, > > I think it makes sense to post validated shell binaries > with the edk2-stable tag releases. GitHub does support > this when a release tag is made. > > However, we would need to make it simple for a platform > to use a binary from that

Re: [edk2] [RFC PATCH v1 0/8] Duplicate 8259/8254 components in OvmfPkg

2019-04-03 Thread Laszlo Ersek
On 04/03/19 14:13, Laszlo Ersek wrote: > On 04/03/19 14:10, Laszlo Ersek wrote: >> On 04/03/19 09:00, Hao Wu wrote: >>> This series is also available at: >>> https://github.com/hwu25/edk2/tree/ovmf_8259_8254_rfcv1 >>> >>> >>>

Re: [edk2] [RFC PATCH v1 8/8] OvmfPkg: Update DSC/FDF files to consume 8259/8254 drivers in OvmfPkg

2019-04-03 Thread Laszlo Ersek
The unconsumed PCD: > gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel > > is removed from DSC files as well. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: David Woodhouse > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu >

Re: [edk2] [RFC PATCH v1 7/8] OvmfPkg/8254TimerDxe: Update to make it build for OVMF

2019-04-03 Thread Laszlo Ersek
n made in OVMF DSC files as well in order to > verify the build. (1) Please add the same hint that I asked for under v1 4/8. With that: Reviewed-by: Laszlo Ersek Thanks Laszlo > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: David Woodhouse &g

Re: [edk2] [RFC PATCH v1 6/8] OvmfPkg: Copy 8254TimerDxe driver from PcAtChipsetPkg

2019-04-03 Thread Laszlo Ersek
On 04/03/19 09:00, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496 > > This commit copies the exact 8254TimerDxe driver from PcAtChipsetPkg to > OvmfPkg. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: David Woodhouse

Re: [edk2] [RFC PATCH v1 5/8] OvmfPkg/AcpiPlatformDxe: Consume the 8259 PCD defined in OvmfPkg

2019-04-03 Thread Laszlo Ersek
mfPkg; > B) Remove the PcAtChipsetPkg DEC file dependency in the driver INF file. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: David Woodhouse > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off

Re: [edk2] [RFC PATCH v1 4/8] OvmfPkg/8259InterruptControllerDxe: Update to make it build for OVMF

2019-04-03 Thread Laszlo Ersek
nding changes have been made in OVMF DSC files as well in order to > verify the build. (1) This patch is really well done, but we need an extra hint here, in the last paragraph of the commit message, namely that the DSC and FDF files will get a final update (= removals) later in this series.

Re: [edk2] [RFC PATCH v1 3/8] OvmfPkg/OvmfPkg.dec: Add 8259-related PCDs in OVMF DEC file

2019-04-03 Thread Laszlo Ersek
On 04/03/19 09:00, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496 > > According to the DEC file in PcAtChipsetPkg, this commit adds the two > 8259-driver-related PCDs into the OvmfPkg DEC file. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2] [RFC PATCH v1 2/8] OvmfPkg: Copy Legacy8259 protocol definitions from IntelFrameworkPkg

2019-04-03 Thread Laszlo Ersek
: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: David Woodhouse > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > OvmfPkg/OvmfPkg.dec | 3 +- > OvmfPkg/Include/Protocol/Legacy8259

Re: [edk2] [RFC PATCH v1 0/8] Duplicate 8259/8254 components in OvmfPkg

2019-04-03 Thread Laszlo Ersek
On 04/03/19 14:10, Laszlo Ersek wrote: > On 04/03/19 09:00, Hao Wu wrote: >> This series is also available at: >> https://github.com/hwu25/edk2/tree/ovmf_8259_8254_rfcv1 >> >> >> As a sub-task to remove the IntelFrameworkPkg (BZ-1604), >> >> 8259

Re: [edk2] [RFC PATCH v1 0/8] Duplicate 8259/8254 components in OvmfPkg

2019-04-03 Thread Laszlo Ersek
on > file:boot.log -global isa-debugcon.iobase=0x402 > C. 'stall X' command under Shell to verify the timer is working properly. > > > (Please note that there will be a subsequent patch to remove the 8259/8254 > components after platforms dropping the dependencies on them.) >

Re: [edk2] [RFC PATCH v1 1/8] OvmfPkg: Copy 8259InterruptControllerDxe driver from PcAtChipsetPkg

2019-04-03 Thread Laszlo Ersek
On 04/03/19 09:00, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496 > > This commit copies the exact 8259InterruptControllerDxe driver from > PcAtChipsetPkg to OvmfPkg. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Da

Re: [edk2] [PATCH V2] Change EDK II to BSD+Patent License

2019-04-03 Thread Laszlo Ersek
RFC link list has been extended with the v3 RFC, - the reference to your branch on github has been removed, - the Cc: list in the commit message has been deleted. Hence all my remarks have been observed. For this patch: Reviewed-by: Laszlo Ersek > e39d07266d OvmfPkg: Replace BSD License with BSD+Patent L

Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-03 Thread Laszlo Ersek
On 04/03/19 04:17, Ni, Ray wrote: > > >> -Original Message- >> From: edk2-devel On Behalf Of Laszlo >> Ersek >> Sent: Tuesday, April 2, 2019 4:49 PM >> To: Bi, Dandan ; edk2-devel@lists.01.org >> Cc: Cetola, Stephano ; Kinney, Michael D >&

Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-02 Thread Laszlo Ersek
On 04/02/19 13:50, Ryszard Knop wrote: > On Tue, 2019-04-02 at 13:45 +0200, Laszlo Ersek wrote: >> On 04/02/19 13:29, Ryszard Knop wrote: >>> On Tue, 2019-04-02 at 10:12 +0100, Leif Lindholm wrote: >>>> Hi Laszlo, >>>> >>>> On Tue, Apr 02, 201

Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-02 Thread Laszlo Ersek
On 04/02/19 13:29, Ryszard Knop wrote: > On Tue, 2019-04-02 at 10:12 +0100, Leif Lindholm wrote: >> Hi Laszlo, >> >> On Tue, Apr 02, 2019 at 10:49:16AM +0200, Laszlo Ersek wrote: >>> On 04/02/19 07:38, Bi, Dandan wrote: >>>> Hi All, >>>> &g

Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-02 Thread Laszlo Ersek
On 04/02/19 07:38, Bi, Dandan wrote: > Hi All, > > ShellBinPkg is the remaining binary package in Edk2 repo. We plan to delete > ShellBinPkg from edk2/master, and keep source ShellPkg only in edk2 repo. > Before the deletion, I will update the existing consumers in Edk2 and > Edk2Platforms to

Re: [edk2] [PATCH 0/2] Add event signal before and after ReadyToBoot

2019-04-02 Thread Laszlo Ersek
On 04/02/19 07:49, Zhichao Gao wrote: > Add two event guids. > And signal them immediately before and after the ReadyToBoot signal Event. > > Bret Barkelew (2): > MdeModulePkg: Add event guids > MdeModulePkg/UefiBootManagerlib: Add two event signals > >

Re: [edk2] [PATCH 1/2] ArmVirtPkg: add runtime instance of FdtPL011SerialPortLib

2019-04-02 Thread Laszlo Ersek
ichever you like, and you can even mix them in a single file -- for example, use the condensed style as a basis, but switch to the more verbose official style if you have several comments on the arguments of a large function call.) Thanks, Laszlo > > On 2019/4/2 0:14, Laszlo Ersek

Re: [edk2] [Patch] AdvancedFeaturePkg/AcpiDebug: Add new AcpiDebug modules.

2019-04-01 Thread Laszlo Ersek
On 04/01/19 05:16, Eric Dong wrote: > Add new AcpiDebug modules which provide ACPI Debug feature. > Detail about this feature see the readme.txt in the patch. > > Change-Id: Ib977ece46f3494301574b04af32282b99045f673 > Cc: Hao Wu > Cc: Michael Kubacki > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread Laszlo Ersek
EDK2 Coding style. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vanguput Narendra K > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Yao Jiewen > --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 26 ++ >

Re: [edk2] [PATCH 2/2] ArmVirtQemu: enable runtime debug by build flag

2019-04-01 Thread Laszlo Ersek
or somewhere else. We use a bunch of other similar flags, and "-D FLAG" works just fine. See "HTTP_BOOT_ENABLE" for example -- set to FALSE by default in the individual DSC files, and depended upon in the dsc.inc file as well. > Cc: Laszlo Ersek > Cc: Ard Biesheuvel >

Re: [edk2] [PATCH 1/2] ArmVirtPkg: add runtime instance of FdtPL011SerialPortLib

2019-04-01 Thread Laszlo Ersek
efault RT_DEBUG setting (of FALSE) in the DSC file, in patch #2. People looking at the build flags should realize that RT_DEBUG=TRUE is basically broken, and find a pointer to the missing QEMU feature. > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Julien Grall > Contributed-under: T

Re: [edk2] [PATCH] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-04-01 Thread Laszlo Ersek
(+David) On 03/29/19 06:15, Ni, Ray wrote: > > Guo, > Just to double confirm: UefiPayloadPkg will not require Legacy8254 timer > support. > The old packages Coreboot*Pkgs will be removed. > Which means now only QEMU/OVMF needs the Legacy8254 support. > > Laszlo, > Now since QEMU/OVMF is the

Re: [edk2] [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h

2019-04-01 Thread Laszlo Ersek
On 03/29/19 02:41, Shenglei Zhang wrote: > Mps.h is included in BdsPlatform.h but not actually used. > So remove it. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang

Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-26 Thread Laszlo Ersek
On 03/27/19 01:20, Wu, Hao A wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, March 26, 2019 11:15 PM >> To: Wu, Hao A >> Cc: Anthony PERARD; Justen, Jordan L; edk2-devel@lists.01.org; Julien Grall >> Sub

Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-26 Thread Laszlo Ersek
Hi Hao, On 03/26/19 16:01, Laszlo Ersek wrote: > On 03/26/19 14:03, Anthony PERARD wrote: >> On Mon, Mar 25, 2019 at 12:29:25PM +0100, Laszlo Ersek wrote: >>> (4) Julien, Anthony: can you please fetch this series (github URL at the >>> top) and see if the PS/2 keyboard,

Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-26 Thread Laszlo Ersek
On 03/26/19 14:03, Anthony PERARD wrote: > On Mon, Mar 25, 2019 at 12:29:25PM +0100, Laszlo Ersek wrote: >> (4) Julien, Anthony: can you please fetch this series (github URL at the >> top) and see if the PS/2 keyboard, and the serial port, still work on >> Xen, to interact e.g

Re: [edk2] [PATCH] OvmfPkg: retire "create-release.py"

2019-03-26 Thread Laszlo Ersek
On 03/25/19 14:24, Laszlo Ersek wrote: > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1653 > > "create-release.py" generates a 2-BSDL copyright block that will no longer > apply once we fix <https://bugzilla.tianocore.org/show_bug.cgi?id=1373>. >

Re: [edk2] [edk2-announce] Mailing List Move Day Set: April 4th

2019-03-26 Thread Laszlo Ersek
On 03/25/19 23:21, Rebecca Cran via edk2-devel wrote: > On 3/25/19 10:21 AM, stephano wrote: >> >> This is a good point and shows the level of detail that is preserved >> by the mailing list if maintained properly. I would assume this is >> part of the reason that the Linux kernel has continued to

Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-26 Thread Laszlo Ersek
On 03/26/19 11:09, Julien Grall wrote: > Hi Laszlo, > > On 3/25/19 11:29 AM, Laszlo Ersek wrote: >> On 03/25/19 11:58, Laszlo Ersek wrote: >>> On 03/25/19 06:28, Hao Wu wrote: >> (4) Julien, Anthony: can you please fetch this series (github URL at the >&g

Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-26 Thread Laszlo Ersek
On 03/26/19 11:14, Laszlo Ersek wrote: > On 03/26/19 03:49, Wu, Hao A wrote: >>> -Original Message- >>> From: Laszlo Ersek [mailto:ler...@redhat.com] >>> Sent: Monday, March 25, 2019 7:29 PM >>> To: Wu, Hao A; edk2-devel@lists.01.org; Julien Grall;

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-26 Thread Laszlo Ersek
On 03/25/19 21:02, Kinney, Michael D wrote: > Hi Laszlo, > > The review of the content based on the edk2-stable201903 > is intended to make sure there are no mistakes on that > content so I can adjust for the final patch series. A > mistake would be applying new license to files that should >

Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-26 Thread Laszlo Ersek
On 03/26/19 03:49, Wu, Hao A wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Monday, March 25, 2019 7:29 PM >> To: Wu, Hao A; edk2-devel@lists.01.org; Julien Grall; Anthony Perard >> Cc: Justen, Jordan L; Ard Biesheuvel;

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Laszlo Ersek
On 03/25/19 18:30, Kinney, Michael D wrote: > Hi Laszlo, > > I do not think content added before April 9, 2019 > should use the new license type. We need to let the > 30-day review period complete and make sure all feedback > is resolved. Good point. > We will handle files added between the

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror

2019-03-25 Thread Laszlo Ersek
On 03/25/19 14:30, Rebecca Cran via edk2-devel wrote: > On 3/25/19 5:49 AM, Laszlo Ersek wrote: >> >> Any particular reason for dropping the website URL update? >> <http://www.tianocore.org/edk2/> still redirects to >> <https://github.com/tianocore/tianoc

[edk2] [PATCH] OvmfPkg: retire "create-release.py"

2019-03-25 Thread Laszlo Ersek
Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- Notes: Repo: https://github.com/lersek/edk2.git Branch: retire_create_release OvmfPkg/create-release.py | 208 1 file changed,

Re: [edk2] [edk2-announce] Mailing List Move Day Set: April 4th

2019-03-25 Thread Laszlo Ersek
Hi Stephano, On 03/23/19 01:41, stephano wrote: > I will be moving our mailing list from 01.org over to Groups.io as of > April 4th. I will send out another warning 1 week before, and a final > warning 1 day before the move. > > On April 4th the edk2-devel@lists.01.org will begin to bounce

Re: [edk2] [PATCH V2] Change EDK II to BSD+Patent License

2019-03-25 Thread Laszlo Ersek
Hi Mike, On 03/23/19 03:25, Kinney, Michael D wrote: > Hello, > > New in V2 > = > * Remove Cc lines from commit messages > * Remove branch reference from commit messages > * Change license in 2 files missed in OvmfPkg > * Update OvmfPkg/License.txt to BSD+Patent as the default license >

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Laszlo Ersek
Hello Hao, (+Mike) my apologies that I seem unable to collect my thoughts in one go... So here's another comment: On 03/25/19 06:28, Hao Wu wrote: > diff --git a/OvmfPkg/SioBusDxe/SioBusDxe.inf b/OvmfPkg/SioBusDxe/SioBusDxe.inf > new file mode 100644 > index 00..5c462f1a8c > ---

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror

2019-03-25 Thread Laszlo Ersek
ttp://git.code.sf.net/p/tianocore/edk2 Same as before, and also good. > T: svn (read-only, deprecated) - > https://svn.code.sf.net/p/edk2/code/trunk/edk2 > > Tianocore Stewards > So, if you dropped the "W:" change intentionally, I don't mind. After all, the origin

Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-25 Thread Laszlo Ersek
On 03/25/19 11:58, Laszlo Ersek wrote: > On 03/25/19 06:28, Hao Wu wrote: >> The series is also available at: >> https://github.com/hwu25/edk2/tree/ovmf_siobus_v2 >> >> V2 changes: >> * Introduce a static build flag 'USE_LEGACY_ISA_STACK' in OVMF DSC files >>

Re: [edk2] [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

2019-03-25 Thread Laszlo Ersek
the > below child devices: > > * COM 1 UART > * COM 2 UART > * PS/2 Keyboard > > and installs the Super I/O Protocol on them. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH v2 3/3] OvmfPkg: Add a build flag to select ISA driver stack

2019-03-25 Thread Laszlo Ersek
will be used: > OvmfPkg/SioBusDxe/SioBusDxe.inf > MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > > The default value is set to FALSE in OVMF DSC files. > > Cc: Jordan Justen > Cc: Laszlo Ersek > C

Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-25 Thread Laszlo Ersek
connect -r commands in the UEFI shell? Both the ISA keyboard and the serial console should resume working after "reconnect -r". Thanks, Laszlo > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Ray Ni > > > Hao Wu (3): > OvmfPkg: Dr

Re: [edk2] [PATCH v2 1/3] OvmfPkg: Drop the ISA Floppy device support

2019-03-25 Thread Laszlo Ersek
; > This patch proposes to drop the ISA Floppy device support in OVMF. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > OvmfPkg/OvmfPk

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-25 Thread Laszlo Ersek
On 03/23/19 01:44, Kinney, Michael D wrote: > Hi Laszlo, > > I have entered the following BZ for SPDX identifiers for > MIT licensed content in OvmfPkg. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1654 Thank you! Laszlo >> -Original Message----- >>

Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-22 Thread Laszlo Ersek
On 03/22/19 10:41, Ard Biesheuvel wrote: > On Fri, 22 Mar 2019 at 10:25, Laszlo Ersek wrote: >> >> On 03/22/19 02:33, Wu, Hao A wrote: >>>> -Original Message----- >>>> From: Laszlo Ersek [mailto:ler...@redhat.com] >>>> Sent: Friday, Marc

Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-22 Thread Laszlo Ersek
On 03/22/19 02:33, Wu, Hao A wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Friday, March 22, 2019 3:04 AM >> To: Ard Biesheuvel; Wu, Hao A >> Cc: edk2-devel@lists.01.org; Justen, Jordan L; Ni, Ray >> Subject: Re:

Re: [edk2] [Xen-devel] [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

2019-03-22 Thread Laszlo Ersek
On 03/22/19 09:33, Roger Pau Monné wrote: > On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote: >> This aperture doesn't exist in OVMF and trying to use it causes >> failing assertions later in cases there are prefetchable and >> non-prefetchable BARs following each other. This

Re: [edk2] [PATCH 2/3] Maintainers.txt: Remove EdkCompatibilityPkg information

2019-03-22 Thread Laszlo Ersek
On 03/22/19 07:32, Gao, Liming wrote: > Reviewed-by: Liming Gao Reviewed-by: Laszlo Ersek Thanks Laszlo >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Shenglei Zhang >> Sent: Friday, March 22, 2019 10:35 AM

Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-21 Thread Laszlo Ersek
On 03/21/19 11:08, Ard Biesheuvel wrote: > On Thu, 21 Mar 2019 at 07:44, Wu, Hao A wrote: >> > > Just a couple of notes from my side - I'm sure Laszlo will have a much > longer list :-) > > - Dropping the floppy driver is fine with me. > - What is OVMF specific about this

Re: [edk2] [PATCH V4 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-21 Thread Laszlo Ersek
gt; Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > Ovmf

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-21 Thread Laszlo Ersek
On 03/21/19 13:04, Lars Kurth wrote: > > > On 20/03/2019, 18:25, "Laszlo Ersek" wrote: > > But, again, this should be discussed in that separate BZ then. > > > >OvmfPkg/XenBusDxe/XenBus.c > > This file is l

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-20 Thread Laszlo Ersek
On 03/20/19 19:42, Julien Grall wrote: > Hi, > > On 20/03/2019 18:25, Laszlo Ersek wrote: >> On 03/20/19 14:03, Lars Kurth wrote: >>> On 15/03/2019, 17:48, "Lars Kurth" wrote: >>> On 15/03/2019, 10:18, "Julien Grall" wrote: >>>

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-20 Thread Laszlo Ersek
On 03/20/19 14:03, Lars Kurth wrote: > > > On 15/03/2019, 17:48, "Lars Kurth" wrote: > > > > On 15/03/2019, 10:18, "Julien Grall" wrote: > > > > > EDK2 is converting the full copyright in each file to SDPX > identifier. While the > >

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-03-20 Thread Laszlo Ersek
On 03/20/19 13:16, Heyi Guo wrote: > > > On 2019/3/20 17:55, Laszlo Ersek wrote: >> If we don't have to flatten a ridiculous amount of other library code >> into the RuntimePrepare() function, I think such flattening would be a >> viable approach. We've run into th

Re: [edk2] [PATCH V3 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-20 Thread Laszlo Ersek
gt; Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > Ovmf

Re: [edk2] [PATCH v4] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-03-20 Thread Laszlo Ersek
tion Agreement 1.1 > Signed-off-by: Vanguput Narendra K > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Yao Jiewen > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 22 ++ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 2 +- > 2 files changed, 15

Re: [edk2] [PATCH V2 09/17] OvmfPkg/PlatformDebugLibIoPort: Add a new api DebugVPrint

2019-03-20 Thread Laszlo Ersek
ibution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 38 >

Re: [edk2] [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc

2019-03-20 Thread Laszlo Ersek
part of that. Perhaps it will use "standalone MM"; I'm not sure. The point is, once the goal of the commit starts applying to ARM/AARCH64, a functional LockBox will have been implemented for ARM/AARCH64; and that lib instance will certainly not depend on PcdDxeIplSwitchToLongMode. Until

Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-20 Thread Laszlo Ersek
On 03/18/19 04:45, Wu, Hao A wrote: >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Friday, March 15, 2019 7:10 PM >> To: Wu, Hao A >> Cc: edk2-devel@lists.01.org; Justen, Jordan L; Laszlo Ersek; Ni, Ray >> Su

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-20 Thread Laszlo Ersek
On 03/15/19 18:48, Lars Kurth wrote: > > > On 15/03/2019, 10:18, "Julien Grall" wrote: > > > > > EDK2 is converting the full copyright in each file to SDPX > identifier. While the > > copyright looks like an MIT license, it has never been confirmed. > Andrew

Re: [edk2] [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

2019-03-20 Thread Laszlo Ersek
On 03/19/19 15:03, Anthony PERARD wrote: > On Thu, Mar 14, 2019 at 07:45:56PM +, Igor Druzhinin wrote: >> On 14/03/2019 17:41, Anthony PERARD wrote: >>> Hi, >>> >>> On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote: This aperture doesn't exist in OVMF and trying to use it

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-03-20 Thread Laszlo Ersek
On 03/16/19 10:41, Heyi Guo wrote: > On 2019/3/13 1:05, Laszlo Ersek wrote: >> Given that you'd have to implement a "special" SerialPortLib instance >> just for StatusCodeHandlerRuntimeDxe anyway, can we perhaps: >> >> (1) Undo -- dependent on a build flag? -

Re: [edk2] [staging/PRMCaseStudy]: Creating a new feature branch "PRMCaseStudy"

2019-03-14 Thread Laszlo Ersek
On 03/14/19 09:46, You, Benjamin wrote: > Hi, > > > > A new feature branch "PRMCaseStudy" is being created in edk2-staging. > > > Platform Runtime Mechanism (PRM) is an architecture for ACPI codes to call > into UEFI BIOS's Runtime Services at OS runtime. Traditionally, ACPI codes > call

Re: [edk2] [PATCH 09/17] OvmfPkg/PlatformDebugLibIoPort: Add a new api DebugVPrint

2019-03-14 Thread Laszlo Ersek
ibution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 41 >

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-14 Thread Laszlo Ersek
Hi Mike, On 03/13/19 18:54, Kinney, Michael D wrote: > Hello, > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373 > > This change is based on the following emails: > https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html >

Re: [edk2] F29 Build Issue.

2019-03-14 Thread Laszlo Ersek
On 03/13/19 14:27, Andrew J. Hutton wrote: > Unsure if this is a missing build dependency (since there doesn't appear > to be a check for this) am I missing a make dep or configure step > somewhere? > > This is stock F29, following the website instructions; the make -C > BaseTools/Source/C

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-03-12 Thread Laszlo Ersek
Hi Andrew, On 03/12/19 18:28, Andrew Fish wrote: > > >> On Mar 12, 2019, at 10:05 AM, Laszlo Ersek wrote: >> >> Hello Heyi, >> >> On 03/12/19 07:56, Heyi Guo wrote: >>> Hi Laszlo, >>> >>> I'm thinking about a proposal

Re: [edk2] [RFC v2] Change EDK II to BSD+Patent License

2019-03-12 Thread Laszlo Ersek
ty > manager or any of the EDK II stewards. > > * Stephano CetolaCommunity Manager > * Leif Lindholm Steward > * Andrew Fish Steward > * Laszlo Ersek Steward > * Michael KinneySteward > > The goal is to convert all of

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-03-12 Thread Laszlo Ersek
SerialPortLib class, at least for runtime DXE drivers, then I think we should do that. Thanks, Laszlo > On 2019/3/1 23:27, Laszlo Ersek wrote: >> +Peter, for the last few paragraphs >> >> On 02/28/19 13:10, Ard Biesheuvel wrote: >>> On Thu, 28 Feb 2019 at 09:06,

Re: [edk2] [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information

2019-03-12 Thread Laszlo Ersek
>> Cc: Dong, Eric ; Ni, Ray ; Laszlo >> Ersek >> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help >> information >> >> The prompt and help information are missing in UefiPkg.uni. >> https://bugzilla.tianocore.org/show_bu

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers

2019-03-08 Thread Laszlo Ersek
ed-off-by: Rebecca Cran > Reviewed-by: Jaben Carsey > Reviewed-by: Laszlo Ersek > --- > StdLib/Efi/StdLib/etc/resolv.conf | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/StdLib/Efi/StdLib/etc/resolv.conf > b/StdLib/Efi/StdLib/etc/resolv.

Re: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

2019-03-08 Thread Laszlo Ersek
On 02/27/19 22:21, Laszlo Ersek wrote: > The current language for "Package Reviewer" only vaguely hints that > Package Reviewers should be able to provide guidance and directions. > Make this more obvious. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Leif L

Re: [edk2] [edk2-announce] EDK II Stable Tag edk2-stable201903 will be created based on commit 89910a

2019-03-08 Thread Laszlo Ersek
On 03/08/19 16:48, Gao, Liming wrote: > Hi, all Sorry for a little late announce. I wait for some time to > collect the feedback on the CEV fix. There is no rejection on CVE > fix. So, I add it to this tag release. I will create > edk2-stable201903 based on current edk2 trunk (commit 89910a >

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Laszlo Ersek
1 which was edited... I got no clue where (certainly not in the edk2-wiki); - and for the upcoming tag, we have the notes at: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes#edk2-stable201903-tag Thanks, Laszlo > -Original Message- > From: Richardson, Brian > Sen

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-08 Thread Laszlo Ersek
900 ("UefiCpuPkg/DxeMpLib: Allocate new safe stack < 4GB", 2016-11-28) Laszlo > > > > Thank you > Yao Jiewen > > >> -----Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> S

Re: [edk2] [PATCH v2 0/2] Fix bugs in HiiDatabase driver

2019-03-08 Thread Laszlo Ersek
On 03/08/19 09:52, Laszlo Ersek wrote: > On 03/08/19 07:41, Gao, Liming wrote: >> This is to fix the security issue. I agree it is an import bug fix. I am OK >> to push it for edk2-stable201903 tag > > Me too. > > If we had stable *branches* (as opposed to just stabl

Re: [edk2] [PATCH] Maintainers.txt: remove unexpected unicode BOM

2019-03-08 Thread Laszlo Ersek
On 03/08/19 10:07, Wang, Jian J wrote: > Pushed at c2c4b919caa297fbe83f02b897c125b87eb1fd58 > > Regards, > Jian (I didn't ignore the fixup patch, I was just busy with something else.) Thanks for this! Laszlo ___ edk2-devel mailing list

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers

2019-03-08 Thread Laszlo Ersek
ed-off-by: Rebecca Cran > Reviewed-by: Jaben Carsey > Reviewed-by: Laszlo Ersek > --- > StdLib/Efi/StdLib/etc/resolv.conf | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/StdLib/Efi/StdLib/etc/resolv.conf > b/StdLib/Efi/StdLib/etc/resolv.

Re: [edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

2019-03-08 Thread Laszlo Ersek
Hi Liming, On 03/01/19 09:57, Gao, Liming wrote: > Hi, all > Today, we enter into Hard Feature Freeze phase until edk2-stable201903 tag > is created at 2019-03-08. In this phase, there is no feature to be pushed. > The bug fix is still allowed. I meant to ask you about permanent links to

Re: [edk2] [PATCH v2 0/2] Fix bugs in HiiDatabase driver

2019-03-08 Thread Laszlo Ersek
On 03/08/19 07:41, Gao, Liming wrote: > This is to fix the security issue. I agree it is an import bug fix. I am OK > to push it for edk2-stable201903 tag Me too. If we had stable *branches* (as opposed to just stable tags), then we wouldn't have to delay the stable tag (the release) -- we'd

Re: [edk2] [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.

2019-03-08 Thread Laszlo Ersek
On 03/08/19 03:56, Zhang, Chao B wrote: > Cc: Yao Jiewen > Cc: Jian Wang > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhang, Chao B > --- > Maintainers.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Maintainers.txt

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-08 Thread Laszlo Ersek
Hi Andrew, On 03/07/19 23:37, Andrew Fish via edk2-devel wrote: > I'm trying to understand why gdtPtr.Base is casting to (UINT32)? > 1) gdtPtr.Base is a a UINTN > 2) It is legal for AllocateRuntimePool() to return an address > 4GB > > It seems like the code should just cast to (UINTN)? > > >

Re: [edk2] [PATCH v2] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-03-07 Thread Laszlo Ersek
tion Agreement 1.1 > Signed-off-by: Vanguput Narendra K > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Yao Jiewen > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) (1) There is an open q

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Direct allocate buffer for Wake up Buffer.

2019-03-07 Thread Laszlo Ersek
Tuesday, March 5, 2019 3:33 PM >> To: Dong, Eric ; edk2-devel@lists.01.org >> Cc: Ni, Ray ; Laszlo Ersek (ler...@redhat.com) >> ; Zeng, Star >> Subject: RE: [edk2] [Patch] UefiCpuPkg/MpInitLib: Direct allocate buffer for >> Wake up Buffer. >> >> J

Re: [edk2] [PATCH 00/10] Remove .S files for IA32 and X64 arch in MdePkg and UefiCpuPkg

2019-03-07 Thread Laszlo Ersek
Hi, On 03/07/19 03:30, Shenglei Zhang wrote: > .nasm file has been added for X86 arch. .S assembly code > is not required any more. > https://bugzilla.tianocore.org/show_bug.cgi?id=1594 > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Eric Dong > Cc: Ray Ni > C

Re: [edk2] [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

2019-03-06 Thread Laszlo Ersek
On 03/06/19 15:26, Igor Druzhinin wrote: > On 06/03/2019 13:22, Laszlo Ersek wrote: >> On 03/06/19 13:40, Igor Druzhinin wrote: >>> On Xen, hvmloader firmware leaves address decoding enabled for >>> enumerated PCI device before jumping into OVMF. OVMF seems to &

Re: [edk2] [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

2019-03-06 Thread Laszlo Ersek
On 03/06/19 13:40, Igor Druzhinin wrote: > On Xen, hvmloader firmware leaves address decoding enabled for > enumerated PCI device before jumping into OVMF. OVMF seems to > expect it to be disabled and tries to size PCI BARs in several places > without disabling it which causes BAR64, for example,

Re: [edk2] [PATCH 0/3] Xen PCI passthrough fixes

2019-03-05 Thread Laszlo Ersek
Hi Igor, On 03/04/19 16:04, Igor Druzhinin wrote: > Igor Druzhinin (3): > OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge > aperture > OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64 > OvmfPkg/XenSupport: turn off address decoding before BAR sizing

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-03-01 Thread Laszlo Ersek
On 03/01/19 16:09, Peter Maydell wrote: > On Fri, 1 Mar 2019 at 14:59, Laszlo Ersek wrote: >> >> +Peter >> >> On 03/01/19 13:24, Heyi Guo wrote: >>> On 2019/2/28 21:39, Laszlo Ersek wrote: >> >>>> (4) What's most worrying is that this change

Re: [edk2] [Patch v2 4/4] UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments.

2019-03-01 Thread Laszlo Ersek
On 03/01/19 06:39, Eric Dong wrote: > Cc: Ray Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 4 ++-- > 1 file changed, 2 inser

Re: [edk2] [Patch v2 0/4] Simplify CPU Features solution.

2019-03-01 Thread Laszlo Ersek
uld reference "CpuBitMask". > > V1 Changes includes: > 1. Optimize PCD PcdCpuFeaturesUserConfiguration > 2. Limit useage of PcdCpuFeaturesSupport > 3. Remove some useless APIs. > Detail explanation please check each patch's introduction. > > Cc:

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-03-01 Thread Laszlo Ersek
od to enable runtime serial >> port >> debug for ArmVirtQemu. >> >> Cc: Jian J Wang >> Cc: Hao Wu >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Julien Grall >> >> Heyi Guo (3): >> MdeModulePkg/StatusCode: Add PCD

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-03-01 Thread Laszlo Ersek
+Peter On 03/01/19 13:24, Heyi Guo wrote: > On 2019/2/28 21:39, Laszlo Ersek wrote: >> (4) What's most worrying is that this change would lead to an unexpected >> sharing of the PL011 device between the OS and the firmware. I don't >> think that's a great idea, especially i

Re: [edk2] [PATCH 2] UefiCpuPkg: restore strict page attributes via #DB in nonstop mode only

2019-03-01 Thread Laszlo Ersek
, March 01, 2019 9:55 AM >> To: Wang, Jian J ; edk2-devel@lists.01.org >> Cc: Ni, Ray ; Laszlo Ersek ; Zeng, Star >> >> Subject: RE: [edk2] [PATCH 2] UefiCpuPkg: restore strict page attributes via >> #DB >> in nonstop mode only >> >> Review

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-03-01 Thread Laszlo Ersek
On 03/01/19 02:15, Gao, Liming wrote: > OK. To be clear, I take your suggestion. wiki page has been updated. Looks great, thank you! Laszlo > >> -Original Message----- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, February 28, 2019 7:58 PM &

Re: [edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory beyond 4G

2019-02-28 Thread Laszlo Ersek
On 02/28/19 15:07, Laszlo Ersek wrote: > (4) I also suggest adding: > > Fixes: dcc026217fdc363f55c217039fc43d344f69fed6 Additionally append: Fixes: 16b918bbaf51211a32ae04d9d8a5ba6ccca25a6a Thanks, Laszlo > > near the end of the commit message. > > > With (

Re: [edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory beyond 4G

2019-02-28 Thread Laszlo Ersek
#DB in nonstop mode only (71 characters). (4) I also suggest adding: Fixes: dcc026217fdc363f55c217039fc43d344f69fed6 near the end of the commit message. With (2) through (4) addressed: Acked-by: Laszlo Ersek Thanks Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

  1   2   3   4   5   6   7   8   9   10   >