Re: [edk2-devel] [edk2] [edk2-announce] ATTN: List Transition Begins Today

2019-04-04 Thread Leif Lindholm
Hi Stephano, Excellent news, thanks. Just to get the information inline in this thread: the new list address is de...@edk2.groups.io. Regards, Leif On Wed, Apr 03, 2019 at 10:59:31AM -0500, stephano wrote: > tl;dr > If you're sending emails to this list, now would be a good time to switch >

Re: [edk2] aarch64-linux-gnu-gcc.exe: error due to loss ‘/’in code path in in Jenkins server

2019-04-03 Thread Leif Lindholm
GNUmake revision : GNUMake-3.81_win32 > > > Can the tool provide more debug output ? > > > > > > > > > > > At 2019-04-03 16:00:04, "Leif Lindholm" wrote: > >Sami, any ideas? > > > >Xiaofeng, what gcc is being used for

Re: [edk2] aarch64-linux-gnu-gcc.exe: error due to loss ‘/’in code path in in Jenkins server

2019-04-03 Thread Leif Lindholm
Sami, any ideas? Xiaofeng, what gcc is being used for x86? (output of "gcc -v") Best Regards, Leif On Wed, Apr 03, 2019 at 03:54:33PM +0800, wang xiaofeng wrote: > HI ARM Base tool owners, >I meet a strange issue that aarch64 build . The aarch64 build pass on my > local server. But it

Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-02 Thread Leif Lindholm
Hi Laszlo, On Tue, Apr 02, 2019 at 10:49:16AM +0200, Laszlo Ersek wrote: > On 04/02/19 07:38, Bi, Dandan wrote: > > Hi All, > > > > ShellBinPkg is the remaining binary package in Edk2 repo. We plan > > to delete ShellBinPkg from edk2/master, and keep source ShellPkg > > only in edk2 repo. > >

Re: [edk2] [PATCH edk2-non-osi] Platform/DeveloperBox: add binary build of TF-A + standalone MM varstore

2019-03-29 Thread Leif Lindholm
On Fri, Mar 29, 2019 at 10:52:41AM +0100, Ard Biesheuvel wrote: > On Fri, 29 Mar 2019 at 09:57, Leif Lindholm wrote: > > > > On Fri, Mar 29, 2019 at 08:46:12AM +0100, Ard Biesheuvel wrote: > > > Provide a prebuilt binary of the standalone MM payload containing the

Re: [edk2] [PATCH edk2-non-osi] Platform/DeveloperBox: add binary build of TF-A + standalone MM varstore

2019-03-29 Thread Leif Lindholm
er and built into the secure world TF-A image. > > TF-A commit: e86e202c2e4e > edk2 commit: 8028f0303218 > edk2-platforms commit: 05fdad573966 > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindh

Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Socionext/DeveloperBox: align with upstream StandaloneMmPkg changes

2019-03-29 Thread Leif Lindholm
On Fri, Mar 29, 2019 at 08:32:31AM +0100, Ard Biesheuvel wrote: > On Fri, 8 Mar 2019 at 16:31, Ard Biesheuvel wrote: > > > > Bring DeveloperBox in line with EDK2 core changes to StandaloneMmPkg: > > - switch from BaseExtractGuidedSectionLib to PrePiExtractGuidedSectionLib > > - include a NULL

[edk2] [PATCH edk2-platforms] Platform/Hisilicon: update D06 system firmware description

2019-03-26 Thread Leif Lindholm
: 3 and LowestSupportedFirmwareVersion: 3. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- Ming: I would also be cherry-picking this patch into RPF 19.03. Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 6

Re: [edk2] [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc

2019-03-26 Thread Leif Lindholm
On Mon, Mar 25, 2019 at 02:17:05AM +, Wu, Hao A wrote: > > My original version is my preferred way of addressing the immediate > > problem though, mainly to keep the separate .EBC section. > > Got it. > Do you want me to help to push the patch? If you could, that would be appreciated. Best

Re: [edk2] [PATCH edk2-platforms v4 0/4] Platform/ARM: Platform support for Dynamic Tables Framework

2019-03-26 Thread Leif Lindholm
t; > The changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/365_dynamic_tables_framework_v4 For the series: Reviewed-by: Leif Lindholm Pushed as 89f6901df0..8cb8080438. / Leif > This v4 patch series incorporates: > * Updates based on review comments to

Re: [edk2] [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes

2019-03-26 Thread Leif Lindholm
g changes required in the platform > Configuration Manager. > > Note: This patch series is dependent on the patch series: > https://lists.01.org/pipermail/edk2-devel/2019-January/035611.html Ah, right, so these changes will have to be pushed simultaneously with the edk2 ones. I

Re: [edk2] [PATCH v1 1/2] DynamicTablesPkg: Fix line endings in dsc file

2019-03-26 Thread Leif Lindholm
https://git.linaro.org/uefi/uefi-tools.git/tree/edk2-to-git-am.sh I'll remember to put any future sets to you on a branch, as you helpfully do for me. Reviewed-by: Leif Lindholm > Cc: Alexei Fedorov > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-b

Re: [edk2] [PATCH V2] Change EDK II to BSD+Patent License

2019-03-26 Thread Leif Lindholm
On Tue, Mar 26, 2019 at 06:21:43PM +, Kinney, Michael D wrote: > Hi Leif, > > Thanks for the reviews. Responses below. > > Mike > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Tuesday, March 26, 201

Re: [edk2] [PATCH V2] Change EDK II to BSD+Patent License

2019-03-26 Thread Leif Lindholm
around to relicensing edk2-platforms too? For the changes to ArmPkg, ArmPlatformPkg, EmbeddedPkg(, BeagleBoardPkg, Omap35xxPkg): Reviewed-by: Leif Lindholm For the changes to edk2: License.txt - could the commit message describe where the new text is from (as an implicit way

Re: [edk2] [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-26 Thread Leif Lindholm
ibution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > ArmPkg/Library/SemiHostingDebugLib/DebugLib.c | 106 > -

Re: [edk2] [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes

2019-03-25 Thread Leif Lindholm
e resolution of StandaloneMmDriverEntryPoint > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel For series: Reviewed-by: Leif Lindholm > --- > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [edk2] [PATCH edk2-platforms v3 0/4] Platform/ARM: Platform support for Dynamic Tables Framework

2019-03-22 Thread Leif Lindholm
Hi Sami, On the whole, this set looks fine - but: - could you go through and sort the #include files alphabetically in .c/.h (within each grouping)? - similarly, could you go through and ensure that .inf files contain alphabetically sorted [Sources], [Packages] and [LibraryClasses]

Re: [edk2] [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc

2019-03-22 Thread Leif Lindholm
On Thu, Mar 21, 2019 at 03:27:45AM +, Wu, Hao A wrote: > > -Original Message- > > From: Zeng, Star > > Sent: Thursday, March 21, 2019 9:03 AM > > To: Leif Lindholm; Laszlo Ersek > > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Wang, Jian J;

Re: [edk2] [PATCH edk2-non-osi v3 0/8] Upload D0x binary modules

2019-03-21 Thread Leif Lindholm
Apart from the patches I've called out separately: Reviewed-by: Leif Lindholm Pushed as 635f97e0..99907896. Thanks! > Ming Huang (8): > Hisilicon/D0x: Add some header files > Hisilicon/D06: Remove PCI enumeration dependency from SAS driver > Hisilicon/D0x: Update PlatformSys

Re: [edk2] [PATCH edk2-platforms v3 00/18] Fix issues and improve D0x

2019-03-21 Thread Leif Lindholm
t from the patches I've called out separately: Reviewed-by: Leif Lindholm Pushed as a8f34e0658..89f6901df0. Thanks! > Jason Zhang (1): > Hisilicon/D06: Fix access variable fail issue > > Ming Huang (16): > Hisilicon/D0x: Remove and tidy some codes about SerdesLib > His

Re: [edk2] [PATCH edk2-non-osi v3 8/8] Hisilicon/D06: Add Setup Item "Support DPC"

2019-03-21 Thread Leif Lindholm
ributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi | Bin 232832 -> > 226784 bytes > 1 file changed, 0 insertions(+), 0 deletions(-) > > diff --g

Re: [edk2] [PATCH edk2-platforms v3 12/18] Hisilicon/D06: Modify for IMP self-Adapte support

2019-03-21 Thread Leif Lindholm
On Wed, Mar 20, 2019 at 04:08:23PM +0800, Ming Huang wrote: > As new IMP(Cortex-M7) firmware support self-adapte, so do not > need BIOS to implement some function, remove useless funtions I will reword/correct the above to "unused functions". With that: Reviewed-by: Leif Lindholm

Re: [edk2] [PATCH edk2-platforms v3 05/18] Hisilicon/D06: Fix access variable fail issue

2019-03-21 Thread Leif Lindholm
ill be pushed with an improved subject. / Leif On Thu, Mar 21, 2019 at 05:52:18PM +, Leif Lindholm wrote: > I will update the subject line to reflect what is actually being > changed. > > Other than that, > Reviewed-by: Leif Lindholm > > > On Wed, Mar 20, 2019 at 04:08:1

Re: [edk2] [PATCH edk2-platforms v3 05/18] Hisilicon/D06: Fix access variable fail issue

2019-03-21 Thread Leif Lindholm
I will update the subject line to reflect what is actually being changed. Other than that, Reviewed-by: Leif Lindholm On Wed, Mar 20, 2019 at 04:08:16PM +0800, Ming Huang wrote: > From: Jason Zhang > > BmcWdtEnable is a field of OemConfigData structure, need have > run

Re: [edk2] [PATCH edk2-platforms v3 13/18] Hisilicon/D06: Add Setup Item "Support DPC" and delete some PCIe menus

2019-03-21 Thread Leif Lindholm
Hi Ming, On Wed, Mar 20, 2019 at 04:08:24PM +0800, Ming Huang wrote: > Add setup item "Support DPC" to enable or disable PCIe DPC > (Downstream Port Containment). > > The pcie menu is suppressed for original code as these menus > are not ready. This patch remove the suppression for pcie menu, >

Re: [edk2] [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc

2019-03-20 Thread Leif Lindholm
On Wed, Mar 20, 2019 at 03:51:39PM +0100, Laszlo Ersek wrote: > Hi Leif, > > On 03/18/19 15:56, Leif Lindholm wrote: > > Commit 05fd2a926833 > > ("MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox") > > added a dependency on LockBoxLib t

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-19 Thread Leif Lindholm
together a specific proposal > and perhaps some links to other projects that use > the same approach? > > I am happy to update the RFC to V3 to address this > topic if we can close on it quickly. > > Thanks, > > Mike > > > > -Original Message- > >

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-19 Thread Leif Lindholm
Hi Mike, I see where Jordan is coming from here. It isn't just about losing the comment in Contriutions.txt - there are bits in the actual TianoCore Contribution Agreement that cover the same things as https://developercertificate.org/ (that are not explicitly called out elsewhere in the

Re: [edk2] [Patch MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-19 Thread Leif Lindholm
631 > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/Library/UefiBootManage

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-19 Thread Leif Lindholm
On Tue, Mar 19, 2019 at 12:01:51PM +0800, Ming Huang wrote: > On 3/18/2019 8:42 PM, Leif Lindholm wrote: > > +MdeModulePkg maintainers (you added MdePkg maintainers to cc) > > > > This looks like an improvement to me. > > > > Am I correct in guessing this behavio

[edk2] [PATCH 0/2] DynamicTablesPkg: add package .dsc

2019-03-18 Thread Leif Lindholm
Having a top-level .dsc simplifies automated builds of core modules in isolation from any final platforms. As demonstrated by 1/2, discovered while putting the .dsc together. Leif Lindholm (2): DynamicTablesPkg: correct LibraryClass dependencies for Arm/DBG2 DynamicTablesPkg: add package .dsc

[edk2] [PATCH 1/2] DynamicTablesPkg: correct LibraryClass dependencies for Arm/DBG2

2019-03-18 Thread Leif Lindholm
This patch changes the stated dependency in AcpiDbg2LibArm.inf from currently listed SerialPortLib to actually required PL011UartLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf | 2

[edk2] [PATCH 2/2] DynamicTablesPkg: add package .dsc file

2019-03-18 Thread Leif Lindholm
Having a top-level .dsc makes it easier to perform standalone build tests of the core code, so add one. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- DynamicTablesPkg/DynamicTablesPkg.dsc | 44 +++ 1 file changed, 44

[edk2] [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc

2019-03-18 Thread Leif Lindholm
reference to gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode. Add a resolution for LockBoxNullLib for ARM/AARCH64 to restore builds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- Note: this patch hides the symptom, but this isn't really the fix I would like to see. The build error

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-18 Thread Leif Lindholm
+MdeModulePkg maintainers (you added MdePkg maintainers to cc) This looks like an improvement to me. Am I correct in guessing this behaviour refers to some specific corner case of a USB CDROM emulated from a BMC? On Mon, Feb 25, 2019 at 05:10:52PM +0800, Ming Huang wrote: > The system

Re: [edk2] [PATCH] EmbeddedPkg/DwEmacSnpDxe: Add designware emac support This add support for designware emac controller

2019-02-28 Thread Leif Lindholm
rocess. Hmm, I probably should add a Readme.md about this in EmbeddedPkg/Drivers. Best Regards, Leif > Best regards, > Tzy Way > > > On Thu, 2019-01-31 at 18:22 +, Leif Lindholm wrote: > > Hi Tzy Way, > > > > Thank you for this contribution. > >

Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Leif Lindholm
t; Bob > > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, February 27, 2019 4:26 PM > To: Feng, Bob C > Cc: Ard Biesheuvel ; edk2-devel@lists.01.org; Gao, > Liming > Subject: Re: [edk2] [Patch] BaseTools: Add python

Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Leif Lindholm
On Wed, Feb 27, 2019 at 09:07:49AM +0100, Ard Biesheuvel wrote: > On Tue, 26 Feb 2019 at 02:05, Feng, Bob C wrote: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > > > > Add python3-distutils Ubuntu package checking. > > > > Hi Bob, > > This assumes that all Linux systems are

Re: [edk2] [PATCH edk2-platforms v2 17/18] Hisilicon/D0x: Delete some header files

2019-02-20 Thread Leif Lindholm
Hi Ming, Thank you for this rework. However, can you move it first in the series, so that it's obvious this series contains no changes to these headers (because they have all happened in edk2-non-osi)? Regards, Leif On Wed, Feb 20, 2019 at 03:28:36PM +0800, Ming Huang wrote: > As some

Re: [edk2] [PATCH edk2-platforms] Silicon/AMD/Styx/Drivers/AcpiPlatformDxe: use correct object ref in DBG2

2019-02-20 Thread Leif Lindholm
Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc > b/Silicon/AMD/Styx/Drivers/AcpiPlatformD

Re: [edk2] [PATCH edk2-platforms 0/2] Platform/RaspberryPi3: add RNG support

2019-02-19 Thread Leif Lindholm
in the arm64 Linux kernel to randomize the placement of various parts of > the kernel. > > Changes since v2: > - move the RNG specific SoC definitions into the Bcm2836.h common header > - add patch that wires up the driver into the RPi3 platform > > Cc: Pete Batard > Cc

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-15 Thread Leif Lindholm
On Fri, Feb 15, 2019 at 01:12:11AM +0100, Pete Batard wrote: > Hi Leif, > > On 2019-02-12 19:14, Leif Lindholm wrote: > > On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote: > > > This is designed to be used on platforms where a a real RTC is not &g

Re: [edk2] [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support

2019-02-14 Thread Leif Lindholm
On Tue, Feb 05, 2019 at 04:25:15PM +, Pete Batard wrote: > Changes for v5: > > * Raspberry/Pi3 -> RaspberryPi/RPi3 > * Remove VirtualRealTimeClockLib as well as BUILD_EPOCH macro (use the > upcoming > EmbeddedPkg Virtual RTC from EDK2 instead) > * Use $(PLATFORM_NAME) where possible in

Re: [edk2] [PATCH v5 edk2-platforms 22/22] Platform/RaspberryPi/RPi3: Add platform readme's

2019-02-14 Thread Leif Lindholm
On Tue, Feb 05, 2019 at 04:25:37PM +, Pete Batard wrote: > Documentation is split between general plaform data and OS testing > and installation details. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard Reviewed-by: Leif Lindholm &g

Re: [edk2] [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib

2019-02-13 Thread Leif Lindholm
On Wed, Feb 13, 2019 at 02:36:11PM +0800, Ming Huang wrote: > > Should it not then also delete #include from > > Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, > > Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and > >

Re: [edk2] [PATCH edk2-platforms v1 09/16] Hisilicon/D06: Add PCI_OSC_SUPPORT

2019-02-13 Thread Leif Lindholm
On Wed, Feb 13, 2019 at 10:59:17AM +0800, Ming Huang wrote: > On 2/12/2019 2:51 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:29PM +0800, Ming Huang wrote: > >> Add PCI_OSC_SUPPORT for remaining host bridges to remove fail > >> output in kernel: > >

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-12 Thread Leif Lindholm
On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote: > This is designed to be used on platforms where a a real RTC is not > available and relies on an RtcEpochSeconds variable having been set or, > if that is not the case, falls back to using the epoch embedded at > compilation time. > >

Re: [edk2] [PATCH edk2-platforms v1 11/16] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 11:22:24PM +0800, Ming Huang wrote: > On 2/12/2019 3:46 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:31PM +0800, Ming Huang wrote: > >> Add setup item "Support DPC" to enable or disable PCIe DPC > >> (Downstream Port C

Re: [edk2] [PATCH edk2-platforms v1 10/16] Hisilicon/D06: Modify for M7 self-Adapte support

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 11:14:43PM +0800, Ming Huang wrote: > > > On 2/12/2019 3:28 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:30PM +0800, Ming Huang wrote: > >> As new M7(Cortex-M7) firmware support self-adapte, so do not > >> need BIOS to implem

Re: [edk2] [PATCH edk2-non-osi v1 7/7] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:25:07PM +0800, Ming Huang wrote: > Add setup item "Support DPC" to enable or disable PCIe DPC > (Downstream Port Containment). > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lin

Re: [edk2] [PATCH edk2-non-osi v1 5/7] Hisilicon/D06: Use new flash layout

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:25:05PM +0800, Ming Huang wrote: > In new flash layout, BIOS fd change from offset 1M to 8M in 16M > spi flash. I think I covered all of the layout questions in the corresponding edk2-platforms patch. > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH edk2-non-osi v1 4/7] Hisilicon/D06: Support PCIe local RAS

2019-02-12 Thread Leif Lindholm
off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi | Bin 21248 > -> 22048 bytes > Platform/Hisilicon/D06/bl1.bin | Bin 12432 > -> 12432

Re: [edk2] [PATCH edk2-non-osi v1 1/7] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-12 Thread Leif Lindholm
Change the subject line to: Hisilicon/D06: remove PCI enumeration dependency from SAS driver On Fri, Feb 01, 2019 at 10:25:01PM +0800, Ming Huang wrote: > SAS controller is always existed, so accessing SAS register don't > depend on PciBusDxe (pci enumeration). Modify SAS driver remove the >

Re: [edk2] [PATCH edk2-platforms v1 04/16] Hisilicon/D06: Fix access variable fail issue

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:24PM +0800, Ming Huang wrote: > From: Jason Zhang > > BmcWdtEnable is a field of OemConfigData structure, need have > runtime service attribution if use it during exit boot service This sounds like a very shady thing to do. Which module is seeing issues, and what

Re: [edk2] [PATCH edk2-platforms v1 03/16] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:23PM +0800, Ming Huang wrote: > SAS controller is always existed, so accessing SAS register don't > depend on PciBusDxe (pci enumeration). > Move the SAS module early in D06.fdf for dispatching SAS driver > early. This can avoid wait in BDS normally and reduce boot

Re: [edk2] [PATCH edk2-platforms v1 08/16] Hisilicon/D06: Change HCCS speed from 30G to 26G

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 10:45:05PM +0800, Ming Huang wrote: > > > On 2/12/2019 2:36 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:28PM +0800, Ming Huang wrote: > >> Follow chip team suggestion to change HCCS(Huawei Cache-Coherent > >> System) speed f

Re: [edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote: > >> For D06 library, we use the same source code to support all Hi1620 > >> projects, > >> include product projects,so there are some modify for this, like support > >> 3 sockets, 4 sockets and remove some useless functions. > > > > So

Re: [edk2] [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 07:42:55PM +0800, Ming Huang wrote: > > > On 2/12/2019 5:38 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 10:25:03PM +0800, Ming Huang wrote: > >> As chip group suggestions, update Mbigen and gic RAS configuration > >> flow. > &g

Re: [edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 04:05:50PM +0800, Ming Huang wrote: > On 2/12/2019 5:36 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote: > >> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 > >> context. PI spe

Re: [edk2] [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:25:03PM +0800, Ming Huang wrote: > As chip group suggestions, update Mbigen and gic RAS configuration > flow. Update how? / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- >

Re: [edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote: > As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 > context. PI specifies 'BSP' for Boot-strap Processor, as the one > executing all of the EDK2 code. It then uses 'AP' to refer to > Additional Processors, which can

Re: [edk2] [PATCH edk2-platforms v1 16/16] Hisilicon/D0x: Modify version to 19.02

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:29:07PM +0800, Ming Huang wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D03/D03.dsc | 4 ++-- > Platform/Hisilicon/D05/D05.dsc | 4 ++-- > Platform

Re: [edk2] [PATCH edk2-platforms v1 15/16] Hisilicon/D06: Use CalculateCrc16 in BaseLib

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:29:06PM +0800, Ming Huang wrote: > This patch is relative with "Add new API CalculateCrc16()" in edk2. The commit message should describe what the patch does. I don't mind keeping the above line in, but we also need the description. Obviously, this patch depends on the

Re: [edk2] [PATCH edk2-platforms v1 14/16] Hisilicon/D0x: Remove SP805 watchdog pcd

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:34PM +0800, Ming Huang wrote: > SP805 watchdog is no used for D0x, so remove it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/His

Re: [edk2] [PATCH edk2-platforms v1 13/16] Hisilicon/D06: Remove SECURE_BOOT_ENABLE definition

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:33PM +0800, Ming Huang wrote: > As secure boot is not ready, remove SECURE_BOOT_ENABLE and > relative code. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/

Re: [edk2] [PATCH edk2-platforms v1 11/16] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:31PM +0800, Ming Huang wrote: > Add setup item "Support DPC" to enable or disable PCIe DPC > (Downstream Port Containment). This patch also seems to disable the SRIOV configuration and delete a lot of ports. Can you explain how this is related? / Leif >

Re: [edk2] [PATCH edk2-platforms v1 10/16] Hisilicon/D06: Modify for M7 self-Adapte support

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:30PM +0800, Ming Huang wrote: > As new M7(Cortex-M7) firmware support self-adapte, so do not > need BIOS to implement some function, remove useless funtions > and report CPU0/CPU1 Nic NCL offset to M7. I don't really care that some other device in the system is a

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer/Stage2Tables: fix build for cross compile from x86

2019-02-11 Thread Leif Lindholm
ype. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Acked-by: Leif Lindholm Tested-by: Leif Lindholm > --- > Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf | 2 ++ > 1 file changed, 2 insertions(+) > > di

Re: [edk2] [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h

2019-02-11 Thread Leif Lindholm
On Mon, Feb 11, 2019 at 07:03:09PM +0100, Ard Biesheuvel wrote: > On Mon, 11 Feb 2019 at 19:02, Leif Lindholm wrote: > > > > Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe > > .vfr rather than local definitions. > > > > Contributed-under:

Re: [edk2] [PATCH edk2-platforms v1 09/16] Hisilicon/D06: Add PCI_OSC_SUPPORT

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:29PM +0800, Ming Huang wrote: > Add PCI_OSC_SUPPORT for remaining host bridges to remove fail > output in kernel: > [ 103.478893] acpi PNP0A08:01: _OSC failed (AE_NOT_FOUND); > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang >

Re: [edk2] [PATCH edk2-platforms v1 08/16] Hisilicon/D06: Change HCCS speed from 30G to 26G

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:28PM +0800, Ming Huang wrote: > Follow chip team suggestion to change HCCS(Huawei Cache-Coherent > System) speed from 30G to 26G, this modification can avoid some > unstable stress issue. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

Re: [edk2] [PATCH edk2-platforms v1 07/16] Hisilicon/D0x: Rename StartupAp() function

2019-02-11 Thread Leif Lindholm
s, which can be assigned tasks using the > EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be 'BSP'. > So, Rename StartupAp() to StartUpBSP. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm Thanks!

[edk2] [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h

2019-02-11 Thread Leif Lindholm
Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe .vfr rather than local definitions. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 9 + 1 file changed, 1

Re: [edk2] [PATCH edk2-platforms v1 06/16] Hisilicon/D06: Add OemGetCpuFreq to encapsulate difference

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:26PM +0800, Ming Huang wrote: > From: xingjiang tang > > Implementation OemGetCpuFreq() to get cpu frequency from cpld to > encapsulate project difference, for some projects don't support > get cpu frequency by this way. > > Contributed-under: TianoCore

Re: [edk2] [PATCH edk2-platforms v1 05/16] Hisilicon/D06: Add more PCIe port INT-x support

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:25PM +0800, Ming Huang wrote: > From: Jason Zhang > > Since NVMe riser width is 6*X4, need add the related > port's INT-x support to match OS driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- >

Re: [edk2] [PATCH edk2-platforms 6/8] Silicon/SynQuacer/Stage2Tables: fix 32-bit build

2019-02-11 Thread Leif Lindholm
On Mon, Jan 14, 2019 at 06:52:07PM +0100, Ard Biesheuvel wrote: > On Mon, 14 Jan 2019 at 18:02, Ard Biesheuvel > wrote: > > > > The static stage2 page tables don't contain any code, but we are > > relying on the linker to resolve the references to the next level > > tables, so we can only use

Re: [edk2] [PATCH edk2-platforms v1 02/16] Hisilicon/D0x: Add DriverHealthManagerDxe

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:22PM +0800, Ming Huang wrote: > DriverHealthManagerDxe Collect driver health form of third party > drivers to repair no healthy card. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by

Re: [edk2] [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:21PM +0800, Ming Huang wrote: > SerdesLib is useless for SmbiosMiscDxe and D06, so remove it. Should it not then also delete #include from Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c

Re: [edk2] [PATCH edk2-platforms v1 12/16] Hisilicon/D06: Use new flash layout

2019-02-11 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:32PM +0800, Ming Huang wrote: > In new flash layout, BIOS fd change from offset 1M to 8M in 16M > spi flash. This bit > Use the new CustomData.Fv which indicate the offset > of fd and which flash area can be updated for BMC. is of critical importance. Should be its

Re: [edk2] [PATCH edk2-non-osi v1 6/7] Hisilicon/D06: Fix numa node wrong issue

2019-02-11 Thread Leif Lindholm
*bangs head on desk* That question I just asked as a reply to ("Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot") was meant to be a comment on this patch. So - was this change one that was meant to happen together with edk2-platforms "Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot"?

Re: [edk2] [PATCH edk2-platforms v3 4/5] Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot

2019-02-11 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 05:01:49PM +0800, Ming Huang wrote: > Linux kernel will recognize NUMA node by processor order, > and the Node and proximity domain (PXM) will be not identical > between BIOS and OS kernel after changing to TA(Totem A) boot, > so adjust the NUMA node number and proximity

Re: [edk2] [PATCH] MdePkg/BaseLib: implement SpeculationBarrier() for ARM and AArch64

2019-02-11 Thread Leif Lindholm
gt; version 2.4, dated October 2018. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Patch looks fine. Reviewed-by: Leif Lindholm Question: do we expect performance impact to be sufficient to motivate a Pcd to be able to disable the b

Re: [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg

2019-02-11 Thread Leif Lindholm
On Mon, Feb 11, 2019 at 01:53:43PM +0100, Laszlo Ersek wrote: > OVMF can be built with a significant amount of TPM2 code now; add > Marc-André and Stefan as Reviewers for TPM2-related patches. > > Keep the list of "R" entries alphabetically sorted. For this patch: Revi

Re: [edk2] [PATCH] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-05 Thread Leif Lindholm
xLike/../../Source/Python/build/build.py", line > > 1921, in _MultiThreadBuildPlatform > > self.Progress > > File "BaseTools/Source/Python/AutoGen/AutoGen.py", line 304, in > > __init__ > > self._InitWorker(Workspace, MetaFil

Re: [edk2] BaseTools: handling of $(ARCH) in .dsc/.fdf when multiple -a specified

2019-02-05 Thread Leif Lindholm
On Mon, Feb 04, 2019 at 08:02:55PM +0100, Laszlo Ersek wrote: > > Now, the Ia32X64 target is very much of a special case, which I don't > > necessarily see as usefully supported by the current .dsc > > specification. But I believe we need to do one of > > - banning (simultaneous)

[edk2] BaseTools: handling of $(ARCH) in .dsc/.fdf when multiple -a specified

2019-02-04 Thread Leif Lindholm
Hi Bob, Liming, So, I've been playing around with merging the .dsc/.fdf files in OvmfPkg. Merging IA32 and X64 is simple enough, since you can test on !if $(ARCH) == "X64" However, from what I can tell, when trying to merge in the OvmfPkgIa32X64 platform - what you actually end up with in

Re: [edk2] [PATCH 0/6] fix top-level package builds for AARCH64/ARM

2019-02-04 Thread Leif Lindholm
lePkg/dsc: move DxeDebugSupportDxe to x86 only section") Since I now have R-b for the set, I have just pushed the remaining 5 as 6c61ec4c62..3b6c73f13e. On Thu, Nov 01, 2018 at 03:36:36PM +, Leif Lindholm wrote: > Most of the top-level packages should be buildable for all architectures > He

Re: [edk2] BaseTools: build failure when specifying multiple BUILDTARGET

2019-02-04 Thread Leif Lindholm
On Mon, Feb 04, 2019 at 01:22:03PM +0100, Philippe Mathieu-Daudé wrote: > On 2/4/19 12:54 PM, Philippe Mathieu-Daudé wrote: > > On 2/4/19 10:58 AM, Leif Lindholm wrote: > >> Hi Bob, Liming, > >> > >> With the latest BaseTools (current HEAD, 6c61ec4c62), building

Re: [edk2] [PATCH v2] AppPkg: fix webserver build for !Ia32/X64

2019-02-04 Thread Leif Lindholm
Mike, Daryl, Jaben - any comments on v2? On Fri, Nov 02, 2018 at 10:50:15AM +, Leif Lindholm wrote: > The WebServer application is not meant to be Ia32/X64 specific, and would > build for other architectures, if it wasn't for the > #include > in WebServer.h. Move that stateme

[edk2] BaseTools: build failure when specifying multiple BUILDTARGET

2019-02-04 Thread Leif Lindholm
Hi Bob, Liming, With the latest BaseTools (current HEAD, 6c61ec4c62), building multiple targets from a single command line crashes. To reproduce: build -a IA32 -t GCC5 -b RELEASE -b NOOPT -p OvmfPkg/OvmfPkgIa32.dsc (I first built with -n32, but dropped that to see if it would make a difference -

Re: [edk2] [PATCH v4 edk2-platforms 01/23] Silicon/Broadcom/Bcm282x: Add interrupt driver

2019-02-01 Thread Leif Lindholm
wrote: > > On 01/31/19 22:01, Andrew Fish wrote: > > > > > > > > > > On Jan 31, 2019, at 11:57 AM, Leif Lindholm > > > > wrote: > > > > > > > > +Andrew, Laszlo, Mike. > > > > > > > &g

Re: [edk2] [PATCH v4 edk2-platforms 01/23] Silicon/Broadcom/Bcm282x: Add interrupt driver

2019-01-31 Thread Leif Lindholm
+Andrew, Laszlo, Mike. On Thu, Jan 31, 2019 at 06:19:48PM +0100, Ard Biesheuvel wrote: > On Thu, 31 Jan 2019 at 16:24, Leif Lindholm wrote: > > > > On Tue, Jan 29, 2019 at 04:26:33PM +, Pete Batard wrote: > > > Contributed-under: TianoCore Contribution Agreement 1.1 &

Re: [edk2] [PATCH edk2-platforms] Silicon/Bcm2836: add random number generator driver

2019-01-31 Thread Leif Lindholm
On Thu, Jan 31, 2019 at 06:14:45PM +0100, Ard Biesheuvel wrote: > On Thu, 31 Jan 2019 at 16:05, Leif Lindholm wrote: > > > > On Wed, Jan 30, 2019 at 08:39:43PM +0100, Ard Biesheuvel wrote: > > > Expose the SoC's RNG peripheral via the EFI_RNG_PROTOCOL. > > &

Re: [edk2] [PATCH] EmbeddedPkg/DwEmacSnpDxe: Add designware emac support This add support for designware emac controller

2019-01-31 Thread Leif Lindholm
Hi Tzy Way, Thank you for this contribution. I do have some high-level comments. First of all, my best guess is that you have used Lan9118Dxe for reference when developing this driver. This is somewhat unfortunate. I am reminded that a) we badly need to migrate that driver (and Lan91xDxe) to

Re: [edk2] [PATCH v4 edk2-platforms 01/23] Silicon/Broadcom/Bcm282x: Add interrupt driver

2019-01-31 Thread Leif Lindholm
On Tue, Jan 29, 2019 at 04:26:33PM +, Pete Batard wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard > > Reviewed-by: Ard Biesheuvel > --- > Silicon/Broadcom/Bcm283x/Bcm283x.dec | 23 ++ >

Re: [edk2] [PATCH edk2-platforms] Silicon/Bcm2836: add random number generator driver

2019-01-31 Thread Leif Lindholm
On Wed, Jan 30, 2019 at 08:39:43PM +0100, Ard Biesheuvel wrote: > Expose the SoC's RNG peripheral via the EFI_RNG_PROTOCOL. > This is used by Linux to seed the KASLR routines. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Not tested, but looks fine.

Re: [edk2] [PATCH v4 edk2-platforms 20/23] Platform/Raspberry/Pi3: Add platform readme

2019-01-31 Thread Leif Lindholm
On Thu, Jan 31, 2019 at 12:30:22PM +, Pete Batard wrote: > Hi Leif. Thanks for reviewing this patchset. > > On 2019.01.30 21:50, Leif Lindholm wrote: > > Hi Pete, > > > > I will only have minor comments on this set, but I'll start with this > > documentati

Re: [edk2] [platforms: PATCH v3 0/5] Armada7k8k memory handling update

2019-01-31 Thread Leif Lindholm
On Thu, Jan 31, 2019 at 01:06:15PM +0100, Marcin Wojtas wrote: > czw., 31 sty 2019 o 11:28 Leif Lindholm napisał(a): > > > > On Thu, Jan 31, 2019 at 08:01:08AM +0100, Marcin Wojtas wrote: > > > Hi Leif, > > > > > > Thanks a lot. While at it - do

Re: [edk2] [platforms: PATCH v3 0/5] Armada7k8k memory handling update

2019-01-31 Thread Leif Lindholm
I feel it's probably ARM-platform specific. I mean, hopefully we'll some day we'll get a sane reporting mechanism of Secure-reserved regions by ARM-TF and we can drop this juggling in Non-secure firmware. Best Regards, Leif > Best regards, > Marcin > > śr., 30 sty 2019 o 17:47

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-30 Thread Leif Lindholm
On Wed, Jan 30, 2019 at 09:59:34PM +, Leif Lindholm wrote: > Hi Pete, > > I have two annoying pieces of feedback that apply to the whole set. > > Firstly, I would really appreciate if we could have some sort of > commit messages rather than just subject lines. >

  1   2   3   4   5   6   7   8   9   10   >