Re: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of nkvangup Sent: Monday, April 1, 2019 4:16 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Dong, Eric ; Laszlo Ersek Subject: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save &

Re: [edk2] [PATCH v6] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-03-30 Thread Zeng, Star
Not comment to functionality. But just some observations about code style. Please check them inline. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > nkvangup > Sent: Friday, March 29, 2019 12:58 PM > To: edk2-devel@lists.01.org > Cc: Yao,

Re: [edk2] [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc

2019-03-20 Thread Zeng, Star
age- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, March 21, 2019 1:43 AM To: Laszlo Ersek Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Wang, Jian J ; Wu, Hao A ; Ni, Ray ; Zeng, Star ; Andrew Fish ; Kinney, Michael D Subject: Re: [RFC PATCH] MdeModule

Re: [edk2] [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc

2019-03-20 Thread Zeng, Star
A ; Ni, Ray ; Zeng, Star ; Andrew Fish ; Kinney, Michael D Subject: Re: [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc Hi Leif, On 03/18/19 15:56, Leif Lindholm wrote: > Commit 05fd2a926833 > ("MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList > L

Re: [edk2] [PATCH v2 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information

2019-03-12 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shenglei Zhang Sent: Tuesday, March 12, 2019 10:05 AM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Dong, Eric Subject: [edk2] [PATCH v2 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add

Re: [edk2] [Patch v2 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

2019-03-05 Thread Zeng, Star
And suggest update the title to be like "UefiCpuPkg: Retire PcdCpuFeaturesUserConfiguration". Thanks, Star -Original Message----- From: Zeng, Star Sent: Tuesday, March 5, 2019 5:55 PM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Ni, Ray ; Laszlo Ersek (ler...@redhat.com) ; G

Re: [edk2] [Patch v2 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

2019-03-05 Thread Zeng, Star
It should be an incompatible change to remove PcdCpuFeaturesUserConfiguration. Please add upgrade notes for it. I know upgrade notes for 2019 Q1 stable tag is at https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes. I do not know where is the link for 2019 Q1 stable tag.

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Direct allocate buffer for Wake up Buffer.

2019-03-04 Thread Zeng, Star
Just an idea to avoid hard code value 0x88000. Before EndOfDxe: Allocate buffer in AllocateResetVector(), and free buffer in FreeResetVector(). At EndOfDxe (it is after LegacyBiosDxe driver entry point) callback: Allocate buffer and record it to CpuMpData->WakeupBuffer, and always occupy the

Re: [edk2] [PATCH v2] MdePkg/Library: Install dummy variable arch protocol

2019-03-01 Thread Zeng, Star
:31 PM To: Jagadeesh Ujja Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao B ; Leif Lindholm ; Zeng, Star ; Yao, Jiewen ; Kinney, Michael D Subject: Re: [PATCH v2] MdePkg/Library: Install dummy variable arch protocol On Fri, 1 Mar 2019 at 12:14, Jagadeesh Ujja wrote: > > In a

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-21 Thread Zeng, Star
On 2019/2/21 17:11, Ard Biesheuvel wrote: On Thu, 21 Feb 2019 at 10:04, Laszlo Ersek wrote: On 02/20/19 13:23, Ard Biesheuvel wrote: On Wed, 20 Feb 2019 at 06:53, Jagadeesh Ujja wrote: hi Ard, On Tue, Feb 19, 2019 at 6:55 PM Ard Biesheuvel wrote: Hello Jagadeesh, On Tue, 19 Feb 2019

Re: [edk2] [PATCH] MdeModulePkg/PropertiesTableAttributesDxe: Remove this driver

2019-02-18 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wang, Jian J Sent: Monday, February 18, 2019 10:16 PM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Ni, Ray ; Zeng, Star Subject: RE: [PATCH] MdeModulePkg/PropertiesTableAttributesDxe: Remove this driver Reviewed

Re: [edk2] [patch V4] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-18 Thread Zeng, Star
Reviewed-by: Star Zeng . -Original Message- From: Bi, Dandan Sent: Monday, February 18, 2019 9:37 PM To: edk2-devel@lists.01.org Cc: Max Knutsen ; Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Michael Turner ; Gao, Liming Subject: [patch V4] MdeModulePkg/ReportStatusCodeLib: Avoid using

Re: [edk2] [patch V3] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-18 Thread Zeng, Star
10:43 AM To: edk2-devel@lists.01.org Cc: Max Knutsen ; Wu, Hao A ; Michael Turner ; Gao, Liming ; Zeng, Star Subject: [edk2] [patch V3] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible From: Max Knutsen REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1114 V2: simplify

Re: [edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-15 Thread Zeng, Star
After applying the patch, the author is Max and the Signed-off-by is Dandan, is it expected? And the code below is better to be into the else condition (stack buffer is not enough), right? if (gBS == NULL || gBS->AllocatePool == NULL || gBS->FreePool == NULL) { return EFI_UNSUPPORTED;

Re: [edk2] [PATCH v4 11/13] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

2019-02-14 Thread Zeng, Star
Some minor comments. With them addressed, Reviewed-by: Star Zeng . On 2019/2/11 15:57, Hao Wu wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). Please note that the new support

Re: [edk2] [PATCH v4 09/13] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_'

2019-02-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wu, Hao A Sent: Monday, February 11, 2019 3:58 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Wang, Jian J ; Zeng, Star Subject: [PATCH v4 09/13] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_' This commit is out

Re: [edk2] [PATCH v4 10/13] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

2019-02-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wu, Hao A Sent: Monday, February 11, 2019 3:58 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Wang, Jian J ; Zeng, Star Subject: [PATCH v4 10/13] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox() This commit is out

Re: [edk2] [PATCH v3 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Zeng, Star
// // Perform platform specific initialization before entering PeiCore. // This comment block should be also moved together with SecPlatformMain() calling, right? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel,

Re: [edk2] [PATCH v3 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel, Chiu Sent: Thursday, February 14, 2019 6:59 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2] [PATCH v3 1/3] MdePkg: Support

Re: [edk2] [PATCH v3 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Thursday, February 14, 2019 6:59 PM To: edk2-devel@lists.01.org Cc: Wang, Jian J ; Wu, Hao A ; Ni, Ray ; Zeng, Star ; Gao, Liming ; Chiu, Chasel Subject: [PATCH v3 2/3] MdeModulePkg/PeiMain: Support

Re: [edk2] [PATCH v2 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel, Chiu Sent: Wednesday, February 13, 2019 5:47 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2] [PATCH v2 1/3] MdePkg: Support

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Wednesday, February 13, 2019 5:47 PM To: edk2-devel@lists.01.org Cc: Wang, Jian J ; Wu, Hao A ; Ni, Ray ; Zeng, Star ; Gao, Liming ; Chiu, Chasel Subject: [PATCH v2 2/3] MdeModulePkg/PeiMain: Support

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Zeng, Star
With this addressed, Reviewed-by: Star Zeng . -Original Message- From: Chiu, Chasel Sent: Wednesday, February 13, 2019 11:59 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Ni, Ray ; Zeng, Star ; Gao, Liming Subject: RE: [PATCH 2/3] MdeModulePkg/PeiMain: Support

Re: [edk2] [PATCH 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Zeng, Star
On 2019/2/12 21:19, Chasel, Chiu wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 Add EFI_PEI_CORE_FV_LOCATION_PPI definition basing on PI spec 1.7, Section 6.3.9. This PPI can support the secnario that PEI Foundation not in BFV. Cc: Michael D Kinney Cc: Liming Gao

Re: [edk2] [PATCH] MdeModulePkg VariableStandaloneMm: Add PcdEmuVariableNvModeEnable in inf

2019-01-24 Thread Zeng, Star
Thanks. I just pushed it at 9084239f3440369fcb5ff0476d9bdd9442a03258 since it is a build failure. Star -Original Message- From: Wang, Jian J Sent: Friday, January 25, 2019 9:42 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Ard Biesheuvel ; Bi, Dandan Subject: RE

Re: [edk2] [PATCH] IntelFsp2Pkg: FSP can utilize bootloader stack

2019-01-24 Thread Zeng, Star
On 2019/1/23 17:33, Chasel, Chiu wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1485 Current FSP utilizes pre-allocated temporary memory from boot loader for both heap and stack. To reduce overall temporary memory usage FSP may share the same stack with boot loader and only needs a

Re: [edk2] [PATCH] IntelFsp2Pkg: Add function to get bootloader stack pointer

2019-01-24 Thread Zeng, Star
On 2019/1/23 13:36, Chasel, Chiu wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1391 FSP on-going enhancement for stack utilization required to know bootloader stack pointer and this pointer can be retrieved by first input parameter address when FSP-M entry API invoked by

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-23 Thread Zeng, Star
On 2019/1/23 20:15, Julien Grall wrote: On 23/01/2019 01:41, Zeng, Star wrote: Hi Julien, Hi Star, On 2019/1/22 12:30, Zeng, Star wrote: On 2019/1/22 3:40, Ard Biesheuvel wrote: On Mon, 21 Jan 2019 at 14:36, Julien Grall wrote: diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-22 Thread Zeng, Star
Hi Julien, On 2019/1/22 12:30, Zeng, Star wrote: Hi, On 2019/1/22 3:40, Ard Biesheuvel wrote: On Mon, 21 Jan 2019 at 14:36, Julien Grall wrote: Hi, On 21/01/2019 10:46, Zeng, Star wrote: On 2019/1/18 2:59, Julien Grall wrote: I saw the discussion at https://lists.01.org/pipermail/edk2

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-21 Thread Zeng, Star
Hi, On 2019/1/22 3:40, Ard Biesheuvel wrote: On Mon, 21 Jan 2019 at 14:36, Julien Grall wrote: Hi, On 21/01/2019 10:46, Zeng, Star wrote: On 2019/1/18 2:59, Julien Grall wrote: I saw the discussion at https://lists.01.org/pipermail/edk2-devel/2019-January/035405.html. Fortunately, it has

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-21 Thread Zeng, Star
Hi Julien, On 2019/1/18 2:59, Julien Grall wrote: Hi Star, On 17/01/2019 01:26, Zeng, Star wrote: On 2019/1/16 22:26, Julien Grall wrote: Hi Laszlo, On 15/01/2019 09:37, Laszlo Ersek wrote: On 01/14/19 16:19, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge

Re: [edk2] [PATCH] IntelFsp2Pkg: Remove unused keyword in new PPI header

2019-01-20 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel, Chiu Sent: Monday, January 21, 2019 1:56 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH] IntelFsp2Pkg: Remove unused keyword in new PPI header

Re: [edk2] [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules

2019-01-18 Thread Zeng, Star
Anther, the parameters of constructor are removed, so their descriptions in function header also need to be cleaned up. Same comment to patch 2. With them fixed, Reviewed-by: Star Zeng to the series. Thanks, Star -Original Message- From: Zeng, Star Sent: Friday, January 18, 2019 4:15

Re: [edk2] [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules

2019-01-18 Thread Zeng, Star
, January 17, 2019 5:22 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming ; Ye, Ting ; Wei, Gang ; Wang, Jian J ; Zhang, Chao B ; Yao, Jiewen ; Wu, Hao A ; Zeng, Star ; Achin Gupta ; Jagadeesh Ujja Subject: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-16 Thread Zeng, Star
On 2019/1/16 22:26, Julien Grall wrote: Hi Laszlo, On 15/01/2019 09:37, Laszlo Ersek wrote: On 01/14/19 16:19, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated

Re: [edk2] [PATCH v2 09/17] MdePkg: introduce standalone MM entry point library class

2019-01-15 Thread Zeng, Star
On 2019/1/14 21:27, Ard Biesheuvel wrote: Add the library interface for the standalone MM driver entry point. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdePkg/MdePkg.dec | 3 +

Re: [edk2] [PATCH v2 14/17] MdeModulePkg/MdeModulePkg/dsc: move DxeDebugSupportDxe to x86 only section

2019-01-15 Thread Zeng, Star
On 2019/1/14 21:27, Ard Biesheuvel wrote: MdeModulePkg/Universal/DebugSupportDxe/DebugSupportDxe.inf does not build for AARCH64 since it does not provide the needed PlDebugSupport.h header. So move the module to a x86 only section. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v2 12/17] MdeModulePkg: implement NULL instance of HobLib library class

2019-01-15 Thread Zeng, Star
On 2019/1/14 21:27, Ard Biesheuvel wrote: In order to permit MM_STANDALONE modules to be built without relying on StandaloneMmPkg, provide a BASE type NULL implementation of HobLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Star Zeng

Re: [edk2] [PATCH v2 13/17] MdeModulePkg: implement NULL instance of MemoryAllocationLib library class

2019-01-15 Thread Zeng, Star
On 2019/1/14 21:27, Ard Biesheuvel wrote: In order to permit MM_STANDALONE modules to be built without relying on StandaloneMmPkg, provide a BASE type NULL implementation of MemoryAllocationLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH v2 17/17] MdeModulePkg/MdeModulePkg.dsc: add MM_STANDALONE FTW and variable modules

2019-01-15 Thread Zeng, Star
On 2019/1/14 21:27, Ard Biesheuvel wrote: For build testing coverage, add the newly introduced MM_STANDALONE versions of the fault tolerant write (FTW) and variable runtime driver to MdeModulePkg.dsc. Note that the resulting binaries will not be able to run, since they rely on dummy

Re: [edk2] [PATCH v2 16/17] MdeModulePkg/VarCheckLib: add MM_STANDALONE support

2019-01-15 Thread Zeng, Star
On 2019/1/14 21:27, Ard Biesheuvel wrote: Add MM_STANDALONE to the list of permitted module types of the VarCheckLib library implementation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Star Zeng ---

Re: [edk2] [PATCH v2 15/17] MdeModulePkg/AuthVariableLibNull: add MM_STANDALONE support

2019-01-15 Thread Zeng, Star
On 2019/1/14 21:27, Ard Biesheuvel wrote: Add MM_STANDALONE to the list of permitted module types of the AuthVariableLibNull library implementation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Star Zeng ---

Re: [edk2] [PATCH v2 01/17] MdeModulePkg/MdeModulePkg.dsc: add MmServicesTableLib resolution

2019-01-15 Thread Zeng, Star
On 2019/1/14 21:27, Ard Biesheuvel wrote: The SMM based FTW and variable drivers are going to depend on MmServicesTableLib after a subsequent patch, so add a resolution for it to MdeModulePkg.dsc. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2 08/17] MdeModulePkg/VariableRuntimeDxe: implement standalone MM version

2019-01-15 Thread Zeng, Star
One minor comment. With it handled, Reviewed-by: Star Zeng On 2019/1/14 21:27, Ard Biesheuvel wrote: Reuse most of the existing code to implement a variable runtime driver that will be able to execute in the context of standalone MM. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v2 07/17] MdeModulePkg/VariableRuntimeDxe: factor out boot service accesses

2019-01-15 Thread Zeng, Star
Some minor comments. With them handled, Reviewed-by: Star Zeng On 2019/1/14 21:27, Ard Biesheuvel wrote: In preparation of providing a standalone MM based variable runtime driver, move the existing SMM driver to the new MM services table, and factor out some pieces that are specific to the

Re: [edk2] [PATCH v2 06/17] MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version

2019-01-15 Thread Zeng, Star
One minor comment. With it handled, Reviewed-by: Star Zeng On 2019/1/14 21:27, Ard Biesheuvel wrote: Implement a new version of the fault tolerant write driver that can be used in the context of a standalone MM implementation. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v2 05/17] MdeModulePkg/FaultTolerantWriteDxe: factor out boot service accesses

2019-01-15 Thread Zeng, Star
Some minor comments. With them handled, Reviewed-by: Star Zeng Thanks, Star On 2019/1/14 21:27, Ard Biesheuvel wrote: In preparation of providing a standalone MM based FTW driver, move the existing SMM driver to the new MM services table, and factor out some pieces that are specific to the

Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-15 Thread Zeng, Star
On 2019/1/15 14:37, Wang, Jian J wrote: Hi Star, One comment below. -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD

Re: [edk2] [PATCH V2 06/15] MdeModulePkg Variable: Remove CacheOffset in UpdateVariable()

2019-01-15 Thread Zeng, Star
On 2019/1/15 17:58, Laszlo Ersek wrote: On 01/15/19 09:04, Wang, Jian J wrote: Star, Just a tiny comment below. With it's addressed, Reviewed-by: Jian J Wang -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star

Re: [edk2] [PATCH V2 08/15] MdeModulePkg Variable: Add emulated variable NV mode support

2019-01-15 Thread Zeng, Star
On 2019/1/15 17:33, Laszlo Ersek wrote: On 01/14/19 16:19, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Add emulated variable NV mode support in real variable driver. Platform can configure PcdEmuVariableNvModeEnable

Re: [edk2] [PATCH V2 08/15] MdeModulePkg Variable: Add emulated variable NV mode support

2019-01-14 Thread Zeng, Star
On 2019/1/15 14:01, Wang, Jian J wrote: Hi Star, Just two minor comments below. -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Kinney, Michael D ; Gao, Liming ; Ni, Ray ; Laszlo Ersek

Re: [edk2] [PATCH v3] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode

2019-01-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Tuesday, January 15, 2019 2:03 PM To: edk2-devel@lists.01.org Cc: Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel Subject: [PATCH v3] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode REF: https

Re: [edk2] [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec

2019-01-14 Thread Zeng, Star
On 2019/1/15 13:05, Wang, Jian J wrote: Hi Star, -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A Subject: [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec REF: https

Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Zeng, Star
On 2019/1/15 13:48, Wu, Hao A wrote: Hi Star, One minor comment below. -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star; Wang, Jian J; Wu, Hao A Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD

Re: [edk2] [PATCH V2 12/15] BeagleBoardPkg: Use merged variable driver for emulated NV mode

2019-01-14 Thread Zeng, Star
On 2019/1/15 6:11, Leif Lindholm wrote: Hi Star, This set looks like a good cleanup. Thanks. This patch also need an added resolution for SynchronizationLib. (MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf should be fine.) Oh, yes. I assumed it has been there, but it is

Re: [edk2] [PATCH 08/12] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-14 Thread Zeng, Star
Hi Laszlo, On 2019/1/14 19:40, Laszlo Ersek wrote: On 01/13/19 16:37, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the

Re: [edk2] [PATCH 06/12] MdeModulePkg Variable: Add emulated variable NV mode support

2019-01-14 Thread Zeng, Star
Hi Laszlo, Yes, agree with the suggestions. Two patches have been separated from this patch in V2 patch series at https://lists.01.org/pipermail/edk2-devel/2019-January/035015.html. Thanks, Star On 2019/1/14 18:57, Laszlo Ersek wrote: Hi Star, On 01/13/19 16:37, Star Zeng wrote: REF:

Re: [edk2] [PATCH 05/12] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dsc

2019-01-14 Thread Zeng, Star
Hi Laszlo, On 2019/1/14 18:22, Laszlo Ersek wrote: Hi Star, On 01/13/19 16:37, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Add PcdEmuVariableNvModeEnable (support both static and dynamic) to indicate if Variable

Re: [edk2] [PATCH 01/12] MdeModulePkg Variable: Add some missing changes for 9b18845

2019-01-14 Thread Zeng, Star
Hi Laszlo, On 2019/1/14 18:15, Laszlo Ersek wrote: Hi Star, On 01/13/19 16:37, Star Zeng wrote: 9b18845a4b4cd1d2cf004cbc1cadf8a93ccb37ea changed the code which read from physical MMIO address to read from memory cache. The patch adds some missing changes for it. I found them when updating

Re: [edk2] [Patch 0/2] Use correct field name.

2019-01-13 Thread Zeng, Star
Agree with Laszlo's comments to those two patches. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, January 11, 2019 6:45 PM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Ni, Ray ;

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-13 Thread Zeng, Star
Ard, FYI: There is minor change overlap to VariableDxe/Smm.c between this patch series and the patch series at https://lists.01.org/pipermail/edk2-devel/2019-January/034921.html ([PATCH 04/12]) I just sent. After one patch series is pushed, the other patch series will need a simple rebase.

Re: [edk2] [PATCH 4/6] MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version

2019-01-10 Thread Zeng, Star
On 2019/1/11 0:23, Ard Biesheuvel wrote: On Thu, 10 Jan 2019 at 14:03, Laszlo Ersek wrote: On 01/10/19 08:59, Zeng, Star wrote: On 2019/1/10 15:33, Ard Biesheuvel wrote: On Thu, 10 Jan 2019 at 08:30, Zeng, Star wrote: Hi Ard, Another minor feedback. On 2019/1/10 14:47, Zeng, Star wrote

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-10 Thread Zeng, Star
We'd better have a bugzilla to track this change. And since it will require platform change in platform dsc to add the new library mapping, we need add notes in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes. Thanks, Star On 2019/1/4 2:28, Ard Biesheuvel wrote:

Re: [edk2] [PATCH 4/6] MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version

2019-01-10 Thread Zeng, Star
On 2019/1/10 15:33, Ard Biesheuvel wrote: On Thu, 10 Jan 2019 at 08:30, Zeng, Star wrote: Hi Ard, Another minor feedback. On 2019/1/10 14:47, Zeng, Star wrote: Hi Ard, Some minor feedback added inline. On 2019/1/4 2:28, Ard Biesheuvel wrote: Implement a new version of the fault tolerant

Re: [edk2] [PATCH 4/6] MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version

2019-01-09 Thread Zeng, Star
Hi Ard, Another minor feedback. On 2019/1/10 14:47, Zeng, Star wrote: Hi Ard, Some minor feedback added inline. On 2019/1/4 2:28, Ard Biesheuvel wrote: Implement a new version of the fault tolerant write driver that can be used in the context of a standalone MM implementation. Contributed

Re: [edk2] [PATCH 6/6] MdeModulePkg/VariableRuntimeDxe: implement standalone MM version

2019-01-09 Thread Zeng, Star
Hi Ard, Some minor feedback added below. With them handled, Reviewed-by: Sta Zeng . On 2019/1/4 2:28, Ard Biesheuvel wrote: Reuse most of the existing code to implement a variable runtime driver that will be able to execute in the context of standalone MM. Contributed-under: TianoCore

Re: [edk2] [PATCH 5/6] MdeModulePkg/VariableRuntimeDxe: factor out boot service accesses

2019-01-09 Thread Zeng, Star
Hi Ard, Some minor feedback added inline. On 2019/1/4 2:28, Ard Biesheuvel wrote: In preparation of providing a standalone MM based variable runtime driver, move the existing SMM driver to the new MM services table, and factor out some pieces that are specific to the traditional driver, mainly

Re: [edk2] [PATCH 5/6] MdeModulePkg/VariableRuntimeDxe: factor out boot service accesses

2019-01-09 Thread Zeng, Star
On 2019/1/10 10:33, Wang, Jian J wrote: Laszlo, Regards, Jian -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, January 08, 2019 11:38 PM To: Ard Biesheuvel ; edk2-devel@lists.01.org Cc: Leif Lindholm ; Kinney, Michael D ; Gao, Liming ; Wang, Jian J ; Wu,

Re: [edk2] [PATCH 2/6] MdePkg: implement MmServicesTableLib based on traditional SMM

2019-01-09 Thread Zeng, Star
Hi Ard, Another minor feedback. On 2019/1/10 14:14, Zeng, Star wrote: Hi Ard, Some minor feedback added inline. On 2019/1/4 2:28, Ard Biesheuvel wrote: The definitions of the rebranded MM protocol stack were chosen such that the existing SMM based core drivers can be reused. So let's

Re: [edk2] [PATCH 4/6] MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version

2019-01-09 Thread Zeng, Star
Hi Ard, Some minor feedback added inline. On 2019/1/4 2:28, Ard Biesheuvel wrote: Implement a new version of the fault tolerant write driver that can be used in the context of a standalone MM implementation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 3/6] MdeModulePkg/FaultTolerantWriteDxe: factor out boot service accesses

2019-01-09 Thread Zeng, Star
Hi Ard, Some minor feedback added inline. On 2019/1/4 2:28, Ard Biesheuvel wrote: In preparation of providing a standalone MM based FTW driver, move the existing SMM driver to the new MM services table, and factor out some pieces that are specific to the traditional driver, mainly related to

Re: [edk2] [PATCH 4/6] MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version

2019-01-09 Thread Zeng, Star
On 2019/1/10 9:41, Wang, Jian J wrote: Ard, Regards, Jian -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, January 04, 2019 2:28 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel ; Laszlo Ersek ; Leif Lindholm ; Kinney, Michael D ; Gao, Liming

Re: [edk2] [PATCH 2/6] MdePkg: implement MmServicesTableLib based on traditional SMM

2019-01-09 Thread Zeng, Star
Hi Ard, Some minor feedback added inline. On 2019/1/4 2:28, Ard Biesheuvel wrote: The definitions of the rebranded MM protocol stack were chosen such that the existing SMM based core drivers can be reused. So let's implement MmServicesTableLib based on gEfiMmBaseProtocolGuid, which is simply

Re: [edk2] [PATCH 1/6] MdePkg/Include: add MmServicesTableLib header file

2019-01-09 Thread Zeng, Star
Hi Ard, Some feedback added inline. On 2019/1/4 2:28, Ard Biesheuvel wrote: From: Jagadeesh Ujja SMM has been rebranded as MM, and can be implemented in traditional mode or standalone mode, using the same prototype for the services table. Expose this table via MmServicesTableLib, permitting

Re: [edk2] [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib

2019-01-08 Thread Zeng, Star
How about updating "2018" to "2019"? :) With that, Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: Carsey, Jaben Sent: Wednesday, January 9, 2019 5:58 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J Subject: [Patch v1 1/1] MdeMod

Re: [edk2] [patch] MdeModulePkg/NonDiscoverable: Use compare operator for comparison

2019-01-01 Thread Zeng, Star
if (Attributes) { if ((Attributes & (~(DEV_SUPPORTED_ATTRIBUTES))) != 0) { return EFI_UNSUPPORTED; } } If ((Attributes & (~(DEV_SUPPORTED_ATTRIBUTES))) != 0) is TRUE, the Attributes must be not 0. So " if (Attributes " could be removed. BTW: This code block has

Re: [edk2] [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-18 Thread Zeng, Star
Yi, Zailiang and David, So, is it ok to give RB to the patch from you? :) Thanks, Star -Original Message- From: Qian, Yi Sent: Wednesday, December 19, 2018 9:21 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Sun, Zailiang ; Wei, David Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg

Re: [edk2] [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-18 Thread Zeng, Star
. Thanks, Star -Original Message- From: Qian, Yi Sent: Tuesday, December 18, 2018 10:08 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Sun, Zailiang Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement Hi Star, This patch is good to me. Only one thing I

Re: [edk2] [edk2-platforms PATCH 2/2] PurleyOpenBoardPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-18 Thread Zeng, Star
Could you help take a review to the patch? :) Thanks, Star -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:43 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Lu, Shifei A ; Zhou, Bowen ; Oram, Isaac W Subject: [edk2-platforms PATCH 2/2] PurleyOpenBoardPkg: Remove

Re: [edk2] [PATCH 4/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported

2018-12-17 Thread Zeng, Star
Jian, Good observation. I did consider it. But they are handling different structures. Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, December 18, 2018 10:24 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D

Re: [edk2] [PATCH 1/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv

2018-12-17 Thread Zeng, Star
Good suggestion. It will make the buffer extension log consistent. I will send V2 to cover it with some test. Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, December 18, 2018 10:04 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Gao, Liming ; Ni, Ruiyu

Re: [edk2] [PATCH] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode

2018-12-10 Thread Zeng, Star
Hi Chasel, Two minor comments are added inline. On 2018/12/7 21:30, Chasel, Chiu wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1381 In Dispatch mode FSP may consume PPI directly so creating FSPM_ARCH_CONFIG_PPI to align with FSPM_ARCH_UPD. Test: Verified on internal platform to

Re: [edk2] [PATCH v2] Maintainers.txt: Change package maintainer of IntelFsp*Pkg

2018-12-04 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Wednesday, December 5, 2018 8:49 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel Subject: [PATCH v2] Maintainers.txt: Change package maintainer of IntelFsp*Pkg Cc

Re: [edk2] [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni

2018-11-28 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Gao, Liming Sent: Thursday, November 29, 2018 9:18 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Zeng, Star Subject: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni https://bugzilla.tianocore.org/show_bug.cgi?id=1363 New PCD

Re: [edk2] [Patch] Edk2: Update FmpDevicePkg Maintainers

2018-11-27 Thread Zeng, Star
Philippe, Good suggestion. :) Let me send the patch. Thanks, Star -Original Message- From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] Sent: Tuesday, November 27, 2018 11:17 PM To: Gao, Liming ; edk2-devel@lists.01.org Cc: Zeng, Star Subject: Re: [edk2] [Patch] Edk2: Update

Re: [edk2] [PATCH] Maintainers.txt: Update maintainer & reviewer info for MdeModulePkg

2018-11-26 Thread Zeng, Star
Reviewed-by: Star Zeng Hao and Jian, thanks to spend effort as the maintainer. Star -Original Message- From: Wu, Hao A Sent: Tuesday, November 27, 2018 8:37 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star ; Wang, Jian J Subject: [PATCH] Maintainers.txt: Update maintainer

Re: [edk2] [PATCH] MdeModulePkg/LockboxNullLib: clean up INF file.

2018-11-25 Thread Zeng, Star
Forgot to push this patch. Just pushed it at ed3951ebbd20e1e29b093c753cf051e7e4b2bfae. Thanks, Star -Original Message- From: Zeng, Star Sent: Wednesday, January 17, 2018 12:38 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star Subject: [PATCH] MdeModulePkg/LockboxNullLib

Re: [edk2] [Patch] MdeModulePkg PCD: Add DynamicEx PcdVpdBaseAddress64 for non SPI platform

2018-11-25 Thread Zeng, Star
On 2018/11/22 22:32, Liming Gao wrote: https://bugzilla.tianocore.org/show_bug.cgi?id=1356 Current PcdVpdBaseAddress is 32bit static Pcd. NON SPI platform needs to configure it as Dynamic PCD. Emulator platform (such as NT32) may set its value to 64bit address. To meet with this usage, 64bit

Re: [edk2] [PATCH v2] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

2018-11-22 Thread Zeng, Star
Pushed at a90c7df7edeec375edee99bc9b116406543b9959. Thanks, Star -Original Message- From: Zeng, Star Sent: Thursday, November 22, 2018 8:57 AM To: Vijayenthiran Subramaniam ; edk2-devel@lists.01.org; Wang, Jian J ; Ni, Ruiyu Cc: Zeng, Star Subject: RE: [PATCH v2] MdeModulePkg

Re: [edk2] [PATCH v2 0/2] Fix constant if statement issue

2018-11-22 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel, Chiu Sent: Thursday, November 22, 2018 11:51 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Yao, Jiewen Subject: [edk2] [PATCH v2 0/2] Fix constant if statement

Re: [edk2] [PATCH v2] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

2018-11-21 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Vijayenthiran Subramaniam [mailto:vijayenthiran.subraman...@arm.com] Sent: Wednesday, November 21, 2018 11:29 PM To: edk2-devel@lists.01.org; Zeng, Star ; Wang, Jian J ; Ni, Ruiyu Cc: Vijayenthiran Subramaniam Subject: [PATCH v2

Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

2018-11-20 Thread Zeng, Star
On 2018/11/20 22:37, Gao, Liming wrote: Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, November 20, 2018 4:52 PM To: Gary Lin ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming

Re: [edk2] [PATCH] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

2018-11-20 Thread Zeng, Star
On 2018/11/20 19:17, Laszlo Ersek wrote: On 11/20/18 11:38, Vijayenthiran Subramaniam wrote: Print debug messages if size of the VariableName plus DataSize exceeds Max(Auth|Voltaile)VariableSize bytes. The messages will be useful if any platform specific value of Max(Auth|Voltaile)VariableSize

Re: [edk2] [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB

2018-11-20 Thread Zeng, Star
On 2018/11/20 21:15, Leif Lindholm wrote: On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg package. This driver requires the

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Revert 90c5bc08

2018-11-19 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Tuesday, November 20, 2018 11:53 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star ; Chiu, Chasel Subject: [PATCH] IntelFsp2WrapperPkg: Revert 90c5bc08 Commit message issue and reverted commit

Re: [edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr

2018-11-19 Thread Zeng, Star
Pushed at 316b3a719fd2ee97a01b0d941bba15ef06840d78. Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, November 19, 2018 1:48 PM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star Subject: RE: [edk2] [PATCH v2] MdeModulePkg: Remove

Re: [edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr

2018-11-18 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shenglei Zhang Sent: Monday, November 19, 2018 12:39 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star Subject: [edk2] [PATCH v2] MdeModulePkg: Remove

Re: [edk2] [PATCH v2 1/2] MdeModulePkg/SmmCorePerfLib: [CVE-2017-5753] Fix bounds check bypass

2018-11-15 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Friday, November 16, 2018 12:13 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Laszlo Ersek ; Yao, Jiewen ; Zeng, Star Subject: [edk2] [PATCH v2 1/2

Re: [edk2] [PATCH v1 1/2] MdeModulePkg/SmmCorePerfLib: [CVE-2017-5753] Fix bounds check bypass

2018-11-15 Thread Zeng, Star
On 2018/11/16 9:37, Hao Wu wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1194 Speculative execution is used by processor to avoid having to wait for data to arrive from memory, or for previous operations to finish, the processor may speculate as to what will be executed. If the

Re: [edk2] [PATCH] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr

2018-11-15 Thread Zeng, Star
Of Shenglei Zhang Sent: Thursday, November 15, 2018 3:46 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr PcdIdentifyMappingPageTablePtr is useless and could be removed. https://bugzilla.tianocore.org/show_bug.cgi?id

  1   2   3   4   5   6   7   8   9   10   >