Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-14 Thread Gao, Liming
Ard: Got it. I will update our internal platform dsc to include new MmServicesTableLib library. Besides, will you send the patch to update platform DSC files in edk2-platforms? If yes, please update DSCs in https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform. They both

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 03:55, Gao, Liming wrote: > > Ard: > I don't find the function issue in this patch. I have no other comments for > the change in MdePkg. Reviewed-by: Liming Gao . For > this patch set, if you push the change, please push the patches in MdePkg > first, and tell me the

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-13 Thread Gao, Liming
Ard: I don't find the function issue in this patch. I have no other comments for the change in MdePkg. Reviewed-by: Liming Gao . For this patch set, if you push the change, please push the patches in MdePkg first, and tell me the revision. I will update our internal platform DSC to include

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-13 Thread Zeng, Star
Ard, FYI: There is minor change overlap to VariableDxe/Smm.c between this patch series and the patch series at https://lists.01.org/pipermail/edk2-devel/2019-January/034921.html ([PATCH 04/12]) I just sent. After one patch series is pushed, the other patch series will need a simple rebase.

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-10 Thread Zeng, Star
We'd better have a bugzilla to track this change. And since it will require platform change in platform dsc to add the new library mapping, we need add notes in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes. Thanks, Star On 2019/1/4 2:28, Ard Biesheuvel wrote:

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-09 Thread Ard Biesheuvel
On Wed, 9 Jan 2019 at 22:46, Laszlo Ersek wrote: > > On 01/09/19 16:04, Laszlo Ersek wrote: > > On 01/09/19 11:28, Ard Biesheuvel wrote: > >> In the mean time, the hunk below should suffice to complete your > >> regression testing. > > I used: > > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-09 Thread Laszlo Ersek
On 01/09/19 16:04, Laszlo Ersek wrote: > On 01/09/19 11:28, Ard Biesheuvel wrote: >> In the mean time, the hunk below should suffice to complete your >> regression testing. I used: > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 3f3533e5c163..908450eda174 100644 > ---

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-09 Thread Ard Biesheuvel
On Wed, 9 Jan 2019 at 14:56, Gao, Liming wrote: > > Ard: > Now, the impact is to update platform DSC to include MmServicesTableLib > library instance. This change is acceptable for me. I suggest your create one > BZ for this patch set. https://bugzilla.tianocore.org/show_bug.cgi?id=1442 >

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-09 Thread Laszlo Ersek
On 01/09/19 11:28, Ard Biesheuvel wrote: > On Wed, 9 Jan 2019 at 10:44, Laszlo Ersek wrote: >> But, it's still not clear to me (without trying) whether I should >> resolve MmServicesTableLib for DXE_SMM_DRIVER in addition to >> SmmServicesTableLib, or in its place. I'd prefer not experimenting

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-09 Thread Gao, Liming
Ard: Now, the impact is to update platform DSC to include MmServicesTableLib library instance. This change is acceptable for me. I suggest your create one BZ for this patch set. Besides, I can't apply for these patches in my machine. Could you share git branch to me? Then, I can further

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-09 Thread Ard Biesheuvel
On Wed, 9 Jan 2019 at 10:44, Laszlo Ersek wrote: > > On 01/03/19 19:28, Ard Biesheuvel wrote: > > This series proposed an alternative approach to the series sent out by > > Jagadeesh [0]. In particular, it gets rid of the InMm() calls and the > > special PCD, as well as some other if()

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-09 Thread Laszlo Ersek
On 01/03/19 19:28, Ard Biesheuvel wrote: > This series proposed an alternative approach to the series sent out by > Jagadeesh [0]. In particular, it gets rid of the InMm() calls and the > special PCD, as well as some other if() conditionals. > > The primary difference is that this series defines

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-07 Thread Laszlo Ersek
On 01/07/19 14:05, Ard Biesheuvel wrote: > On Mon, 7 Jan 2019 at 13:44, Gao, Liming wrote: >> >> Ard: >> I agree this design is good. But, I need some time to evaluate its impact >> on our X86 platform. Could you wait for several days? >> > > Of course. I think it would be prudent of me to

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-07 Thread Ard Biesheuvel
On Mon, 7 Jan 2019 at 13:44, Gao, Liming wrote: > > Ard: > I agree this design is good. But, I need some time to evaluate its impact > on our X86 platform. Could you wait for several days? > Of course. Thanks, > > -Original Message- > > From: Ard Biesheuvel

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-07 Thread Gao, Liming
Ard: I agree this design is good. But, I need some time to evaluate its impact on our X86 platform. Could you wait for several days? Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, January 4, 2019 2:28 AM > To:

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-03 Thread Ard Biesheuvel
On Thu, 3 Jan 2019 at 19:28, Ard Biesheuvel wrote: > > This series proposed an alternative approach to the series sent out by > Jagadeesh [0]. In particular, it gets rid of the InMm() calls and the > special PCD, as well as some other if() conditionals. > That would be [0]

[edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-03 Thread Ard Biesheuvel
This series proposed an alternative approach to the series sent out by Jagadeesh [0]. In particular, it gets rid of the InMm() calls and the special PCD, as well as some other if() conditionals. The primary difference is that this series defines and implements MmServicesTableLib in such a way