Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-02-04 Thread Ashish Singhal
Mike, I have refactored my change and with this I am not seeing any size bloating in DEBUG or RELEASE images I am building for my platform. The new change has been submitted for consideration. Thanks Ashish -Original Message- From: Ashish Singhal Sent: Tuesday, January 8, 2019 8:02

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-08 Thread Ashish Singhal
Hi Mike, Thanks for the analysis. I will investigate at my end what could be causing this. Meanwhile, to fix the issue do you want to submit PATCH v2 1/4 and 2/4 patches? These 2 patches are just what you suggested. Thanks Ashish -Original Message- From: Kinney, Michael D Sent:

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-08 Thread Kinney, Michael D
Ashish, When I do full platform builds and individual driver builds, the result is always a little bigger with the V3 version of the patch. DEBUG DEBUG+Patch Delta RELEASE RELEASE+Patch Delta * *** *

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-08 Thread Ashish Singhal
Thanks Mike. Please let me know if you have any more questions and/or comments. Thanks Ashish -Original Message- From: Kinney, Michael D Sent: Tuesday, January 8, 2019 9:26 AM To: Ashish Singhal ; edk2-devel@lists.01.org; Gao, Liming ; Fu, Siyuan ; Wu, Jiaxin ; Kinney, Michael D

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-08 Thread Kinney, Michael D
Ashish, Good point. I was looking at the code size of a single uncompressed UEFI Driver (DiskIoDxe). I suspect that the patch provides a more consistent pattern across all drivers that use these UefiLib APIs, and then provides better compression on an FV that contains many UEFI Drivers. I also

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-07 Thread Ashish Singhal
Hi Mike, I build both DEBUG and RELEASE variant of the library and they both built a few KB less in size compared to what is in tip right now. Can you please help me with the optimization settings you have enabled so that I can try the same at my end? Also, if you want, we can look at the

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-07 Thread Kinney, Michael D
Hi Ashish, My main concern with this patch is that the generated code for optimized RELEASE builds is not as small. >From a source maintenance perspective, the patch you have provided is easier to maintain. However, the implementation of the APIs that install protocols was done to make sure

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-07 Thread Ashish Singhal
+ Maintainers -Original Message- From: Ashish Singhal Sent: Sunday, January 6, 2019 9:38 PM To: edk2-devel@lists.01.org Cc: Ashish Singhal Subject: [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation. An issue was seen in IScsiDxe in NetworkPkg where driver cleanup

[edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-06 Thread Ashish Singhal
An issue was seen in IScsiDxe in NetworkPkg where driver cleanup after initialization failure was not done right. Bug 1428 was filed in this regard. As per discussions with Mike, it was also discussed that having UEFILib provide protocol uninstallation abstraction would help to avoid these issues