Ignore my previous mail.
You could use AllocatePages() instead of directly calling gBS->AllocatePages().
Then rename the AllocateBootServiceMemory() to AllocateZeroPages() to better
reflect the function behavior.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Ni, Ruiyu
Thanks/Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Friday, August 10, 2018 11:40 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [Patch v3 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT
> saved in Smram.
>
> On 08/10/18 06:19, Eric Dong wrote:
> >
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 10, 2018 12:19 PM
> To: edk2-devel@lists.01.org
> Cc: Marvin Häuser ; Fan Jeff
> ; Laszlo Ersek ; Ni, Ruiyu
>
> Subject: [Patch v3 2/5] UefiCpuPkg/AcpiCpuData.h: Remove AcpiNVS and
> Below
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 10, 2018 12:19 PM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Ni, Ruiyu
> Subject: [Patch v3 4/5] UefiCpuPkg/CpuS3DataDxe: Remove below 4G
> limitation.
>
> Because
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 10, 2018 12:19 PM
> To: edk2-devel@lists.01.org
> Cc: Marvin Häuser ; Fan Jeff
> ; Laszlo Ersek ; Ni, Ruiyu
>
> Subject: [Patch v3 5/5] UefiCpuPkg/RegisterCpuFeaturesLib: Combine
>
Eric,
I think you could change:
AcpiCpuDataEx = AllocateBootServiceMemory (sizeof (ACPI_CPU_DATA_EX));
->
AcpiCpuDataEx = AllocatePages (EFI_SIZE_TO_PAGES (sizeof (ACPI_CPU_DATA_EX)));
So the AllocateBootServiceMemory() is not needed.
Thanks/Ray
> -Original Message-
> From: Dong, Eric
>
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Li, Songpeng
> Sent: Thursday, August 9, 2018 4:33 PM
> To: edk2-devel@lists.01.org; Fu, Siyuan ; Wu, Jiaxin
>
> Cc: Li, Songpeng
> Subject: [PATCH] NetworkPkg: Remove the redundant code and definition.
>
> Contributed-under:
Hi, Songpeng
The patch is good with me, please remember to update the copyright year when
commit it.
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Li, Songpeng
> Sent: Monday, August 13, 2018 10:45 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject:
Cc: Jiaxin Wu
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li
---
NetworkPkg/IScsiDxe/IScsiDxe.inf | 1 -
NetworkPkg/IScsiDxe/IScsiProto.c | 33
Hi Laszlo,
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Friday, August 10, 2018 11:40 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [edk2] [Patch v3 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Use
Hi Laszlo,
I checked the code base and don't find the API AllocateZeroPages (), and I
agree to Zero the memory before using it. So I think update the original
function is the best way now.
Thanks,
Eric
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent:
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey,
Jaben
Sent: Friday, August 03, 2018 11:46 PM
To: Carsey, Jaben ; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH v1 0/5] Refactor
1. Remove some import statement that are not used.
2. Remove the Type value in the LibraryClassObject because we don't
actually use it.
Cc: Liming Gao
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
The code in SecurityPkg\Library\DxeTcg2PhysicalPresenceLib can be treated as
the example for the platform with trusted console.
If a platform does not have a trusted graphic console, the platform may
implement another DxeTcg2PhysicalPresenceLib instance to get user confirmation.
For example,
Is there any work around if we don't have such trusted console on available
hardware platforms? Is there any example implementation which we can refer to?
Thanks,
Heyi
On Fri, Aug 10, 2018 at 09:12:46AM +, Yao, Jiewen wrote:
> by design a platform need define a trusted console and only
Ming Huang (1):
MdePkg Cper.h: Add generic error macros for ARM platform
MdePkg/Include/Guid/Cper.h | 3 +++
1 file changed, 3 insertions(+)
--
2.17.0
___
edk2-devel mailing list
edk2-devel@lists.01.org
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
MdePkg/Include/Guid/Cper.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h
index 5ddd4c715ebc..525bfe57b21b 100644
--- a/MdePkg/Include/Guid/Cper.h
17 matches
Mail list logo
