Re: [edk2] [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib

Thank you for your detailed reply, I will think about your suggestions. On 2018/2/8 5:16, Peter Jones wrote: > Coming late to the party because Leif called my attention to this > thread... > > On Mon, Jan 29, 2018 at 11:16:21AM +, Leif Lindholm wrote: >> This type of system behaviour has

Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT

On 2018/2/6 12:16, Zeng, Star wrote: > How about using EFI_ACPI_6_2_PPTT_PROCESSOR_ID_XXX to be more specific? > like this? EFI_ACPI_6_2_PPTT_PROCESSOR_ID_PHYSICAL_PACKAGE 0x01 EFI_ACPI_6_2_PPTT_PROCESSOR_ID_ACPI_PROCESSOR 0x01 > Others are good to me. > > > Thanks, > Star > -Original

Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT

Any comments for this patch? On 2018/2/2 11:30, Heyi Guo wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > MdePkg/Include/IndustryStandard/Acpi62.h | 18 ++

Re: [edk2] [PATCH edk2-platforms v2 00/15] Improve D0x platforms and bug fix

On 2018/1/30 1:33, Leif Lindholm wrote: > So, I'm mostly happy with this set, but: > > Sender (and hence Author for all patches that do not have a second > From: statement after Subject: ) for all patches here is > Ming Huang > > Can you please address this, either by

Re: [edk2] [PATCH edk2-platforms v2 02/15] Hisilicon/D05: Add PPTT support

On 2018/2/1 9:11, Jeremy Linton wrote: > Hi, > > > On 01/26/2018 02:00 AM, Ming Huang wrote: >> Add Processor Properties Topology Table, PPTT include >> Processor hierarchy node, Cache Type Structure and ID structure. >> >> PPTT is needed for lscpu command to show socket information correctly.

Re: [edk2] [PATCH edk2-platforms v2 05/15] Hisilicon D03/D05: Add capsule upgrade support

On 2018/1/30 21:21, Leif Lindholm wrote: > On Tue, Jan 30, 2018 at 08:48:27PM +0800, Huangming (Mark) wrote: >> >> >> On 2018/1/30 3:58, Leif Lindholm wrote: >>> A few style comments below. >>> >>> On Fri, Jan 26, 2018 at 04:00:40PM +0800, Ming

Re: [edk2] [PATCH edk2-platforms v2 05/15] Hisilicon D03/D05: Add capsule upgrade support

On 2018/1/30 3:58, Leif Lindholm wrote: > A few style comments below. > > On Fri, Jan 26, 2018 at 04:00:40PM +0800, Ming Huang wrote: >> From: Jason Zhang >> >> This module support updating the boot CPU firmware only. >> >> Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT

OK, I will refine the title soon. Thanks. On 2018/1/30 11:34, Zeng, Star wrote: > The change looks good to me, Reviewed-by: Star Zeng . > > But the title seems not so correct. > It is about EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR, but not >

Re: [edk2] [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib

On 2018/1/27 18:37, Ard Biesheuvel wrote: > On 27 January 2018 at 01:47, Huangming (Mark) <huangmin...@huawei.com> wrote: >> >> >> On 2018/1/23 18:23, Leif Lindholm wrote: >>> On Thu, Jan 18, 2018 at 11:01:42PM +0800, Ming Huang wrote: >>>> OsBoo

Re: [edk2] [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib

On 2018/1/23 18:23, Leif Lindholm wrote: > On Thu, Jan 18, 2018 at 11:01:42PM +0800, Ming Huang wrote: >> OsBootLib can create OS option after upgrade firmware. > > I will respond more strongly that Ard did: > > I have seen functionality like this implemented in publicly available > systems -

Re: [edk2] [PATCH edk2-platforms v1 01/14] Hisilicon/D05: Add PPTT support

On 2018/1/24 5:29, Jeremy Linton wrote: > Hi, > > > On 01/18/2018 09:01 AM, Ming Huang wrote: >> From: Jason Zhang >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Jason Zhang >> Signed-off-by: Ming Huang

Re: [edk2] [PATCH edk2-platforms v1 04/14] Hisilicon D03/D05: Add capsule upgrade support

On 2018/1/24 19:21, Ard Biesheuvel wrote: > On 24 January 2018 at 11:10, Huangming (Mark) <huangmin...@huawei.com> wrote: >> >> >> On 2018/1/20 18:50, Ard Biesheuvel wrote: >>> On 18 January 2018 at 15:01, Ming Huang <heyi@linaro.org> wrote: >&g

Re: [edk2] [PATCH edk2-platforms v1 06/14] Hisilicon D03/D05: Open SnpPlatform source code

On 2018/1/23 22:07, Leif Lindholm wrote: > On Thu, Jan 18, 2018 at 11:01:35PM +0800, Ming Huang wrote: >> From: Jason Zhang >> >> 1. Open driver source code. > > Please describe what this driver does. > >> 2. This code includes network sequence correction >>

Re: [edk2] [PATCH edk2-non-osi v1 0/2] Update binary of trusted-firmware

On 2018/1/23 22:40, Leif Lindholm wrote: > On Sat, Jan 20, 2018 at 09:50:40AM +, Ard Biesheuvel wrote: >> On 20 January 2018 at 03:56, Heyi Guo wrote: >>> Workarounds for CVE-2017-5715 on Cortex A57/A72/A73 and A75 #1214. >>> >>> Heyi Guo (2): >>> Hisilicon/D03:

Re: [edk2] [PATCH edk2-platforms v1 04/14] Hisilicon D03/D05: Add capsule upgrade support

On 2018/1/20 18:50, Ard Biesheuvel wrote: > On 18 January 2018 at 15:01, Ming Huang wrote: >> From: Jason Zhang >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Jason Zhang >>

Re: [edk2] [PATCH edk2-platforms v1 01/14] Hisilicon/D05: Add PPTT support

On 2018/1/24 5:29, Jeremy Linton wrote: > Hi, > > > On 01/18/2018 09:01 AM, Ming Huang wrote: >> From: Jason Zhang >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Jason Zhang >> Signed-off-by: Ming Huang

Re: [edk2] [PATCH edk2-platforms v1 05/14] Hisilicon D03/D05: Open SasPlatform source code

I agree with all of your comments and will modify the sources soon. On 2018/1/20 18:57, Ard Biesheuvel wrote: > On 18 January 2018 at 15:01, Ming Huang wrote: >> From: Jason Zhang >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >>

Re: [edk2] [PATCH edk2-platforms v1 06/14] Hisilicon D03/D05: Open SnpPlatform source code

On 2018/1/20 19:00, Ard Biesheuvel wrote: > On 18 January 2018 at 15:01, Ming Huang wrote: >> From: Jason Zhang >> >> 1. Open driver source code. >> 2. This code includes network sequence correction >>solution. >> >> Contributed-under:

Re: [edk2] [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option

OK, I will modify the subject line and drop the change about PlatformIntelBdsLib. Also other comments will be handled. On 2018/1/23 18:28, Leif Lindholm wrote: > I don't agree with this subject line - there is no optimization going > on here. > > "Break BMC SetBoot option out into separate

Re: [edk2] [PATCH edk2-platforms v1 04/14] Hisilicon D03/D05: Add capsule upgrade support

On 2018/1/20 18:50, Ard Biesheuvel wrote: > On 18 January 2018 at 15:01, Ming Huang wrote: >> From: Jason Zhang >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Jason Zhang >>

Re: [edk2] [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option

The sources will be modified following below comments. On 2018/1/20 18:41, Ard Biesheuvel wrote: > On 18 January 2018 at 15:01, Ming Huang wrote: >> Modify the feature of BMC set boot option as switching generic >> BDS. Move main functions to BmcConfigBootLib. >> >>

Re: [edk2] [PATCH edk2-platforms v1 02/14] Hisilicon D03/D05：Switch to Generic BDS driver

On 2018/1/23 2:38, Leif Lindholm wrote: > Please provide a detailed commit message. > For example, explain that: > - Generic BDS use configurable build-time, enabled by default. > (Why? Is this intended to be temporary?) > - Hisilicon-specific PlatformBootManagerLib added. > (Why? What

Re: [edk2] [PATCH edk2-platforms v1 01/14] Hisilicon/D05: Add PPTT support

On 2018/1/20 18:16, Ard Biesheuvel wrote: > On 18 January 2018 at 15:01, Ming Huang wrote: >> From: Jason Zhang >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Jason Zhang >>

Re: [edk2] [PATCH edk2-platforms v1 01/14] Hisilicon/D05: Add PPTT support

On 2018/1/20 18:16, Ard Biesheuvel wrote: > On 18 January 2018 at 15:01, Ming Huang wrote: >> From: Jason Zhang >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Jason Zhang >>