[edk2] [PATCH v2] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-02-19 Thread Jeff Brasen
word accesses. (SD Host Controller Simplified Specification 4.20 Section 1.2) Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen Cc: Hao A Wu --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 25 1 file changed, 21 insertions(+), 4

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-02-01 Thread Jeff Brasen
From: Wu, Hao A Sent: Friday, February 1, 2019 12:54 AM To: Jeff Brasen; edk2-devel@lists.01.org Cc: Edgar Handal Subject: RE: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths > -Original Message- > From: Jeff Brasen [mailt

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-01-31 Thread Jeff Brasen
-Original Message- From: Wu, Hao A Sent: Thursday, January 31, 2019 10:56 PM To: Jeff Brasen ; edk2-devel@lists.01.org Cc: Edgar Handal Subject: RE: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths > -Original Message- > From: edk2-devel [mailto:edk2

[edk2] [PATCH] EmbeddedPkg/PrePiLib: Correct function name

2019-01-31 Thread Jeff Brasen
Update header file function name for FfsFindFileByName to match implementation function name. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Include/Library/PrePiLib.h | 2 +- 1 file changed, 1 insertion

[edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-01-30 Thread Jeff Brasen
Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 25 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c index

[edk2] [PATCH v3] ArmPkg/ArmScmiDxe: Add clock enable function

2018-12-13 Thread Jeff Brasen
. It is placed after the functions that are present in the existing protocol to allow SCMI_CLOCK2_PROTOCOL to be cast to SCMI_CLOCK_PROTOCOL so that only a single implementation of those function are needed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen Cc: Ard Biesheuvel

Re: [edk2] [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function

2018-12-13 Thread Jeff Brasen
-Original Message- From: Leif Lindholm Sent: Wednesday, December 12, 2018 11:49 AM To: Ard Biesheuvel Cc: Jeff Brasen ; edk2-devel@lists.01.org; Girish Pathak Subject: Re: [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function On Thu, Dec 06, 2018 at 06:09:26PM +0100, Ard

Re: [edk2] [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function

2018-12-06 Thread Jeff Brasen
-Original Message- From: Ard Biesheuvel Sent: Thursday, December 6, 2018 9:54 AM To: Jeff Brasen Cc: edk2-devel@lists.01.org; Leif Lindholm ; Girish Pathak Subject: Re: [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function On Thu, 6 Dec 2018 at 01:37, Jeff Brasen wrote

Re: [edk2] [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function

2018-12-05 Thread Jeff Brasen
Leif/Ard, Any comments on this v2 patch for this? Thanks, Jeff From: Jeff Brasen Sent: Wednesday, November 28, 2018 1:36:16 PM To: edk2-devel@lists.01.org Cc: Jeff Brasen; Ard Biesheuvel; Leif Lindholm; Grish Pathak Subject: [PATCH v2] ArmPkg/ArmScmiDxe

[edk2] [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-28 Thread Jeff Brasen
Add function to allow enabling and disabling of the clock using the SCMI interface. Add gArmScmiClock2ProtocolGuid to distinguish platforms that support new API from those that just have the older protocol. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen Cc

Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC

2018-11-28 Thread Jeff Brasen
+cc package maintainers From: Jeff Brasen Sent: Wednesday, November 28, 2018 10:17 AM To: Carsey, Jaben; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC Any additional updates on this patch series? Thanks, Jeff

[edk2] [PATCH v2] MdeModulePkg/SdDxe: Fix potential NULL pointer access

2018-11-16 Thread Jeff Brasen
SdReadWrite can be called with a NULL Token for synchronous operations. Add guard for DEBUG print to only print event pointer with Token is not NULL. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 5 +++-- 1 file

Re: [edk2] [PATCH] MdeModulePkg/SdDxe: Fix potential NULL pointer access

2018-11-15 Thread Jeff Brasen
Sounds good, will upload a v2 patch with that. Thanks, Jeff -Original Message- From: Wu, Hao A Sent: Thursday, November 15, 2018 9:33 PM To: Jeff Brasen ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] MdeModulePkg/SdDxe: Fix potential NULL pointer access > -Original Mess

[edk2] [PATCH] MdeModulePkg/SdDxe: Fix potential NULL pointer access

2018-11-09 Thread Jeff Brasen
SdReadWrite can be called with a NULL Token for synchronous operations. Add guard for DEBUG print to only print event pointer with Token is not NULL. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 +-- 1 file

Re: [edk2] [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-09 Thread Jeff Brasen
From: Leif Lindholm Sent: Friday, November 9, 2018 7:09 AM To: Jeff Brasen Cc: edk2-devel@lists.01.org; Ard Biesheuvel; Grish Pathak; Sami Mujawar Subject: Re: [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function Hi Jeff, On Thu, Nov 08, 2018 at 10:50:44AM

[edk2] [PATCH v3 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

2018-11-08 Thread Jeff Brasen
Expose BaseSortLib for use in SEC and PEI phases. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/BaseSortLib

[edk2] [PATCH v3 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()

2018-11-08 Thread Jeff Brasen
This function is exposed by the MemoryAllocationLib header. An AllocateZeroPool() function has been added to fix modules depending on this library and this function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- .../PrePiMemoryAllocationLib

[edk2] [PATCH v3 0/2] SortLib for UEFI SEC

2018-11-08 Thread Jeff Brasen
Jeff Brasen (2): EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() MdeModulePkg/BaseSortLib: Enable for all module types .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32 ++ MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 +-- 2 files changed, 34

[edk2] [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-08 Thread Jeff Brasen
Add function to allow enabling and disabling of the clock using the SCMI interface. Update the protocol GUID as the protocol interface has changed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Grish Pathak

[edk2] [PATCH v2 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

2018-11-08 Thread Jeff Brasen
Expose BaseSortLib for use in SEC and PEI phases. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/BaseSortLib

[edk2] [PATCH v2 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()

2018-11-08 Thread Jeff Brasen
This function is exposed by the MemoryAllocationLib header. An AllocateZeroPool() function has been added to fix modules depending on this library and this function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- .../PrePiMemoryAllocationLib

[edk2] [PATCH v2 0/2] SortLib for UEFI SEC

2018-11-08 Thread Jeff Brasen
This patch series enables support for BaseSortLib in UEFI SEC Phase. This requires the addition of the AllocateZeroPool which is implemented in the PrePiMemoryAllocationLib. Changelog: v1 - Initial version v2 - Update order of NULL check in MemoryAllocationLib Jeff Brasen (2): EmbeddedPkg

Re: [edk2] [PATCH 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()

2018-11-08 Thread Jeff Brasen
From: Ard Biesheuvel Sent: Thursday, November 8, 2018 4:13 AM To: Jeff Brasen; Leif Lindholm Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() On 30 October 2018 at 22:30, Jeff Brasen

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

2018-11-01 Thread Jeff Brasen
to an allocation-less SortLib but was trying to enable this capability without impact to other users of this library. Thanks, Jeff From: Ni, Ruiyu Sent: Wednesday, October 31, 2018 2:56:42 AM To: Jeff Brasen; edk2-devel@lists.01.org Cc: Gao, Liming; Kinney

[edk2] [PATCH 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()

2018-10-30 Thread Jeff Brasen
This function is exposed by the MemoryAllocationLib header. An AllocateZeroPool() function has been added to fix modules depending on this library and this function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- .../PrePiMemoryAllocationLib

[edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

2018-10-30 Thread Jeff Brasen
Expose BaseSortLib for use in SEC and PEI phases. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/BaseSortLib

[edk2] [PATCH 0/2] SortLib for UEFI SEC

2018-10-30 Thread Jeff Brasen
This patch series enables support for BaseSortLib in UEFI SEC Phase. This requires the addition of the AllocateZeroPool which is implemented in the PrePiMemoryAllocationLib. Jeff Brasen (2): EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() MdeModulePkg/BaseSortLib: Enable

[edk2] [PATCH v2 0/2] [SdMmcPciDxe] SDHCI v4+ support

2018-10-09 Thread Jeff Brasen
> 3.00 Jeff Brasen (2): MdeModulePkg/SdMmcPciHcDxe: Add controller version defines MdeModulePkg/SdMmcPciHcDxe: Allow additional SDHCI versions MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c| 5 +++-- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 3 ++- MdeModulePkg/Bus/

[edk2] [PATCH v2 1/2] MdeModulePkg/SdMmcPciHcDxe: Add controller version defines

2018-10-09 Thread Jeff Brasen
Signed-off-by: Jeff Brasen --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c| 4 ++-- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 10 ++ 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Bus

[edk2] [PATCH v2 2/2] MdeModulePkg/SdMmcPciHcDxe: Allow additional SDHCI versions

2018-10-09 Thread Jeff Brasen
: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c| 3 ++- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c b

[edk2] [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Add controller version defines

2018-10-05 Thread Jeff Brasen
Add SDHCI controller defines, this is useful as the version in the register does not explictly map to a specification version. For example vesion 4.10 of the specification is version 0x04. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Bus

[edk2] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Allow additional SDHCI versions

2018-10-05 Thread Jeff Brasen
Clock control is similar in SDHCI versions greater then version 3. Add support for more recent versions of the controller specification. SD card support for 1.8V is also present in controller versions 3 and greater. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff