Re: [edk2-devel] [Patch] BaseTools: Move buildoptions.py to Common folder

2019-08-13 Thread Liming Gao
gt;Subject: [Patch] BaseTools: Move buildoptions.py to Common folder > >buildoptions is used by build.py and TargetTxtClassObj.py >Move buildoptions.py to Common folder so that >build tool and ECC tool work fine. > >Cc: Liming Gao >Signed-off-by: Bob Feng >--- > BaseTools/Source

[edk2] [Patch] Revert "BaseTools:BaseTools supports to the driver combination."

2019-02-24 Thread Liming Gao
need to call the sub driver unload function for the driver start fail only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/Python/AutoGen/GenC.py| 32 -- .../Source/Python/Workspace/WorkspaceCommon.py

[edk2] [Patch] BaseTools: Remove unused txt files

2019-02-15 Thread Liming Gao
. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Bin/externals.txt | 1 - BaseTools/BuildNotes.txt | 83 -- BaseTools/Source/BinaryFiles.txt | 79 -- BaseTools/building-gcc.txt | 15 -- BaseTools/gcc/README.txt

[edk2] [Patch edk2 Wiki] Add three features for edk2-stable201903

2019-02-12 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- EDK-II-Release-Planning.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index f302be3..095da69 100644 --- a/EDK-II-Release

[edk2] [Patch] BaseTools VolInfo: Fix XCODE5 build issue

2019-01-15 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Feng Bob C --- BaseTools/Source/C/VolInfo/VolInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolInfo/VolInfo.c index 89fe3a044d..c8a99face2 100644 --- a/BaseTools/Source/C/VolInfo/VolIn

[edk2] [Patch] BaseTools GenFw: Fix XCODE5 build issue

2019-01-14 Thread Liming Gao
Remove extraneous parentheses around the comparison to silence this warning. This issue is caused by commit 8daa4278e80c70e6caabc525cd122744488253f5. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Feng Bob C --- BaseTools/Source/C/GenFw/GenFw.c | 4

[edk2] [Patch] MdeModulePkg DxeCapsuleLibFmp: Update SupportCapsuleImage() for Fake Capsule

2019-01-13 Thread Liming Gao
-by: Liming Gao Cc: Star Zeng Cc: Jian J Wang --- MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c index fa557b61ae..f56809bb70

[edk2] [Patch v2] Dsc Spec: Add the syntax to initialize structure PCD with C style value

2019-01-07 Thread Liming Gao
In V2: Update Pcd Field value assignment with array index. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1292 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Bob Feng --- 3_edk_ii_dsc_file_format/33_platform_dsc_definition.md | 10 -- 1 file

[edk2] [Patch v3] Dec Spec: Support the syntax of the structure array for structure PCD

2019-01-07 Thread Liming Gao
value Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Bob Feng --- 3_edk_ii_dec_file_format/310_pcd_sections.md | 2 +- .../32_package_declaration_dec_definitions.md | 11 +-- 2 files changed, 10 insertions(+), 3

[edk2] [Patch 4/5] BaseTools tools_def.template: Remove obsolete ICC/ICC11 tool chains

2018-12-24 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 1103 - 1 file changed, 1103 deletions(-) diff --git a/BaseTools/Conf

[edk2] [Patch 2/5] BaseTools tools_def.template: Remove obsolete ELFGCC/UNIXGCC/CYGGCC tool chain

2018-12-24 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 387 -- 1 file changed, 387 deletions(-) diff --git a/BaseTools/Conf

[edk2] [Patch 1/5] BaseTools/Conf/tools_def.template: drop ARM/AARCH support from GCC46/GCC47

2018-12-24 Thread Liming Gao
From: Ard Biesheuvel This drops ARM and AARCH64 support from the GCC46 and GCC47 toolchain definitions, which are on the list to be removed, along with VS2003, VS2005, VS2008, VS2010, DDK3790, UNIXGCC, GCC44, GCC45, ELFGCC, CYGGCC, ICC, ICC11 and MYTOOLS. Since GCC46 and GCC47 are the only ones

[edk2] [Patch 0/5] Remove unused tool chains in tools_def.template

2018-12-24 Thread Liming Gao
: Yonghong Zhu Cc: Feng Bob C Ard Biesheuvel (1): BaseTools/Conf/tools_def.template: drop ARM/AARCH support from GCC46/GCC47 Liming Gao (4): BaseTools tools_def.template: Remove obsolete ELFGCC/UNIXGCC/CYGGCC tool chain BaseTools tools_def.template: Remove obsolete GCC44-GCC47 tool

[edk2] [Patch 5/5] BaseTools tools_def.template: Remove obsolete VS2003-2005/DDK3790 tool chains

2018-12-24 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 924 -- 1 file changed, 924 deletions(-) diff --git a/BaseTools/Conf

[edk2] [Patch 3/5] BaseTools tools_def.template: Remove obsolete GCC44-GCC47 tool chain

2018-12-24 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 419 ++ 1 file changed, 20 insertions(+), 399 deletions(-) diff --git a/BaseTools

[edk2] [Patch V2] edk2 DecSpec: Support the syntax of the structure array for structure PCD

2018-12-23 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Bob Feng --- 3_edk_ii_dec_file_format/310_pcd_sections.md | 2 +- .../32_package_declaration_dec_definitions.md| 9 - 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/3_edk_ii_dec_file_format

[edk2] [Patch edk2 wiki] Add two features for edk2-stable201903 in EDK-II-Release-Planning

2018-12-17 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- EDK-II-Release-Planning.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index f134ed2..229bb4e 100644 --- a/EDK-II-Release-Planning.md +++ b/EDK

[edk2] [Patch] edk2 wiki: remove edk2-stable201811 tag planning in EDK-II-Release-Planning

2018-12-05 Thread Liming Gao
edk2-stable201811 tag has been created. its planning can be removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- EDK-II-Release-Planning.md | 24 1 file changed, 24 deletions(-) diff --git a/EDK-II-Release-Planning.md b/EDK-II

[edk2] [Patch] edk2 Readme.md: Add edk2 release tag and edk2 release plan

2018-12-05 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1364 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- Readme.md | 4 1 file changed, 4 insertions(+) diff --git a/Readme.md b/Readme.md index 1ef0780ee0..bf7c97cd2b 100644 --- a/Readme.md +++ b/Readme.md

[edk2] [Patch] Update edk2-stable201903 tag planning with Remove DuetPkg

2018-12-04 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- EDK-II-Release-Planning.md | 1 + 1 file changed, 1 insertion(+) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index f70ca5a..23011fa 100644 --- a/EDK-II-Release-Planning.md +++ b/EDK-II

[edk2] [Patch] ModuleWriteGuide: Add notes to define library instance module type

2018-12-04 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=834 If the library instance supports the cross module types PEIM, UEFI_DIRVER, DXE_DRIVER. Its module type can be PEIM or UEFI_DRIVER or DXE_DRIVER. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Bi Dandan

[edk2] [Patch] edk2 Dscspec: Add the syntax to initialize structure PCD with C style value

2018-12-04 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1292 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Bob Feng --- 3_edk_ii_dsc_file_format/33_platform_dsc_definition.md | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[edk2] [Patch] edk2 DecSpec: Support the syntax of the structure array for structure PCD

2018-12-04 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1292 1. Support the syntax of the structure array for structure PCD 2. Add the syntax to initialize structure PCD with C style value Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Bob Feng

[edk2] [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni

2018-11-28 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1363 New PCD PcdVpdBaseAddress64 is added in MdeModulePkg.dec. Its string token in MdeModulePkg.uni should match to its name. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Bi Dandan Cc: Star Zeng

[edk2] [Patch v2] Maintainers.txt: Add the rule to hand over the package maintain role

2018-11-28 Thread Liming Gao
In V2, change his to the, and add new maintainers follow up. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- Maintainers.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 91a4657adc

[edk2] [Patch] Maintainers.txt: Add the rule to hand over the package maintain role

2018-11-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- Maintainers.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 91a4657adc..d75bbe278d 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -6,7

[edk2] [Patch] Edk2: Update FmpDevicePkg Maintainers

2018-11-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 9a36f0232b..91a4657adc 100644 --- a/Maintainers.txt +++ b

[edk2] [Patch] MdeModulePkg PCD: Add DynamicEx PcdVpdBaseAddress64 for non SPI platform

2018-11-22 Thread Liming Gao
. If its value is not zero, it will be used. If its value is zero, static PcdVpdBaseAddress will be used. When NON SPI platform enables VPD PCD, they need to set PcdVpdBaseAddress64. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng Cc: Jian J Wang Cc

[edk2] [Patch] OvmfPkg: Don't include TftpDynamicCommand in XCODE5 tool chain

2018-11-22 Thread Liming Gao
Agreement 1.1 Signed-off-by: Liming Gao Cc: Jordan Justen Cc: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 2 ++ OvmfPkg/OvmfPkgIa32.fdf| 2 ++ OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ OvmfPkg/OvmfPkgIa32X64.fdf | 2 ++ OvmfPkg/OvmfPkgX64.dsc | 2 ++ OvmfPkg/OvmfPkgX64.fdf | 2 ++ 6 files changed

[edk2] [Patch] BaseTools Script: Update ConvertFceToStructurePcd to report warning messages

2018-11-20 Thread Liming Gao
A Reviewed-by: Liming Gao --- BaseTools/Scripts/ConvertFceToStructurePcd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py b/BaseTools/Scripts/ConvertFceToStructurePcd.py index 9240b8f0f3..59eec28d5e 100644 --- a/BaseTools

[edk2] [Patch] Revert "MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos"

2018-11-10 Thread Liming Gao
This reverts commit 8cd4e734ccdfbc961c72aeaa8dbd3f5154171f9b. It is not a real bug fix. It should not be pushed after Hard Feature Freeze for edk2-stable201811 tag. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Universal

[edk2] [Patch V2] Maintainers.txt: Update EDK II Releases to EDK-II-Release-Planning wiki

2018-11-10 Thread Liming Gao
In V2, add Liming Gao as the maintainer of EDK II Releases. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Laszlo Ersek --- Maintainers.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index

[edk2] [Patch 1/3] BaseTools: Fix UEFI and Tiano Decompression logic issue

2018-11-08 Thread Liming Gao
: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- BaseTools/Source/C/Common/Decompress.c | 6 ++ BaseTools/Source/C/TianoCompress/TianoCompress.c | 6 ++ 2 files changed, 12 insertions(+) diff --git a/BaseTools/Source/C/Common/Decompress.c b

[edk2] [Patch 3/3] IntelFrameworkModulePkg: Fix UEFI and Tiano Decompression logic issue

2018-11-08 Thread Liming Gao
: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib

[edk2] [Patch 2/3] MdePkg BaseUefiDecompressLib: Fix UEFI Decompression logic issue

2018-11-08 Thread Liming Gao
: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Michael Kinney --- MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c b/MdePkg/Library

[edk2] [Patch 0/3] Fix UEFI and Tiano Decompression logic issue

2018-11-08 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1317 This is a regression issue caused by previous change with more checkers in UefiDecompress. In Decode() function, once mOutBuf is fully filled, Decode() should return. Current logic misses the checker of mOutBuf after while() loop. Liming Gao

[edk2] [Patch] Maintainers.txt: Update EDK II Releases to EDK-II-Release-Planning wiki

2018-11-08 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- Maintainers.txt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 6c9156169a..fc183d6477 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -51,9

[edk2] [Patch] BaseTools build_rule.template: Update aslc rule for XCODE tool chain

2018-11-02 Thread Liming Gao
Update aslc rule to rename the temp output file from .efi to .pecoff. This change can avoid the conflict .efi file name in output directory. One is the driver image, another is aslc temp output file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong

[edk2] [Patch 1/1] BaseTools tools_def.template: Add GCC link script in X86 ASLDLINK_FLAGS

2018-11-01 Thread Liming Gao
-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index a22b96c0b8..e0e68fd7fb

[edk2] [Patch] MdeModulePkg: Remove the trailing space in three source files.

2018-11-01 Thread Liming Gao
The recent changes in these three source files introduce the trailing space. This patch removes them to follow edk2 coding style. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c

[edk2] [Patch] BaseTools ConvertFceToStructurePcd: Fix the array value with empty string

2018-10-30 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- BaseTools/Scripts/ConvertFceToStructurePcd.py | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py b/BaseTools

[edk2] [Patch] FmpDevicePkg DSC: Add NOOPT target to verify NOOPT target

2018-10-30 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- FmpDevicePkg/FmpDevicePkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc index 444cd1f..62f4608 100644

[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE

2018-10-25 Thread Liming Gao
This patch makes RegularExpressionDxe pass XCODE5 build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch

2018-10-25 Thread Liming Gao
SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is defined in MdeModulePkg.dec for IA32 and X64 only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file changed, 2 insertions

[edk2] [PATCH v2 1/3] MdePkg: Add more checker in UefiDecompressLib to access the valid buffer only(CVE FIX)

2018-10-22 Thread Liming Gao
Fix CVE-2017-5731,CVE-2017-5732,CVE-2017-5733,CVE-2017-5734,CVE-2017-5735 https://bugzilla.tianocore.org/show_bug.cgi?id=686 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao Reviewed-by: Star Zeng --- .../BaseUefiDecompressLib

[edk2] [PATCH v2 2/3] IntelFrameworkModulePkg: Add more checker in UefiTianoDecompressLib(CVE FIX)

2018-10-22 Thread Liming Gao
Fix CVE-2017-5731,CVE-2017-5732,CVE-2017-5733,CVE-2017-5734,CVE-2017-5735 https://bugzilla.tianocore.org/show_bug.cgi?id=686 To make sure the valid buffer be accessed only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao Reviewed

[edk2] [Patch] BaseTools: Remove the step to freeze python tool

2018-10-16 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1257 Binary python tool is not supported anymore. So, the freeze python tool step is not required. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- BaseTools/BuildNotes.txt | 3

[edk2] [Patch] MdeModulePkg BrotliDecompressLib: Add the checker to avoid array out of bound

2018-10-16 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c b

[edk2] [Patch 3/3] BaseTools: Add more checker in Decompress algorithm to access the valid buffer

2018-10-15 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=686 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao --- BaseTools/Source/C/Common/Decompress.c | 23 +++-- BaseTools/Source/C/TianoCompress/TianoCompress.c

[edk2] [Patch 2/3] IntelFrameworkModulePkg: Add more checker in UefiTianoDecompressLib

2018-10-15 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=686 To make sure the valid buffer be accessed only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao --- .../BaseUefiTianoCustomDecompressLib.c | 16

[edk2] [Patch 1/3] MdePkg: Add more checker in UefiDecompressLib to access the valid buffer only

2018-10-15 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=686 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao --- .../BaseUefiDecompressLib/BaseUefiDecompressLib.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions

[edk2] [Patch 0/3] Add more checker for Tianocompress and Ueficompress

2018-10-15 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=686 Liming Gao (3): MdePkg: Add more checker in UefiDecompressLib to access the valid buffer only IntelFrameworkModulePkg: Add more checker in UefiTianoDecompressLib BaseTools: Add more checker in Decompress algorithm to access

[edk2] [Patch 2/4] MdeModulePkg/RegularExpressionDxe: Miss null pointer check

2018-10-11 Thread Liming Gao
From: Dongao Guo Oniguruma https://github.com/kkos/oniguruma this change is merged from oniguruma develop branch. from commit ea36d810f1d9b28f3ef20bd8d453bea2f7fb598b Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dongao Guo Reviewed-by: Liming Gao

[edk2] [Patch 0/4] MdeModulePkg/RegularExpressionDxe: Miss null pointer check

2018-10-11 Thread Liming Gao
Some check are the real issues. Some are for pass static analysis. Dongao Guo (4): MdeModulePkg/RegularExpressionDxe: Miss null pointer check MdeModulePkg/RegularExpressionDxe: Miss null pointer check MdeModulePkg/RegularExpressionDxe: Miss null pointer check

[edk2] [Patch 4/4] MdeModulePkg/RegularExpressionDxe: Add null pointer check

2018-10-11 Thread Liming Gao
From: Dongao Guo There are five check not necessary in logic ,just for pass static analysis. More detail please refer to comment in code. And the rest changes are all accepted by owner, they are reasonable. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off

[edk2] [Patch 3/4] MdeModulePkg/RegularExpressionDxe: Miss null pointer check

2018-10-11 Thread Liming Gao
From: Dongao Guo Oniguruma https://github.com/kkos/oniguruma this change is merged from oniguruma develop branch. from commit 1db8a2726dfad0401f928cb8474bd770f07040a7. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dongao Guo Reviewed-by: Liming Gao

[edk2] [Patch 1/4] MdeModulePkg/RegularExpressionDxe: Miss null pointer check

2018-10-11 Thread Liming Gao
From: Dongao Guo Oniguruma https://github.com/kkos/oniguruma this change is merged from oniguruma develop branch. from commit 396a757dffafc0c7eb269433c29a0ba961d73ad6. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dongao Guo Reviewed-by: Liming Gao

[edk2] [Patch] MdeModulePkg BrotliCustomDecompressLib: Don't build it for EBC arch

2018-10-10 Thread Liming Gao
BrotliCustomDecompressLib has the definition with float type. But, Floating-point types are not supported by EBC compiler. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng Cc: Bi Dandan --- MdeModulePkg/MdeModulePkg.dsc | 2 +- 1 file changed, 1

[edk2] [Patch] edk2-BaseTools-win32: Add notes to announce BaseTools Win32 doesn't work

2018-10-09 Thread Liming Gao
https://lists.01.org/pipermail/edk2-devel/2018-September/029436.html Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- Readme.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Readme.txt b/Readme.txt index 9caee63..793d1cd 100644 --- a/Readme.txt

[edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

2018-10-09 Thread Liming Gao
GCC 6 or above reports the warning misleading-indentation. This patch fixes it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ard Biesheuvel --- BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Disable XCODE unknown warning option

2018-10-07 Thread Liming Gao
to Oniguruma project. After it is fixed, next version code can remove those options. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git

[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Enable STDARG for variable arguments

2018-10-07 Thread Liming Gao
Set macro for variable arguments, and remove the hard code definition to avoid the potential duplicated definition. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c | 1 - MdeModulePkg

[edk2] [Patch] FDF spec: Support Structure PCD field assignment syntax in [Defines] section

2018-09-29 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- 3_edk_ii_fdf_file_format/34_[defines]_section.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/3_edk_ii_fdf_file_format/34_[defines]_section.md b

[edk2] [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code

2018-09-24 Thread Liming Gao
DscBuildData has been updated to define SkuIds instead of _GetSkuIds(). The consumer code should refer to SkuIds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu Cc: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- 1 file

[edk2] [PATCH v2] UefiCpuPkg PiSmmCpuDxeSmm: Update SmiEntry function run the same position

2018-09-20 Thread Liming Gao
rax, strict qword 0 ; callASM_PFX(CpuSmmDebugEntry) CpuSmmDebugEntryAbsAddr: callrax Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Laszlo Ersek Cc: Eric Dong Cc: Jiewen Yao --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 42

[edk2] [Patch] UefiCpuPkg PiSmmCpuDxeSmm: Update SmiEntry function run the same position

2018-09-11 Thread Liming Gao
1. Remove jmp _SmiHandler, and run the code at the same position. 2. Fix up the function call address as the absolute address. Verify OVMF SMM boot to shell with VS2017, GCC5 and XCODE5 tool chain. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Laszlo Ersek

[edk2] [Patch] UefiCpuPkg PiSmmCpuDxeSmm: Remove unnecessary jmp _SmiHandler

2018-09-10 Thread Liming Gao
This change is wrong introduced by e21e355e2ca7fefb15b4df7078f995d3fb9c2b89 It is not required. So, revert it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 9 ++--- 1 file changed, 2

[edk2] [Patch 0/2] Update BrotliCompress to the latest version 1.0.5

2018-09-09 Thread Liming Gao
Because the patch is too big, the change is placed in https://github.com/lgao4/edk2/tree/Brotli Update Brotli to the latest version 1.0.5 https://github.com/google/brotli Verify VS2017, GCC5 build. Verify Decompression boot functionality. Liming Gao (2): BaseTools: Update Brotli Compress

[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Update Oniguruma to 6.9.0

2018-09-07 Thread Liming Gao
Contribution Agreement 1.1 Signed-off-by: Dongao Guo Reviewed-by: Liming Gao Cc: Cecil Sheng ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v2] MdeModulePkg PeiCore: Always use PeiImageRead() function to load PEI image

2018-09-05 Thread Liming Gao
In V2, Remove GetImageReadFunction(), directly use PeiImageRead(). The copy PeiImageReadForShadow function doesn't improve the boot performance. This patch removes this copy logic to simplify the code logic. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao

[edk2] [Patch] MdeModulePkg PeiCore: Remove the copy logic for PeiImageRead function

2018-09-04 Thread Liming Gao
The copy PeiImageRead function doesn't improve the boot performance. This patch removes this copy logic to simplify the code logic. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Core/Pei/Image/Image.c | 65

[edk2] [Patch] BaseTools: Enable LTO option in XCODE5 tool chain

2018-08-30 Thread Liming Gao
LTO option can achieve the better image size and boot performance. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Andrew Fish --- BaseTools/Conf/tools_def.template | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[edk2] [Patch 2/3] MdeModulePkg Lzma: Update LZMA SDK version to 18.05

2018-08-28 Thread Liming Gao
New formal release in https://www.7-zip.org/sdk.html is 18.05. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- .../LzmaCustomDecompressLib/LZMA-SDK-README.txt| 6 +- .../LzmaArchCustomDecompressLib.inf| 6

[edk2] [Patch 0/3] Update LZMA SDK version to the latest 18.05

2018-08-28 Thread Liming Gao
Liming Gao (3): IntelFrameworkModulePkg Lzma: Update LZMA SDK version to 18.05 MdeModulePkg Lzma: Update LZMA SDK version to 18.05 BaseTools Lzma: Update LZMA SDK version to 18.05 .../Source/C/LzmaCompress/LZMA-SDK-README.txt |4 +- BaseTools/Source/C/LzmaCompress/LzmaCompress.c

[edk2] [Patch 1/3] IntelFrameworkModulePkg Lzma: Update LZMA SDK version to 18.05

2018-08-28 Thread Liming Gao
New formal release in https://www.7-zip.org/sdk.html is 18.05. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- .../LzmaCustomDecompressLib/LZMA-SDK-README.txt| 6 +- .../LzmaArchCustomDecompressLib.inf| 6

[edk2] [Patch] BaseTools: Support multi thread build Basetool on Windows

2018-08-28 Thread Liming Gao
Contribution Agreement 1.1 Signed-off-by: Dongao Guo Reviewed-by: Liming Gao Test-by: Liming Gao --- BaseTools/Makefile | 12 +- BaseTools/Source/C/Makefile | 14 +-- BaseTools/Source/C/Makefiles/NmakeSubdirs.py | 169 +++ 3

[edk2] [Patch] DSC Spec: Update SkuId and DefaultStore name as C name style

2018-08-07 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- 3_edk_ii_dsc_file_format/310_pcd_sections.md| 15 +-- 3_edk_ii_dsc_file_format/313_[defaultstores]_section.md | 3 +-- 3_edk_ii_dsc_file_format/35_[defines]_section.md

[edk2] [Patch] IntelFrameworkModulePkg SmmRuntimeDxeReportStatusCodeLib: Add missing EFIAPI

2018-07-26 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1059 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Steven Shi --- .../SmmRuntimeDxeReportStatusCodeLibFramework/SmmRuntimeDxeSupport.c | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [Patch] IntelFrameworkModulePkg IsaSerialDxe: Update algorithm to calculate Divisor

2018-07-26 Thread Liming Gao
To align the way in MdeModulePkg SerialPortLib and PciSioSerialDxe driver, Divisor is added by one when the reminder is more than half (16 * BaudRate). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni --- IntelFrameworkModulePkg/Bus/Isa

[edk2] [PATCH v2] OvmfPkg: Correct ResourcePublicationLib class name in DSC/INF files

2018-07-23 Thread Liming Gao
ResourcePublicationLib class name is ResourcePublicationLib. INF and DSC files are updated to use the correct one. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Signed-off-by: Dongao Guo --- OvmfPkg/OvmfPkgIa32.dsc | 2 +- OvmfPkg/OvmfPkgIa32X64

[edk2] [Patch] OvmfPkg: Correct library class name in INF and DSC

2018-07-22 Thread Liming Gao
From: Dongao Guo ResourcePublicationLib class name is ResourcePublicationLib. INF and DSC files are updated to use the correct one. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Signed-off-by: Dongao Guo --- OvmfPkg/OvmfPkgIa32.dsc | 2

[edk2] [Patch] BaseTools Script: Add the script to generate Structure PCD setting

2018-07-16 Thread Liming Gao
Dir OutputDir directory have StructurePcd.dec, StructurePcd.dsc, StructurePcd.inf. 4. Refer to wiki https://github.com/lgao4/edk2/wiki/StructurePcd-Enable-Steps to enable structure pcd in this platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTo

[edk2] [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout

2018-07-10 Thread Liming Gao
timeout command may not work well in some environment. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Platform

[edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: update ReadMe.md to correct branch name

2018-07-06 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- ReadMe.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReadMe.md b/ReadMe.md index 9de6493..5bcdd1d 100644 --- a/ReadMe.md +++ b/ReadMe.md @@ -32,7 +32,7 @@ edk2-non-osi

[edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: Update batch file to call python.exe

2018-07-06 Thread Liming Gao
Use python.exe from PYTHON_HOME Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/bld.bat | 2 +- .../Tools/Fsp/RebaseAndPatchFspBinBaseAddress.py | 7 --- .../Intel

[edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatformPkg: Enable PatchFv tool supports PCD value format in build report

2018-07-06 Thread Liming Gao
PCD value in build report shows HEX and DEC both. PatchFv tool only requires one value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBfv.py | 2 +- Platform/Intel/MinPlatformPkg/Tools

[edk2] [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Remove unnecessary Link16 and IASL override

2018-07-06 Thread Liming Gao
Link16 is not used any longer. Remove the checker for it. IASL path is not required to be override. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- .../BoardMtOlympus/PlatformPkgBuildOption.dsc| 2 +- .../Intel

[edk2] [Patch] BaseTools: Clean up source files

2018-07-05 Thread Liming Gao
: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch] SecurityPkg Tpm2DeviceLibDTpm: Update enum type name to match the one in lib

2018-06-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c | 2 +- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SecurityPkg

[edk2] [Patch] BaseTools tools_def.template: Ignore link warning 4281 for VS2017

2018-06-21 Thread Liming Gao
VS2017 reports warning LNK4281: undesirable base address 0x0 for x64 image; set base address above 4GB for best ASLR optimization. edk2 build always sets baes address to zero as default. So, ignore this link warning. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming

[edk2] [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot option later

2018-06-21 Thread Liming Gao
Constructor is too early that ConnectAll() may not do. Move refresh boot option in form open. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Xu WeiX Reviewed-by: Liming Gao --- MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 3 +-- 1 file changed

[edk2] [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage to match code logic

2018-06-18 Thread Liming Gao
BdsEntry marks the read-only variables if the Variable Lock protocol exists. So, this protocol usage is updated from CONSUMES to SOMETIMES_CONSUMES. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni Cc: Star Zeng --- MdeModulePkg/Universal/BdsDxe

[edk2] [Patch] BaseTools Conf: Update tools_def and build_rule to remove IPF setting

2018-06-13 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- BaseTools/Conf/build_rule.template | 40 -- BaseTools/Conf/tools_def.template | 773 - 2 files changed, 813 deletions(-) diff --git a/BaseTools/Conf

[edk2] [Patch] FDF spec: Add the syntax to describe structure pcd usage

2018-06-05 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- 2_fdf_design_discussion/21_processing_overview.md | 1 + 2_fdf_design_discussion/22_flash_description_file_format.md | 6 +++--- 2_fdf_design_discussion/24_[fd]_sections.md

[edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

2018-05-28 Thread Liming Gao
BootLogo protocol is not always required. If it is installed, BootManagerMenuApp can work. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni --- MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf | 4 ++-- 1 file changed, 2

[edk2] [Patch] OvmfPkg BasePciCapLib: Fix VS build failure

2018-05-28 Thread Liming Gao
Fix VS warning C4244: 'function': conversion from 'UINT32' to 'UINT16', possible loss of data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Laszlo Ersek --- OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2] [Patch 0/3] Use comparison logic to check UINTN parameter in GetBestLanguage API

2018-05-28 Thread Liming Gao
Liming Gao (3): MdePkg UefiLib: Use comparison logic to check UINTN parameter IntelFrameworkPkg UefiLib: Use comparison logic to check UINTN parameter MdeModulePkg Variable: Use comparison logic to check UINTN parameter IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c| 6

[edk2] [Patch 2/3] IntelFrameworkPkg UefiLib: Use comparison logic to check UINTN parameter

2018-05-28 Thread Liming Gao
Commit cb96e7d4f7afdbaef0706f9251ae479639d85a28 changes the input parameter from BOOLEAN to UINTN. Its comparison logic should be updated. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming@intel.com> --- IntelFrameworkPkg/Library/FrameworkU

[edk2] [Patch 3/3] MdeModulePkg Variable: Use comparison logic to check UINTN parameter

2018-05-28 Thread Liming Gao
Commit 180ac200da84785989443b06bcfa5db343c0bf7e changes the input parameter from BOOLEAN to UINTN. Its comparison logic should be updated. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming@intel.com> Cc: Star Zeng <star.z...@intel.com> ---

[edk2] [Patch 1/3] MdePkg UefiLib: Use comparison logic to check UINTN parameter

2018-05-28 Thread Liming Gao
Commit d2aafe1e410c80d1046f2d1e743055882ead8489 changes the input parameter from BOOLEAN to UINTN. Its comparison logic should be updated. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming@intel.com> Cc: Michael Kinney <michael.d.kin...@

  1   2   3   4   5   >