Re: [edk2] [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

2018-03-14 Thread Marc Zyngier
On Wed, 14 Mar 2018 00:25:09 +, Guo Heyi wrote: > > On Tue, Mar 13, 2018 at 09:33:33AM +, Marc Zyngier wrote: > > On 13/03/18 00:31, Heyi Guo wrote: > > > If timer interrupt is level sensitive, reloading timer compare > > > register has a side effect of c

Re: [edk2] [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

2018-03-13 Thread Marc Zyngier
rious timer interrupts. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo <heyi@linaro.org> > Signed-off-by: Yi Li <phoenix.l...@huawei.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.bi

Re: [edk2] [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload

2018-03-12 Thread Marc Zyngier
On 12/03/18 10:38, Ard Biesheuvel wrote: > On 12 March 2018 at 10:38, Guo Heyi wrote: >> Hi Marc, >> >> I just tested with an ISB and it also worked for our platform. >> >> So is it acceptable to add an ISB after reloading timer compare value? >> > > I am fine with that if

Re: [edk2] [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload

2018-03-12 Thread Marc Zyngier
ontribution Agreement 1.1 > Signed-off-by: Heyi Guo <heyi@linaro.org> > Signed-off-by: Yi Li <phoenix.l...@huawei.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Marc Zyngier <marc.zyng...@a

Re: [edk2] [PATCH] ArmPkg/TimerDxe: Always perform an EOI, even for spurious interrupts

2018-03-06 Thread Marc Zyngier
On 06/03/18 14:25, Laszlo Ersek wrote: > On 03/06/18 14:24, Ard Biesheuvel wrote: >> From: Marc Zyngier <marc.zyng...@arm.com> >> >> The generic timer driver only EOIs the timer interrupt if >> the ISTATUS bit is set. This is completely fine if you pretend >>

Re: [edk2] [PATCH] ArmPkg/Gic: force GIC driver to run before CPU arch protocol driver

2018-02-06 Thread Marc Zyngier
t; > This fixes an issue observed with GICv3 guests running under KVM. This fixes the problem I was seeing, so here's my: Tested-by: Marc Zyngier <marc.zyng...@arm.com> Thanks a lot Ard! M. -- Jazz is not dead. It just smells funny... _

Re: [edk2] [PATCH edk2-non-osi 2/2] Silicon/AMD/Styx: update ArmTrustedFirmware.bin

2018-02-03 Thread Marc Zyngier
On Thu, 1 Feb 2018 16:42:53 + Ard Biesheuvel wrote: > On 1 February 2018 at 16:04, Ard Biesheuvel wrote: > > The ARM Trusted Firmware build we have been using up until now was built > > with optimizations disabled (which means every

Re: [edk2] [PATCH edk2-non-osi 2/2] Silicon/AMD/Styx: update ArmTrustedFirmware.bin

2018-02-01 Thread Marc Zyngier
On 01/02/18 16:42, Ard Biesheuvel wrote: > On 1 February 2018 at 16:04, Ard Biesheuvel wrote: >> The ARM Trusted Firmware build we have been using up until now was built >> with optimizations disabled (which means every variable manipulation >> involves a load, the