Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-16 Thread Roman Bacik
; -Original Message- > > From: rba...@gmail.com [mailto:rba...@gmail.com] > > Sent: Wednesday, July 11, 2018 6:51 AM > > To: edk2-devel@lists.01.org > > Cc: Zhang, Chao B ; Yao, Jiewen > > ; Laszlo Ersek ; Vladimir > > Olovyannikov > > Subject:

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Roman Bacik
Hi Laszlo, Thank you very much for your review and help. I would prefer the option 2b. Thanks, Roman On Wed, Jul 11, 2018 at 5:05 AM, Laszlo Ersek wrote: > Hi Roman, > > On 07/11/18 00:51, rba...@gmail.com wrote: > > From: Roman Bacik > > > > When secure boot is

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Roman Bacik
Signed-off-by: Roman Bacik On Tue, Jul 10, 2018 at 3:51 PM, wrote: > From: Roman Bacik > > When secure boot is enabled, if one loads keys from a FAT formatted > eMMC/SD/USB when trying to provision PK/KEK/DB keys via the menu, > an assert in StrLen() occurs. > This is be

Re: [edk2] [PATCH v1] SecurityPkg: Fix assert when setting key from FAT formatted eMMC/SD/USB

2018-07-09 Thread Roman Bacik
Laszlo, Thank you very much for your comments. I will address them and post another patch. Regards, Roman On Mon, Jul 9, 2018 at 5:24 PM, Laszlo Ersek wrote: > On 07/10/18 02:02, Laszlo Ersek wrote: > > On 07/10/18 00:11, Roman Bacik wrote: > > >> +PathName = Allocat

[edk2] [PATCH v1] SecurityPkg: Fix assert when setting key from FAT formatted eMMC/SD/USB

2018-07-09 Thread Roman Bacik
/show_bug.cgi?id=1003 Cc: Chao Zhang Cc: Jiewen Yao Cc: Laszlo Ersek Cc: Vladimir Olovyannikov Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Roman Bacik --- .../SecureBootConfigFileExplorer.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions

Re: [edk2] [PATCH] Enable using device address when programming BARs

2018-05-15 Thread Roman Bacik
Ersek [mailto:ler...@redhat.com] > Sent: Monday, May 14, 2018 11:05 AM > To: Roman Bacik > Cc: Ard Biesheuvel; Ruiyu Ni; edk2-devel@lists.01.org; Vladimir > Olovyannikov > Subject: Re: [edk2] [PATCH] Enable using device address when programming > BARs > > Hi Roman, > > On

Re: [edk2] [PATCH] Enable using device address when programming BARs

2018-05-14 Thread Roman Bacik
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, May 14, 2018 10:35 AM > To: Roman Bacik > Cc: edk2-devel@lists.01.org; Ruiyu Ni; Vladimir Olovyannikov > Subject: Re: [edk2] [PATCH] Enable using device address when programmin

Re: [edk2] [PATCH] Enable using device address when programming BARs

2018-05-14 Thread Roman Bacik
Ard, Thank you very much for your comment. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Sunday, May 13, 2018 3:25 AM > To: Roman Bacik > Cc: edk2-devel@lists.01.org; Ruiyu Ni; Vladimir Olovyannikov > Subject: Re: [edk2] [P

Re: [edk2] [PATCH v2] MdeModulePkg/Bus: Enable to use device address when programming BARs

2018-05-10 Thread Roman Bacik
tem, or certain PCI devices > in a system? > > > > Thanks/Ray > > > > From: Roman Bacik <roman.ba...@broadcom.com> > Sent: Thursday, May 10, 2018 4:25 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Vladimir Olovyannikov > <vladimir

[edk2] [PATCH v2] MdeModulePkg/Bus: Enable to use device address when programming BARs

2018-05-09 Thread Roman Bacik
Some SoCs require to use device address when BARs are programmed: https://bugzilla.tianocore.org/show_bug.cgi?id=948 Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH] Enable using device address when programming BARs

2018-05-09 Thread Roman Bacik
I will upload v2 with the corrected subject - add package name MdeModulePkg/Bus . *From:* Roman Bacik [mailto:roman.ba...@broadcom.com] *Sent:* Thursday, May 3, 2018 3:55 PM *To:* edk2-devel@lists.01.org *Cc:* Ruiyu Ni; Vladimir Olovyannikov *Subject:* [edk2] [PATCH] Enable using device address

[edk2] [PATCH] Enable using device address when programming BARs

2018-05-03 Thread Roman Bacik
Some SoCs require to use device address when BARs are programmed: https://bugzilla.tianocore.org/show_bug.cgi?id=948 Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH v2] MdeModulePkg/Bus: Enable ascending resource list

2018-05-03 Thread Roman Bacik
Hi Ard, Thank you very much for your suggestion, we will have a look. Regards, Roman > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, May 3, 2018 12:36 PM > To: Roman Bacik > Cc: Laszlo Ersek; Ruiyu Ni; edk2-devel@lists.0

Re: [edk2] [PATCH v2] MdeModulePkg/Bus: Enable ascending resource list

2018-05-03 Thread Roman Bacik
with a bus address of 0, not the memory address of 0x6000. I will submit another patch enabling this. I would like to withdraw the current patch. I appreciate your time and apologise for my misunderstandings, Roman > -Original Message- > From: Roman Bacik [mailto:roman.ba...@b

Re: [edk2] [PATCH v2] MdeModulePkg/Bus: Enable ascending resource list

2018-05-03 Thread Roman Bacik
/Core/Dxe/DxeMain/DEBUG/DxeCore.dll Thanks, Roman > -Original Message- > From: Roman Bacik [mailto:roman.ba...@broadcom.com] > Sent: Thursday, May 3, 2018 8:23 AM > To: 'Laszlo Ersek' > Cc: 'edk2-devel@lists.01.org'; 'Ruiyu Ni'; Vladimir Olovyannikov > Subject: RE

Re: [edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd

2018-05-03 Thread Roman Bacik
> -Original Message- > From: Roman Bacik [mailto:roman.ba...@broadcom.com] > Sent: Thursday, May 3, 2018 7:47 AM > To: 'Zeng, Star'; 'edk2-devel@lists.01.org' > Cc: 'Ni, Ruiyu'; Vladimir Olovyannikov > Subject: RE: [edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd > >

Re: [edk2] [PATCH v2] MdeModulePkg/Bus: Enable ascending resource list

2018-05-03 Thread Roman Bacik
0xFFF; Owner = PCI [01|00|01:20]; Type = PMem64 Base = 0x60BC3000; Length = 0x1000;Alignment = 0xFFF; Owner = PCI [01|00|00:20]; Type = PMem64 Thanks, Roman > -Original Message- > From: Roman Bacik [mailto:roman.ba...@broadcom.com] > Sent: Thursday, May 3, 2018 7:58 A

Re: [edk2] [PATCH v2] MdeModulePkg/Bus: Enable ascending resource list

2018-05-03 Thread Roman Bacik
Laszlo, Thank you very much for your explanation. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, May 3, 2018 6:52 AM > To: Roman Bacik > Cc: edk2-devel@lists.01.org; Ruiyu Ni; Vladimir Olovyannikov > Subject: Re: [edk2] [PATCH v2

Re: [edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd

2018-05-03 Thread Roman Bacik
we need to add another search type? Thanks, Roman -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Wednesday, May 2, 2018 6:35 PM To: Roman Bacik; edk2-devel@lists.01.org Cc: Ni, Ruiyu; Vladimir Olovyannikov; Zeng, Star Subject: RE: [edk2] [PATCH v2] MdeModulePkg/Core

[edk2] [PATCH v2] MdeModulePkg/Bus: Enable ascending resource list

2018-05-02 Thread Roman Bacik
Some processors require resource list sorted in ascending order. Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Roman Bacik <roman.ba...@broadcom.com> --- Md

[edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd

2018-05-02 Thread Roman Bacik
When BottomUp search is used the MaxAddress is incorrectly chosen to be the BaseAddress instead of the EndAddress. Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH v1] MdeModulePkg/Bus: Enable ascending resource list

2018-04-30 Thread Roman Bacik
On Sat, Apr 28, 2018 at 11:53 AM, Roman Bacik <roman.ba...@broadcom.com> wrote: > Enable resource list sorted in ascending order required by some SoCs. > > Cc: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> > Cc: Ruiyu Ni <ruiyu...@intel.com>

Re: [edk2] [PATCH] [PATCH v1] MdeModulePkg/Core: Fix MaxAddress in Gcd

2018-04-30 Thread Roman Bacik
Will change subject to: "[edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd" for the next version if required. On Fri, Apr 27, 2018 at 3:36 PM, Roman Bacik <roman.ba...@broadcom.com> wrote: > When BottomUp search is used the MaxAddress is incorrectly chosen to >

[edk2] [PATCH v1] MdeModulePkg/Bus: Enable ascending resource list

2018-04-28 Thread Roman Bacik
Enable resource list sorted in ascending order required by some SoCs. Cc: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Roman Bacik <roman.ba...@broadcom.com>

[edk2] [PATCH] [PATCH v1] MdeModulePkg/Core: Fix MaxAddress in Gcd

2018-04-27 Thread Roman Bacik
When BottomUp search is used the MaxAddress is incorrectly chosen to be BaseAddress instead of EndAddress. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Roman Bacik <roman.ba...@broadcom.com> --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 4 ++-- 1 file changed, 2 inse