Hi Laszlo,
Thanks for your reply, I have also discussed this patch with Eric and Ray, all
comments will be in the V2 patch.
Best Regards,
Bell Song
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, February 1, 2018 9:16 PM
> To: Song,
CpuFeaturesLibSortCpuFeatures() will be unique.
Best Regards,
Bell Song
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, January 31, 2018 5:44 PM
> To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.d...@int
Hi All,
Attached my test case F.Y.R.
Best Regards,
Bell Song
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Song, BinX
> Sent: Wednesday, January 31, 2018 3:01 PM
> To: edk2-devel@lists.01.org
> Cc: ler...@redhat.com;
Current CPU feature dependency check will hang on when meet below or
similar case:
if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) {
Status = RegisterCpuFeature (
"AESNI",
AesniGetConfigData,
AesniSupport,
AesniInitialize,
Enhance MCA feature dependency check base on SDM pseudocode example 15-1.
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song
---
Fix comment typo for MtrrLibApplyFixedMtrrs function
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song
---
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 +-
1 file changed, 1
With correct model CPU, current checking logic will
always execute AsmReadMsr64 operation and then check
ECX.AESNI[bit 25] = 1. Update checking logic to check
ECX.AESNI[bit 25] = 1 first and then do AsmReadMsr64
operation.
Cc: Eric Dong
Cc: Laszlo Ersek
When CpuCommonFeaturesLib use RegisterCpuFeaturesLib to register
CPU features, the CpuFeaturesData->BitMaskSize has already been
initialized. So delete redundant PcdGetSize PcdCpuFeaturesSupport
in CpuInitDataInitialize.
Cc: Eric Dong
Cc: Laszlo Ersek
work, I will roll back the
patch which has been checked in before.
Best Regards,
Bell Song
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, December 19, 2017 7:21 AM
> To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org; Kinney,
> Mic
V2:
Move CPU_FEATURE_MAX definition from header file to C file.
V1:
Keep library class header file definition independent
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song
Hi Ray & Mike,
Thanks for your suggestion, I will update a V2 patch.
Best Regards,
Bell Song
> -Original Message-
> From: Kinney, Michael D
> Sent: Saturday, December 16, 2017 1:34 AM
> To: Ni, Ruiyu <ruiyu...@intel.com>; Song, BinX <binx.s...@intel.com>
Keep library class header file definition independent
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song
---
UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
Hi All,
Thanks for your suggestion, I will update a V3 patch.
Best Regards,
Bell Song
From: Fan Jeff [mailto:vanjeff_...@hotmail.com]
Sent: Wednesday, December 13, 2017 11:35 PM
To: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Song,
BinX <binx.s...@intel.c
V2:
Update function name, add more detail description.
V1:
Check and assert invalid RegisterCpuFeature function parameter
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song
Hi Ray,
Got it, I will update a V2 patch.
Best Regards,
Bell Song
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, December 12, 2017 4:44 PM
> To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org
> Cc: ler...@redhat.com; Dong, Eric <eric.d...@
; -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, December 11, 2017 5:40 PM
> To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org
> Cc: ler...@redhat.com; Dong, Eric <eric.d...@intel.com>
> Subject: Re: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFe
Check and assert invalid RegisterCpuFeature function parameter
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song
---
.../Include/Library/RegisterCpuFeaturesLib.h |
Change GetSupportPcds and GetConfigurationPcds to be singular
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song
---
.../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c |
V2:
Fix MSFT C4255 warning
V1:
Enable MSFT C4255 warning.
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming
V2:
Fix MSFT C4255 warning
V1:
Enable MSFT C4255 warning.
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming
V2:
Fix MSFT C4255 warning
V1:
Enable MSFT C4255 warning.
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming
V2:
Fix MSFT C4255 warning
V1:
Enable MSFT C4255 warning.
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming
V2:
Fix MSFT C4255 warning
V1:
Enable MSFT C4255 warning.
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming
V2:
Fix MSFT C4255 warning.
V1:
Enable MSFT C4255 warning.
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming
Hi Jiewen,
Do you mean we fix the problem after enable MSFT C4255 warning?
If yes, I have fix them in related patch, such as MdeModulePkg.
Best Regards,
Bell Song
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, November 7, 2017 1:39 PM
> To: Song, BinX <binx
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Enable MSFT C4255 warning.
>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.
Cc: Liming Gao
Got it, thanks.
Best Regards,
Bell Song
From: Yao, Jiewen
Sent: Wednesday, August 23, 2017 11:03 AM
To: Song, BinX <binx.s...@intel.com>; Gao, Liming <liming@intel.com>;
Kinney, Michael D <michael.d.kin...@intel.com>; Kinney, Michael D
<michael.d.kin...@intel.com>
Hi Jiewen,
Do I need to update this patch?
Best Regards,
Bell Song
From: Yao, Jiewen
Sent: Wednesday, August 23, 2017 10:54 AM
To: Gao, Liming <liming@intel.com>; Kinney, Michael D
<michael.d.kin...@intel.com>; Song, BinX <binx.s...@intel.com>; Kinney, Michael
V3:
- Update dummy TempRamInitApi function and remove unnecessary info
V2:
- Recover TempRamInitApi API and add dummy TempRamInitApi function to fix
build error with WHOLEARCHIVE option
V1:
- Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
error
Cc: Jiewen Yao
Hi Jiewen,
Yes, I will update.
Best Regards,
Bell Song
> -Original Message-
> From: Yao, Jiewen
> Sent: Monday, August 21, 2017 4:26 PM
> To: Song, BinX <binx.s...@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build
V2:
- Recover TempRamInitApi API and add dummy TempRamInitApi function to fix
build error with WHOLEARCHIVE option
V1:
- Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
error with VS2015 tool chain
Cc: Jiewen Yao
Contributed-under: TianoCore
- Delete useless case code to fix /WHOLEARCHIVE build
error with VS2015 tool chain
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
- Delete never touched code
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c | 3 +--
- Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
error with VS2015 tool chain
Cc: Jiewen Yao
Cc: Giri P Mudusuru
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
- Update header file including style to avoid MSDN C4464 warning
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
Reviewed-by: Bell Song <binx.s...@intel.com>
Best Regards,
Bell Song
> -Original Message-
> From: Gao, Liming
> Sent: Friday, April 14, 2017 10:00 AM
> To: edk2-devel@lists.01.org
> Cc: Song, BinX <binx.s...@intel.com>
> Subject: [PATCH v2] MdeModulePkg
- Sync BrotliCompress script the same style with BrotliCompress.bat
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
https://bugzilla.tianocore.org/show_bug.cgi?id=464
V2:
- Add build version
V1:
- Add --version option in Brotli and BrotliCompress
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
https://bugzilla.tianocore.org/show_bug.cgi?id=464
- Add --version option in Brotli and BrotliCompress
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
BaseTools/BinWrappers/PosixLike/BrotliCompress
- Fix BrotliCustomDecompressLib potential issue
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
.../Library/BrotliCustomDecompressLib/BrotliDecompress.c | 1 +
- Fix GCC48/GCC49 build error
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
.../Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf| 3 +++
1 file changed, 3 insertions(+)
diff
V2:
- Update correct patch info
V1:
- Add x mode for Brotli and BrotliCompress
- Change Brotli and BrotliCompress format from DOS to UNIX
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
- Add x mode for Brotli and BrotliCompress
- Change Brotli and BrotliCompress format from DOS to UNIX
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
BaseTools/BinWrappers/PosixLike/Brotli |
Hi All,
The code is also in https://github.com/binxsong/edk2/tree/Brotli_V1
Best Regards,
Bell Song
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Song,
> BinX
> Sent: Thursday, March 23, 2017 10:16 AM
> To: edk2-devel@li
- Add Brotli algorithm decompression library support
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
.../BrotliCustomDecompressLib.inf | 56
- Add Brotli algorithm tool support
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
BaseTools/BinWrappers/PosixLike/Brotli | 29 ++
BaseTools/BinWrappers/PosixLike/BrotliCompress
Brotli algorithm was released on the website https://github.com/google/brotli.
It has a little less compress ratio than Lzma, but has better decompress
performance than it.
Add Brotli algorithm support, include Brotli decompression library and tool set.
Tested on:
OS: Windows
Arch: IA32/X64
FreePool (Blt) function will be called in while loop, cannot be removed.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4
1 file changed, 4
lse.
}/
c.Blt = Image.Bitmap; Step 3, Blt get an valid value.
>From above, I think we can remove this if judgment.
Best Regards,
Bell Song
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, November 9, 2016 10:25 AM
&
There are two invalid if judgments in BootLogoEnableLogo() function,
remove them.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8
1 file
- Required unicode control chars -> Null character
- Remove CHAR_NULL definition in SimpleTextIn.h
- https://bugzilla.tianocore.org/show_bug.cgi?id=172
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
Hi Liming,
Got it, I will update again.
Best Regards,
Bell Song
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, November 3, 2016 9:56 AM
> To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [PATCH] MdePkg/BaseLib: Move
- https://bugzilla.tianocore.org/show_bug.cgi?id=172
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
MdePkg/Include/Base.h | 5 +
MdePkg/Include/Protocol/SimpleTextIn.h | 1 -
Hi Liming,
Thanks for your info, I will update.
Best Regards,
Bell Song
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, November 2, 2016 4:44 PM
> To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [PATCH] MdePkg/BaseLib
- https://bugzilla.tianocore.org/show_bug.cgi?id=172
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
MdePkg/Include/Base.h | 7 +++
MdePkg/Library/BaseLib/FilePaths.c | 2 --
2 files
- BASE -> UEFI_DRIVER
- https://bugzilla.tianocore.org/show_bug.cgi?id=173
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf | 2 +-
1 file
- '\0' -> NULL
- https://bugzilla.tianocore.org/show_bug.cgi?id=47
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c | 2 +-
1 file
71 matches
Mail list logo