Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-02-01 Thread Song, BinX
Hi Laszlo, Thanks for your reply, I have also discussed this patch with Eric and Ray, all comments will be in the V2 patch. Best Regards, Bell Song > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 1, 2018 9:16 PM > To: Song,

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-01-31 Thread Song, BinX
CpuFeaturesLibSortCpuFeatures() will be unique. Best Regards, Bell Song > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, January 31, 2018 5:44 PM > To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@int

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-01-30 Thread Song, BinX
Hi All, Attached my test case F.Y.R. Best Regards, Bell Song > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Song, BinX > Sent: Wednesday, January 31, 2018 3:01 PM > To: edk2-devel@lists.01.org > Cc: ler...@redhat.com;

[edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-01-30 Thread Song, BinX
Current CPU feature dependency check will hang on when meet below or similar case: if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) { Status = RegisterCpuFeature ( "AESNI", AesniGetConfigData, AesniSupport, AesniInitialize,

[edk2] [PATCH] UefiCpuPkg: Enhance feature dependency check

2018-01-11 Thread Song, BinX
Enhance MCA feature dependency check base on SDM pseudocode example 15-1. Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song ---

[edk2] [PATCH] UefiCpuPkg: Fix comment typo for MtrrLibApplyFixedMtrrs function

2017-12-26 Thread Song, BinX
Fix comment typo for MtrrLibApplyFixedMtrrs function Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song --- UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 +- 1 file changed, 1

[edk2] [PATCH] UefiCpuPkg: Update AESNI support checking logic

2017-12-24 Thread Song, BinX
With correct model CPU, current checking logic will always execute AsmReadMsr64 operation and then check ECX.AESNI[bit 25] = 1. Update checking logic to check ECX.AESNI[bit 25] = 1 first and then do AsmReadMsr64 operation. Cc: Eric Dong Cc: Laszlo Ersek

[edk2] [PATCH] UefiCpuPkg: Delete redundant PcdGetSize PcdCpuFeaturesSupport

2017-12-21 Thread Song, BinX
When CpuCommonFeaturesLib use RegisterCpuFeaturesLib to register CPU features, the CpuFeaturesData->BitMaskSize has already been initialized. So delete redundant PcdGetSize PcdCpuFeaturesSupport in CpuInitDataInitialize. Cc: Eric Dong Cc: Laszlo Ersek

Re: [edk2] [PATCH V2] UefiCpuPkg: Keep library class header file definition independent

2017-12-21 Thread Song, BinX
work, I will roll back the patch which has been checked in before. Best Regards, Bell Song > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, December 19, 2017 7:21 AM > To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org; Kinney, > Mic

[edk2] [PATCH V2] UefiCpuPkg: Keep library class header file definition independent

2017-12-17 Thread Song, BinX
V2: Move CPU_FEATURE_MAX definition from header file to C file. V1: Keep library class header file definition independent Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song

Re: [edk2] [PATCH] UefiCpuPkg: Keep library class header file definition independent

2017-12-17 Thread Song, BinX
Hi Ray & Mike, Thanks for your suggestion, I will update a V2 patch. Best Regards, Bell Song > -Original Message- > From: Kinney, Michael D > Sent: Saturday, December 16, 2017 1:34 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; Song, BinX <binx.s...@intel.com>

[edk2] [PATCH] UefiCpuPkg: Keep library class header file definition independent

2017-12-14 Thread Song, BinX
Keep library class header file definition independent Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song --- UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h

Re: [edk2] [PATCH V2] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

2017-12-13 Thread Song, BinX
Hi All, Thanks for your suggestion, I will update a V3 patch. Best Regards, Bell Song From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Wednesday, December 13, 2017 11:35 PM To: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Song, BinX <binx.s...@intel.c

[edk2] [PATCH V2] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

2017-12-12 Thread Song, BinX
V2: Update function name, add more detail description. V1: Check and assert invalid RegisterCpuFeature function parameter Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song

Re: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

2017-12-12 Thread Song, BinX
Hi Ray, Got it, I will update a V2 patch. Best Regards, Bell Song > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, December 12, 2017 4:44 PM > To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org > Cc: ler...@redhat.com; Dong, Eric <eric.d...@

Re: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

2017-12-11 Thread Song, BinX
; -Original Message- > From: Ni, Ruiyu > Sent: Monday, December 11, 2017 5:40 PM > To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org > Cc: ler...@redhat.com; Dong, Eric <eric.d...@intel.com> > Subject: Re: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFe

[edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

2017-12-11 Thread Song, BinX
Check and assert invalid RegisterCpuFeature function parameter Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song --- .../Include/Library/RegisterCpuFeaturesLib.h |

[edk2] [PATCH] UefiCpuPkg: Singularize function name

2017-12-11 Thread Song, BinX
Change GetSupportPcds and GetConfigurationPcds to be singular Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song --- .../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c |

[edk2] [PATCH V2 3/5] MdePkg: Fix MSFT C4255 warning

2017-11-09 Thread Song, BinX
V2: Fix MSFT C4255 warning V1: Enable MSFT C4255 warning. >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming

[edk2] [PATCH V2 5/5] ShellPkg: Fix MSFT C4255 warning

2017-11-09 Thread Song, BinX
V2: Fix MSFT C4255 warning V1: Enable MSFT C4255 warning. >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming

[edk2] [PATCH V2 2/5] MdeModulePkg: Fix MSFT C4255 warning

2017-11-09 Thread Song, BinX
V2: Fix MSFT C4255 warning V1: Enable MSFT C4255 warning. >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming

[edk2] [PATCH V2 4/5] NetworkPkg: Fix MSFT C4255 warning

2017-11-09 Thread Song, BinX
V2: Fix MSFT C4255 warning V1: Enable MSFT C4255 warning. >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming

[edk2] [PATCH V2 1/5] IntelFrameworkModulePkg: Fix MSFT C4255 warning

2017-11-09 Thread Song, BinX
V2: Fix MSFT C4255 warning V1: Enable MSFT C4255 warning. >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming

[edk2] [PATCH V2 0/5] Fix MSFT C4255 warning

2017-11-09 Thread Song, BinX
V2: Fix MSFT C4255 warning. V1: Enable MSFT C4255 warning. >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming

Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Hi Jiewen, Do you mean we fix the problem after enable MSFT C4255 warning? If yes, I have fix them in related patch, such as MdeModulePkg. Best Regards, Bell Song > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 7, 2017 1:39 PM > To: Song, BinX <binx

[edk2] [PATCH 14/14] UefiCpuPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 12/14] SignedCapsulePkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 13/14] SourceLevelDebugPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 07/14] MdePkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 06/14] MdeModulePkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 04/14] IntelFsp2Pkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 01/14] FatPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 08/14] NetworkPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 11/14] ShellPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 09/14] PcAtChipsetPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 10/14] SecurityPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 02/14] IntelFrameworkModulePkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 03/14] IntelFrameworkPkg: Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 00/14] Enable MSFT C4255 warning

2017-11-06 Thread Song, BinX
Enable MSFT C4255 warning. >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-22 Thread Song, BinX
Got it, thanks. Best Regards, Bell Song From: Yao, Jiewen Sent: Wednesday, August 23, 2017 11:03 AM To: Song, BinX <binx.s...@intel.com>; Gao, Liming <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>

Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-22 Thread Song, BinX
Hi Jiewen, Do I need to update this patch? Best Regards, Bell Song From: Yao, Jiewen Sent: Wednesday, August 23, 2017 10:54 AM To: Gao, Liming <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Song, BinX <binx.s...@intel.com>; Kinney, Michael

[edk2] [PATCH V3] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Song, BinX
V3: - Update dummy TempRamInitApi function and remove unnecessary info V2: - Recover TempRamInitApi API and add dummy TempRamInitApi function to fix build error with WHOLEARCHIVE option V1: - Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build error Cc: Jiewen Yao

Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Song, BinX
Hi Jiewen, Yes, I will update. Best Regards, Bell Song > -Original Message- > From: Yao, Jiewen > Sent: Monday, August 21, 2017 4:26 PM > To: Song, BinX <binx.s...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build

[edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Song, BinX
V2: - Recover TempRamInitApi API and add dummy TempRamInitApi function to fix build error with WHOLEARCHIVE option V1: - Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build error with VS2015 tool chain Cc: Jiewen Yao Contributed-under: TianoCore

[edk2] [PATCH] MdeModulePkg: Delete useless case code

2017-08-02 Thread Song, BinX
- Delete useless case code to fix /WHOLEARCHIVE build error with VS2015 tool chain Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song ---

[edk2] [PATCH] MdeModulePkg: Delete never touched code

2017-08-02 Thread Song, BinX
- Delete never touched code Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c | 3 +--

[edk2] [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API

2017-08-02 Thread Song, BinX
- Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build error with VS2015 tool chain Cc: Jiewen Yao Cc: Giri P Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song ---

[edk2] [PATCH] ShellPkg: Update header file including style

2017-08-02 Thread Song, BinX
- Update header file including style to avoid MSDN C4464 warning Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song ---

Re: [edk2] [PATCH v2] MdeModulePkg BrotliLib: Fix the regression logic issue in loop

2017-04-13 Thread Song, BinX
Reviewed-by: Bell Song <binx.s...@intel.com> Best Regards, Bell Song > -Original Message- > From: Gao, Liming > Sent: Friday, April 14, 2017 10:00 AM > To: edk2-devel@lists.01.org > Cc: Song, BinX <binx.s...@intel.com> > Subject: [PATCH v2] MdeModulePkg

[edk2] [PATCH] BaseTools: Sync BrotliCompress script the same style

2017-04-13 Thread Song, BinX
- Sync BrotliCompress script the same style with BrotliCompress.bat Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song ---

[edk2] [PATCH] BaseTools: Add --version option in Brotli and BrotliCompress

2017-04-12 Thread Song, BinX
https://bugzilla.tianocore.org/show_bug.cgi?id=464 V2: - Add build version V1: - Add --version option in Brotli and BrotliCompress Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song

[edk2] [PATCH] BaseTools: Add --version option in Brotli and BrotliCompress

2017-04-07 Thread Song, BinX
https://bugzilla.tianocore.org/show_bug.cgi?id=464 - Add --version option in Brotli and BrotliCompress Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- BaseTools/BinWrappers/PosixLike/BrotliCompress

[edk2] [PATCH] MdeModulePkg: Fix BrotliCustomDecompressLib potential issue

2017-04-07 Thread Song, BinX
- Fix BrotliCustomDecompressLib potential issue Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- .../Library/BrotliCustomDecompressLib/BrotliDecompress.c | 1 +

[edk2] [PATCH] MdeModulePkg: Fix GCC48/GCC49 build error

2017-04-01 Thread Song, BinX
- Fix GCC48/GCC49 build error Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- .../Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf| 3 +++ 1 file changed, 3 insertions(+) diff

[edk2] [PATCH V2] BaseTools: Update Brotli and BrotliCompress mode and format

2017-03-30 Thread Song, BinX
V2: - Update correct patch info V1: - Add x mode for Brotli and BrotliCompress - Change Brotli and BrotliCompress format from DOS to UNIX Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song ---

[edk2] [PATCH] BaseTools: Update Brotli and BrotliCompress mode and format

2017-03-30 Thread Song, BinX
- Add x mode for Brotli and BrotliCompress - Change Brotli and BrotliCompress format from DOS to UNIX Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- BaseTools/BinWrappers/PosixLike/Brotli |

Re: [edk2] [PATCH 0/4] MdeModulePkg/BaseTools: Add Brotli algorithm support

2017-03-23 Thread Song, BinX
Hi All, The code is also in https://github.com/binxsong/edk2/tree/Brotli_V1 Best Regards, Bell Song > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Song, > BinX > Sent: Thursday, March 23, 2017 10:16 AM > To: edk2-devel@li

[edk2] [PATCH 2/4] MdeModulePkg: Add Brotli algorithm decompression library

2017-03-22 Thread Song, BinX
- Add Brotli algorithm decompression library support Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- .../BrotliCustomDecompressLib.inf | 56

[edk2] [PATCH 4/4] BaseTools: Add Brotli algorithm tool

2017-03-22 Thread Song, BinX
- Add Brotli algorithm tool support Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- BaseTools/BinWrappers/PosixLike/Brotli | 29 ++ BaseTools/BinWrappers/PosixLike/BrotliCompress

[edk2] [PATCH 0/4] MdeModulePkg/BaseTools: Add Brotli algorithm support

2017-03-22 Thread Song, BinX
Brotli algorithm was released on the website https://github.com/google/brotli. It has a little less compress ratio than Lzma, but has better decompress performance than it. Add Brotli algorithm support, include Brotli decompression library and tool set. Tested on: OS: Windows Arch: IA32/X64

[edk2] [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments

2016-11-10 Thread Song, BinX
FreePool (Blt) function will be called in while loop, cannot be removed. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 1 file changed, 4

Re: [edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

2016-11-09 Thread Song, BinX
lse. }/ c.Blt = Image.Bitmap; Step 3, Blt get an valid value. >From above, I think we can remove this if judgment. Best Regards, Bell Song > -Original Message- > From: Gao, Liming > Sent: Wednesday, November 9, 2016 10:25 AM &

[edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

2016-11-07 Thread Song, BinX
There are two invalid if judgments in BootLogoEnableLogo() function, remove them. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 1 file

[edk2] [PATCH V3] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib

2016-11-02 Thread Song, BinX
- Required unicode control chars -> Null character - Remove CHAR_NULL definition in SimpleTextIn.h - https://bugzilla.tianocore.org/show_bug.cgi?id=172 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song ---

Re: [edk2] [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib

2016-11-02 Thread Song, BinX
Hi Liming, Got it, I will update again. Best Regards, Bell Song > -Original Message- > From: Gao, Liming > Sent: Thursday, November 3, 2016 9:56 AM > To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [PATCH] MdePkg/BaseLib: Move

[edk2] [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib

2016-11-02 Thread Song, BinX
- https://bugzilla.tianocore.org/show_bug.cgi?id=172 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- MdePkg/Include/Base.h | 5 + MdePkg/Include/Protocol/SimpleTextIn.h | 1 -

Re: [edk2] [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib

2016-11-02 Thread Song, BinX
Hi Liming, Thanks for your info, I will update. Best Regards, Bell Song > -Original Message- > From: Gao, Liming > Sent: Wednesday, November 2, 2016 4:44 PM > To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [PATCH] MdePkg/BaseLib

[edk2] [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib

2016-11-02 Thread Song, BinX
- https://bugzilla.tianocore.org/show_bug.cgi?id=172 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- MdePkg/Include/Base.h | 7 +++ MdePkg/Library/BaseLib/FilePaths.c | 2 -- 2 files

[edk2] [PATCH] MdeModulePkg/FrameBufferBltLib: Change module type to UEFI_DRIVER

2016-11-01 Thread Song, BinX
- BASE -> UEFI_DRIVER - https://bugzilla.tianocore.org/show_bug.cgi?id=173 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf | 2 +- 1 file

[edk2] [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check

2016-11-01 Thread Song, BinX
- '\0' -> NULL - https://bugzilla.tianocore.org/show_bug.cgi?id=47 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- EdkCompatibilityPkg/Foundation/Library/Dxe/PrintLite/StdErr.c | 2 +- 1 file