Re: [edk2] [PATCH v2 edk2-platforms 6/8] SgiClark.Ares: AcpiTables: Add entry for virtio network device

2019-02-26 Thread Vijayenthiran Subramaniam
ayenthiran Subramaniam < vijayenthiran.subraman...@arm.com> wrote: > SgiClark Ares include an instance of the virtio network device. Add > a representation for it in the ACPI tables. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subrama

Re: [edk2] [PATCH v2 edk2-platforms 0/8] Platform/ARM/Sgi: Add support for virtio network device

2018-12-19 Thread Vijayenthiran Subramaniam
On Wed, Dec 19, 2018 at 4:08 PM Ard Biesheuvel wrote: > > On Fri, 14 Dec 2018 at 17:59, Vijayenthiran Subramaniam > wrote: > > > > Changes since v1: > > - Rebased the series against latest edk2-platforms > > > > This patch series adds support for virtio n

[edk2] [PATCH v2 edk2-platforms 8/8] SgiClark.Helios: AcpiTables: Add entry for virtio network device

2018-12-14 Thread Vijayenthiran Subramaniam
SgiClark Helios include an instance of the virtio network device. Add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 3 +++ Platform

[edk2] [PATCH v2 edk2-platforms 7/8] SgiClark.Helios: AcpiTables: Use PCDs for virtio disk

2018-12-14 Thread Vijayenthiran Subramaniam
Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl

[edk2] [PATCH v2 edk2-platforms 6/8] SgiClark.Ares: AcpiTables: Add entry for virtio network device

2018-12-14 Thread Vijayenthiran Subramaniam
SgiClark Ares include an instance of the virtio network device. Add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 3 +++ Platform/ARM

[edk2] [PATCH v2 edk2-platforms 5/8] SgiClark.Ares: AcpiTables: Use PCDs for virtio disk

2018-12-14 Thread Vijayenthiran Subramaniam
Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl | 12

[edk2] [PATCH v2 edk2-platforms 4/8] Sgi575: AcpiTables: Add entry for virtio network device

2018-12-14 Thread Vijayenthiran Subramaniam
From: Daniil Egranov SGI575 include an instance of the virtio network device. So add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 3 +++

[edk2] [PATCH v2 edk2-platforms 3/8] Sgi575: AcpiTables: Use PCDs for virtio disk

2018-12-14 Thread Vijayenthiran Subramaniam
From: Daniil Egranov Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 10

[edk2] [PATCH v2 edk2-platforms 2/8] Platform/ARM/SgiPkg: Add support for virtio net device

2018-12-14 Thread Vijayenthiran Subramaniam
From: Daniil Egranov Add support for virtio net device by adding PCDs to specify the data required to setup the virtio net device and register it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/SgiPlatform.dec

[edk2] [PATCH v2 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-14 Thread Vijayenthiran Subramaniam
From: Daniil Egranov SGI platforms support multiple virtio devices. So the existing code, that supports registration of only the virtio disk, is restructured to accommodate the registration of additional virtio devices. In addition to this, PCDs to represent the virtio controller base and

[edk2] [PATCH v2 edk2-platforms 0/8] Platform/ARM/Sgi: Add support for virtio network device

2018-12-14 Thread Vijayenthiran Subramaniam
Platform/ARM/SgiPkg: Add support for virtio net device Sgi575: AcpiTables: Use PCDs for virtio disk Sgi575: AcpiTables: Add entry for virtio network device Vijayenthiran Subramaniam (4): SgiClark.Ares: AcpiTables: Use PCDs for virtio disk SgiClark.Ares: AcpiTables: Add entry for virtio

Re: [edk2] [PATCH v1 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-14 Thread Vijayenthiran Subramaniam
On Fri, Dec 14, 2018 at 8:26 PM Ard Biesheuvel wrote: > > On Tue, 11 Dec 2018 at 10:08, Vijayenthiran Subramaniam > wrote: > > > > On Fri, Dec 7, 2018 at 5:49 AM Vijayenthiran Subramaniam > > wrote: > > > > > > On Thu, Dec 6, 2018 at 5:18 PM Ard Bie

Re: [edk2] [PATCH v1 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-11 Thread Vijayenthiran Subramaniam
On Fri, Dec 7, 2018 at 5:49 AM Vijayenthiran Subramaniam wrote: > > On Thu, Dec 6, 2018 at 5:18 PM Ard Biesheuvel > wrote: > > > > On Wed, 5 Dec 2018 at 07:10, Vijayenthiran Subramaniam > > wrote: > > > > > > Hi Ard, > > > > > >

[edk2] [PATCH v3 edk2-platforms] Platform/ARM/SgiPkg: Add support for HDLCD

2018-12-07 Thread Vijayenthiran Subramaniam
Add HDLCD platform library for SGI platform that implements platform callbacks for the Arm HDLCD driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Change from v2: No code change. Posting patch again with Change-Id removed. Platform/ARM

Re: [edk2] [PATCH] Platform/ARM/SgiPkg: Add support for HDLCD

2018-12-06 Thread Vijayenthiran Subramaniam
On Thu, Dec 6, 2018 at 5:08 PM Ard Biesheuvel wrote: > > On Thu, 6 Dec 2018 at 13:43, Vijayenthiran Subramaniam > wrote: > > > > Add HDLCD platform library for SGI platform that implements platform > > callbacks for the Arm HDLCD driver. > > > > Co

[edk2] [PATCH v2 edk2-platforms] Platform/ARM/SgiPkg: Add support for HDLCD

2018-12-06 Thread Vijayenthiran Subramaniam
Add HDLCD platform library for SGI platform that implements platform callbacks for the Arm HDLCD driver. Change-Id: I6cdca16bd69eeadeeb879dd5fe9acc72a12fbf2f Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/SgiPlatform.dsc

Re: [edk2] [PATCH v1 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-06 Thread Vijayenthiran Subramaniam
On Thu, Dec 6, 2018 at 5:18 PM Ard Biesheuvel wrote: > > On Wed, 5 Dec 2018 at 07:10, Vijayenthiran Subramaniam > wrote: > > > > Hi Ard, > > > > The virtio block device and virtio network device are available in software > > model only. As of now, it e

[edk2] [PATCH] Platform/ARM/SgiPkg: Add support for HDLCD

2018-12-06 Thread Vijayenthiran Subramaniam
Add HDLCD platform library for SGI platform that implements platform callbacks for the Arm HDLCD driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/SgiPlatform.dsc | 6 + Platform/ARM

Re: [edk2] [PATCH v1 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-04 Thread Vijayenthiran Subramaniam
Hi Ard, The virtio block device and virtio network device are available in software model only. As of now, it exposes only one instance of each device. On Tue, Dec 4, 2018 at 8:16 PM Ard Biesheuvel wrote: > On Tue, 4 Dec 2018 at 10:12, Vijayenthiran Subramaniam > wrote: > > >

[edk2] [PATCH v1 edk2-platforms 8/8] SgiClark.Helios: AcpiTables: Add entry for virtio network device

2018-12-04 Thread Vijayenthiran Subramaniam
SgiClark Helios include an instance of the virtio network device. Add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 3 +++ Platform

[edk2] [PATCH v1 edk2-platforms 7/8] SgiClark.Helios: AcpiTables: Use PCDs for virtio disk

2018-12-04 Thread Vijayenthiran Subramaniam
Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl

[edk2] [PATCH v1 edk2-platforms 6/8] SgiClark.Ares: AcpiTables: Add entry for virtio network device

2018-12-04 Thread Vijayenthiran Subramaniam
SgiClark Ares include an instance of the virtio network device. Add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 3 +++ Platform/ARM

[edk2] [PATCH v1 edk2-platforms 5/8] SgiClark.Ares: AcpiTables: Use PCDs for virtio disk

2018-12-04 Thread Vijayenthiran Subramaniam
Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl | 12

[edk2] [PATCH v1 edk2-platforms 4/8] Sgi575: AcpiTables: Add entry for virtio network device

2018-12-04 Thread Vijayenthiran Subramaniam
From: Daniil Egranov SGI575 include an instance of the virtio network device. So add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 3 +++

[edk2] [PATCH v1 edk2-platforms 3/8] Sgi575: AcpiTables: Use PCDs for virtio disk

2018-12-04 Thread Vijayenthiran Subramaniam
From: Daniil Egranov Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 10

[edk2] [PATCH v1 edk2-platforms 2/8] Platform/ARM/SgiPkg: Add support for virtio net device

2018-12-04 Thread Vijayenthiran Subramaniam
From: Daniil Egranov Add support for virtio net device by adding PCDs to specify the data required to setup the virtio net device and register it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/SgiPlatform.dec

[edk2] [PATCH v1 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-04 Thread Vijayenthiran Subramaniam
From: Daniil Egranov SGI platforms support multiple virtio devices. So the existing code, that supports registration of only the virtio disk, is restructured to accommodate the registration of additional virtio devices. In addition to this, PCDs to represent the virtio controller base and

[edk2] [PATCH v1 edk2-platforms 0/8] Platform/ARM/Sgi: Add support for virtio network device

2018-12-04 Thread Vijayenthiran Subramaniam
: AcpiTables: Use PCDs for virtio disk Sgi575: AcpiTables: Add entry for virtio network device Vijayenthiran Subramaniam (4): SgiClark.Ares: AcpiTables: Use PCDs for virtio disk SgiClark.Ares: AcpiTables: Add entry for virtio network device SgiClark.Helios: AcpiTables: Use PCDs for virtio disk

[edk2] [PATCH] Platform/ARM/Juno: increase max variable size to 8KB

2018-11-21 Thread Vijayenthiran Subramaniam
ize to 8KB on the Juno platform. Without this, the iSCSI driver fails to load. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Thomas Abraham Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/JunoPkg/ArmJuno.dsc | 2 ++ 1 file changed, 2

[edk2] [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts

2018-11-21 Thread Vijayenthiran Subramaniam
Add debug messages for failed attempts to write to a variable. Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Made the log messages bit more useful. Thanks, Vijayenthiran NetworkPkg/IScsiDxe/IScsiMisc.c | 8

[edk2] [PATCH v2] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

2018-11-21 Thread Vijayenthiran Subramaniam
: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Thanks for the review. I have made changes based on Laszlo's and Star's suggestions. - Vijayenthiran MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 30 1 file changed, 30 insertions

[edk2] [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts

2018-11-20 Thread Vijayenthiran Subramaniam
Add debug messages for failed attempts to write to a variable. Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- NetworkPkg/IScsiDxe/IScsiMisc.c | 4 1 file changed, 4 insertions(+) diff --git a/NetworkPkg

[edk2] [PATCH] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

2018-11-20 Thread Vijayenthiran Subramaniam
: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe

[edk2] [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB

2018-11-20 Thread Vijayenthiran Subramaniam
ize to 8KB on the SGI platforms. Without this, the iSCSI driver fails to load. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + 1 file changed, 1 insertion(+)