Re: [edk2] [Patch] NetworkPkg: Fix Duplicate FreePool Error in WCM

2019-02-28 Thread Wang, Fan
Thanks, Siyuan, will update commit message for this change. Best Regards Fan -Original Message- From: Fu, Siyuan Sent: Thursday, February 28, 2019 6:35 PM To: Wang, Fan ; edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject: RE: [Patch] NetworkPkg: Fix Duplicate FreePool Error

[edk2] [Patch] NetworkPkg: Fix Duplicate FreePool Error in WCM

2019-02-28 Thread Wang Fan
is to fix these issues. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang Fan --- NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrDriver.c| 1 + NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrFileUtil.c | 1

[edk2] [Patch edk2 wiki] Add new feature: WiFi Connection Manager for edk2-stable201903 in EDK-II-Release-Planning

2019-02-12 Thread Wang Fan
Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang Fan --- EDK-II-Release-Planning.md | 1 + 1 file changed, 1 insertion(+) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index f302be3..eba2afe 100644 --- a/EDK-II-Release

Re: [edk2] [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-18 Thread Wang, Fan
Thanks, Laszlo and Jiaxin, I will have a check about the author name "edk2-devel-boun...@lists.01.org". Best Regards Fan -Original Message- From: Wu, Jiaxin Sent: Wednesday, September 19, 2018 9:44 AM To: Wu, Jiaxin ; Laszlo Ersek ; Subramanian, Sriram ; Wang, Fan ; edk2-d

[edk2] [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Wang Fan
Jiaxin Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang Fan --- NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c index bc9dc914f3

Re: [edk2] [Patch] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Wang, Fan
Thanks, Shiram, I missed that. Best Regards Fan -Original Message- From: Subramanian, Sriram [mailto:srira...@hpe.com] Sent: Friday, September 14, 2018 4:05 PM To: Wang, Fan ; edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: RE: [edk2] [Patch] NetworkPkg

[edk2] [Patch] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Wang Fan
to do this by error, and thus cause a system crash. This patch adds EXCLUSIVE attribute when opening SNP in PXE driver, and will reject all OpenProtocol requests by EXCLUSIVE. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang Fan

Re: [edk2] [Patch] MdeModulePkg/Mtftp4Dxe: Fix the incorrect return status.

2018-03-12 Thread Wang, Fan
Reviewed-by: Wang, Fan <fan.w...@intel.com>. Best Regards Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Monday, March 12, 2018 10:22 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Wang

[edk2] [Patch] MdeModulePkg/DxeIpIoLib: Fixed the error ASSERT incorrectly used in IpIoAddIp().

2018-01-15 Thread Wang Fan
0 Signed-off-by: Wang Fan <fan.w...@intel.com> --- MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c b/MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c index 0c6681d..66c7fec 100644 --- a/Md

[edk2] [Patch] MdeModulePkg/Ip4Dxe: Add an independent timer for reconfig checking

2018-01-11 Thread Wang Fan
m> Cc: Fu Siyuan <siyuan...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan <fan.w...@intel.com> --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Driver.c | 28 +- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c | 47 +

[edk2] [Patch v2] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual().

2018-01-11 Thread Wang Fan
ent 1.0 Signed-off-by: Wang Fan <fan.w...@intel.com> --- MdeModulePkg/Include/Library/NetLib.h | 50 +++--- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 8 +++-- 2 files changed, 52 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Include/Library/NetLib.h

Re: [edk2] [Patch] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual().

2018-01-11 Thread Wang, Fan
Thanks, Jiaxin, I will revise it. Best Regards Fan -Original Message- From: Wu, Jiaxin Sent: Thursday, January 11, 2018 3:48 PM To: Wang, Fan <fan.w...@intel.com>; edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Wu, Hao A <hao.a...@intel.com> S

[edk2] [Patch] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual().

2018-01-10 Thread Wang Fan
tion Agreement 1.0 Signed-off-by: Wang Fan <fan.w...@intel.com> --- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 4 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c index cbce28f..34e11a8 100644 --

Re: [edk2] [Patch 2/2] MdeModulePkg: Did some code enhancement for DxeIpIpLib.

2018-01-09 Thread Wang, Fan
enhancement for DxeIpIpLib. Patch title: DxeIpIoLib On 1/10/2018 11:16 AM, Wang Fan wrote: > * In DxeIpIo, there are several places use ASSERT() to check input >parameters without and descriptions or error handling. This patch >fixed this issue. > * Fixed some incorrect descript

[edk2] [Patch 0/2] Fixed some issues in DxeIpIoLib

2018-01-09 Thread Wang Fan
See descriptions in each patch. Wang Fan (2): MdeModulePkg: Freed the received packet buffer if it is not expected. MdeModulePkg: Did some code enhancement for DxeIpIpLib. MdeModulePkg/Include/Library/IpIoLib.h | 21 - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c | 70

[edk2] [Patch 1/2] MdeModulePkg: Freed the received packet buffer if it is not expected.

2018-01-09 Thread Wang Fan
yuan <siyuan...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan <fan.w...@intel.com> --- MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Library/Dx

[edk2] [Patch 2/2] MdeModulePkg: Did some code enhancement for DxeIpIpLib.

2018-01-09 Thread Wang Fan
for function IpIoRefreshNeighbor. Cc: Jiaxin Wu <jiaxin...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan <fan.w...@intel.com> --- MdeModulePkg/Include/Libr

[edk2] [Patch 2/2] MdeModulePkg: Freed packet buffer when error occurs to avoid memory leak.

2018-01-08 Thread Wang Fan
an...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan <fan.w...@intel.com> --- MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Wrq.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Network/

[edk2] [Patch 0/2] Fixed some issues in Mtftp4Dxe

2018-01-08 Thread Wang Fan
See descriptions in each patch. Wang Fan (2): MdeModulePkg: Fixed two issues when error occurs in Mtftp4Start. MdeModulePkg: Freed packet buffer when error occurs to avoid memory leak. .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.c | 20 MdeModulePkg/Universal

[edk2] [Patch 1/2] MdeModulePkg: Fixed two issues when error occurs in Mtftp4Start.

2018-01-08 Thread Wang Fan
: Jiaxin Wu <jiaxin...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan <fan.w...@intel.com> --- .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.c | 20

Re: [edk2] [Patch 0/2] NetworkPkg/HttpDxe: Fix some issues in HttpDxe

2017-12-26 Thread Wang, Fan
Series reviewed by Wang, Fan <fan.w...@intel.com>. Best Regards Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Tuesday, December 26, 2017 2:35 PM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Wang

Re: [edk2] [Patch 0/2] Fix some issues in HttpBootDxe driver.

2017-12-21 Thread Wang, Fan
Patch series reviewed by Wang, Fan <fan.w...@intel.com>. Best Regards Fan -Original Message- From: Wu, Jiaxin Sent: Thursday, December 21, 2017 2:51 PM To: edk2-devel@lists.01.org Cc: Wang, Fan <fan.w...@intel.com>; Ye, Ting <ting...@intel.com>; Fu, Siyuan <siy

Re: [edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

2017-12-21 Thread Wang, Fan
Reviewed by Wang, Fan <fan.w...@intel.com> -Original Message- From: Fu, Siyuan Sent: Friday, December 22, 2017 2:14 PM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Wang, Fan <fan.w...@intel.com> Subject: [Pa

[edk2] [Patch] MdeModulePkg: Change the macro name to fit coding style

2015-08-06 Thread Wang Fan
Change a macro name to fit EDK2 naming conventions: Use all capital letters for #define. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: fanwang2 fan.w...@intel.com --- MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c | 2 +-

[edk2] [Patch] NetworkPkg: Change the macro name to fit coding style

2015-08-06 Thread Wang Fan
Change several macro names to fit EDK2 naming conventions: Use all capital letters for #define. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: fanwang2 fan.w...@intel.com --- NetworkPkg/IScsiDxe/IScsiMisc.c | 8 NetworkPkg/IScsiDxe/IScsiMisc.h | 8 2

[edk2] [Patch] NetworkPkg: fix an error lead building crash

2015-07-26 Thread Wang Fan
Fix an error which leads the building process crashes. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: fanwang2 fan.w...@intel.com --- NetworkPkg/IScsiDxe/IScsiMisc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.h

[edk2] [Patch] MdeModulePkg: Add old IPv4_DEVICE_PATH support for new IScsiDxe

2015-07-19 Thread Wang Fan
GatewayIpAddress and SubnetMask do not exist in old IPv4_DEVICE_PATH, this will lead new IScsiDxe to error if IPv4_DEVICE_PATH in system is not updated. So add a judgement here to make old IPv4_DEVICE_PATH and new IScsiDxe can cowork. Contributed-under: TianoCore Contribution Agreement 1.0