REF:https://bugzilla.tianocore.org/show_bug.cgi?id=999
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432
---
BaseTools/Source/C/GenFw/Elf64Convert.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git
symbols causing them to have
hidden visibility. This patch is offered instead to allow GenFw to
handle any residual GOTPCREL.
Cc: Shi Steven
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432
---
BaseTools/Source/C/GenFw/Elf64Convert.c
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=999
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432
---
BaseTools/Source/C/GenFw/Elf64Convert.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/BaseTools/Source/C
The size differences are negligible because the code generator only emits GOT
loads in narrow circumstances that reduce code size
- using pointer arithmetic on an address of an external symbol.
- if loading an address of an external symbol as function a argument using a
push instruction.
> Absolute symbol references such as?
> References to fixed (constant)
> addresses?
Pointers stored in the .data section. For example, if you have an array of
const char*.
> Why is that approach optimal? As few
> relocations records are required as
> possible?
small pic model is optimal for
d in build of OvmfPkgX64.dsc.
On Fri, 6/8/18, Andrew Fish wrote:
Subject: Re: [edk2] [PATCH v2] BaseTools/GenFw: Add X64 GOTPCREL Support to
GenFw
To: "Zenith432"
Cc: "edk2-devel@lists.01.org" , "LimingGao"
Date:
Adds support for the following X64 ELF relocations to GenFw
R_X86_64_GOTPCREL
R_X86_64_GOTPCRELX
R_X86_64_REX_GOTPCRELX
CC: Shi Steven
CC: Yonghong Zhu
CC: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432
---
BaseTools/Source/C/GenFw
d X64 GOTPCREL Support to GenFw
To: "Zenith432" , "edk2-devel@lists.01.org"
Cc: "Shi, Steven" , "Zhu, Yonghong"
Date: Thursday, June 7, 2018, 4:32 AM
What's purpose to support GOTPCREL in GenFw?
Could you introduce your usage model?
___
To: "Gao, Liming" , "Zenith432"
, "edk2-devel@lists.01.org"
Date: Thursday, June 7, 2018, 5:24 AM
Hi Zenith,
BTW,
besides the build pass, did you try to run a Uefi binary,
e.g. a simple shell application, which contain the GOTPCREL
relocations? If yes. Pleas
----
On Thu, 6/7/18, Gao, Liming wrote:
Subject: RE: [PATCH] BaseTools/GenFw: Add X64 GOTPCREL Support to GenFw
To: "Zenith432" , "edk2-devel@lists.01.org"
Cc: "Shi, Steven" , "Zhu, Yonghong"
Date: Thursday, June 7, 2018, 4:32 AM
What's purpose to
Adds support for the following X64 ELF relocations to GenFw
R_X86_64_GOTPCREL
R_X86_64_GOTPCRELX
R_X86_64_REX_GOTPCRELX
CC: Shi Steven
CC: Yonghong Zhu
CC: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432
---
BaseTools/Source/C/GenFw
as well.
---
This is to resolve bug 457.
https://bugzilla.tianocore.org/show_bug.cgi?id=457
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432
---
MdePkg/Include/Base.h | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git
ns that have a variable argument list and call VA_START / VA_END
- functions that call VA_COPY
Thanks
Liming
-Original Message-
From: Zenith432 [mailto:zenith...@users.sourceforge.net]
Sent: Sunday, December 10, 2017 11:43 PM
To: Gao, Liming <liming@intel.com>; edk2-devel@lists
On 10/12/2017 03:52 PM, Gao, Liming wrote:
I think these patches resolves CLANG build issues in BaseTools. Do you verify
them with GCC or VS tool chain?
GCC 7.2 does not give any of the warnings generated by clang while compiling
BaseTools.
After applying the 4 BaseTools patches, it still
Contribution Agreement 1.1
Signed-off-by: Zenith432
---
MdePkg/Include/Base.h | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index 02140a5a..19f36872 100644
--- a/MdePkg/Include/Base.h
+++ b/MdePkg/Include
On 10/12/2017 15:52, Gao, Liming wrote:
> For 4, 'unsigned char' goes default argument promotion to int. This
is CLANG compiler behavior. Does GCC and VS compiler follow this rule?
>
> Disable varargs warning is the temp solution. For long term, we
expect to figure out the compatible solution.
This is to resolve bug 457.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432
---
MdePkg/Include/Base.h | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index 02140a5a
It's the package maintainer's choice. As a practical matter, silencing the
warning also works because...
1. clang is the only compiler that complains. Even though it complains, it
generates correct code because it has __builtin implementation of va_start that
takes register argument and
logic is not disturbed by treating the argument as an INT32.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
MdePkg/Include/Library/UefiLib.h | 2 +-
MdePkg/Library/UefiLib/UefiLib.c | 2 +-
2 files changed, 2 insertions(+),
In CheckRemainingSpaceForConsistencyInternal, one of the return paths leaves a
loose
VA_COPY with no matching VA_END.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable
-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr.c | 1 +
BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr.g | 1 +
BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg_p.c | 2 ++
BaseTools/So
This is a repost, subject truncated in previous send.
---
Remove some code generated by antlr that causes clang to emit warning
warning: expression result unused [-Wunused-value]
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith...@users.sourceforge.
Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 4 +-
BaseTools/Source/C/VfrCompile/VfrFormPkg.h | 659 ++-
BaseTools/Source/C/VfrCompile/VfrSyntax.g| 8 +-
3 files change
-by: Zenith432 <zenith...@users.sourceforge.net>
---
BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr.c | 1 +
BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr.g | 1 +
BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg_p.c | 2 ++
BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg_p.g | 4 +++-
4 files chan
Remove some code generated by antlr that causes clang to emit warning
warning: expression result unused [-Wunused-value]
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
OvmfPkg/XenBusDxe/XenStore.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
index 6
-time checks of null,
it may still generate an error for accessing the zeroth entry in the
array. This sort of instrumentation is not normally used.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
IntelFrameworkModuleP
-time checks of null,
it may still generate an error for accessing the zeroth entry in the
array. This sort of instrumentation is not normally used.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
DuetPkg/BiosVideoTh
clang 3.8 flags -Wshift-negative-value warning, which turns fatal due to
use of -Werror.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
BaseTools/Source/C/Common/FvLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
b/MdePkg/L
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
b/MdeMod
On 25/04/2016 08:03 PM, Laszlo Ersek wrote:
> Second, the commit message should explain why the correction is being made.
There's an explanation with more detail here
http://www.insanelymac.com/forum/topic/304530-clover-change-explanations/?p=2234289
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zenith432 <zenith...@users.sourceforge.net>
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++
MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 6 --
OvmfPkg/XenBusDxe/XenS
33 matches
Mail list logo
